vb.org Archive
Page 3 of 62 12 3 451353 Last »
Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.5 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=113)
-   -   Links and Downloads Manager (https://vborg.vbsupport.ru/showthread.php?t=91107)

Boofo 08-17-2005 06:55 AM
Does this also have the apostrophe fix?

AndrewD 08-17-2005 08:55 AM
Quote:
Originally Posted by Boofo
Does this also have the apostrophe fix?
No, that requires a change to the code, which I need to think about.

Boofo 08-17-2005 08:58 AM
addslashes and stripslashes should do it. ;)

welo 08-20-2005 06:06 AM
Installed/upgraded on RC2 and running nicely. Great job as always :up:. Am adding a slew of content to it and will take it public on my board shortly.

I notice your installer still insists on prefixing the links tables with local_, so rather than hack the code I finally relented and just changed my links_ prefixes to comply. No big deal but that local_ prefix still bugs me some. I know you did this to match your file prefixes but in the overall db schema it really doesn't make sense. Maybe I'll get used to it :).

Regardless, thanks for providing this. I'm willing to declare it as one of the (if not the) best supported and developed hacks at vb.org.

AndrewD 08-20-2005 06:47 AM
Quote:
Originally Posted by welo
Installed/upgraded on RC2 and running nicely. Great job as always :up:. Am adding a slew of content to it and will take it public on my board shortly.

I notice your installer still insists on prefixing the links tables with local_, so rather than hack the code I finally relented and just changed my links_ prefixes to comply. No big deal but that local_ prefix still bugs me some. I know you did this to match your file prefixes but in the overall db schema it really doesn't make sense. Maybe I'll get used to it :).

Regardless, thanks for providing this. I'm willing to declare it as one of the (if not the) best supported and developed hacks at vb.org.
I appreciate your kind remarks, thanks.

Probably the table prefix does need rethinking, now that we have full product support in VB. Perhaps tables should use a product prefix (e.g. this one would be LDM). I want to keep this clearly separate from VB. What do you think?

Boofo 08-20-2005 07:25 AM
Quote:
Originally Posted by AndrewD
I appreciate your kind remarks, thanks.

Probably the table prefix does need rethinking, now that we have full product support in VB. Perhaps tables should use a product prefix (e.g. this one would be LDM). I want to keep this clearly separate from VB. What do you think?
I think that would be a good idea as it would allow us to know which tables are vb tables and which tables have been added for a specific mod/hack.

welo 08-20-2005 07:31 AM
Quote:
Originally Posted by AndrewD
Perhaps tables should use a product prefix (e.g. this one would be LDM). I want to keep this clearly separate from VB. What do you think?
I agree product tables should be differentiated from those used by VB. I could live with an ldm_ table prefix. However, your code is already setup to allow for user-defined prefixes. I just get kinda stumped that it never asks me what mine are during the upgrade process.

Regardless, I realize this is a nitpickery db-geek thing that has nothing to do with the functionality of your script. Out of close to 300 people having installed the VB 3.0.X version I seem to be the only one having an issue with it :). I just like my database to make as much sense as possible, is all.

lttcoder 08-21-2005 02:28 PM
Upgrade doesnt work from 2.0.2->> 2.0.3

Quote:
Critical error: different versions of software, templates, phrases and database.
Software: 2.0.3 database: 2.0.2
Cannot continue - ask administrator to correct.

lttcoder 08-21-2005 02:41 PM
I uninstalled the old one and clean installed the new.
It works fine, I like the little box at the bottom telling my settings :)
Links and Downloads Database
Code 2.0.3
MySQL 4.1.13a-Debian_1-log
PHP 4.3.10
allow_url_fopen No
cURL Yes
GD2 Yes
open_basedir

AndrewD 08-21-2005 02:50 PM
Quote:
Originally Posted by lttcoder
I uninstalled the old one and clean installed the new.
It works fine, I like the little box at the bottom telling my settings :)
Links and Downloads Database
Code 2.0.3
MySQL 4.1.13a-Debian_1-log
PHP 4.3.10
allow_url_fopen No
cURL Yes
GD2 Yes
open_basedir
OK, seems to work fine - not sure what went wrong with the upgrade - ran fine for me.

I added a remote file download - worked ok - removed it again from your d/b

Boofo 08-21-2005 10:41 PM
Won't we lose our links doing it that way?

WhisperPntr 08-22-2005 01:40 AM
This is an amazing hack Andrew. If in the future I make changes to this code, ie an addon or port to function with another code, would you mind my asking permission to release modifications? All credit for the original hack would be yours btw and any modifications will be documented.

And thanks for being such a good sport handling the questions :) It makes me wonder if you work full time as a customer service rep...though on that note most of them don't have the same charm and capability you've shown. :)

AndrewD 08-22-2005 04:02 AM
Quote:
Originally Posted by Boofo
Won't we lose our links doing it that way?
The upgrade should work properly - I don't understand why Ltlcoder had difficulties.

However, uninstalling and reinstalling is also ok, as the database tables are not deleted during uninstallation. (There's another script to run if you really want to kill LDM.)

If you are concerned, best idea is always to back up the local_xx tables before running an upgrade.

AndrewD 08-22-2005 04:05 AM
Quote:
Originally Posted by WhisperPntr
If in the future I make changes to this code, ie an addon or port to function with another code, would you mind my asking permission to release modifications? All credit for the original hack would be yours btw and any modifications will be documented.
Please feel free. My only concern would be if we started having separate streams of code that have to be kept in sync - we'd need to be careful how this was managed.

welo 08-23-2005 03:52 AM
For the first time since installing this I visited my style manager to make a few template tweaks, to discover LDM has added all its templates alphabetically to the main forum templates list rather than to a "Custom templates" set. If you insist on going ahead with this method could you at least subcategorize the LDM templates so they can be collapsed? Adding no less than 40 links_ templates to the main display is cumbersome at best.

AndrewD 08-23-2005 03:59 AM
Quote:
Originally Posted by welo
For the first time since installing this I visited my style manager to make a few template tweaks, to discover LDM has added all its templates alphabetically to the main forum templates list rather than to a "Custom templates" set. If you insist on going ahead with this method could you at least subcategorize the LDM templates so they can be collapsed? Adding no less than 40 links_ templates to the main display is cumbersome at best.
Welo, yes, will do - it's been a matter of gradually working out how everything in VB35 works, so that everything slots in smoothly.

AndrewD 08-23-2005 03:33 PM
Having made a quick check on Welo's suggestion, the best way to group these templates is through a plugin attached to template_groups:

PHP Code:
$only['links_'] = 'Links and Database Manager'; 
I will include this in the release, but - Welo - you might like to check that this works for you.

Boofo 08-23-2005 04:41 PM
Will the apostrophe fix for the db name be in the new version, also? ;)

AndrewD 08-23-2005 05:26 PM
Quote:
Originally Posted by Boofo
Will the apostrophe fix for the db name be in the new version, also? ;)
It's already in 2.0.3, a few posts up. Should be ok - maybe you can give it a try?

Boofo 08-23-2005 07:06 PM
No problem, sir. ;)

Do I need to upload files is all then?

Boofo 08-23-2005 07:22 PM
Just tested it and the apostrophe problem is now fixed. ;)

Is CURL actually better to use with this or the other way? I apparently have CURL installed on the server. Or is CURL only for remote file links?

AndrewD 08-24-2005 04:13 AM
Quote:
Originally Posted by Boofo
Just tested it and the apostrophe problem is now fixed. ;)
Good!

Quote:
Originally Posted by Boofo
Is CURL actually better to use with this or the other way? I apparently have CURL installed on the server. Or is CURL only for remote file links?
I don't know which is better/faster/etc - some advisors recommend that allow_url_fopen() is turned off, because this improves overall site security, but as far as LDM is concerned, I'm not sure that it makes any difference.

cURL is only being used for remote file links and remote thumbnails. This includes local files and thumbnails if these are set up with a complete url rather than a relative filename. The code tries the fopen() route first before falling back onto cURL.

Boofo 08-24-2005 09:24 AM
Ahhh, ok, sinve I have remore files truned off, then it doesn't even use CURL, right? I think I get it now. ;)

welo 08-24-2005 10:03 AM
Quote:
Originally Posted by AndrewD
Having made a quick check on Welo's suggestion, the best way to group these templates is through a plugin attached to template_groups:

PHP Code:
$only['links_'] = 'Links and Database Manager'; 
I will include this in the release, but - Welo - you might like to check that this works for you.
Woo-hoo! Much nicer. :up:

GrendelKhan{TSU 08-26-2005 05:39 AM
as to the "allow_url_fopen" issue....

can someone tell me WHERE or HOW to actually turn it ON? (mine is off, but I want it on...but don't know where to go to do this) :/

AndrewD 08-26-2005 05:42 AM
Quote:
Originally Posted by GrendelKhan{TSU
as to the "allow_url_fopen" issue....

can someone tell me WHERE or HOW to actually turn it ON? (mine is off, but I want it on...but don't know where to go to do this) :/
allow_url_fopen is set in the php.ini file. Depending on how your site is handled, either you or your ISP must edit this file. If your ISP has turned it off, it is likely to be because they think it is a security risk, in which case you will have to go the cURL route (configure php to access the curl library)

GrendelKhan{TSU 08-26-2005 06:31 AM
Quote:
allow_url_fopen is set in the php.ini file. Depending on how your site is handled, either you or your ISP must edit this file. If your ISP has turned it off, it is likely to be because they think it is a security risk, in which case you will have to go the cURL route (configure php to access the curl library)
ok...contacted them but waiting for a reply.

in the meantime (cause I have a feel they won't turn it on for me).....
how do I go about using the cURL route? Is that something I have to request from my ISP as well? Then what?

Quote:
Originally Posted by AndrewD
This error is flagged if you enter something in the monitor_dir text box and the code can't find a directory that matches. But your error message suggests that you haven't put anything in this box? Do you get this error every time you try to change admin settings?
sorry. been working on other parts of my board...and just got to this. :ninja:

yes. I get this error everytime.

the monitor_dir box is empty.

any help would be greatly appreciated...this hack RULES!! I can't edit ANY of my settings right now. :/

AndrewD 08-26-2005 06:35 AM
Quote:
Originally Posted by GrendelKhan{TSU
ok...contacted them but waiting for a reply.

in the meantime (cause I have a feel they won't turn it on for me).....
how do I go about using the cURL route? Is that something I have to request from my ISP as well? Then what?



sorry. been working on other parts of my board...and just got to this. :ninja:

yes. I get this error everytime.

the monitor_dir box is empty.

any help would be greatly appreciated...this hack RULES!! I can't edit ANY of my settings right now. :/
Could you create me an account with admin privs and send me a PM - also the URL of your (VB308/VB35??) forums so that I can take a look?

GrendelKhan{TSU 08-26-2005 07:11 AM
Quote:
Originally Posted by AndrewD
Could you create me an account with admin privs and send me a PM - also the URL of your (VB308/VB35??) forums so that I can take a look?
done. :D

GenSec 08-26-2005 10:00 AM
Seaching link:
Quote:
Fatal error: Call to undefined function get_linksratings() in C:\Apache2\htdocs\upload\local_links.php on line 580
I couldn't find function get_linksratings too

AndrewD 08-26-2005 10:10 AM
Quote:
Originally Posted by GenSec
Seaching link:


I couldn't find function get_linksratings too

Yup, it was removed in a recent release but I forgot to remove this call. Just comment out the call to get_linksratings on line 580 of local_links.php.

This kills the search facility as you have observed. Sorry about that...

GenSec 08-26-2005 10:36 AM
Thanks for so fast reply!

The hack is excellent!!!

GrendelKhan{TSU 08-29-2005 11:10 AM
n00b questions:

how do you add/use all the cool icons you have included in the zip?

what is the Template.xml file with the zip? what does that template look like? and the "codes.xml"....are we supposed to do something with that?

<<< n00b confused easily. :( :p

AndrewD 08-29-2005 11:15 AM
Quote:
Originally Posted by GrendelKhan{TSU
n00b questions:

how do you add/use all the cool icons you have included in the zip?

what is the Template.xml file with the zip? what does that template look like? and the "codes.xml"....are we supposed to do something with that?

<<< n00b confused easily. :( :p
It is all explained in the 'instructions.txt'

You don't need to do anything with the template or code file. These have already been packaged into the product xml file. They're included in the zip for completeness.

To use the icons, upload as a subdirectory onto your site, then tell the LDM admin page which directory to use (settings and permissions/file_icons_dir)

GrendelKhan{TSU 08-30-2005 03:47 AM
Quote:
Originally Posted by AndrewD
It is all explained in the 'instructions.txt'

You don't need to do anything with the template or code file. These have already been packaged into the product xml file. They're included in the zip for completeness.

To use the icons, upload as a subdirectory onto your site, then tell the LDM admin page which directory to use (settings and permissions/file_icons_dir)
DOH! thanks!!^^ :nervous:

AndrewD 08-30-2005 05:39 PM
Links and Downloads Manager 2.0.4 uploaded as the supported release. Mainly bug fixes (oh I am so embarassed by the broek search command..):

- LDM template group created within main VB admincp style display
- Uses cURL library if available when *allow_url_fopen* is switched off in php.ini
- bugs fixed
reporting of access permissions in admin/categories
redirection after moderate link
navbar and title settings when texts include bbcodes
handling of unset monitor_dir
search facility (broken since v2.00 alpha 1!!)
mass edits
addslashes check on admin param settings

To upgrade, re-upload the code files and then re-import the product file via the VB admincp

GrendelKhan{TSU 09-09-2005 08:16 PM
Quote:
Originally Posted by AndrewD
Links and Downloads Manager 2.0.4 uploaded as the supported release. Mainly bug fixes (oh I am so embarassed by the broek search command..):

- LDM template group created within main VB admincp style display
- Uses cURL library if available when *allow_url_fopen* is switched off in php.ini
- bugs fixed
reporting of access permissions in admin/categories
redirection after moderate link
navbar and title settings when texts include bbcodes
handling of unset monitor_dir
search facility (broken since v2.00 alpha 1!!)
mass edits
addslashes check on admin param settings

To upgrade, re-upload the code files and then re-import the product file via the VB admincp
Awesome :D


BUG: I think...

the default sort order doesn't seem to want to change no matter what I set it to. :/ or that could be just mine. :(

AndrewD 09-10-2005 05:07 AM
Quote:
Originally Posted by GrendelKhan{TSU
Awesome :D

BUG: I think...

the default sort order doesn't seem to want to change no matter what I set it to. :/ or that could be just mine. :(
You're right - sorry about that. It will be fixed in 2.0.5 in a few days.

If it's urgent, you can edit local_links.php. Find line 386:

PHP Code:
    default:
        $sort = $vbulletin->GPC['sort'];
        if ($sort == "") {
            $sort = iif($linkscat["$viewcatid"]['catsortorder'] == ' ', 
                        iif(isset($links_defaults['default_sort_order']), $links_defaults['default_sort_order'], 'N'),
                        $linkscat["$viewcatid"]['catsortorder']);
        } 
and change to

PHP Code:
    default:
        $sort = $vbulletin->GPC['sort'];
        if ($sort == "") {
            $sort = iif(trim($linkscat["$viewcatid"]['catsortorder']),
                        $linkscat["$viewcatid"]['catsortorder'],
                        iif(isset($links_defaults['default_sort_order']), $links_defaults['default_sort_order'], 'N')
                        );
        } 

Sadie Frost 09-11-2005 02:58 AM
I'm having a little problem installing this - when I try to add the product, I get this error:

Quote:
Links and Downloads Manager
Checking installation status...
Currently installed version: 2.0.4
Checking environment...
Environment checked
Creating/Verifying database tables

--------------------------------------------------------------------------------
Step 1 - Verifying database tables

Fatal error: Call to a member function on a non-object in /path/to/forums/includes/local_links_admininclude.php on line 414
Anyone have any ideas? Thanks :)

AndrewD 09-11-2005 05:50 AM
Quote:
Originally Posted by Sadie Frost
I'm having a little problem installing this - when I try to add the product, I get this error:

Anyone have any ideas? Thanks :)
Sorry about that - you must be the first person who's used this to upgrade from version 1.50 or earlier, as you've hit a bad line of code to deal with that situtation.

I've repaired the zip file in the first post - please redownload and reinstall - you'll probably have to use the product manager to uninstall LDM first (don't worry, you won't lose your database tables).

Alternatively, just edit links_admininclude.php, go to line 414 and change the two adjacent dollar signs

PHP Code:
$asb = $$db->query_write(" 
into a single dollar sign:

PHP Code:
$asb = $db->query_write(" 


All times are GMT. The time now is 04:20 AM.
Page 3 of 62 12 3 451353 Last »
Show 40 post(s) from this thread on one page

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.03061 seconds
  • Memory Usage 1,873KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (6)bbcode_php_printable
  • (26)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (2)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete