vb.org Archive - Advanced Editing Options For Mods & Admins

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vBulletin 3.0 Full Releases (https://vborg.vbsupport.ru/forumdisplay.php?f=33)

- - Advanced Editing Options For Mods & Admins (https://vborg.vbsupport.ru/showthread.php?t=61412)

Hi, Xenon!

I am using your Editing Hierarchy Hack (quite happily, I might add) , and as such - I have no need or desire to install the Edit Permissions portion of this particular hack.

However, I do need the other features - specifically, the ability to edit the Author, Timestamp, IP, etc...

What portions would I need to keep/remove from your Instructions in order to do this?
Thanks! :)

well, you have to remove the selection menue from the additional template, and then in editpost.php all you have to do is to change

PHP Code:


		
			
$bbuserinfo['editlevel'] > $editlevel['author']

into

PHP Code:


		
			
$bbuserinfo['editlevel'] == $editlevel['admin']

that should work i think :)

Hmm... well, since this will only be used for Admins, I think I can trim out quite a bit more in order to keep things efficient.

For example, I think I can remove the entire Permission Checking routines (in addition to the Database Modification), by simply enclosing the Template additions like so:

Code:

 

 

<if condition="is_member_of($bbuserinfo,6)">

 

<!-- code goes here -->

 

</if>

Yes?

If so, than I should be able to remove a good section of this hack.

I have made an absolutely amateurish attempt at doing so. If you happen to have the time, and are in the mood to do so - I would be grateful if you could look over my revised version, and tell me just how badly I screwed up. <grin>

erm, you shouldn't hardcode the usergroupids, that's why i used the editlevel things.

as for the rest, there is no need to struck out much, the better efficiency is not remarkable, especially not for the prize to work on that more time than really needed to achieve the goal ;)

Quote:

Originally Posted by Xenon

Well, I have several Admin-only hacks that are access controlled in the same way, so adding this one really is not a problem. :)

So, keeping that in mind - did I actually alter the original code correctly? Or did you notice something that I missed?

(p.s. thanks for taking any time at all to look at it! ) :)

well it seems you trimmed way too much, as there is an ending } but not an opening one....

as said, just do the changes i suggested and you will be fine.

Quote:

Originally Posted by Xenon

well it seems you trimmed way too much, as there is an ending } but not an opening one....

as said, just do the changes i suggested and you will be fine.

Well, I guess I'm just uncomfortable adding what, for me, is an unnecessary subsystem. I took out the extra "}" (oops!), but I still ended up with problems. (If I went in to edit a message, but didn't change anything and didn't hit Submit, all the Advanced Info ended up getting blanked out anyway. No User, no IP, marked as being posted in 1965, etc...).

So, clearly, I must have missed something. I guess I'll just have to spend some more time on it when I get the chance. :)

Great hack, though! I can't wait until I get this ready for use. :) (Yeah, I know - I'm making this hard on myself - I can't help it. :nervous: )

*gg*

well i wish you good luck then :)
Your way will be very hard, but then on the other hand you will know each line of the code afterwards, good for upgrades :p

Quote:

Originally Posted by Xenon

*gg*

well i wish you good luck then :)
Your way will be very hard, but then on the other hand you will know each line of the code afterwards, good for upgrades :p

Very true. :)

However, if, 20 or 30 years from now, you should happen to choose to ruin my "fun" by telling me what I missed - I just want you to know that you shouldn't feel too bad about it - I won't hold it against you. :) :) :)

yeah, in 20 or 30 years, with vb10 ;)

Thanks Xenon! (and Sandman for referring me to this Thread at vB.com)
This will be a tremendous help to change usernames of posts that I moved over from our yahoogroups.

Not sure yet whether I will need to update user post counts etc after making the changes...

Is it important to change the username IP too when I make the changes?
It just means an extra chore to find the user IP as I have a lot of posts needing username changes.
I want the author to be able to edit content of posts.

Mark

This is useful, but how about adding a feature to edit the thread title? As VB is now, only the post title can be edited after x time. It would be nice to be able to edit the actual thread title without having to open phpMyAdmin..

Quote:

Originally Posted by 006

You can edit the Thread title any time you want - just use Thread Tools > Edit Thread > Perform Action > Edit The Title Field > Save Changes

@006: sandman already said, the threadtitle is editable in a normal vb already

@MJM: nope, it's not needed to change the IP.
The username is the important field, as a username change changes the userid of that specific post, and that will lead to that the new user can edit the post instead of the old one :)

Updating postcounts, would be needed, correct, thats something i will change in the next version :)

Great job once again Xenon
:)

Quick question tho, as posted here : Quick Edit Hack

Quote:

Ok
Im using :
- the updated set of instructions provided by Slave (https://vborg.vbsupport.ru/show...63&postcount=95)
- with the slight revision to that provided by poetic (https://vborg.vbsupport.ru/show...5&postcount=103)
In conjunction with :
Advanced Editing Options For Mods & Admins (https://vborg.vbsupport.ru/showthread.php?t=61412)

And all works fine
Except one thing

Whenever I use the quick edit, it is dropping the details of the original poster
ie
ends up being posted as guest

To get around this, I have to use the preview option, re-enter the original poster, then submit
And as you can gather, thats hardly a quick edit

Has anyone got these 2 fine hacks to play nicely together as I would really like to keep both.

TIA

Any chance you could have a look into it ?

Thanks
:)

well, that's a problem of the quick edit hack.

you have to add the additional fields from my hack into the quick edit hack.

or another way would be to post another variable when using quickedit, and then add an if condition, if this var is set, do nothing of the advanced features.

I'm sure you can figure that out :)

No not reallly
Any chance of bit more assistance ?

nah, not really, as i don't know the code of the quick edit hack, and i do not have the time to install it on a testboard to find it out..

maybe someone who has installed that hack as well can assist?

No worries
Thanks anyway
:)

Has anyone manged to get both these hacks working together ?

Quote:

Originally Posted by Xenon

i dont see where it conflicts
- quick edit uses showthread php and functions showthread
advanced doesnt
-quickedit makes u create a new template called quickedit
and edit posbit/postbit legacy and the advanced hack doesnt
- so wheres the conflict?

plus there are no calls in the install to replace any text in advanced

i gotta step out for a bit but im gonna try and install both on a test board
im using the original quick edit in the first post with the added reason and delete fields
so if you want to try it again thats what im testing it on

this just doesnt make sense... ill update this post later tonight

well it conflicts, that the quickedit send to editpost.php as well, but doesn't fill the admin edit fields as well, so all those are considered as empty...

Quote:

Originally Posted by Xenon

well it conflicts, that the quickedit send to editpost.php as well, but doesn't fill the admin edit fields as well, so all those are considered as empty...

but if the quick edit is disabled from being used by admin... since theres no need for it with this hack.... by applying this in the postbit/postbit_legacy

Code:

<if condition="THIS_SCRIPT=='showthread' and $bbuserinfo[usergroupid]!=5 and $bbuserinfo[usergroupid]!=6 and $bbuserinfo[usergroupid]!=7"> 

$quickedit 

</if>

than there shouldnt be a problem no?? i mean since this hack is for admins and mods than there shouldnt be any problems with the two together no??(im probably just talkin outta my a$s :lick: )

this is for those that have the quick edit hack installed

ok i got it to work .... somewhat... i just need one more step

this is what i did so far....

i have this code in the showthread_quickedit

Code:

                        <span id="quickedit_$post[postid]">

                                <img src="$stylevar[imgdir_button]/quickedit_icon.gif" alt="Quick Edit" border="0" />

                                <script type="text/javascript"> vbmenu_register("quickedit_$post[postid]", true); </script>

                        </span>

<div class="vbmenu_popup" id="quickedit_$post[postid]_menu" style="display:none">

<form enctype="multipart/form-data" name="vbulletinform" style="display:inline;" action="editpost.php" method="post">

<input type="hidden" name="s" value="$session[sessionhash]" />

<input type="hidden" name="do" value="updatepost" />

<input type="hidden" name="p" value="$post[postid]" />

<input type="hidden" name="posthash" value="$posthash" />

<input type="hidden" name="poststarttime" value="$poststarttime" />

<input type="hidden" name="emailupdate" value="9999" />

<input type="hidden" name="disablesmilies" value="0" />

<input type="hidden" name="parseurl" value="1" id="cb_parseurl" />        

<table class="tborder" cellpadding="6" cellspacing="1" border="0" width="100%" align="center">

<tr>

<td class="tcat" align="left">

<strong>$vbphrase[edit_post]</strong>

</td>

</tr>

<tbody> 

<tr valign="top">

<td class="panelsurround" align="center">

<div class="panel">

<div align="left">

<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">

<tr>

        <td class="tcat">

                <a style="float:$stylevar[right]" href="#top" onclick="return toggle_collapse('editpost_advanced')"><img id="collapseimg_editpost_advanced" src="$stylevar[imgdir_button]/collapse_tcat$vbcollapse[collapseimg_editpost_advanced].gif" alt="" border="0" /></a>

                Advanced Editing Options

        </td>

</tr>

<tbody id="collapseobj_editpost_advanced" style="$vbcollapse[collapseobj_editpost_advanced]">

        <tr>

                <td class="panelsurround" align="center">

                <div class="panel">

                        <div style="width:$stylevar[formwidth]" align="$stylevar[left]">

                        

                        <div class="fieldset">

                                <div>This Form allows you to change advanced settings of this post</div>

                        </div>

                        

                        <fieldset class="fieldset">

                                <legend>Advanced options</legend>

                                <div style="padding:$stylevar[formspacer]px">

                                        <div>

                                                <label for="sb_editable">

                                                        <select name="editable" id="sb_editable">

                                                                <option value="$editlevel[author]"<if condition="$postinfo['editlevel'] == $editlevel['author']"> selected="selected"</if>>

                                                                        Author

                                                                </option>

                                                                <option value="$editlevel[mod]"<if condition="$postinfo['editlevel'] == $editlevel['mod']"> selected="selected"</if>>

                                                                        Moderator

                                                                </option>

                                                                <if condition="$bbuserinfo['editlevel'] >= $editlevel['smod']">

                                                                        <option value="$editlevel[smod]"<if condition="$postinfo['editlevel'] == $editlevel['smod']"> selected="selected"</if>>

                                                                                Supermoderator

                                                                        </option>

                                                                </if>

                                                                <if condition="$bbuserinfo['editlevel'] >= $editlevel['admin']">

                                                                        <option value="$editlevel[admin]"<if condition="$postinfo['editlevel'] == $editlevel['admin']"> selected="selected"</if>>

                                                                                Admin

                                                                        </option>

                                                                </if>

                                                        </select>

                                                        or above can edit this post!

                                                </label>

                                        </div>

                                        

                                        <!-- Specific Section for Admin -->

                                        <if condition="$bbuserinfo['editlevel'] == $editlevel['admin']">

                                                <div>

                                                        <label for="tb_dateline">

                                                                <input type="text" name="newday" value="$posttime[mday]" size="1" maxlength="2" id="tb_dateline_day" />.

                                                                <input type="text" name="newmonth" value="$posttime[mon]" size="1" maxlength="2" id="tb_dateline_month" />.

                                                                <input type="text" name="newyear" value="$posttime[year]" size="3" maxlength="4" id="tb_dateline_year" />  -

                                                                <input type="text" name="newhour" value="$posttime[hours]" size="1" maxlength="2" id="tb_dateline_day" />:

                                                                <input type="text" name="newminute" value="$posttime[minutes]" size="1" maxlength="2"  id="tb_dateline_day" />

                                                                Date posted (d.m.Y - H:i)

                                                        </label>

                                                </div>

                                                <div>

                                                        <label for="tb_username">

                                                                <input type="text" name="newusername" value="$postinfo[username]" id="tb_username" /> Author of this post (if user doesn't exist, it will be set to a guest post)

                                                        </label>

                                                </div>

                                                <div>

                                                        <label for="tb_ipaddress">

                                                                <input type="text" name="newipaddress" value="$postinfo[ipaddress]" id="tb_ipaddress" /> IP Address

                                                        </label>

                                                </div>

                                        </if>

                                </div>

                        </fieldset>

                        

                        </div>

                </div>

                

                </td>

        </tr>

</tbody>

</table>

<br />

        <div class="smallfont" style="margin-bottom:$stylevar[formspacer]px">

         <div>$vbphrase[title]:</div>

         <div><input type="text" class="bginput" name="title" value="$post[title]" size="60" maxlength="85" tabindex="1" /></div>

        </div>

        <div class="smallfont" style="margin-bottom:$stylevar[formspacer]px">

         <div>$vbphrase[message]:</div>

         <div><textarea name="message" class="bginput" style="width:433px; height:125px;" wrap="virtual" tabindex="1">$edittext</textarea></div>

        </div>

</div>

</div>

<div style="margin-top:6px">

        <input type="submit" class="button" name="sbutton" value="Save Changes" accesskey="s" tabindex="1" />

        <input type="submit" class="button" name="preview" value="Preview Changes" accesskey="p" tabindex="1" />



         <if condition="$bbuserinfo['signature'] != ''"><label for="cb_signature"><input type="checkbox" name="signature" value="1" id="cb_signature" tabindex="1" checked /><span class="smallfont">Signature</span></label></if>

</div>

</td>

</tr>

</tbody>

</table>

</form>

</div>

and i get (see thumbnail for details) the advanced edit screen in the quick edit but the fields in the advanced edit are blank... as well as the dropdown

im not sure what i have left to add... any suggestions?

well, to see the correct infos, they have to be prepared/parsed before.

so you better use a different way:

in MY hack find:

PHP Code:


		
			
if ($_POST['do'] == 'updatepost' AND  $bbuserinfo['editlevel'] > $editlevel['author'])

and replace with:

PHP Code:


		
			
if ($_POST['quickedit'] != 'true' AND $_POST['do'] == 'updatepost' AND  $bbuserinfo['editlevel'] > $editlevel['author'])

then in the quickedit formular add:

HTML Code:

<input type="hidden" name="quickedit" value="true" />

using that way, there shouldn't be problems anymore.
but it means the special edit options can just be used in real edit, not quick edit :)

This has been working great! Can't thank you enough.
Couple things....
If the day/month boxes could be a little bigger to show the 2 numbers...
They only show one number each, and when making date changes it's a bit of a pain.

Any way username changes can be made in calendar of event?

Thanks, thanks and thanks again,
Mark

hmm, they show two numbers for me.
seems to be browser related, or maybe font relatad.

just change the sizevalue in the template:

Code:

<input type="text" name="newday" value="$posttime[mday]" size="1" maxlength="2" id="tb_dateline_day" />.

hmm, would be a different hack for calendar events i fear ;)

Using IO on a Mac, maybe thats why
...will pass this on to my partner
Thanks
Mark
No problems about the calendar/username change.

We now post calendar events under pseudonym `EventsDesk' and wanted to change our personal username entries, which we can by deleting, then re-entering info under new username, as the date of entry is irrelevant.

The only thing we can't do is change the name to another member username, but we'll just have the member re-enter the info.

Anyone try installing this on 3.0.3 yet?

actually not, but it should work with 3.0.3 as well, there weren'T in deep changes in editpost.php

Nice hack, just wanted to mention that it installed fine on vBulletin 3.0.3.
Had a little problem with another hack but I managed to fix it. I fyou have the quick edit hack installed and tried to quick edit a post, all the options get reset like IP, userid and name, the date and so on.

If anyone else has this problem heres a quick fix, in the template "showthread_quickedit" find:

HTML Code:

<form enctype="multipart/form-data" name="vbulletinform" style="display:inline;" action="editpost.php" method="post">

and add under it:

HTML Code:

<input type="hidden" name="quickedit" value="true" />

Then find in editpost.php:

PHP Code:


		
			
  if ($_POST['do'] == 'updatepost' AND  $bbuserinfo['editlevel'] > $editlevel['author'])

and change it to:

PHP Code:


		
			
  if ($_POST['do'] == 'updatepost' AND  $bbuserinfo['editlevel'] > $editlevel['author'] AND !$_POST['quickedit'])

and that should solve that problem.

Also I notice a small problem with this hack, if you change the user of the post, the original poster count doesn't decrese and the new user post count doesn't increase so you would have to update the counters to get them accurate again. Other then that, its a good hack.

Quote:

Originally Posted by Slynderdale

HTML Code:

<form enctype="multipart/form-data" name="vbulletinform" style="display:inline;" action="editpost.php" method="post">

and add under it:

HTML Code:

<input type="hidden" name="quickedit" value="true" />

Then find in editpost.php:

PHP Code:


		
			
  if ($_POST['do'] == 'updatepost' AND  $bbuserinfo['editlevel'] > $editlevel['author'])

and change it to:

PHP Code:


		
			
  if ($_POST['do'] == 'updatepost' AND  $bbuserinfo['editlevel'] > $editlevel['author'] AND !$_POST['quickedit'])

Might this have some relation to the issue I was mentioning about the info being lost if SuperMods edit a post ?

@Sly: hmm, a lint to that post

would have fit also ^^

As for the postcount, yes i know, will have to add that in my next update (when i find the time to add what i want to add ^^)

Quote:

Originally Posted by Xenon

@Sly: hmm, a lint to that post

would have fit also ^^

As for the postcount, yes i know, will have to add that in my next update (when i find the time to add what i want to add ^^)

Didn't notice that post.

I made some changes to your hack that fixed up a couple things, one is corectly setting the users pos count and the other is updating the forum last poster and first poster info if you change the user.

After you install this hack, find:

PHP Code:


		
			
        // now do changes to thread, if logged in user is an admin and changed the dateline
            if ($bbuserinfo['editlevel'] == $editlevel['admin'] AND
                $postinfo['dateline'] != $newpost['dateline'])
            {
                require_once('./includes/functions_databuild.php');
                build_thread_counters($postinfo['threadid']);
            }

Replace it with:

PHP Code:


		
			
        //------------------------------------------------------------
        if($postinfo['userid']!=$newpost['userid'] && $foruminfo['countposts'])
        {
          if ($postinfo['userid'] > 0)
          {
            $DB_site->query("
                  UPDATE " . TABLE_PREFIX . "user
                    SET  posts=posts-1
                 WHERE userid = $postinfo[userid]
                ");
          }
          if ($newpost[userid] > 0)
          {
            $DB_site->query("
                UPDATE " . TABLE_PREFIX . "user
                SET  posts=posts+1
                  WHERE userid = $newpost[userid]
              ");
          }
        }
        //------------------------------------------------------------
    
        // now do changes to thread, if logged in user is an admin and changed the dateline
            if ($bbuserinfo['editlevel'] == $editlevel['admin'] AND
                $postinfo['dateline'] != $newpost['dateline'] OR
                $postinfo['userid']!=$newpost['userid'])
            {
                require_once('./includes/functions_databuild.php');
                build_thread_counters($postinfo['threadid']);
            }

Now in includes/function_datastore.php find:

PHP Code:


		
			
    // ###################### Start updatethreadcount #######################
    function build_thread_counters($threadid)
    {
        global $DB_site, $threadcache;

and change it to:

PHP Code:


		
			
    // ###################### Start updatethreadcount #######################
    function build_thread_counters($threadid)
    {
        global $DB_site, $threadcache, $vbphrase;

Now a little ways under that find:

PHP Code:


		
			
    $lastposter = iif(empty($lastposts['username']), $lastposts['postuser'], $lastposts['username']);

under it add:

PHP Code:


		
			
    $lastposter = iif(empty($lastposter),$vbphrase['guest'],$lastposter);

Now a little ways under that find:

PHP Code:


		
			
    $firstposter = iif(empty($firstposts['username']), $firstposts['postuser'], $firstposts['username']);

and under it add:

PHP Code:


		
			
    $firstposter = iif(empty($firstposter),$vbphrase['guest'],$firstposter);

Thats all, now the posts will show Guest instead of nothing when you enter in a blank field. Also it will now update the post count of those who you change the post to and from.

Thx for sharing your changes :)

i might add, that your code for the postcounts isn't correct 100%
if you have forums where post's aren't counted, then of course you would not have to change the postcount ;)

but i'm sure a lot can use this, until i can come up with the next version (which hopefully has all of that implemented and the special additions i want to have ;))

Quote:

Originally Posted by Xenon

Thanks for bringing that to me attention, fixed it by adding:
&& $foruminfo['countposts']
To the If statement.

The only problem now is updating the user's usertitle if they gain/lose enough posts for a different one.

:)

now you see why i didn't add that things to the first version of my hack ;)

If you edit the date, does it bump the post up the list/to the top? Or is it just whats displayed when the post is viewed?

it does bump the post up/down the list (in linear mode)
in threaded mode it just changes the displayed time

Hi, Xenon! I was wondering if you had any ideas as to when you'll be releasing the next version of this hack? :)

unfortunatelly not.
I'm currently totally overworked with other things, but i will at some day.

I expect when i'm back at university *gg*

Phrase Groups Available:

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01685 seconds Memory Usage 1,968KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (4)bbcode_code_printable (5)bbcode_html_printable (16)bbcode_php_printable (10)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (1)post_thanks_navbar_search (1)printthread (40)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: