vb.org Archive
Page 3 of 10 12 3 45 Last »
Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.0 Full Releases (https://vborg.vbsupport.ru/forumdisplay.php?f=33)
-   -   [HTL] Hack Tracking Log (https://vborg.vbsupport.ru/showthread.php?t=60735)

KuraFire 01-26-2004 04:38 PM
Quote:
Originally Posted by princeton
yes, it actually changed my style settings. Upon logging-out, it reverts back to the default.
Hmmm... that might be due to the HTL using 'styleid' as the varname, and that that somehow changes a setting.... weird though, shouldn't happen in the Admin CP..
I'll look into it.

Quote:
Originally Posted by princeton
about the dropdown ... that was my point you don't want people to put anything in there; if you want to allow people to include an optional note then you should include an additional option (input). It is easier to view EASY/MEDIUM/HARD.
Maybe. If I were to implement that change now, I'd have to make HTL 1.1 be compatible with 2 versions of .htl files.... :|

Quote:
Originally Posted by princeton
yea, I didn't think you would make an option for a standalone installer. The question now is would a hacker create two versions of their hacks - a non-htl and a htl version. If a hacker wishes for their hack to be installed by as many users they would be smart to create a non-htl version. Not everyone will install the HTL especially if it's not needed.
Everyone, -everyone-, is better off using HTL-hacks only. There is no reason for people who want to hack up their vBulletin to not install the HTL. Even for the tiniest hack, it makes things easier. To create, but also to use the hack.

The HTL was made and designed to make things easier, and it works perfectly for that. Creating a non-HTL installer would not only defeat the purpose, but also mean a lot of needless work for the Hack creator.

There is no real harm in making people install the HTL, it's only a few clicks and 3 simple file edits away. And then, once they've done that, a whole new world will open up for them. If people go release HTL-hacks only for a while, now, pretty soon there will be no need for this entire discussion anymore, and suddenly we'll have much more hacks because everyone has to spend far less time on each hack, and thus has more time to spare for new / other hacks :)

Quote:
Originally Posted by princeton
Anyway, I do agree with Faranth. the htl would make it more diffucult (more work) for some hacks.
I disagree. For the simplest, tiniest hack, the HTL is a better choice. For the huge, highly intricate hacks, the HTL is a better choice. For everything in-between, the HTL is still a better choice.

No matter the size of the hack, using the HTL for it is easier and faster.

Zachery 01-26-2004 04:40 PM
Quote:
Originally Posted by KuraFire
Hmmm... that might be due to the HTL using 'styleid' as the varname, and that that somehow changes a setting.... weird though, shouldn't happen in the Admin CP..
I'll look into it.


Maybe. If I were to implement that change now, I'd have to make HTL 1.1 be compatible with 2 versions of .htl files.... :|


Everyone, -everyone-, is better off using HTL-hacks only. There is no reason for people who want to hack up their vBulletin to not install the HTL. Even for the tiniest hack, it makes things easier. To create, but also to use the hack.

The HTL was made and designed to make things easier, and it works perfectly for that. Creating a non-HTL installer would not only defeat the purpose, but also mean a lot of needless work for the Hack creator.

There is no real harm in making people install the HTL, it's only a few clicks and 3 simple file edits away. And then, once they've done that, a whole new world will open up for them. If people go release HTL-hacks only for a while, now, pretty soon there will be no need for this entire discussion anymore, and suddenly we'll have much more hacks because everyone has to spend far less time on each hack, and thus has more time to spare for new / other hacks :)


I disagree. For the simplest, tiniest hack, the HTL is a better choice. For the huge, highly intricate hacks, the HTL is a better choice. For everything in-between, the HTL is still a better choice.

No matter the size of the hack, using the HTL for it is easier and faster.
unless you only want to install one hack :P

KuraFire 01-26-2004 04:40 PM
Quote:
Originally Posted by Faranth
it has 1 if not 2 file edits and no template edits :) all my templates are stand alone
Then it could still be done easier with the HTL :)

right now it may be slightly tricky, but I'm looking into ways for HTL 1.1 so that you can just install a new version of an already installed hack right on top of the existing one. So that would be easiest of all ways... sadly that's not in HTL 1.0 yet though, but hey, 1.1 won't be too long.. ^_^

KuraFire 01-26-2004 04:42 PM
Quote:
Originally Posted by Faranth
unless you only want to install one hack :P
Really, how many people in this community install only one tiny simple hack, and never touch any other hack?

That percentage is minimal, and certainly negligable if you ask me. Even for them it would be easier, cos the HTL, no matter how you look at it, is the easiest way to upgrade your vBulletin and instantly re-apply your hacks. Whether it's one hack or one hundred.

Zachery 01-26-2004 04:44 PM
Quote:
Originally Posted by KuraFire
Then it could still be done easier with the HTL :)

right now it may be slightly tricky, but I'm looking into ways for HTL 1.1 so that you can just install a new version of an already installed hack right on top of the existing one. So that would be easiest of all ways... sadly that's not in HTL 1.0 yet though, but hey, 1.1 won't be too long.. ^_^
not really, im my installer is ezier for this one alone but like ive stated it will be released for both.

all you need to do , upload files, run install, click button 2-3 times and your done :)

also only one file edit is truely nessary and thats only if you use CSS as a file

eXtremeTim 01-26-2004 04:45 PM
Quote:
Originally Posted by KuraFire
Upload the .htl file to your htlfiles/ directory, then go to Install Hack, choose the Nowplaying hack that should now be there, hit Install, and on the next screen, you will have 4 radio buttons at the bottom:

Import into database only - no changes
Do a complete, Real Install
Do a test run (shows file- and template edits)
Do a verbose test run (shows exact contents of each step)

Choose the first one (Import into database only) and it will add it to your database
Thats no good tho. It just shows me that i have a hack waiting to install. I cant edit any of the hacks stuff or anything. Like say that its installed on the hacklog.php page or anything. I got around the problems by just skipping over step 5, but not everybody is going to think about that. And with some hacks there might be new queries and stuff.

KuraFire 01-26-2004 04:51 PM
Quote:
Originally Posted by eXtremeTim
Thats no good tho. It just shows me that i have a hack waiting to install. I cant edit any of the hacks stuff or anything. Like say that its installed on the hacklog.php page or anything. I got around the problems by just skipping over step 5, but not everybody is going to think about that. And with some hacks there might be new queries and stuff.
That's probably residue from you doing an incomplete installation.

Try manually removing the hack from your database, table hack. Look at what hackid it has and then remove all rows in table hacklog that belong to that hackid.

Then try to import again.

KuraFire 01-26-2004 04:52 PM
Quote:
Originally Posted by Faranth
not really, im my installer is ezier for this one alone but like ive stated it will be released for both.

all you need to do , upload files, run install, click button 2-3 times and your done :)

also only one file edit is truely nessary and thats only if you use CSS as a file
That's because you've already had your installer. That isn't the case for 95% of the rest, they would still have to handcraft an installer on their own, first. But not if they choose to go the HTL-way.

eXtremeTim 01-26-2004 04:58 PM
Quote:
Originally Posted by KuraFire
That's probably residue from you doing an incomplete installation.

Try manually removing the hack from your database, table hack. Look at what hackid it has and then remove all rows in table hacklog that belong to that hackid.

Then try to import again.
No see the problem is that i have already installed the hack before the htl and alot of other people have installed hack before the htl. So there will be problems bringing hacks into the htl at first for poeple. There will also be problems with upgrades up hack from what i can tell. Your hack appears to not compare the new version with the old version and detect what to run and not run. If you could manage to add that in this hack would be god.

buro9 01-26-2004 05:42 PM
Loads of hype to be sure... but are there screenshots?

I personally am from the camp that I don't trust anything like this to manage my hacks... and I wonder how it will keep track of all the hacks I make to my own code that I don't release.

To this end, amid the cries of "lovely UI", is possible to have a series of screen shots showing how this all looks and as an overview for how it hangs together.

The killer thing that I'm waiting for is not the management of file changes, but the management of template changes (diff tool for updated templates compared to customised templates for example... phrase manager to show the non-default phrases and and the customised values after upgradem, etc).

As such... as overwhelming as the docs and this thread is... put me in the skeptical camp until I've seen convincing screenies and believe that this will manage my own private hacks too.

Awaiting the gif's or links ;)

Cheers

David K

PS: Don't flame me for being a cynic... I really want this to work... it sounds dreamy... but I'm elderly (30) and have grown far too cynical to just install a big hack and hope that it fills my dreams so easily ;)

Zachery 01-26-2004 05:48 PM
im currently taking some screens :)

Zachery 01-26-2004 05:54 PM
ok now i have a problem,

the templates only got installed to a single style not all of my styles >.> i see this as a problem in the long run

eXtremeTim 01-26-2004 06:03 PM
I agree that could be a problem but should also be fairly easy to fix.

Sufian 01-26-2004 06:28 PM
Great Hack! I just installed it :)

KuraFire 01-26-2004 06:56 PM
buro9, I can't blame you for being skeptical, it's a good attitude to have on Hacks! :)

As for screenshots, I wanted to do those today but I didn't get round to them.

As for the Templates issue Faranth mentioned, it will most likely be fixed in HTL 1.1

Back to what the HTL can do: it doesn't scout through files or templates to see what changes have 'magically' been made. What it does is provide you an easy to use interface so you can log your changes, each and every one, so that they are stored separately, in a nice organized manner. 'coincidentally' this manner can be utilized to create HTL Installer files that you can use to release your hack to the public - but you don't have to do that.

Zelda-King 01-26-2004 07:40 PM
I've installed it smoothly. Just one thing;

I get this error when I opt to 'show all modifications':
Quote:
Currently listing all Hacks at once
--------------------------------------------------------------------------------

Current hack:

Warning: in_array(): Wrong datatype for second argument in /domainurl/admincp/hackadmin.php on line 2183

You don't have permission to see the File- or Template edits for this Hack!

Warning: in_array(): Wrong datatype for second argument in /domainurl/admincp/hackadmin.php on line 2183
in spite of my userid being 1.

KuraFire 01-26-2004 07:50 PM
Quote:
Originally Posted by Zelda-King
I've installed it smoothly. Just one thing;

I get this error when I opt to 'show all modifications':
in spite of my userid being 1.
interesting....

are you sure that the HTL installation was finished entirely, properly?

Zelda-King 01-26-2004 08:15 PM
Yes, it certainly looked smooth. I should mention that I manually added the previously installed hacks without bothering to list mods and so on. Just the required fields and a few options. They all have the default allowed userid of 1 anyway.

If I go to the list at the bottom though (of hacks run through the installer), those links work fine.

ie,
Quote:
1) Hack Tracking Log

KuraFire 01-26-2004 08:22 PM
Quote:
Originally Posted by Zelda-King
Yes, it certainly looked smooth. I should mention that I manually added the previously installed hacks without bothering to list mods and so on. Just the required fields and a few options. They all have the default allowed userid of 1 though.

If I go to the list at the bottom though (of hacks run through the installer), those links work fine.

ie,
Very weird...

So, let me get this straight:

If you go to List All Modifications, you first get that error warning, then you get normal File/Template modifications, and then you get the PROPER list of hacks that you can click?
Or do you not get any file/template modifications in the middle either?

Zelda-King 01-26-2004 08:25 PM
I get the error on the 'list all modifications'. At the bottom of that page is the list of installed hacks that you can click on individually. If I click on those (though I only have one at the moment run through this installer) THOSE mods show up fine. Watch this space for a screenshot.

KuraFire 01-26-2004 08:33 PM
Quote:
Originally Posted by Zelda-King
I get the error on the 'list all modifications'. At the bottom of that page is the list of installed hacks that you can click on individually. If I click on those (though I only have one at the moment run through this installer) THOSE mods show up fine. Watch this space for a screenshot.
*waits for a screenshot*

I don't really get why you're having an error there, by all means it should work fine :/

What is your line 2183 ?

Zelda-King 01-26-2004 08:41 PM
Here! You know, I think it has something to do with the fact I haven't archived the file-template edits for the old hacks.

Zelda-King 01-26-2004 08:44 PM
Line 2183:
PHP Code:
if (!in_array($bbuserinfo['userid'], $hack['allowedusers'])) 
That being the case though (what I said in my last post) I'm wondering why the error only shows three times when I have like 14 old hacks.

KuraFire 01-26-2004 08:50 PM
Quote:
Originally Posted by Zelda-King
Line 2183:
PHP Code:
if (!in_array($bbuserinfo['userid'], $hack['allowedusers'])) 
That being the case though (what I said in my last post) I'm wondering why the error only shows three times when I have like 14 old hacks.
weird, weird, weird...

ok, try something for me, please. Try going to Manage Hacks -> Edit Hack Details (for the Hack Tracking Log), Allowed Userids field: enter 1 2 3 4

so, enter the first four possible userids, separated by spaced. Hit save. If you want, you can go edit it again and remove all but your userid from the list. It's just important that that field is recreated...

Then try again, please, and tell me what you get...

Link14716 01-26-2004 08:52 PM
I'm wondering: what is the deal with the "Temporary Phrase File"? I can see it being useful and all, but why is it required?

KuraFire 01-26-2004 08:55 PM
Quote:
Originally Posted by Link14716
I'm wondering: what is the deal with the "Temporary Phrase File"? I can see it being useful and all, but why is it required?
It's not entirely required, as such, but it _is_ necessary if you want to generate the XML file with your phrases.

The use of a Temporary Phrases File will make things easier during development (you don't have to do any phrases inserting or phrase group creating or anything during creation of your hack), and then once the hack is done, it will allow you to instantly have an XML file with those phrases, ready to be imported.

It's possible that you do it the old, conventional way, but that way is much slower and thus not recommended at all!

Zelda-King 01-26-2004 09:00 PM
Quote:
Originally Posted by KuraFire
weird, weird, weird...

ok, try something for me, please. Try going to Manage Hacks -> Edit Hack Details (for the Hack Tracking Log), Allowed Userids field: enter 1 2 3 4

so, enter the first four possible userids, separated by spaced. Hit save. If you want, you can go edit it again and remove all but your userid from the list. It's just important that that field is recreated...

Then try again, please, and tell me what you get...
OK I did that. No joy. Here I'll PM you some admin login info. I'm sure you want to see for yourself. :)

Link14716 01-26-2004 09:13 PM
Quote:
Originally Posted by KuraFire
It's not entirely required, as such, but it _is_ necessary if you want to generate the XML file with your phrases.

The use of a Temporary Phrases File will make things easier during development (you don't have to do any phrases inserting or phrase group creating or anything during creation of your hack), and then once the hack is done, it will allow you to instantly have an XML file with those phrases, ready to be imported.

It's possible that you do it the old, conventional way, but that way is much slower and thus not recommended at all!
I just read in the 'Help and Tips' about the existing phrasegroups. Gah, now I have to rename a lot of my phrases.... well, it's for the better I suppose.

Nice hack, Kura, now I just hope I'll get this working right for my shoutbox...

KuraFire 01-26-2004 09:16 PM
Quote:
Originally Posted by Zelda-King
OK I did that. No joy. Here I'll PM you some admin login info. I'm sure you want to see for yourself. :)
Thanks, I'll see what I can figure out... though it's boggling me quite a bit :|

Link: yeah, that's the downside of people converting their existing hacks to HTL, they haven't been warned in advanced that there are certain 'outlines' for making the hack in the most optimal way... :(

's why I wanted to rush the release of this thing so much, the longer I waited the more people would have your problem :(

Zelda-King 01-26-2004 10:21 PM
KuraFire: Your instructions did the trick. Many thanks! I thought I'd better say that in this thread so people know it wasn't a fault with the hack script at all. Very impressive support!

KuraFire 01-26-2004 10:47 PM
Quote:
Originally Posted by Zelda-King
KuraFire: Your instructions did the trick. Many thanks! I thought I'd better say that in this thread so people know it wasn't a fault with the hack script at all. Very impressive support!
Hey, it's just cos I know my script inside out ;)

I'm glad it did the trick, I would've been in trouble if that hadn't been the problem :D

^_^ And I'm glad you like the HTL! :)

squawell 01-26-2004 11:08 PM
hello Kura..i already test it on my another computer and it work now BUT when i refrash my admin cp i got below error message:
PHP Code:
Fatal error: Call to undefined function: construct_nav_option2() in C:\Apache Group\Apache2\htdocs\forum\admincp\index.php on line 450 
the line 450 is
PHP Code:
construct_nav_option2($vbphrase['htl_cphome_refresh_current_menu'], 'index.php?do=nav' . iif($thisnav!='vb' AND $vboptions['htl_use_dual_nav'], '&amp;hacksnav=1'), '<br />'); 
any idea?

PS:im use ur new update zip file.

Link14716 01-26-2004 11:12 PM
Did you edit includes/adminfunctions_navpanel.php?

madhouse 01-26-2004 11:15 PM
Got the same error messege , well on the same lines kinda....

Fatal error: Call to undefined function: construct_nav_option2() in /home/madhouse/public_html/forum/admincp/index.php on line 500

And yes I have edited the includes/adminfunctions_navpanel.php

KuraFire 01-26-2004 11:31 PM
IF YOU HAVE THIS PROBLEM:

Code:
Call to undefined function: construct_nav_option2()
You PROBABLY mis-placed the file edit in adminfunctions_navpanel.php!

The file edit in adminfunctions_navpanel.php has to go BELOW this:
PHP Code:
       </script>
        <?php
    
        echo $controls . $_NAV . $_controls;
    
     }
Pay close attention to the closing bracket:
}

it all has to go BELOW that!


This is *most likely* what you did wrong - paste the new code 2 lines too high. :)

Link14716 01-26-2004 11:35 PM
I personally still have a "Make vB.org Post" error with the text for the modified stuff:
https://vborg.vbsupport.ru/showthread.php?p=469032

I redownloaded the zip and uploaded the new hackadmin.php and even tried modifying it to work myself with little luck.

madhouse 01-26-2004 11:36 PM
Sorry KuraFire ,

I have it exactly like you said

</script>
<?php

echo $controls . $_NAV . $_controls;

} <<<<<<<-----------\

right after the bracket

Link14716 01-26-2004 11:41 PM
Personally, I dropped it under this code:
PHP Code:
// ###################### Start makenavoption #######################
function construct_nav_option($title, $url, $extra = '')
{
// creates an <option> or <a href for the left-panel of index.php
// (depending on value of $cpnavjs)
// NOTE: '&$session[sessionurl]' will be AUTOMATICALLY added to the URL - do not add to your link!
    global $session, $options;
    static $sessionlink, $bubblefix;

    if (!isset($options))
    {
        $options = array();

        if ($session['sessionurl'] == '')
        {
            $sessionlink = '';
        }
        else
        {
            $sessionlink = "&amp;s=$session[sessionhash]";
        }

        // only include the bubble-fix for IE - ignore when encountering the Konqueror/Safari event model
        if (is_browser('ie'))
        {
            $bubblefix = ' onclick="nobub()"';
        }
        else
        {
            $bubblefix = '';
        }
    }

    $options[] = "\t\t<div class=\"navlink-normal\" onclick=\"nav_goto('$url$sessionlink');\" onmouseover=\"this.className='navlink-hover';\" onmouseout=\"this.className='navlink-normal'\"><a href=\"$url$sessionlink\"$bubblefix>$title</a>$_extra</div>\n";
} 
and it works perfectly.

madhouse 01-27-2004 12:02 AM
Tried it that way too link and still same error in the admin panel nav.

Its calling the error on the index.php , which keeps talking about the
construct_nav_option2()

For some reason it just does not like this at all...

KuraFire 01-27-2004 12:03 AM
Quote:
Originally Posted by Link14716
I personally still have a "Make vB.org Post" error with the text for the modified stuff:
https://vborg.vbsupport.ru/showthread.php?p=469032

I redownloaded the zip and uploaded the new hackadmin.php and even tried modifying it to work myself with little luck.
oh christ, don't tell me I made a typo in the updated zip's hackadmin.php.....


... ++++! I did... :(

*sighs and updates again*


All times are GMT. The time now is 10:15 AM.
Page 3 of 10 12 3 45 Last »
Show 40 post(s) from this thread on one page

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01897 seconds
  • Memory Usage 1,890KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code_printable
  • (6)bbcode_php_printable
  • (24)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete