I like to like it ;)

I had a similiar problem with everything seeming to work fine but the attachments not actually showing in the pm's.. I finally tracked it down to the fact the forum had been upgraded from vb2, and we`d had the private attachments hack installed and so there was already a "private" table in attachments, I`d overlooked this on installation, but on removing that table and creating a new one fixed the problem with attachments not showing...

Might not work for others, but it worked for us and it gives people another option to try when attempting to get this great addon working... (haveto agree with Erwin too, this should be standard in gold! definetly get's my vote)

Great job!

Thanks for this excellent tool ...

/me installs *

Found another boo-boo with this. If you add an attachment to a pm and then preview the pm, the attachment has detatched itself. Then, without saving the message, view your attachments and you will see the attachment in the listing.

I installed this, and everything looks fine so far, except it keeps
telling me I don't have permission to do an attachment.

I'm not clear as to what is meant here...
Do I do this in a PM?

oh, and I'm running RC3
I couldn't fine this bit of code in the "pm_newpm"
I also have the hack so that the reciept box is a checkbox instead of a popup.

OK with the checkbox mod the line look like this in the "pm_newpm"

in stead of ...look for....
and change to...
right?

Yes, that's right. In fact you can add that bit of code anywhere inside the form tag... it doesn't have to be near the receipt or anything. I just added it there to group it with all the other hidden fields.

The new phrases are added in the admin control panel, that is, you go to the phrase manager and click on the "add new phrase" button

A couple of changes to fix this. Thanks for spotting this, Boofo.

In private.php search for this
change it to
In the template pm_newpm, search for this
change it to
TXT updated also

I found where to add the phrases there.
It still says I don't have permission when I open the attachment window though. :surprised:

Did you do the template modifications in the newattachment template? That would be a cause for the window to give you a nopermission error.

If you have the hack installed in an accesible board for me to take a quick peek that would help also.

Thanks Kentaurus!
It was in the "newattachment.php" file.
I must have missed something in that file the first time around.
I took a fresh copy, and tried it again. It works perfectly now. :up:

Is there a way to moderate PM attachments in the admincp, like
the regular attachments?

The attachments follow the same rules as the regular attachments, they count for the quota of the user, and you can search for them in the admincp by author, date or any other field.

As for having a moderator queue for attachments that's not a feature. In fact, you do not moderate user's private messages and neither the attachments.

ah, I see

Well I upgraded to RC4 and reinstalled this hack, but
it has put it at the top for some reason..
It still works good though.:D

How is your pm_newpm template? You can add $attachmentoption wherever you want that box to show. Seems to me that it is above the message area. I wil re-check it as soon as I have rc4 installed.

ah, yeah I had to move it down in the pm_newpm temp.

find
and put it right below it...like..
I also had a problem with the "private.php" file and had to
change a few things.

All seems to be working well.. :)
Just a small thing of concern, in the message itself where the attached images are shown, the "Attached Images" in the message isn't framed like your screenshot demonstrates..

I've attached a screenshot of this, hopefully you can shed some light on this.?

I think I found another bug. I had a member send me a photo of something. I still have the message and there is a paperclip showing there is an attachment to it but when you open the message, there is no attachment there. Now, this member erased all of her sent messages in the pm area. Could that have something to do with this since she is the one who sent it? Cause the attachment she sent me never showed up in my attachment list, only hers.

Yes that'll do it. I just did the install and found that out right away. Which is a good feature if you ask me. Great hack. My install was flawless on RC4. Thanks alot.

It's not a good feature if you want to hold on to an attachment like I wanted to. ;)

That's a template thing, if the normal attachments appear framed then the attachments in private message should, too. Try attaching a jpg instead or a gif to see if it changes. How does it show in a normal postbit?

That's because the ownership of the attachment is mantained to the person who sent it. He can delete it anytime and you wouldn't have the attachment anymore. I can't give the ownership of the attachment to the recipient because there could be multiple recipients and I wouldn't know who should be the owner. And making a copy for everyone and storing an attachment 3-4 times doesn't seem to me as a good solution.

But the paperclip still showing up is a bug, I'll look into it. That should dissapear as soon as there are no more attachments.

Then how can we save an attachment for later without having to download it? Is there anyway to set it up so if someone does decide to delete their attachment, then and only then it would transfer ownership to whoever still has the message that was sent to them with the attachment? On bigger sites, I can see what you're saying might make sense as to not fill up the site with attachments. But on a small site, like mine, there is no worry there yet. Besides, the Admin can see and delete any attachments in the Admin CP if it looks like it is starting to get out of hand.

Aha.! Correct..
This is a problem with the .gif extension for some reason (on normal posts too)..

Hmm.. *scratches head*


[high][EDIT][/high]
Hmm.. Just noticed vB.org has this very same problem.
https://vborg.vbsupport.ru/showthrea...586#post474586

[high][EDIT 2][/high]
Ok, this is due to image sizes.. My bad.. :o

That gif in the link has the box around it ok. What are you seeing?

EDIT: What sizes are we talking about?

The maximum pixel size w/h an image can be before it is shown as "thumbnail" form.. :)

Concluding that this is default behaviour and not a bug with the mod..
Awesome work Kentaurus.. :D

LOL I know WHAT it is, I was curious about what actual size file is messing it up.

Ahh sorry.. It IS 2am here afterall.. ;)
Anything below the default w AND h of 100 pixels here at vB.org..

Looks great but..

* PM attachment is showing up on the forumindex trough this mod: https://vborg.vbsupport.ru/showthread.php?t=61244

* javascript error sendmail: (see attachment)

* Kan not see the send attachment in PM

Note... if the author updates his hack this would need to be updated also.

In Mindtrix hack, look for:

change it to:
sendmail has nothing to do with this hack, what error are you getting?

Some people reported me before that the attachments weren't showing in the pm, I haven't traced why yet but someone also said that enabling thumbnails in the acp made them visible (I still haven't been able to reproduce it).

Wand me to update my hack with your fix, so it does not clash with your hack mate?

Thanks Mindtrix, that would be nice. Only that you would need to put it as a note because normally they don't have a "private" column in the table.

Sure ill just make a link then in my post saying about it etc

/me installs, and hopes it all works fine in RC4.

Another small bug. ;)

When you preview a message, the attachment is still there but it doesn't show in the attachments box until you open it up and do a blank upload. Then it lists like it should. Can I get my "fix" for this? ;)

I would need more details for this one. When I send a PM, preview it, if I click in the manage attachments button then the pop-up already has the previously attached file. Or do you mean in the pm original window and not the pop-up?

Ok, I guess I got it a little confused. I mean right above the Manage Attchaments button in the Additional options box underneath the message. It won't show the attachment in a preview until you open up the manage attachments box and close it.