vb.org Archive
Page 3 of 5 12 3 45
Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 2.x Full Releases (https://vborg.vbsupport.ru/forumdisplay.php?f=4)
-   -   Quick PM Reply Box (https://vborg.vbsupport.ru/showthread.php?t=38178)

MalaK_3araby 07-28-2002 11:59 AM
Thanks Erwin.

* Installed *

Erwin 07-28-2002 07:19 PM
Quote:
Originally posted by Boofo
I'm sorry, I guess i didn't explain it right. :)

It worksd fine for me except when it is quoted from someone else. Then it still shows the [disable]/me[/disable] code instead of that person's name in the quote.
Like I said, the /me code works for me in both the reply and the quoted section. If it doesn't work for you, then you didn't install the /me code or my hack properly. I didn't do anything extra for it to work.

Erwin 07-28-2002 07:22 PM
Quote:
Originally posted by Boofo
I must be doing something wrong then, because I have that hack installed and I still get more than the last quote if there is more than one (but only in the Quick Reply PM Box, the regular reply box works as it should).

The RE: RE: fix is working fine now. Thanks, Erwin. :)

Now, all we have to do is figure out the quote problem, for now, anyway. :) Is anyone else having the quote problem in the Quick PM Reply Box after the hack install?
That's weird, because I installed the "remove quote hack" and it fixed up my quote problems. Did you install that hack properly - you need to place the variables in the right spot.

Virix 07-28-2002 08:41 PM
The Re: problem is because your hack just keeps adding Re: to the title, it does not strip the old one out:

Code:
In template privmsg:

Find:
<input type="text" class="bginput" name="title" value="RE: $message[title]" size="40" maxlength="85" tabindex="2">


Replace with:
<input type="text" class="bginput" name="title" value="$quicktitle" size="40" maxlength="85" tabindex="2">



In file private.php:

Find:
$touserinfo = getuserinfo($message[touserid]);


Under that add:

    if (strtolower(substr($message[title],0,3))=="re:") {
      $quicktitle=trim(substr($message[title],3));
    }else{
    $quicktitle=$message[title];
    }
 
  $quicktitle="Re: $quicktitle";
I got several complaints abou the Re:'s so I went though and fix it..

Hope this is what you want....

Boofo 07-29-2002 01:12 AM
How can you install it wrong? Herer is that section of code to prove it.

PHP Code:
$message['message'] = preg_replace('#^/me(.*)$#im', "[color=yellow]* $fromuserinfo[username]\\1[/color]",
$message['message']);
$message['message'] = trim(preg_replace('~\[quote\](.*)\[/quote\]~si', '', $message['message']));
      eval("\$message[message] = \"".gettemplate("priv_reply",1,0)."\";");
  } else {
    $message = array();
  } 
Quote:
Originally posted by Erwin


That's weird, because I installed the "remove quote hack" and it fixed up my quote problems. Did you install that hack properly - you need to place the variables in the right spot.

Erwin 07-29-2002 01:34 AM
There is no need to do anything to the private.php file for the /me hack to work with my hack. Nothing at all. Just remove all those things from the private.php if they are there. (Trust me, the /me code works for me.)

Boofo 07-29-2002 01:50 AM
But we need the code above to make it work in the Regular Reply for private messages, don't we? :)

Erwin 07-29-2002 03:35 AM
Like I said, it all works - just install the /me hack as normal, and then my hack as normal, no need to do anything else.

Boofo 07-29-2002 03:40 AM
Whatever. The reason I put the code in above is I couldn't get it to work in private messages (Quick reply or regular) until Firefly gave me that code to put in there. Then it started working in the regular replies. I don't use the Quick PM Reply Box much anyway, so UNINSTALL. The support isn't that good anyway. Anyone can say "I don't know, works good for me".

Quote:
Originally posted by Erwin
Like I said, it all works - just install the /me hack as normal, and then my hack as normal, no need to do anything else.

Erwin 07-29-2002 07:20 AM
Quote:
Originally posted by Boofo
Whatever. The reason I put the code in above is I couldn't get it to work in private messages (Quick reply or regular) until Firefly gave me that code to put in there. Then it started working in the regular replies. I don't use the Quick PM Reply Box much anyway, so UNINSTALL. The support isn't that good anyway. Anyone can say "I don't know, works good for me".
You haven't given me anything to work with. Your problem could be caused by a million things - another hack interfering with this one etc. I support this hack - I cannot be expected to support Firefly's hack to make it compatible with this one. Like I said, it IS compatible. You posted a piece of code but don't tell me where it is. It's not in my private.php. Where is that code from? What do you expect me to do? I don't have access to your PHP files or your templates?

Also, I work full-time as well - I posted this hack up as a gesture of thanks for the multiple hacks I have taken from here. Don't expect 24 hour instant support. :)

Erwin 07-29-2002 07:35 AM
Just for you, Boofo, I'll make an exception. PM me your private.php file, and your privmsg template as attachments, and I will fix it and PM them back to you. It's going to be interference from another hack. I had the /me hack running for a while, before I did up this hack, and they both work fine. Anyone else with this problem?

Boofo 07-29-2002 07:59 AM
I've given you as much to work with as I have available. I DID fix the quote problem though. I replaced the code for your hack in private.php with the following:

PHP Code:
// Start of Quick PM Reply by Erwin
  $pmquote = trim(preg_replace('~\[quote\](.*)\[/quote\]~si', '', $message['message']));
// End of Quick PM Reply by Erwin 
and now there is only one quote in the quick pm box. As far as the RE fix, I followed Virix's code above and took care of that problem. I'll pm you the files if you still want to look at the me code problem.

Quote:
Originally posted by Erwin


You haven't given me anything to work with. Your problem could be caused by a million things - another hack interfering with this one etc. I support this hack - I cannot be expected to support Firefly's hack to make it compatible with this one. Like I said, it IS compatible. You posted a piece of code but don't tell me where it is. It's not in my private.php. Where is that code from? What do you expect me to do? I don't have access to your PHP files or your templates?

Also, I work full-time as well - I posted this hack up as a gesture of thanks for the multiple hacks I have taken from here. Don't expect 24 hour instant support. :)

Erwin 07-29-2002 10:51 AM
The quote hack would fix my hack without needing to change any of the code in my hack, but anyway...

I have PMed you a modified copy of your private.php - it should fix the /me hack (I hope) - but I did take out that quote hack thing in the meantime.

If all goes well, both your /me hack and quote hack should work automatically. Like I said, my hack does NOT interfere with these hacks since it just copies the data that has already been changed - if not, you may need to move the $pmquote line after the message has been parsed into vBCode, but BEFORE it has been parsed into HTML.

Anyway, try out the private.php that I modified for you.

Erwin 07-29-2002 10:52 AM
Also, may I add, Boofo, that your private.php actually has MORE hacks than mine - :) - there is a high chance of conflict between them. I had to rationalize your $message[message] variables - you had multiple copies of these with different values.

Boofo 07-29-2002 11:00 AM
Well, I just tried it with the file you sent me. Now I have no subject line when I am replying with the quick reply box and the quotes are back again if there are multiple of them. :)

Boofo 07-29-2002 11:11 AM
This is what I mean with the me code. This is what shows up in the Quick PM Reply Box when I look at a message from anyone who has used this code. Instead of seeing their name in place of the me, I see this. For some reason it isn't being parsed like it is in the pm regular reply box

Quote:
/me like this
and this is how it shows up in the regular pm reply box:

Quote:
* Boofo like this

Erwin 07-29-2002 07:23 PM
Okay, I know it's not the private.php file, because your private.php file looks a bit more like mine now (I did an Araxis Merge compare) - you are just missing something essential that I have in another file that you don't. Let me look at it again. I'm going to work, and can only do this tonight. Please be patient.

Boofo 07-29-2002 08:00 PM
Thanks for taking the trouble and the time on this. I really appreciate it. No hurry, just when you get some time. Thanks again. :)

Quote:
Originally posted by Erwin
Okay, I know it's not the private.php file, because your private.php file looks a bit more like mine now (I did an Araxis Merge compare) - you are just missing something essential that I have in another file that you don't. Let me look at it again. I'm going to work, and can only do this tonight. Please be patient.

Erwin 07-30-2002 09:13 AM
Boofo, did you install this bug fix? Make sure you do.

https://vborg.vbsupport.ru/showthrea...threadid=35894

I cannot find the reason why /me would not work for you. I looked at your private.php at length - no idea.

Sorry.

Also, I don't know why the quote hack would not work for you too.

For other members: both the /me hack and quote hack works for me. Do they work for you? Anyway, I am not responsible for this hack being compatible with other hacks - there are hundreds of hacks out there - I don't have time to figure it out for each individual.

Boofo 07-30-2002 05:17 PM
Yes, I installed that bug fix a long time ago before I installed the me hack. You said something about moving the quote hack in the file, too.

Right now, I am using the original private.php I sent you and the quote and RE hack work fine. I have an idea on the me hack, too. If it works, I'll let you know.

Quote:
Originally posted by Erwin
Boofo, did you install this bug fix? Make sure you do.

https://vborg.vbsupport.ru/showthrea...threadid=35894

I cannot find the reason why /me would not work for you. I looked at your private.php at length - no idea.

Sorry.

Also, I don't know why the quote hack would not work for you too.

For other members: both the /me hack and quote hack works for me. Do they work for you? Anyway, I am not responsible for this hack being compatible with other hacks - there are hundreds of hacks out there - I don't have time to figure it out for each individual.

Vile 08-14-2002 05:34 AM
Awesome hack, worked like a charm:)

2 X Viverridae 08-14-2002 10:50 AM
Great hack - installed with no problems whatsoever.

Thanks a lot!

threadcrapper 08-15-2002 11:30 PM
I hit the install button on this one -- the users love it -- went in like a charm!

Erwin 08-16-2002 07:06 AM
Glad you like it. :)

ULTIMATESSJ 08-16-2002 07:37 PM
great hack

/me clicks on install

Buddha 09-04-2002 02:38 AM
installed.
thanks.

yzztik 09-09-2002 10:52 AM
I have a quick question ... when you reply to a PM with the quick reply box, it does not change icon next to the message saying it has been replied to. Any idea what code I can change/add to get it to do that? Thanks!

Erwin 09-09-2002 07:08 PM
Quote:
Originally posted by yzztik
I have a quick question ... when you reply to a PM with the quick reply box, it does not change icon next to the message saying it has been replied to. Any idea what code I can change/add to get it to do that? Thanks!
It works.

The quick PM reply box uses the SAME code as the normal PM reply page. The icon automatically changes when you use the Quick PM Reply Box. I just tested it on my forum and it definitely works. So something is wrong with your private.php or you haven't installed the hack properly.

yzztik 09-09-2002 07:24 PM
Hmm ... thats not good :p Any idea of where I should start looking for what might be wrong? Can you maybe post the part of that page that controls this and see if I can find the error? :S I have seen this behavior at another board too so its not just mine. I wonder if there is an extra step I missed somewhere :S

Erwin 09-09-2002 09:58 PM
Quote:
Originally posted by yzztik
Hmm ... thats not good :p Any idea of where I should start looking for what might be wrong? Can you maybe post the part of that page that controls this and see if I can find the error? :S I have seen this behavior at another board too so its not just mine. I wonder if there is an extra step I missed somewhere :S
Mmm... considering the code additions to private.php are:

1) 1 line for the copying of the PM message before it's parsed into HTML so that we can display the quote

2) 3-4 lines of an "if" section to delete the old PM if the delete box is ticked

Everything else uses the normal PM reply function in privatep.php so the only reason why it is not working for you is if you have accidentally deleted the section of code that changes the icon... my hack doesn't even go near it.

yzztik 09-09-2002 10:19 PM
Ok fair enough, I'll sift through it and see if I can find the error ... but if i had accidently deleted that part of the code, wouldnt it not work at all even when using the regular PM reply instead of the quick PM box? Cuz it works then ... thats whats so odd.

Erwin 09-09-2002 11:02 PM
Is this happening to anyone else using this hack? Or is this an isolated problem? Because this problem doesn't occur with my forums.

yzztik 09-09-2002 11:22 PM
Well, I know that it happens for sure in one other board that I frequent and I did not install that one though we have similar hacks *shrug*

I am curious to know if anyone else is having the problem ...

JoergZ 09-22-2002 12:40 AM
Great Hack Erwin ! :)

But I must say, I have the same error, that after a reply with the Quick-Box the icon of the original PM is not changed.

(vB Vers. 2.2.6)


J?rg



P.S. I found the error why the icon was not correct (the field "messageread" was not updated correct.

In the template modification of your hack the wrong line is:

Code:
<input type="hidden" name="privatemessageid" value="$privatemessageid">
It must be

Code:
<input type="hidden" name="prevmessageid" value="$privatemessageid">
After that change it works correct.


J?rg

Erwin 09-22-2002 06:49 AM
Ahhh... thanks Jorg. I have both lines in my forums - the line that I put in the hack is the line for the private message preview hack. That's why I never had this problem.

When I wrote the installation file, I deleted the standard line and kept the wrong line for this hack. :) I meant to delete that one, not the one that is standard.

I've fixed the installation text file, and sent an update to all who installed this so they know to fix it.

TheEDIGuy 09-25-2002 11:49 AM
Erwin, I just installed this hack, because my users have been requesting it. I think it'll be nice, and the install was problem-free.

However, when I check the box to delete the original PM, I always get this message:

Quote:
No privatemessage specified. If you followed a valid link, please notify the webmaster
I haven't made any modifications to private.php or the privmsg template before this. I'm running vb 2.2.7. Any further info needed, please let me know.

Thanks!

John
http://www.fansofrealitytv.com
When your reality sucks, there's Reality TV!

Mike11212 09-25-2002 12:07 PM
great hack :)

Erwin 09-25-2002 11:23 PM
Okay, a minor bug fix.

It seems that you need BOTH lines in the template.

Make sure that you have BOTH of these lines in the template code that you add to "privmsg" - the first one is needed for the delete box to work, the second one for the icon to change to SENT when a message is replied to.

Code:
<input type="hidden" name="privatemessageid" value="$privatemessageid">
<input type="hidden" name="prevmessageid" value="$privatemessageid">
Sorry about this. :) I knew that the first line was there for a reason! :)

Erwin 09-25-2002 11:23 PM
Yeah, and I've updated the installation text file to version 2.2 to reflect this.

Areku 10-06-2002 05:07 PM
Once more, thanks for this great hack!

Works like a charm on vb 2.2.0!

Thanks!


All times are GMT. The time now is 03:49 AM.
Page 3 of 5 12 3 45
Show 40 post(s) from this thread on one page

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01479 seconds
  • Memory Usage 1,847KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (4)bbcode_code_printable
  • (2)bbcode_php_printable
  • (13)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete