vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   Modification Graveyard (https://vborg.vbsupport.ru/forumdisplay.php?f=224)
-   -   Mini Mods - [OzzModz] Welcome Thread / Post For New Users (https://vborg.vbsupport.ru/showthread.php?t=305915)

ozzy47 12-26-2013 10:26 PM

Glad ya like it. I figured there was a few issues with the older ones, so I made this up. Thanks for marking as installed. :)

CAG CheechDogg 12-27-2013 04:24 AM

Quote:

Originally Posted by Alan_SP (Post 2469257)
This is excellent news.

But there's something funny that just happened. The mod created three welcome threads without user actually being registered.

Time stamps of threads are:

18.12.2013, 16:21:24
18.12.2013, 16:21:33
18.12.2013, 16:21:34

In place of user name, there's nothing, as no user actually registered. I'm using option that they have to confirm email address.

At that time one user probably tried to confirm email address, or did something, I have for that user this info in ACP:

Time of last activity 18:21 (no seconds in ACP).

So, there's something that this user did what triggered creation of thread although there were not actual successful email activation.

I need to mention, on my site there are sometimes situations when users post double posts when they try to post single. This is vB bug, or something, as this should be prevented if they try to post same post too soon. I use vB 4.1.12.

So, this three threads could be result of this, or something related.

Anyway, part of checking if user actually confirmed email address has an error, or at least it didn't worked on my site for some reason.

I actually had 5 recent threads created with that just said, "has just joined my site" with no username...weird eh? ....

ozzy47 12-27-2013 04:33 AM

Hopefully I can track it down this weekend.

CAG CheechDogg 12-27-2013 04:37 AM

Good stuff ozzy ..I will keep an eye for more and I will see if I can maybe catch some kind of pattern or something...thanks Ozzy ..

Alan_SP 12-27-2013 01:58 PM

Quote:

Originally Posted by CAG CheechDogg (Post 2470737)
I actually had 5 recent threads created with that just said, "has just joined my site" with no username...weird eh? ....

I found what triggers this behavior. It's described here in post #70. I added additional instructions in email for email confirmation, hopefully it would help my users confirm emails more often.

CAG CheechDogg 12-28-2013 07:29 AM

Ok ozzy, so I got about 15 new threads created my Man, they all have the same IP of :

The IP Address is: 66.249.73.147
The host name is: crawl-66-249-73-147.googlebot.com

https://www.cagclan.com/community/th...d-CAGCLAN-com-!

Every single one of these threads without a username has googlebot.com triggering it. Hope that helps you out.

ozzy47 12-28-2013 11:40 AM

Hmmm, then they are somehow triggering the link. Do you have your register page in your robots text?

Code:

User-agent: *

Disallow: /register.php


CAG CheechDogg 12-28-2013 04:22 PM

Quote:

Originally Posted by ozzy47 (Post 2470964)
Hmmm, then they are somehow triggering the link. Do you have your register page in your robots text?

Code:

User-agent: *

Disallow: /register.php


It was but I have Rename register.php by BOP5 installed so the register.php was now different. I did add it to my robots.txt file now, is that the reason for this?

ozzy47 12-28-2013 05:22 PM

In your case it may be possible,lets see what happens now that you have the newly named file in the robots.txt.

CAG CheechDogg 12-28-2013 07:31 PM

Quote:

Originally Posted by ozzy47 (Post 2471001)
In your case it may be possible,lets see what happens now that you have the newly named file in the robots.txt.

Ok ozzy...thanks, I will keep an eye on it now ...

CAG CheechDogg 12-29-2013 06:31 AM

Ok so a few hours later and I still got 3 new threads with no name ...1 from google and another one from some random IP ....

ozzy47 12-29-2013 11:35 AM

Crap, ok then that did not help. :(

CAG CheechDogg 12-29-2013 12:14 PM

Lol...Maybe the robots.txt didn't get updated in time for the robots to get the update of the change? .....

I haven't had any new threads with no names since I last posted this, that's why I am hoping that it took time for the bots to notice the change...

ozzy47 12-29-2013 12:27 PM

Possible, I am waiting to figure out a fix for this. If there was another hook that vBulletin had available it would be no problem, but they don't have the right hook available. :(

CAG CheechDogg 12-29-2013 12:55 PM

Can't we create hooks ourselves?

ozzy47 12-29-2013 12:58 PM

Yeah you can, but then that would require a file edit, and I don't like users editing vBulletin files to add stuff. I am wanting to see if any of the users here have a valid vbulletin-germany.org account, there may be a potential fix in a similar mod there.

CAG CheechDogg 12-29-2013 12:59 PM

Sweet ...thanks ozzy

Alan_SP 12-30-2013 06:15 PM

Quote:

Originally Posted by ozzy47 (Post 2471128)
Possible, I am waiting to figure out a fix for this. If there was another hook that vBulletin had available it would be no problem, but they don't have the right hook available. :(

I was thinking about this and maybe I have valid solution.

These multiple threads I call "empty", as they don't have username in them. Maybe if you could check username variable, if it's empty, you don't do anything, but if it contains something (actual user name most likely), you go and create new thread.

With this check I think you'll avoid creating multiple "emtpy" threads and I think it's not too hard to code it.

ozzy47 12-30-2013 08:09 PM

Quote:

Originally Posted by Alan_SP (Post 2471368)
I was thinking about this and maybe I have valid solution.

These multiple threads I call "empty", as they don't have username in them. Maybe if you could check username variable, if it's empty, you don't do anything, but if it contains something (actual user name most likely), you go and create new thread.

With this check I think you'll avoid creating multiple "emtpy" threads and I think it's not too hard to code it.

Try out the attached XML, and lets see if that stops the blank threads. Let me know when you downloaded it so I can remove it.

CAG CheechDogg 12-31-2013 04:51 AM

Ok ozzy, I downloaded and installed it....I will let you know if I get anymore empty name threads my Man ..thanks a lot !

ozzy47 12-31-2013 04:52 AM

Well it was for Alan_SP but yeah it won't hurt to have you test it too. You have it set to create the thread after email validation?

CAG CheechDogg 12-31-2013 05:18 AM

LOL! hah...

But yes, I have it set like that as well ...

But just a note, the googlebot IP is always the one that is triggering these new no username threads still ...

So hopefully this xml file will fix it ....

ozzy47 12-31-2013 05:20 AM

OK cool, let me know how it goes.

CAG CheechDogg 12-31-2013 05:20 AM

Yes I do...I doubled checked and it is checked off with "NO" which is what your description says " No = After email activation".....correct?

ozzy47 12-31-2013 05:21 AM

Correct, No means they should be triggering the activation email link in order to create the thread.

CAG CheechDogg 12-31-2013 05:26 AM

Roger that! ...thanks ozzy

ozzy47 12-31-2013 05:28 AM

In the next version I am going to change that to radio buttons to make it more clearer.

Alan_SP 12-31-2013 03:56 PM

Quote:

Originally Posted by ozzy47 (Post 2471395)
Try out the attached XML, and lets see if that stops the blank threads. Let me know when you downloaded it so I can remove it.

Ok, I installed and tested attached version.

I tested it with everything that before created multiple "empty" threads, now there was none. Of course, I tested if successful activation would produce valid thread, it did.

I think we can call this solved. :up:

Of course, I'll monitor what's happing now in "real life", as I maybe overlooked something, but I think we (well, you :D) got it. :D

ozzy47 12-31-2013 04:08 PM

Ok I will hold off on a update to the mod till we can confirm this a bit longer. :)

Alan_SP 12-31-2013 04:13 PM

If you want to wait, ok, but I think this solved these empty threads.

If only you could easily achieve mentioning to work... But for now, it should be done manually...

ozzy47 12-31-2013 04:19 PM

I just got to go through Fillips code, and see what tables in the DB he updates when a mention is used, and replicate that in this mod. I will also have to put a check in there to make sure the mod exists, and is not off.

Alan_SP 12-31-2013 04:27 PM

Yes, I know, I just wish if it could be easier for you to code. And universal, of course. :(

ozzy47 12-31-2013 04:33 PM

If I could code by what I think, or code like I can do construction work, I would be a millionaire. But alas, I only started to learn coding about two years ago.

Alan_SP 01-01-2014 03:29 PM

Well, we all learn every day something new. :up:

ozzy47 01-01-2014 03:30 PM

Yeah that is a fact. :)

CAG CheechDogg 01-01-2014 06:34 PM

Well so far so good ozzy , no more empty name threads since installing the new xml file. By this time I would of had a few ones already ... I will of course still keep an eye out but like Alan said, this looks to be solved! Great work ozzy!

ozzy47 01-01-2014 06:42 PM

Excellent, I am glad it seems to be sorted. :)

CAG CheechDogg 01-02-2014 09:06 AM

My man ozzy, no more empty name threads on my forums! Thanks Bro, this issue definitely looks like it has been fixed. You rock ozzy, this mod has seriously raised my forum's activity since adding it. It's a hit !

ozzy47 01-02-2014 10:38 AM

OK cool, then I can start building off the fixed version. :)

Menno11 01-03-2014 12:13 PM

Thx Ozzy

I liked it allot

installed en MoTm


All times are GMT. The time now is 06:30 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02669 seconds
  • Memory Usage 1,814KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (7)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete