A brilliant mod, which combines a few things like Keyword Checker and StopForumSpam into one, though I have found one major feature missing.

For the Keyword checking, the only option is Auto-moderation. Sadly with the amount of spam bots about that moderation queue can be over 100 long in the morning every day, with an old VB3.8 plugin we use to just deny anyone with less than 3 posts who hits a keyword, would it be possible in a future version to add the option to either send to moderation, or just stop the thread being posted?

Cheers all the same, a great addon :)

Thanks for the update. This mod is awesome.

Error with vBulletin 4.0.6 by creating an article:
PHP Parse error: parse error in \includes\class_dm_threadpost.php(1766) : eval()'d code on line 4

It's the hook threadfpdata_presave.

Can you fix this error:?

Im getting it after posting.. Its causing me to double post.

If you are getting this error:
it would be nice to know version number of your vB.

Do you mean in the CMS, blog or in the forum? If you can give me details on what you do to get that error I will try to track it down on this side.

CMS Article. As I described I created a new article and clicked Save. The message appears and the article is not saved. If I disable your mod, it works.
I have also disabled automoderation, but this has no effect.

I still don't see the point of it. How often do you see a 3 year old suspected bot resurface and start posting spam? Never I guess. You might as well keep those users and make your forums look like they have more members than they do.

I am not saying it isn't possible that your request will make it into this mod, but it is unlikely anytime soon.

Thanks.

Yes that is possible, do you have an example of the old mod so I can see how it was handled?

We have such bots posting after years of silence. Also it does not make any sense to have dead accounts just to show more users. I love to keep my forums clean.

Anyway, if you don't implement such a thing, I will do it as I need it.

Another thing:
In my Log Viewer there are entries with "No Username Submitted". They just have the eMail Address. How can that be?

The logs are overly verbose in this version and so is the checking. We will probably disable that as in many cases it is just information for your viewing pleasure.

The reason you see no username or no email is because some bots do not provide those details, then Spam-O-Matic sends them to the vBulletin registration system (or bans them as the case may be) When they get to the vBulletin registration system they are eventually blocked for not having the required fields.

Ok, in this case they were blocked due to eMail Address. Thanks for the info.

bug...

Only happens when a user clicks "Go Advanced" on the quick reply form. Does not happen when double clicking "Reply to Thread".

Im running 4.0.6PL1

I get this error when I try to delete a post as spam and ban the bot:


Fatal error: Using $this when not in object context in /home/website/public_html/includes/functions_vbghsfs.php on line 459

Even after I disabled and then uninstalled the plugin this error still exists.

Im getting this error also when making new posts.


Parse error: syntax error, unexpected T_BOOLEAN_OR

I can't dupe it. I need versions.

When you submit a bug report please give me a vB version number and precise and exact steps to reproduce the problem. Thanks. Also, include your browser version and name (IE, FF, Opera, etc).

Here, I will give a checklist:

1: vBulletin Version:
2: Browser:
3: Detailed description of the problem.

Gold Phan7om wins the prize so far for the most detailed report.

I asked vbulletin support about it and they said its most likely the 'newpost_process' hook.

May be a start?

If you create a mod for vb 4.0 and users post an error in the same thread then it should be obvious which version they are using. The mod should work in all 4.0+ forums. No worries though. I found a way to remove the mod completly. You should test this thing out some more before offering it.

PHP Parse error: parse error in \includes\functions_newpost.php (433) : eval()'d code on line 11

This happens by creating a new post within vBulletin 4.0.6 Suite.

I disable the hook newpost_process of you hack for now as it did double posts and print this message.

Thanks very much for this mod ...

Well barring my previous comments... your statement is only half true... basically one of us can create a mod but if something default in vBulletin changes from one version to the next then the mod must be recoded. Otherwise since your half way there we could simply say well heck if that was the case nearly all 3.x mods should work on 4.x, it's only a one number difference! J/K of course as we all know syntax changes in the least took place lol so just bare in mind those things are needed when de-bugging. I do think though if your having to upgrade a mod for let's say 4.0.6 then you should leave the old .zip and specify which version of the mod works on which version of vBulletin unless the update remedies the errors in all current versions.

See solboy, as Phalanx posted it's only 4.0.6 Suite for him, this might not be an issue on 4.0.5.

I am using 4.0.6 suite and experience this when replying to a thread:
I use Firefox 3.6.8

Parse error: syntax error, unexpected T_BOOLEAN_OR in /serverpath/includes/functions_newpost.php(433) : eval()'d code on line 31

Then creating a new thread I get:

Parse error: syntax error, unexpected T_BOOLEAN_OR in /serverpath/includes/functions_newpost.php(433) : eval()'d code on line 31

Parse error: syntax error, unexpected T_BOOLEAN_OR in /serverpath/includes/class_dm_threadpost.php(1766) : eval()'d code on line 4

Unable to add cookies, header already sent.
File: /serverpath/functions_newpost.php(433) : eval()'d code
Line: 31

Disabling until resolved.

Yeah sure, the old mod we use to use on VB3.8 was:
https://vborg.vbsupport.ru/showthread.php?t=184757

Dude, thank you so much for considering this, if we can just get it to deny posts with an error message instead of sending to moderation, it would save having to go through a daily moderation queue of over 100 posts! :)

Fixed when I installed the V 1.2.2 Update. Thanks.


I am running VB 4.05 and installed the updated version of this mod this morning. I went to create a new thread and received an error which was not showing before the update.

Here is the info I received. I tried to create multiple threads and received the same error each time. I have disabled the product and I do not get the error anymore.

Hope this info helps if there is some sort of bug. I can turn it back on again and check other stuff if needed.

-------------------------------------------

Parse error: syntax error, unexpected T_BOOLEAN_OR in /home/domain/public_html/community/includes/functions_newpost.php(433) : eval()'d code on line 5

Parse error: syntax error, unexpected T_BOOLEAN_OR in /home/domain/public_html/community/includes/class_dm_threadpost.php(1795) : eval()'d code on line 4
Domain.com Message

Unable to add cookies, header already sent.
File: /home/domain/public_html/community/includes/functions_newpost.php(433) : eval()'d code
Line: 5


-------------------

Update. I guess I am not the only one that got the error. I just checked my emails and some members said they got the same error. They said the first time they went to post, they got a white screen with the above error. they hit the back button and submtited the post again, receiving the error again, but the post successfully posted.

-------------------

Fixed when I installed the V 1.2.2 Update. Thanks.

I was hoping to upgrade to vB4.0.6 this weekend but I'm finding this product so useful that I'm delaying the upgrade until this issue is resolved.

Can you give us an idea how soon this will be done?

Version 1.2.2 has been released.

* Log System Improvements
* Fixed a bug with facebook
* fixed a bug with advanced post
* Code Optimizations

FYI: Went to download, but it says "No files uploaded" where the donwload links would be.

Try it now.

Thanks for the update! Now bots cant get in again :)

installed v 1.2.2 and did not receive the errors when posting that I had mentioned above. Thanks for the update and good job on the mod. It was killing me to disable this since we have had zero spam registrations since installing this.

Thanks for the quick update. v1.2.2 now running with vB4.0.6 and no obvious problems.

However, will check and report back. ;)

My understanding is that all the show-stopper bugs are fixed and from feedback, this should be running on all 4.x including the recently released vBulletin 4.0.6 as well as long as you are running the latest Spam-O-Matic version 1.2.2 as of this writing.

I am going to stop development on the 1.2 series unless any other show-stoppers pop up.

I am adding a section in the first post below the FAQ for consideration of additional features to make life easier. For now though this mod should keep the spammers off of your boards fairly well barring those of you that find conflicts with other mods.

Could I add the following to the additional features list:

Ability to work with renamed admincp and modcp folders

Since this product is essentially a security aid, it should encourage (or at least enable) admins to add as much security to their site installations as possible and the renaming of those two folders is supported in vB as standard and is a sensible security precaution.

I have always renamed those folders but I have set them back to default just so that this product will run (yes, it's that useful). I don't mind admitting that I now feel a little vulnerable.

Although I'm no expert, I don't think this would be difficult to implement and it would make the product more robust i.e. it wouldn't fail to work if an admin has used the vB renaming feature.

Summary statistics

The log formatting in 1.2.2 is a big improvement but for those of us with busy boards it would be useful to have a summary of successful registrations and rejected registrations on a per day/week/month basis so that we can get an idea of spammer activity.

Excellent mod - should be core to vB.

I have added a bit about admin and modcp directories to the known issues (also asking for feedback in that section) since I have not tested myself if this works or not and so far, you are only the first to report it.

I will move it to suggestions list as soon as we have more feedback on it. I don't want to spend a lot of time on it if its isolated to you or others do not need it. Lets see what people think and go from there.

Not sure if you are looking for a list of people that changed their admincp and modcp directory names, but I am one. If I am not mistaken, I think it was suggested in the installation instructions for VB, so I did it. Renaming them to the original names is probably an easy process....I am guessing just editing the lines in the config file??



On a different note, I installed the newest version of this mod last night on my 4.05 VB Forum and it fixed the problem when a user went to post a new thread and got an error. This morning I received a bunch of emails telling me of vb database errors, Here is some info and I am guessing it has something to do with this mod since it was listed in a few of the errors and all the errors have to do with addmember. I have not received these errors for the past few hours, so I am not sure if this was isolated to just this morning.

----------------

Invalid SQL:
INSERT HIGH_PRIORITY IGNORE INTO glowhostspamomatic_remotecache(`date`, `data`, `is_spambot`, `field`) VALUES (now(), "hfmjgs382", "0", "username");;

Followed by:

Invalid SQL:
SELECT DATEDIFF(NOW(), "2010-08-16 06:00:03") AS DAYS;

----------------

Invalid SQL:
INSERT HIGH_PRIORITY IGNORE INTO glowhostspamomatic_remotecache(`date`, `data`, `is_spambot`, `field`) VALUES (now(), "xmjbry", "0", "username");;

Followed by:

Invalid SQL:
SELECT DATEDIFF(NOW(), "2010-08-13 22:15:58") AS DAYS;

----------------

Invalid SQL:
INSERT HIGH_PRIORITY IGNORE INTO glowhostspamomatic_remotecache(`date`, `data`, `is_spambot`, `field`) VALUES (now(), "n42k21@yahoo.com", "0", "email");;

----------------

Invalid SQL:
INSERT HIGH_PRIORITY IGNORE INTO glowhostspamomatic_remotecache(`date`, `data`, `is_spambot`, `field`) VALUES (now(), "n42k21@yahoo.com", "0", "email");;

----------------

Invalid SQL:
INSERT HIGH_PRIORITY IGNORE INTO glowhostspamomatic_remotecache(`date`, `data`, `is_spambot`, `field`) VALUES (now(), "csuboh", "0", "username");;

----------------


I am not trying to sharpshoot this mod, I think it is great and an asset to us and our members. I just don't know if others may be receiving this error and wanted to bring it to your attention.

Thanks.

The main thing I am looking for is users who have:

1) A fresh, working vBulletin
2) Have decided to change modcp and admincp directories to something other than the default.
3) DO NOT RUN, OR HAVE NOT INSTALLED ANY OTHER ADDONS
4) Have installed the latest Spam-O-Matic.
5) Only have errors when Spam-O-Matic is enabled.

I am trying to confirm that as another poster has said that this mod simply does not work because of renaming these directoryies.

As for your SQL errors, have they gone away on their own?
Have to tried to completely uninstall and re-install this mod?
Also perhaps your database is corrupt? Have you tried to repair the affected tables?

In any of these cases a full uninstall and re-install should correct it, unless others have the same issue but its the first I have heard.

Changing the names of the control panel folders is a recommended security precaution, see tip number 8 in this article for another opinion on this.

As for testing, I can confirm that only some of the functions are broken when the folders are renamed, in general the processing of registrations continues unaffected but the mod and admin functions do not work.

I can't really comment on the security issue, other than the following:

Everyone has their own opinion of what security "should be." There is almost always a trade-off for functionality vs. security and users have to decide where that line is on their own. Keeping the scripts up to date, maintaining an adequate server-side firewall, and strong passwords are generally good enough.

As a suggestion, ff you want to maintain functionality of this mod, other mods, make your upgrades easier for mods and the forum scripts themselves, and add another level of security by simply password protecting admincp and modcp using your web servers http_auth functions. Then keep modcp and admincp where they belong.

Now your crackers have to first guess your web authorization and secondly they have to get past your script authorization. It's unlikely.

Your bug comments are good to know cfish. In this case, hopefully you can wait until 2.x to get past these issues. Hopefully the trade off in reduced spam is worth it. In 2.x we will be removing those functions and making it one stop shopping from the postbit to delete, soft delete, ban etc so the need for admin or mod panels will be bypassed completely and productivity will be increased by just doing the dirty work on the front-end of the forum not the back.