Hello all,

Has anyone had javascript errors when the vbcode/smilies are turned off? I had a user on our board who had a problem but up till now I haven't heard any more complaints. Can somebody who's installed this hack test it? It works fine here when I turn off vB code/smilies. And I can't seem to replicate the problem.

Scott

I had a member e-mail me recently saying that she got an error whenever she clicked on a text input box, preventing her from posting at all. She said she gets this error:

LINE : 182 (less often, it's 183)
CHAR : 1
ERROR : object expected
CODE : 0

With private messages she gets this error:

LINE : 275
CHAR : 1
ERROR : objected expected
CODE : 0

I'll ask her if she has the vbcode buttons turned off and get back to you.

Wow, I just got home from work and got this message:He had vB code turned off. I tried and had no problem. I turned it on for him and sent him an email and told him to try posting again. He's not a regular, so I don't know when I'll hear back.

@FWC and Brain Cruz

Thanks for the info. I think I'll have to post a fix for this. The problem is, when the user doesn't wish to use the vB buttons or smilies we have calls to functions that don't exist. The actual vbcode.js isn't the problem but rather the calling of the functions.

Keep me posted if you here some more news and I'll try to see about adding the fix.

I was also thinking of trying to add the functionality that when a text string is highlighted and a button is pressed, then the code is added to both sides of the highlighted text. I think that would be even better, don't you?

Scott

Just wanted to say that the user I mentioned does indeed have vB code turned off.

That does sound good. :)

Scott, my user came back after I toggled his smilies and vBcodes back on and was able to post with no problem.

When I click inside the text box I immediately get an Object Expected Line 290 of newreply.php etc, etc, etc. I've been through all the posts here twice and didn't see a solution. I believe I've done everything correctly, including using the txt file to edit vbcode.js. I'm sure I saw something about this but I can't find where. Any ideas? I really want this hack. Thanks!
BTW I'm using IE 6

When I use the vbcode.js you provided it works but if I edit the one that comes with 2.2.1 it didn't. Is there any problem with using the file you provided with 2.2.1 or did I misunderstand the previous threads? Thanks for an EXCELLENT hack!

No it should work, I had some trouble setting it up myself but it works on 2.2.1 wonderfully :pleased:

Thanks. I started in the old thread for this then moved to this thread. With all the posts I wanted to make sure I didn't miss something. It is a great hack and useful!

i wonder why this hasn't been put into the official vBulletin release, its a huge improvement and there hasn't been any problems on browsers which support javascript, has there?

It doesn't work with NS but that's their problem. I agree that this is a must for the next vB version, though. :up:

:cry:

On vbulletin.com is now running the new next-to-release 2.2.2 and still vbcode.js is the same as before..... :zzz:

Do you know whether anyone has suggested this? Is there a place where we could start a thread for folks to voice their opinion on getting it added? They use it here so I'm kind of surprised that it didn't get the "thumbs-up" for the next edition. :confused:

GREAT HACK! Damn this helped me a lot, I hated the config before and this does nothing but help! thanks so much scott!

Thank you kindly!

I was hoping something like this would have come out months ago.

:)

BUG REPORT!

I hate to be the bearer of bad news, but I think my members have found a bug in this hack. I've got about 267 smilies on my forum, and my members like to leave the "Get More" window open so they don't have to keep reloading the window every time they post (with all 267 smilies on it). Of course, it works great for them the first time they use it, but when they attempt to click on a smilie to insert it in a another, new message, it wipes out their entire message! :eek: You can read the thread where my members reported it right here. Can anything be done about this?

Hello Lancia,

I just registered at your board and tried out the script as you remarked and I had no probs. Is this a general prob or just one with one user? If it is a general prob can you ask some of the users which Browser they are using?

Scott

Well, it's pretty much a general problem - I'm experiencing it myself with IE 5.5. Since you've registered (thanks!), to simulate the problem, do the following steps...
[list=1][*]Click on the reply button, like you're going to reply to a thread.[*]Open the "Get More" smilies window[*]Go back to the thread, and click on the reply button again[*]Now, type something in the message box[*]Try to insert a smilie by clicking on it in the "Get More" window that you opened earlier. You should then see that your message has been erased, and replaced by the smilie.[/list=1]

I get the same error on my test board. I've also tried closing the more smilies screen then opening it again, but the same error occurs.

I think I have a quick fix though. Apply this add-on (post 26). It's annoying if you don't want it to close, but at least you won't lose your messages.

vb 2.2.1, IE 6, hack plus the add-on for enhanced mode added (and later the auto close add-on).

I have not noticed this error while trying to duplicate it.

Many thanks, this solves a major gripe of all my users; "Jumping to the end of the text".

Thanks again!

Thanks Arathorn, but I'm afraid that would only make my users more mad! :)

I'm having a bit of a problem here. None of the pop-up smilies are clickable and the background is red. I've followed (I think) this somewhat confusing thread and its instructions. I used Mutt's newfxs.txt file and edited the 2.2.1 vbcode.js that came with this version. Here's a screen shot. Any ideas? I'm also not sure why the tables are red. Thanks!

Man, that redness is really strange...have you checked your templates?

Yeah. So far I haven't found anywhere it's not using the variables.
:eek:

Just to show how confusing this is, here's a screen shot of the code rendered to a browser via FrontPage. (That's why the pics don't show up)

You'll notice that the colors are correct in this version, yet when it's parsed through vB, somewhere the layout gets skewed. Anyone have any ideas?

Thanks!

@ stretchr

I believe you may have made a mistake in this stepAlso don't forget to take out the space between java and script.

The vbcode_popup_smiliesbits should then look similar to this.Hope that helps.

Scott

Thanks, Scott. I was wondering what a "pener" was! LOL Unfortunately, I'm left with the problem of the color (red) and that none of the pop-up smilies are clickable.

Regarding the color issue, where does the pop-up pull the table colors from?

I'm lost as to why the smiles in the pop-up are no longer clickable.
Hmmmm.

Here's another screen shot. Any help or suggestions would be greatly appreciated!

oops I see I have a small mistake in my example. Doubt it has something to do with your prob though. The first td tag is missing a ">".

You could do 1 of 2 things:

1. set up a test account on your board so i can take a look at the html code.

or...

2. Post the code here.

Scott

Scott,
I sent you the code PM because I wasn't sure about posting an entire template on here. Just for others' information, as a test I reverted to the original vbcode_popup_smiliesbits template and things seem to work normally. Unless that's a problem I'll keep it that way until and unless we can resolve this other issue. Thank you for your help.

Thanks, Scott. Wasn't seeing the forest from the trees on this one. Must have looked at that section of the code 20 times. I appreciate your help! :D

w00t!! Took me a couple of mins to figure out what you were trying to say... but after I thought it over.... it just clicked! Great Hack... Keep it up!

I still cannot figure out what this does.

The main function is it puts the smilie wherever the cursor is instead of at the end of the message. It also allows you to highlight already typed text and click on one of the tags and have it entered automatically. My users would kill me if I ever removed this hack. :)

I don't think that part works. But it does let you place a tag or a smilie where you want it.

Scott

I don't know. I just typed and highlighted this and hit red and it did the trick. It does on my board, too. :)

Maybe I misunderstood. When I highlight something it gets replaced with the vbcode I choose. I am using IE6.

What browser are you using?

Scott

IE 6 on an XP machine and a 2000 Pro machine.

And it works on both. :)

Well, I managed to break it. It was working fine until I highlighted some text and canceled the tag. :(