Oasi, after giving you some headaches to fix it and now that's is working great....

....I was thinking to my self yeasterday....How about to improve this BBCode or even a new one ? I mean, how about to include Google Earth on it ?

Just an idea...lol...

This was the only way I could get this to work on my system. Thanks for all your hard work!

matt

Hi,
I head the following Problem .
If I test this BBCode in my "Admin Only" Part of the Forum everything was OK.
If I copied the Post to the Forum where I make Announcements it stops working.
Long time ago I set up this Forum with the Possibility of the use of HTML
this is not working together with this BBCode.
Just to let you know, maybe helps somebody if this is not running.
Best regards
Christian

How does it confirm that it is a valid google maps code? Looking at the code, one of the checks seems to be that the URL starts with http://maps.google, and it also confirms that there isn't any other http:// within the code. But if someone posted something like http://maps.google.evildomain.com, would that fail this check or would it be approved?

->Christian,

Could you copy the generated code to see what's wrong?

->aciurczak

The check would fail with the URL you posted, I know that this is not perfect :P
If you try to get a better security check for this please post it here to share it with us.

Thanks!

Hi Oasi -

I changed that check to:

so the code has to include http://maps.google.com/, not just http://maps.google . Still not perfect, but a little better.

I hope all your users come from the US or UK ;-)

What about

http://maps.google.it/
http://maps.google.es/
http://maps.google.de/

If all of your users use the .com domain to insert the maps, it's a very valid solution...

Other option would be to check that after the http://maps.google. there are as maximum 4/5 characters, so only a domain could be included, or set an array of valid domains to check that the rest of the URL is one of the domains allowed.

I'm not worried about anything but .com yet. It will cover 95% of my users, and likely 100% of my users who would be prone to embedding a map. As soon as one of my users tries embedding a google map from a non .com address and runs into a problem, I'll deal with it then.

Also, even if the map or route is not in the US or UK, you can still use maps.google.com to map it or route it. Here's an example route from Berlin to Paris using maps.google.com. Yes, it's in English, but it still works fine.

Great little code... two questions.

1> Is there a way of adding the directions to the map or a automatic link?
2> Why when i zoom into a map to the highest point can I not use the embed code?

Thanks marked as installed.

I'm not suere if it's that you're asking, but you can add directions, routes or whatever the google maps app let you add. You only have to click the link button when you've finished adding the stuff and put this code into the [gmap] bbcode.

It's not possible to add the link, but you only have to add an html link below...

I've been able to add maps with the StreetView inclusive, but it's true that some maps does'nt have the "link" option to add the code to a web or a direct link. You'll have to ask google why, I don't know the reason :(

I mean including the direction, such as "Turn left onto the n332 Alicante" next to the map.

Any help would be appreciated.

Moltes gràcies oasi funciona perfectament.

fins una altra.

Very nice addon.
I'll donate 10$ for a yahoo maps bb code.

thanks perfect

I tried on my vb 3.6.8 and it doesn't work - need to pay for a vb update to get this to work I suppose? :(

Can someone make an XML and separate files for this? I don't want to make code changes unless necessary. I'd like to be able to uninstall it cleanly.

You have to make a new custom BBCode. Please read carefully.

Ok... Thanks.

Thank You For Sharing this BB Code. :up:

There is a Problem when the Map is Searched via "Search in Map", the Embed HTML includes the Search Result Code and when Included in the GMAP BBCode then it Browse the Original Result and Not the Zoomed and Moved Map that supposes to be the one to be seen on the Embed HTML Code.

At first it seems to Displays the Zoomed Map but a Few Seconds Later when the Page is Loaded it Zoomes Back to the Original Result of the Search in Map.

This is a Zoomed Version of the Hotel Burj Al Arab, (Max Zoom), but if you Include it on the GMAP BBCode you'll see that it's Displayed Zoomed Out.

How can I Correct that and Tell Google Maps to Ignore the Search Code (You can see it on the Code as "q=burj+al+arab&amp" and some other Codes that are Different than the ones obtained by Browsing the Google Map and Not Searching it, and by Browsing it the Code is Correct and Displays the Zoomed Map as it should be)? :confused::confused::confused:

I obtained this by searching burj al arab on Google Maps and choosing/clicking on the first result.

My Best Regards.

:)

Tx.. lovely mod.. Installed and voted.. yeah. ;)

very good picture to google maps Enjoy

Got it working, and its ACE! Thanks!

Very nice, installed.

Thankyou :)

Awesome... works... thanks!

Works for me in all browsers (Firefox, Safari, Chrome, Opera) but in IE. In IE 7 and 8 I only get blank, white page inside the iframe. If I look at the source code of the iframe page, it seems to be there alright, but it displays as just plain white...

use this code:

The others settings for the BBCode are:

Title:
Tag:
Sample:
Description:
Use {option}: -> No
Remove Tag If Empty -> Yes
Disable BB Code Within This BB Code -> Yes
Disable Smilies Within This BB Code -> Yes
Disable Word Wrapping Within This BB Code ->Yes

and use this button on the message editor toolbar (16x16 Pixels | PNG transparent)

Whereas the Code in the Firstpost worked in all browsers but IE, the code by GeoMapia does not work for me at all.

Are there any more revisions to this code?

I'm trying to get it to work on vB3.8, with little success.

I've tried each of the code examples and fixes posted here, and the best I get is for it to work in the BBCode test screen, but not in an actual post.

I noted that when I go back in to BBCode Manager to edit it, the "Example" code is cropped short of the full code originally pasted in that field, hence I never have a working example.

Any thoughts would be greatly appreciated.

THANK!

This is work for me in vBulletin v3.8.2

Thanks Sunka, that seems to initially work in the Test your BBCode area, but in an actual post I get the "Wrong map URL, edit the post to change it. Reload the page when finished to check if correct." error message.

On return to the BBCode Manager, and trying the Test your BBCode again, I also get the error there as well.

This is the sample map code used in all instances;
Also in the BBCode Manager window, the "Example" field doesn't work, as the code above gets trimmed when saved... and looks like this;
Any further thoughts?

Hmmm.
On Google Maps, you choose LINK and then copy Paste HTML to embed in website
This is code for Zagreb on Google maps:


If this code I use on my forum with [ gmap ] [ /gmap ] all is OK

I found the IE issue is related to this

{ document.write('<iframe width="640" height="480" frameborder="0" scrolling="no" marginheight="0" marginwidth="0" src="'+u+'"></iframe>');}

with this you can see the map but it messes with the php


{ document.write('<iframe width="640" height="480" frameborder="0" scrolling="no" marginheight="0" marginwidth="0" src="'+u+'"</iframe>');}

So it is a formatting in the above line in BOLD that is causing the IE issues. Not yet worked out what is the actual issue.

Some more information

Internet Explored adds [URL] tags to the Google code and this causes the map not to
show. You see
"Wrong map URL, edit the post to change it. Reload the page when finished to check if correct."

You need to edit the [URL] tags out. Firefox and Chrome do not add these tags when
posting the Google code.

And more..................

If you can see WHITE where the map should be in IE, then Refreshing the page with the <REFRESH>
button will not cause the map to show. HOWEVER right clicking on where the map should be and selecting
REFRESH will cause the map to show.

I noticed that IE will show the map only the first time the page with the map is accessed. After that it will
not load the map the next time the page is loaded ( unless you use the above mentioned refresh ).

I wonder is someone with code experience could modify the script to detect if IE is the
browser and if so detected, refresh the frame twice and also remove any URL /URL
tags from betten the GAMP /GMAP tags.

This worked for me when I used Firefox to do add the BBcode. But strangely, when I used
IE it did not work.

thanks for great Mod..

It been working fine for a few weeks and today we have hit a glitch, I think its always been there but only showed up today

until now all [gmap] code has been in threads started by one of 2 Admins, members have replied with maps and they have showed up with no problems. Today a supermod posted a map in his own thread and it errored and didnt show up, Even if an Admin post a [gmap] in that thread it wouldnt show up. Cut and paste the same code into a Admin started thread, it works fine

doing the research on my forum, Admins have HTML turned on, no one else does, I dont want to turn it on if I can help it.

will turning HTML on for everyone but turn HTML code of be safe?

I will do some more testing, but I wont be near a puter for the next 24hr

any thoughts or ideas?

ta

Marty

Every thing I have read suggests keep HTML turned off for the forums. I am admin on
my forum and I do not have HTML turned on and my users can post maps.

You should post up the error message.

there is no error message, just nothing..blank