vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.6 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=194)
-   -   New Posting Features - Phoogle! An interactive Google Maps mapping system. (https://vborg.vbsupport.ru/showthread.php?t=141584)

Tralala 03-14-2007 07:04 AM

The users reporting issues, all with Firefox, are not seeing maps that are in the first post of a thread. They do see subsequent ones in the thread, though.

magnus 03-14-2007 10:16 AM

Tralala, those with problems are running Firefox or Firefox 2? I developed this in Firefox 1.5.0.10 and tested in IE7.

Tralala 03-14-2007 01:40 PM

Quote:

Originally Posted by magnus (Post 1203200)
Tralala, those with problems are running Firefox or Firefox 2? I developed this in Firefox 1.5.0.10 and tested in IE7.

So far, everyone reporting issues are using Firefox 2. The weird thing is that it's not consistent... some folks using Firefox 2 can see the maps just fine.

And the folks who are having problems, can see some maps, but not all of them. I think the issue is that the first map in a thread doesn't show up for them.

magnus 03-14-2007 02:09 PM

Hrm. I'll install FireFox 2 on another PC in a bit and check -- the fact it's so inconsistent is making me lean towards the problem being end-user related, such as an Extension or AddOn causing a conflict.

I don't know if it's possible, but what would really help is if you could get the 'View Source' output from one of the users experiencing the problem. :D

If I haven't said it before, Tralala, thanks for the help you've provided so far. You've been integral in getting things where they are now.

Tralala 03-14-2007 02:32 PM

Quote:

Originally Posted by magnus (Post 1203330)
Hrm. I'll install FireFox 2 on another PC in a bit and check -- the fact it's so inconsistent is making me lean towards the problem being end-user related, such as an Extension or AddOn causing a conflict.

I was leaning that way at first too, but I've got the problem reports coming in from 7 or 8 folks now, and some of them have no extensions installed, just a clean Firefox 2.

Quote:

Originally Posted by magnus (Post 1203330)
I don't know if it's possible, but what would really help is if you could get the 'View Source' output from one of the users experiencing the problem. :D

That won't be a problem. I'll ask one of the savvier users for that and will get back to you.

Quote:

Originally Posted by magnus (Post 1203330)
If I haven't said it before, Tralala, thanks for the help you've provided so far. You've been integral in getting things where they are now.

My pleasure. And thanks for your continued dedication to making it work perfectly. When it's all sorted out I'm sure it will be a very appreciated add-on for very many forums, and for that you should be proud. Thanks for sharing it. :)

Tralala 03-14-2007 03:59 PM

New information: it appears to be a CDATA problem, specific to my forum's default skin. As best I can tell, it is working fine in the stock vB skin for everyone.

So as not to derail this thread any further, I'll send specific details to magnus via PM.

Tralala 03-17-2007 07:51 AM

Now this is working perfectly for me (:up:)

I notice that entering just a city, state and zip (like you can with maps.google.com) doesn't work with Phoogle. For example, "Gerlach, NV 89412" gave me a blank space. I had to make up a fake street (in this case, "100 Main Street") for it create a map at all.

Also it'd be cool if there was an option to dictate whether the Phoogle map should be in satellite or hybrid format instead. And a way for the user to override the default zoom level.

magnus 03-17-2007 01:46 PM

In the current development version, valid inputs are lat/log, as well as city, state, zip. So, that's covered.

As for allowing the user to set options other than labels and addresses, I don't really see how. BBCode accepts 2 variables:

Code:

[tag={$option}]{$code}[/tag]
I don't see where I could add any extra variables. :(

Tralala 03-17-2007 02:39 PM

Quote:

Originally Posted by magnus (Post 1205623)
In the current development version, valid inputs are lat/log, as well as city, state, zip. So, that's covered.

Excellent!
Quote:

Originally Posted by magnus (Post 1205623)
As for allowing the user to set options other than labels and addresses, I don't really see how. BBCode accepts 2 variables:

Not sure if it will help any, but take a look at this hack I've been using on my forum for awhile now... it embeds all sorts of media via BBcode... but it allows for five options: width, height, autostart, loop, extension.
(Maybe that code will shed some light on how to work around the limitation.)



Another suggestion: when an invalid address is entered, or one that gets no search results, throw up a default "Error" or "no map data" image, rather than just a blank space.

magnus 03-17-2007 05:26 PM

Quote:

Not sure if it will help any, but take a look at this hack I've been using on my forum for awhile now... it embeds all sorts of media via BBcode... but it allows for five options: width, height, autostart, loop, extension.
(Maybe that code will shed some light on how to work around the limitation.)
I'll check it out.


Quote:

Another suggestion: when an invalid address is entered, or one that gets no search results, throw up a default "Error" or "no map data" image, rather than just a blank space.
Already done. :)

Tralala 03-17-2007 06:55 PM

...if not as a user selectable option per map... how about an AdminCP setting for forum-wide default (like we can with Zoom level.) I'd like the maps to show up as Satellite (or Hybrid) by default, rather than the standard "street map" view.

Doctor Death 03-18-2007 04:03 PM

I really want this to work on my board... I have installed (and deinstalled) every version of it since it showed up here hoping it would work...

Here is what happens:

It installs perfectly every time.

After I make a post with [map] [/map] codes in it, you will no longer be able to access that post.

Internet Explorer 7 (which is what I use) gives (not vbulletin) the error that says it cannot display the page.

The error message shown shows the proper path etc to the posting. I have to uninstall the plugin and then go back and delete the post. You cannot edit the post while this error is occuring because it will not let you view the post.

Here are my versions:

Dr.NoTime 03-18-2007 04:47 PM

"Installed" Works great. Thanks!

I am using Firefox 2.0.0.2

magnus 03-18-2007 08:51 PM

Quote:

Originally Posted by Doctor Death (Post 1206522)
I really want this to work on my board... I have installed (and deinstalled) every version of it since it showed up here hoping it would work...

Here is what happens:

It installs perfectly every time.

After I make a post with [map] [/map] codes in it, you will no longer be able to access that post.

Internet Explorer 7 (which is what I use) gives (not vbulletin) the error that says it cannot display the page.

The error message shown shows the proper path etc to the posting. I have to uninstall the plugin and then go back and delete the post. You cannot edit the post while this error is occuring because it will not let you view the post.

Here are my versions:

Well, first things first. Let's see if this is an issue with the modification or Phoogle itself. Download the attached zip file and extract the files to the same directory. Edit the test.php file and add your Google API key. Then try and access the test.php file and see if your browser will display the map.

We'll go from there.

meissenation 03-19-2007 10:54 AM

Have the same problem as Doctor Death. I posted a map and immediately Internet Explorer says it can't open the page now.

I tried viewing the same post in Default Style, and it displays the [map]address[/map] but no actual map.

Code:

<script type="text/javascript">
        function showmap127803()
        {
                //<![CDATA[
                        if (GBrowserIsCompatible())
                        {
                                var map127803 = new GMap(document.getElementById("map127803"));
                                map127803.centerAndZoom(new GPoint(-83.204936, 42.537769), 6);
                        }
                        var icon = new GIcon();
                        icon.image = "http://labs.google.com/ridefinder/images/mm_20_red.png";
                        icon.shadow = "http://labs.google.com/ridefinder/images/mm_20_shadow.png";
                        icon.iconSize = new GSize(12, 20);
                        icon.shadowSize = new GSize(22, 20);
                        icon.iconAnchor = new GPoint(6, 20);
                        icon.infoWindowAnchor = new GPoint(5, 1);
                       
                        map127803.addControl(new GSmallMapControl());
                       
                       
                        map127803.addControl(new GMapTypeControl());
                       
                        var point0127803 = new GPoint(-83.204936, 42.537769);
                        var marker0127803 = new GMarker(point0127803);
                        map127803.addOverlay(marker0127803)
                        GEvent.addListener(marker0127803, "click",        function()
                                {
                                       
                                        marker0127803.openInfoWindowHtml("<font face="Arial"><font size="2">33828 Woodward Avenue Birmingham MI 48009</font></font>");
                                       
                                }
                        );

                //]]>
        }
        showmap127803();
</script>


meissenation 03-19-2007 12:12 PM

Hinting off the previous posts I saw, I removed the map code from the first post and posted into the 2nd post. The mapcode disappeared and I get a blank space with no box or anything... atleast it's getting somewhere.

I noticed IE shows a "Done but with errors" message. Opening it up, it says the error is on line 1902. Opened the view source and 1902 is infact part of the showmap function.
Code:

<script type="text/javascript">
        function showmap127819()
        {
                //<![CDATA[
                        if (GBrowserIsCompatible())
                        {
                                var map127819 = new GMap(document.getElementById("map127819"));
                                map127819.centerAndZoom(new GPoint(-83.204936, 42.537769), 6);
                        }
                        var icon = new GIcon();
                        icon.image = "http://labs.google.com/ridefinder/images/mm_20_red.png";
                        icon.shadow = "http://labs.google.com/ridefinder/images/mm_20_shadow.png";
                        icon.iconSize = new GSize(12, 20);
                        icon.shadowSize = new GSize(22, 20);
                        icon.iconAnchor = new GPoint(6, 20);
                        icon.infoWindowAnchor = new GPoint(5, 1);
                       
                        map127819.addControl(new GSmallMapControl());
                       
                       
                        map127819.addControl(new GMapTypeControl());
                       
                        var point0127819 = new GPoint(-83.204936, 42.537769);
                        var marker0127819 = new GMarker(point0127819);
                        map127819.addOverlay(marker0127819)
                        GEvent.addListener(marker0127819, "click",        function()
(THIS IS LINE 1902)                                {
                                       
                                        marker0127819.openInfoWindowHtml("<font face="Arial"><font size="2">33828 Woodward Avenue Birmingham MI 48009</font></font>");
                                       
                                }
                        );

                //]]>
        }
        showmap127819();
</script>

IE says line 1902, char 52, expected ')', code:0. Line 1902 is indicated in the code... hope this helps.

meissenation 03-19-2007 12:27 PM

Alright, getting further... I don't know what changed, but I can view the thread in my normal customized template without any IE crashes. It loads the thread fully for me now, but still has the blank area.

I'm testing it on my live forum, with a nice "warning title" for the thread haha. Anyway here's the thread so you can see the page source:
http://www.mifbody.com/vbulletin/sho...819#post127819

Trying to use in IE7. Server's config: apache v1.3.33, PHP 4.4.4, MySQL 4.1.21-standard.

meissenation 03-19-2007 12:32 PM

Sorry for the huge rounds of posting, just trying to help everyone out with the "troubleshooting" because this addon will be gold when it's finished.

Thinking it wouldn't cause the browser Operation Aborted error, I went to a different post and tried the map. It did the error like it did before and didn't want to load. I switched to my default style, and (DO NOT ASK ME HOW...) the map loads perfectly fine!!! Why it loads in one thread and not in the other (both in default style), no clue... will continue trouble shooting that.

Update: Went into the thread that I linked to in above post, I had a member say the browser did not crash, so I tested another map... the 2nd map displays perfectly fine (in default style) in post #4, but the map in post #2 does not load (blank space). I went to maps.google.com and put the same address as post #2's map has and it loads fine, so it's not an error with google map's not recognizing the address...

The address for both have commas ( , ) between the street address and the city, and then between the city and state. not sure if this makes a difference or not.

2nd Update: Figured "OK, there must be a difference somewhere that one would work and one wouldn't..." So I looked at the HTML source code. The 1st map that does not load, in the marker text, it puts

Code:

marker0127819.openInfoWindowHtml("<font face="Arial"><font size="2">33828 Woodward Avenue, Birmingham, MI 48009</font></font>");
For the second map, which does work:
Code:

marker0127832.openInfoWindowHtml("33828 Woodward Avenue, Birmingham, MI 48009");
That was the problem. I went into the 1st map's edit post, switched to code view, and sure enough there was the font BB code. So, it would be beneficial to have it strip BB code from the address, or else you'll have the blank area. Once I removed the font BB code between the [map][/map] it worked like a charm (in the Default style)


Update 3: Unfortunately, switching back to our customized style ... IE tries to load the page and then I get the message "Operation Aborted." I can't view the source code, can't do anything but hit "OK" and then it switches over to "The Page Can Not Be Displayed" so I can't troubleshoot it all that much. :( Maybe someone from here going to that thread within IE will see the same message?

magnus 03-19-2007 01:33 PM

Using FireFox, I checked the link (http://www.mifbody.com/vbulletin/showthread.php?t=7876) and everything appeared fine. Using IE7, I received the same error you did -- which is strange, because using IE7 I can view my development forum just fine.

I'll see what I can track down.

Would you have a problem if I created an account on your forum and created a test thread?

meissenation 03-19-2007 02:00 PM

Well, I continued troubleshooting the issue. The weird part is I get the error with the customized style, but not the default style. My first thought was that the biggest difference between my customized style and the default style was the header. So, I copied my header from the custom style and pasted it into my default style and TADA -- Operation Aborted error message!

I systematically went through and removed code by code to figure out what it was that caused the Operation Aborted error. It turns out, the conflict is an open-ended table in the header used for making a left column.

Code:

<!-- content table -->
$spacer_open

$_phpinclude_output

$welcomeheaders

<table border=0 cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" width=100% valign="top">
<tr>
<td width="145">
&nbsp;
</td>
<td>

This caused the error message. I simply ended the table with a </td></table> and TADA no error message. So, there's the culprit for ME atleast... if Doctor Death can chime in, maybe he has the same type of header with a left column code.


@ magnus -- Any ideas on what would cause that with an open ended table that encompasses everything between the header and footer?

meissenation 03-19-2007 02:05 PM

False lead. My header and footer are identical between the customized style and the default style and I still get the error in the customized style.

magnus 03-19-2007 02:11 PM

Quote:

Originally Posted by meissenation (Post 1207332)
False lead. My header and footer are identical between the customized style and the default style and I still get the error in the customized style.

First step, run the affected page through The W3C Markup Validation Service. It will find any mismatched tags, improper usage, etc. All of which could affect proper display.

Many of the errors it will return might be for strict sake, but it will find actual table/layout/etc errors as well. For example:

Quote:

# Error Line 450 column 7: end tag for "tr" omitted, but OMITTAG NO was specified.

</table>
Quote:

Error Line 469 column 4: end tag for "td" omitted, but OMITTAG NO was specified.

</tr>
Quote:

# Error Line 477 column 32: invalid comment declaration: found name character outside comment but inside comment declaration.

<!-- End of Ride of the Month --->
Quote:

# Error Line 771 column 7: end tag for "td" omitted, but OMITTAG NO was specified.

</div>


# Info Line 588 column 0: start tag was here.

<td>

# Error Line 771 column 7: end tag for "tr" omitted, but OMITTAG NO was specified.

</div>


# Info Line 584 column 0: start tag was here.

<tr>

# Error Line 771 column 7: end tag for "table" omitted, but OMITTAG NO was specified.

</div>


# Info Line 583 column 0: start tag was here.

<table border=0 cellpadding="6" cellspacing="1" width=100% valign="top">


# Error Line 2468 column 4: end tag for element "td" which is not open.

</td>


# Error Line 2469 column 7: end tag for element "table" which is not open.

</table>
Those are just a few of the more pressing ones I'd focus on first. Ideally, you'd like to pass the validator and be W3C XHTML Compliant.

My money, however, is on this one:
Quote:

Error Line 607 column 8: end tag for element "script" which is not open.

</script>

meissenation 03-19-2007 02:45 PM

Hrm, I can't get line 607 to correlate to the </script> on my side.

magnus 03-19-2007 02:49 PM

When validating your page, select the "Show Source" button. It will display your page source, with line numbers.

meissenation 03-19-2007 03:01 PM

Ah. Looks like it's in my navbar, I'll take a look in a couple hours -- I have to leave work (LOL been troubleshooting this all day..) and go to class.

meissenation 03-19-2007 05:34 PM

Alright well I removed the </script> and alas the same error is still present. It definitely seems like it's only in IE7, as the people that did not heed the thread's warning title all said they use FireFox, not IE7, and they said the maps load fine for them. I myself can view it fine in FF, and then as soon as I switch over to IE7 it errors me out.

It definitely seems to fail with the Customized style that I use. If I switch over to the Default style, it loads perfectly fine with no problems. What it's not compatible with, I'm not sure. I've copied over the custom style's header, headinclude, and footer so all of that would be the same. So now the difference lies with mods that are applying to the custom style and not the default, or template changes applying to custom and not default. :shrug: I'll try and trouble shoot this more tonight and tomorrow.

meissenation 03-19-2007 09:01 PM

Just an update, I was UNABLE to replicate the Operation Aborted message on my girlfriend's laptop which runs WinXP IE6. This happens on my computer at my office, WinXP IE7 and on my laptop Windows Vista Business with IE7.

Edit: My dad was able to load the site on his WinXP computer with IE7. So it seems the issue is with my computer. I closed my browser, went into the Internet Options and cleared my cache, cookies, and browsing history for IE. Started IE and TA-EFFIN-DA the thread loads with no error messages!!!! Whether this fixes the error on all threads from now on or not, not sure... but in any case, it's now fully functional for my site on IE7, IE6, and FF2 as far as I can tell.

Magnus and Doctor Death, can you clear your cache with IE closed, then reopen IE and try the thread link to see if it works for you now too?
http://www.mifbody.com/vbulletin/showthread.php?t=7876

Tralala 03-19-2007 10:06 PM

Just came back to post here, as I've asked my forum members to explicitly test this plugin with MSIE 7 and all of my forum's skins... and they had no problems whatsoever.

So the issue being troubleshot above is specific to meissenation's forum, and/or it's skin, and/or MSIE 7 on his computer.

meissenation 03-20-2007 12:41 AM

From the sounds of it, seems like just need to clear cache.

meissenation 03-20-2007 10:01 PM

At work clearing my cache didn't fix it, so I cleared my cache, browsing history, and cookies and THEN it worked again.

Doctor Death 03-22-2007 12:11 PM

I cleared cookies, cache, etc with current version under IE 7 and still a no-go...

Same error message it received from day one...

Here is screen shot.

I am using custom templates and would be happy to let you examine the inner-workings of my board... let me know.

Doc
www.ddsog.com

meissenation 03-23-2007 09:39 AM

That's the same exact thing I was getting. Did you have IE7 still open when you did this? I had to entirely close out of the browser completely, then go to my control panel and Internet Options to clear it out.

Doctor Death 03-23-2007 01:42 PM

Did that and my users across the country all reported IE7 errors too.

Cleared all stuff before going back in.

Cyburbia 03-23-2007 04:52 PM

Tried installing it, and it didn't work: bad database errors when I tried to view a thread. Re-installing didn't help. I just disabled the plugin, and there's no more database errors. However, I can't un-install the plugin!

Quote:

Database error in vBulletin 3.6.5:

Invalid SQL:
ALTER TABLE `post` DROP `phoogle_html`;

MySQL Error : Can't DROP 'phoogle_html'; check that column/key exists
Error Number : 1091
Date : Friday, March 23rd 2007 @ 01:51:27 PM
Script : http://www.********/forums/admincp/p...do=productkill
Referrer : http://www.********/forums/admincp/p...tid=phoogle&s=
IP Address : 76.***.***.***
Username : ***
Classname : vb_database

Cyburbia 03-24-2007 10:32 PM

Bumping. Can anyone tell me how to uninstall this plugin? I can't do it through the control panel; I get the errors described above.

magnus 03-25-2007 01:31 PM

You're receiving that error because either the phoogle_html column was never properly installed or it was removed prematurely. Either way, this is the cause for the error and quite likely the original errors you were receiving prior to the uninstallation.

That being said, to resolve this all you need to do is create the column manually then re-run the uninstallation.

[SQL]ALTER TABLE `post` ADD `phoogle_html` mediumtext[/SQL]

tteal 03-25-2007 03:32 PM

Not working with Firefox :-(

Atakan KOC 03-25-2007 06:01 PM

Thanks........

Doctor Death 03-25-2007 07:05 PM

This mod appears to be dead on its ass although it would have been THE mod to have had it not been so buggy.

Disappointing the author never came back.

/me clicks UNINSTALLED

Tralala 03-25-2007 07:39 PM

FWIW, this works for my users in MSIE 7, Firefox 1 and 2, Safari, Camino, and any other desktop browser we've tried. It's a wonderfully useful mod! I have one remaining issue with mobile browsers only (specifically the Sidekick) but I'm confident it'll get sorted out.

Any initial problems I had were specific to one child-style of a custom skin I have. It worked fine in the vBulletin default skin from the start. It's important that readers know this, so they aren't scared off by these other disgruntled problem reports.

I think many of the folks having issues with this one have installed custom skins they're not able to troubleshoot, that's all. And lots of mods offered here on vB.org are only offered up to work with the default skin. If you have a custom skin, you have to be prepared for inconsistency... you have to be able to roll your sleeves up and figure some things out on your own... or work with the coders who are gracious enough to offer any personalized assistance. It comes with the territory.


All times are GMT. The time now is 01:24 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01443 seconds
  • Memory Usage 1,894KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (6)bbcode_code_printable
  • (16)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete