vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.6 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=194)
-   -   Add-On Releases - Post Edit History (PEH) (https://vborg.vbsupport.ru/showthread.php?t=132708)

MThornback 05-18-2007 05:55 PM

Quote:

Originally Posted by ChopBam (Post 1250303)
Just installed it. It works fine for me in 3.6.7.
Here's a change I made.
I edited the phrase to "Edit History" like you can see on the first page. However, I also made use of the $post[editcount] feature by not having the "Edit History" link even show up if there is no edit history. Just a small change, but real handy dandy.

Code:

<if condition="$show['edithistorylink'] && $post[editcount] > 0"><a href="edithistory.php?do=viewedithistory&postid=$post[postid]"><phrase>$vbphrase[saved_edits]</phrase><a></if>

Oh, and I suggest that you add to the readme the fact that you need to allow this for usergroups before it'll work. I was confused at first but started reading the thread and found out that way. Other people might not be so fortunate.

OR...you could use the template mod I released that uses some of the exact same code :)

https://vborg.vbsupport.ru/showthread.php?t=136683

ChopBam 05-18-2007 05:58 PM

Wow, I didn't even see yours, and our code does exactly the same thing.

Great minds think alike I guess. :p
I haven't read through this thread, so I may have missed it because of that.

BadgerDog 05-20-2007 04:29 PM

Installed on v3.6.7 PL1 then un-installed as it didn't work.

Edit function never appeared anywhere....

Ensured it was turned ON and all files were in correct places, but no go...

Regards,
Badger

Edit: Sorry meant MThornback 's version of template edits, as I would have preferred those had this worked.

ChopBam 05-25-2007 06:24 PM

You did enable it for usergroups, yes?

BadgerDog 05-25-2007 10:32 PM

Quote:

Originally Posted by ChopBam (Post 1254598)
You did enable it for usergroups, yes?

Yes, but that wasn't my problem...

I am using MThornback's optional version and I did the following...

Quote:

To: MThornback in another thread....

I had to remove the hack from postbit and put it ONLY in postbit_legacy...

For whatever reason, that kick started it and it's now working. I like the elegance of the way you've approached it. No edit.. no show save history link... nice.. ;)

Thanks for your help...

Regards,
Badger

vengefuldeath87 06-12-2007 08:25 PM

The default template didnt really work for me, so i made a button for it:

Code:

In postbit Find:

<img style="display: none" id="progress_$postid" src="$stylevar[imgdir_misc]/progress.gif" alt="$vbphrase[loading_editor_please_wait]" />

Add under:

<if condition="$show['edithistorylink']"><a href="edithistory.php?do=viewedithistory&postid=$post[postid]" rel="nofollow"><phrase 1=$post[editcount]><img src="$stylevar[imgdir_button]/postedits.gif" alt="$vbphrase[saved_edits]" border="0" /></phrase><a></if>

Pop the attached image in your images/buttons dir, and you should be good to go.

you should be able to do similer with the legacy template, but i didnt bother on my board.

Surviver 06-13-2007 03:28 AM

Quote:

Originally Posted by vengefuldeath87 (Post 1267150)
The default template didnt really work for me, so i made a button for it:

Code:

In postbit Find:

<img style="display: none" id="progress_$postid" src="$stylevar[imgdir_misc]/progress.gif" alt="$vbphrase[loading_editor_please_wait]" />

Add under:

<if condition="$show['edithistorylink']"><a href="edithistory.php?do=viewedithistory&postid=$post[postid]" rel="nofollow"><phrase 1=$post[editcount]><img src="$stylevar[imgdir_button]/postedits.gif" alt="$vbphrase[saved_edits]" border="0" /></phrase><a></if>

Pop the attached image in your images/buttons dir, and you should be good to go.

you should be able to do similer with the legacy template, but i didnt bother on my board.

Wow very nice, Thank you!

Can you translate this to german? If so, i will integrate these Buttons in the Hack as default ;)

The Germany Text: Editierungs-Verlauf

Thanks in advance!

Greetings Surviver

vengefuldeath87 06-13-2007 10:49 AM

ok, give these a try

Surviver 06-13-2007 06:00 PM

Thanks :)

I'll release a new version in a few weeks (after holidays :P)

Greetings Surviver

Surviver 06-13-2007 07:08 PM

Quote:

Originally Posted by dutchbb (Post 1267872)
I'm importing the product but it takes ages...still loading after 5 min??

Yes this is right because it alteres the post-tabel - if its very big this can take much time ;)

aj8690 06-13-2007 07:12 PM

This is awesome!!! Thank you so much.

[nominated for motm]

dutchbb 06-13-2007 07:21 PM

Quote:

Originally Posted by Surviver (Post 1267874)
Yes this is right because it alteres the post-tabel - if its very big this can take much time ;)

Ok thanks.

It's done now but it's not working, i edited a post and no history link is showed, I did the template changes for postbit legacy.

David Lama 06-14-2007 03:24 AM

is there a version of this for 3.5 and up? :) sounds awesome

Surviver 06-14-2007 11:41 AM

Quote:

Originally Posted by dutchbb (Post 1267880)
Ok thanks.

It's done now but it's not working, i edited a post and no history link is showed, I did the template changes for postbit legacy.

You have to activate this Hack global per Forum and per Usergroup ;)

Quote:

Originally Posted by David Lama (Post 1268162)
is there a version of this for 3.5 and up? :) sounds awesome

No, this Version is only for 3.6 (never tested with 3.5)

dutchbb 06-14-2007 11:54 AM

Quote:

Originally Posted by Surviver (Post 1268329)
You have to activate this Hack global per Forum and per Usergroup ;)

Oh ,ok thanks. Great hack, vbulletin should seriously consider this for the next release!

Trigr 06-14-2007 02:11 PM

uhm no .xml file in the attachment? did i miss it?

[e] why yes i did .............

my bad. installed and appreciate the work.

E 06-16-2007 07:54 AM

id like a 3.6.7 aswell, if you plan on updating, thanks

vengefuldeath87 06-16-2007 08:05 AM

Ive installed it on 3.6.7 with no issues, should be fully compatable.

David Lama 06-16-2007 11:52 PM

it works?? hmmm

wrestlepower 06-17-2007 11:14 AM

ok, i've installed it as per instructions, set up the forum and usergrioup permissions and attempted to test it. If i edit a post, it will show in the postbit (legacy) that there has been an edit but when i click on it to see the previous version, it says that the post ahs never been edited.

Any ideas?

Surviver 06-17-2007 12:14 PM

Does the edithistory table exist?

saidsrc 06-23-2007 10:50 AM

there is a bug,

when i want to change user group permissions,
ist going to database error,
and this ++++ing hack :@
i reseted my forum :@

SDB 06-25-2007 01:32 PM

Hi

This keeps timing out in the install script. We have a very large post table (approx 7million posts) and I guess its timing out attempting to change that.

Could you please give me the raw SQL for the post table change and I'll give it a go that way?

Cheers

Simon

SDB 06-27-2007 04:44 PM

Right.

THis is urgent.

I now have a problem, as this install script didn't fully run, and I now can't make changes to my usergroups as it throws up a db error :

Code:

MySQL Error  : Unknown column 'edithistorypermissions' in 'field list'
Error Number : 1054

whenever I try to update the usergroup.

Please help asap - first of all to remove this problem.

cheat-master30 06-29-2007 08:41 AM

Quote:

Originally Posted by SDB (Post 1277803)
Right.

THis is urgent.

I now have a problem, as this install script didn't fully run, and I now can't make changes to my usergroups as it throws up a db error :

Code:

MySQL Error  : Unknown column 'edithistorypermissions' in 'field list'
Error Number : 1054

whenever I try to update the usergroup.

Please help asap - first of all to remove this problem.

Same, even though I uninstalled the product and no plugins for it actually exist. I think the uninstall process is screwed.

Dioxin 07-05-2007 09:34 AM

if the title of a saved post contains a quote character and i restore this post the quote character in the restored post will get messed up.

some sort of conversion error.

could you please fix this bug :)

could this fix solve the problem:
PHP Code:

$postdm->setr('title'unhtmlspecialchars($edit['oldtitle'])); 


SDB 07-05-2007 08:02 PM

Is there any reason why no support is being offered?

ragtek 07-05-2007 08:09 PM

surviver is on holiday ;)
thats the reason

Surviver 07-07-2007 12:53 PM

Quote:

Originally Posted by SDB (Post 1277803)
Right.

THis is urgent.

I now have a problem, as this install script didn't fully run, and I now can't make changes to my usergroups as it throws up a db error :

Code:

MySQL Error  : Unknown column 'edithistorypermissions' in 'field list'
Error Number : 1054

whenever I try to update the usergroup.

Please help asap - first of all to remove this problem.

Re,ove the file bitfield_edithistory.xmlfrom the dir includes/xml - this will fix the problem.
Or better add the column to the uisergrouzptable.

Quote:

Originally Posted by cheat-master30 (Post 1279028)
Same, even though I uninstalled the product and no plugins for it actually exist. I think the uninstall process is screwed.

Quote:

Originally Posted by Dioxin (Post 1283319)
if the title of a saved post contains a quote character and i restore this post the quote character in the restored post will get messed up.

some sort of conversion error.

could you please fix this bug :)

could this fix solve the problem:
PHP Code:

$postdm->setr('title'unhtmlspecialchars($edit['oldtitle'])); 


I'll fix this in thenext release ;)

Quote:

Originally Posted by SDB (Post 1283790)
Is there any reason why no support is being offered?

Quote:

Originally Posted by ragtek (Post 1283796)
surviver is on holiday ;)
thats the reason

Thanks ragtek

magnus 07-07-2007 10:41 PM

How many posts back does this modification save? Does it save only the most recent edit, or every edit since creation?

Surviver 07-10-2007 01:52 PM

Quote:

Originally Posted by magnus (Post 1285436)
How many posts back does this modification save? Does it save only the most recent edit, or every edit since creation?

It saves every edit since creation ;)

mfyvie 07-13-2007 01:42 PM

Quote:

Originally Posted by Surviver (Post 1129356)
You can activate/deactivate ist per Usergroup and Forum ;)

Hi Survivor - nice hack. I just have one suggestion. Could you include that instruction into the instructions in the .zip file? I dutifully followed all instructions and was wondering why it didn't work. Then I discovered in post #22 that I needed to manually activate this on a usergroup basis. It might also be an idea to default the settings to on for the admin and super mod usergroups. This might save some people a lot of confusion (either that, or make sure it is written in the instructions).

I've also made a small change to the template edit as follows:
Code:

<if condition="$show['edithistorylink']"><if condition="$post['editcount'] > 0"><a href="edithistory.php?do=viewedithistory&postid=$post[postid]"><phrase 1=$post[editcount]>$vbphrase[saved_edits]</phrase><a></if></if>
This has the advantage of only displaying the edits link if there are actually edits. I don't think it makes sense to display an edits link when the number of edits is 0.

Thanks again for a great mod.

ragtek 07-13-2007 01:48 PM

Quote:

Originally Posted by mfyvie (Post 1289964)
Hi Survivor - nice hack. I just have one suggestion. Could you include that instruction into the instructions in the .zip file? I dutifully followed all instructions and was wondering why it didn't work. Then I discovered in post #22 that I needed to manually activate this on a usergroup basis. It might also be an idea to default the settings to on for the admin and super mod usergroups. This might save some people a lot of confusion (either that, or make sure it is written in the instructions).

I've also made a small change to the template edit as follows:
Code:

<if condition="$show['edithistorylink']"><if condition="$post['editcount'] > 0"><a href="edithistory.php?do=viewedithistory&postid=$post[postid]"><phrase 1=$post[editcount]>$vbphrase[saved_edits]</phrase><a></if></if>
This has the advantage of only displaying the edits link if there are actually edits. I don't think it makes sense to display an edits link when the number of edits is 0.

Thanks again for a great mod.

good idee

Surviver 07-14-2007 03:09 PM

Quote:

Originally Posted by mfyvie (Post 1289964)
Hi Survivor - nice hack. I just have one suggestion. Could you include that instruction into the instructions in the .zip file? I dutifully followed all instructions and was wondering why it didn't work. Then I discovered in post #22 that I needed to manually activate this on a usergroup basis. It might also be an idea to default the settings to on for the admin and super mod usergroups. This might save some people a lot of confusion (either that, or make sure it is written in the instructions).

I've also made a small change to the template edit as follows:
Code:

<if condition="$show['edithistorylink']"><if condition="$post['editcount'] > 0"><a href="edithistory.php?do=viewedithistory&postid=$post[postid]"><phrase 1=$post[editcount]>$vbphrase[saved_edits]</phrase><a></if></if>
This has the advantage of only displaying the edits link if there are actually edits. I don't think it makes sense to display an edits link when the number of edits is 0.

Thanks again for a great mod.

Thanks for your suggestion - the next update is coming and i will consider your suggestion ;)

Surviver 07-14-2007 04:24 PM

*** Update ***

--> Changes see first post

TrIn@dOr 07-18-2007 07:17 PM

Nice

richTV 07-19-2007 11:03 PM

Hello, tnx for sharing this.

glad to read also that members have installed it fine under 3.6.7 as this is what i have too.

my question:

in the .zip file, do i only need what is in the folder:

Post Edit History\edithistory_1-2-5

i ask because u also have stuff in the folder:

Post Edit History

such as an Upload folder, and .txt files and 1 .xml file

did u do intentionally do this for a German version and an English version?

TIA

richTV 07-19-2007 11:21 PM

also, to not show a link in which an edit does NOT exist, do i need to install the template written by MThornback [Post Edit History (PEH) Alternate Postbit Layout] or is this already included in the update u recently made?

i ask because u said:

1.2.5
=====
- Bugfix: Fixed a problem with entities
- New Feature: Now you can compare saved edits via ajax
- Change: Optimized some code
- Change: Cronjob phrased
- Change: Optimized Installcode
- Change: Link will only show up if post was edited


so i just wanted to know whether or not the update is already built in or we need to add his template too.

TIA

Surviver 07-20-2007 02:22 PM

Quote:

Originally Posted by richTV (Post 1296122)
Hello, tnx for sharing this.

glad to read also that members have installed it fine under 3.6.7 as this is what i have too.

my question:

in the .zip file, do i only need what is in the folder:

Post Edit History\edithistory_1-2-5

i ask because u also have stuff in the folder:

Post Edit History

such as an Upload folder, and .txt files and 1 .xml file

did u do intentionally do this for a German version and an English version?

TIA

I don't understand your problem. Just read readme.txt ;)

Quote:

Originally Posted by richTV (Post 1296126)
also, to not show a link in which an edit does NOT exist, do i need to install the template written by MThornback [Post Edit History (PEH) Alternate Postbit Layout] or is this already included in the update u recently made?

i ask because u said:

1.2.5
=====
- Bugfix: Fixed a problem with entities
- New Feature: Now you can compare saved edits via ajax
- Change: Optimized some code
- Change: Cronjob phrased
- Change: Optimized Installcode
- Change: Link will only show up if post was edited


so i just wanted to know whether or not the update is already built in or we need to add his template too.

TIA

Yes, the update contains this change ;)

Nathan2006 07-24-2007 10:06 PM

This is a lot better

Thank you for the update :)


All times are GMT. The time now is 06:44 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01532 seconds
  • Memory Usage 1,855KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (9)bbcode_code_printable
  • (2)bbcode_php_printable
  • (21)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete