vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.5 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=113)
-   -   Realtime Template Compressor: Reduces page sizes, loads pages faster, saves bandwidth (https://vborg.vbsupport.ru/showthread.php?t=83248)

womensden 06-17-2005 06:30 PM

I just noticed that in the "new posts" page, the topic titles are crammed against the "go to first new post" icon. There is no space in between. It's fine everywhere else though.

ShiningArcanine 06-17-2005 07:32 PM

That alternate expression was experimental, which is why I said that I was still playing with it. Here is the new one I'm playing with:

Quote:

/(?(?=\r\n)\s)/
It doesn't compress as well but it doesn't seem to remove any necessary whitespaces so it is a strong candidate for the expression I'm putting in 1.1.0 (as I'm not happy with the current level of compression).

ShiningArcanine 06-17-2005 08:10 PM

It seems that I made writing expressions more complicated than it needed to be. ^_^;;

I wrote something entirely new that I think will be much more efficient so I've released version 1.1.0.

Andreas 06-17-2005 08:15 PM

Your current regex kills whitespaces that are there intentionally.
And you could achieve higher compression if you remove HTML comments.
However, this might cause problems with JavaScript then.

ShiningArcanine 06-17-2005 08:39 PM

KirbyDE, aren't all of the whitespaces there intentionally? The regex in 1.0.0 was Logician's original regex but it didn't compress things well enough and my attempts at an advanced regex compressed things so well that it killed whitespaces that are necessary for the presentation so I wrote a simpler regex that strips the whitespaces at the beginning of each line.

It doesn't have any effect on how you view the page unless you're viewing the XHTML. If you were viewing the XHTML, you would not have any level of template compression enabled on your forums.

I have this installed on my forums if you want to check it out:

http://www.pokemonfanuniverse.com/forums/

By the way, thanks for the tip regarding the comments. I was considering stripping them in a new version but I didn't realize that stripping them might affect javascript. Looking at the syntax Jelsoft used I could probably strip them either by ensuring they're on a single line or by also requring the whitespace found after "<!--" in comments but not in the javascript (from what I can see).

Edit: Also, if anyone is interested in why vBulletin strips slashes from the plugin upon submit/edit, they'll want to check out this bug report at vBulletin.com:

http://www.vbulletin.com/forum/bugs3...view&bugid=184

It should be fixed in vBulletin 3.5.0 Beta 2 from what I can gather.

Andreas 06-17-2005 08:53 PM

What about that
Code:

The following line has 4 spaces at the beginning
    Test


ShiningArcanine 06-17-2005 09:22 PM

Quote:

Originally Posted by KirbyDE
What about that
Code:

The following line has 4 spaces at the beginning
    Test


I'm not aware of any stock code in vBulletin written like that and to be honest, that is supposed to use &nbsp; rather than standard whitespaces. Not to mention modern browsers display one whitespace instead of several consecutive whitespaces in HTML web pages even if there are several consecutive whitespaces.

Andreas 06-17-2005 10:13 PM

This is the stock [code] Tag :)
It generates <pre>-Tags, which should preserve whitespaces - but you strip them out.

ShiningArcanine 06-17-2005 10:36 PM

Quote:

Originally Posted by KirbyDE
This is the stock [code] Tag :)
It generates <pre>-Tags, which should preserve whitespaces - but you strip them out.

That changes things. Are you proposing a better way of doing it that won't strip those whitespaces or are you leaving it up to me?

By the way, shouldn't Logician's orignal regex also have stripped out those whitespaces?

ja3 06-18-2005 06:47 AM

I use
$output=preg_replace ('/(\s*)\r\n(\s*)/', "", $output);
$output=preg_replace ('/<!-- .*? -->/',"",$output);

and get about 15% compression, don't know why you still need the \r\n? :)


All times are GMT. The time now is 09:12 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01691 seconds
  • Memory Usage 1,740KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (3)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete