vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Administrative and Maintenance Tools - Remove Post Edit History (from within postbits) (https://vborg.vbsupport.ru/showthread.php?t=321937)

X-or 03-10-2017 10:32 AM

This mod is not compatible with latest vb 4.2.4 update.
Accessing a CMS article can result in a database error.

Uninstalled.

BadgerDog 03-10-2017 11:15 AM

Installed with thanks to Mark on v4.13... :)

It seems to work fine, except when you edit a post to perhaps add additional text etc., then after saving it, you choose to click the "Revert Post" button because you want to restore the first original post.

That "Revert Post" button then removes all edit info from bottom of the post so it appears as it it was never edited, which is probably what it should do since you've only done one edit of the original post.

However, the content showing in the post is NOT just the content of the original post you wanted to revert to, but rather the last edited post state you had saved, which included the changes you had made? If you then select EDIT POST again, you now see correctly just the content of the original post you wanted to revert to?

Is there something I'm not understanding?

Thanks...

Regards,
Doug

MarkFL 03-10-2017 02:56 PM

Quote:

Originally Posted by X-or (Post 2583595)
This mod is not compatible with latest vb 4.2.4 update.
Accessing a CMS article can result in a database error.

Uninstalled.

Sorry, I never intended it to work with CMS, but with forum posts only...it is in fact compatible with vB 4.2.4. :)

In the next update, I will add a condition that prevents the button from showing up on CMS articles.

Quote:

Originally Posted by BadgerDog (Post 2583596)
Installed with thanks to Mark on v4.13... :)

It seems to work fine, except when you edit a post to perhaps add additional text etc., then after saving it, you choose to click the "Revert Post" button because you want to restore the first original post.

That "Revert Post" button then removes all edit info from bottom of the post so it appears as it it was never edited, which is probably what it should do since you've only done one edit of the original post.

However, the content showing in the post is NOT just the content of the original post you wanted to revert to, but rather the last edited post state you had saved, which included the changes you had made? If you then select EDIT POST again, you now see correctly just the content of the original post you wanted to revert to?

Is there something I'm not understanding?

Thanks...

Regards,
Doug

That likely has to do with post caching. I may need to look into using vBulletin's intrinsic data manager rather than writing to the db. :)

BadgerDog 03-10-2017 03:40 PM

Quote:

Originally Posted by MarkFL (Post 2583604)
That likely has to do with post caching. I may need to look into using vBulletin's intrinsic data manager rather than writing to the db. :)

Ahhh... that could be ... :up:

If you want to add something to code that forces (flushes) the cache to eliminate the residual left over text, I'd be happy to test an update for you.

Thanks Mark ... :)

Regards,
Doug

MarkFL 03-11-2017 12:23 AM

Update - Version 1.5:
  • Uses intrinsic datamanager functions on post revert.
  • Make sure only forum posts are affected.
  • User returned to specific post upon action performed.

BadgerDog 03-11-2017 09:32 AM

1 Attachment(s)
Thanks Mark... :)

Updated to 1.5 and ran a test thread ..

1. Created a new thread (first post)...
2. Edited (didn't go to advanced edit) first post simply adding some text..
3. After saving the edited post, screen flashed and edited first post returned showing correctly edits post adding the new text, however, there was only the standard vbulletin edit link notification at bottom of post (see right pic). I then clicked page refresh and that link, plus your add on options appeared. (see left pic)
4.Clicked "Revert" button and web page screen cleared to a white page and froze. It didn't return to the post and I had to click on home page to work my way back to the test post.
5. The good news is when I did that and got back to the test post, it had reverted correctly to the original first post content, as it should have, plus no vBulletin edit link or your add-on option appeared any longer, whic would also be correct for your mod. The locked up white screen seems to be something new for us in 1.5.

If there's anything else we can do to help, please let use know.. :)

Note: we do use Sucuri firewal..

https://sucuri.net/website-firewall/

It has been an outstanding product for our site to protect it from spam, viruses and added improved performance. It uses a world wide caching system, so I wonder if that's a factor.

Regards,
Doug

MarkFL 03-11-2017 11:36 AM

Hello Doug,

I suspect the white screen you got is an issue with using vB 4.1.x, as I'm not getting that on my local dev site running vB 4.2.5. The buttons don't appear immediately after using the quick editor, only the advanced editor but I don't consider that much of an issue since you would typically use this on the posts of others. :)

BadgerDog 03-11-2017 11:52 AM

Quote:

Originally Posted by MarkFL (Post 2583661)
Hello Doug,

I suspect the white screen you got is an issue with using vB 4.1.x, as I'm not getting that on my local dev site running vB 4.2.5. The buttons don't appear immediately after using the quick editor, only the advanced editor but I don't consider that much of an issue since you would typically use this on the posts of others. :)

Thanks Mark.. :)

I didn't get the white screen hang with v1.4, so something changed in 1.5 that has caused the hanging white screeninteraction.

Appreciate your efforts, but I'll uninstall the mod, since it's unlikely to work with our site at this point...

Regards,
Doug

MarkFL 03-11-2017 12:05 PM

I made only one change to the removal portion of the script, and this change is also in the revert portion, so it's odd that the removal portion gives you a white screen while the revert portion doesn't.

However, as I said, I can't replicate the issue. Sorry about that. :(

X-or 03-12-2017 08:44 PM

database error on cms articles still happen


All times are GMT. The time now is 12:49 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01394 seconds
  • Memory Usage 1,746KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (4)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete