vb.org Archive - vBulletin 4 & PHP 7 - drastic speed improvement!

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vB4 General Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=251)

- - vBulletin 4 & PHP 7 - drastic speed improvement! (https://vborg.vbsupport.ru/showthread.php?t=320975)

@Alan_SP
My blog works fine from here, weird.
Here's the post with the upgrade instructions: http://pastie.org/pastes/10622659/te...xtqlc7ktv3mwxg

Thanks for the info, I just tested it with FireFox, it seems you're blocking my browser (Opera). Probably same as was with Ozzmodz.

Hello all,

first of all thank you for the blog post. We're about to migrate our web services to PHP 7 as well and vB forum is one of them. I've done the modification as mentioned unfortunately i am facing an issue when posting a new thread/post. It will end up in blank post.

New thread with some text
https://vborg.vbsupport.ru/external/2016/07/4.png

This is how it looks like after submit
https://vborg.vbsupport.ru/external/2016/07/5.png

Firebug confirms that no text at all in the body
https://vborg.vbsupport.ru/external/2016/07/6.png

I've tested it with all plugins disabled via "define('DISABLE_HOOKS', true);" and with the default template as well. Still facing the issue.

We're running following setup in our test environment:
vBulletin 4.2.2 Patch Level 5
PHP Version 7.0.8
Web server: fpm-fcgi

I've also found following warnings in error.log ... not sure if related or just another things to be fixed.

Code:

PHP Deprecated:  Methods with the same name as their class will not be constructors in a future version of PHP;

        vB_DataManager has a deprecated constructor in /www/includes/class_dm.php on line 20

        vB_DataManager_Multiple has a deprecated constructor in /www/includes/class_dm.php on line 1628

        vB_DataManager_ThreadPost has a deprecated constructor in /www/includes/class_dm_threadpost.php on line 27

        vB_DataManager_Post has a deprecated constructor in /www/includes/class_dm_threadpost.php on line 656

        vB_DataManager_Thread has a deprecated constructor in /www/includes/class_dm_threadpost.php on line 1031

        vB_DataManager_Thread_FirstPost has a deprecated constructor in /www/includes/class_dm_threadpost.php on line 1574

        vB_BbCodeParser_Wysiwyg has a deprecated constructor in /www/includes/class_bbcode_alt.php on line 28

        vB_BbCodeParser_ImgCheck has a deprecated constructor in /www/includes/class_bbcode_alt.php on line 689

        vB_BbCodeParser_PrintableThread has a deprecated constructor in /www/includes/class_bbcode_alt.php on line 846

        vB_BbCodeParser_PlainText has a deprecated constructor in /www/includes/class_bbcode_alt.php on line 890

        vB_BbCodeParser_Video_PreParse has a deprecated constructor in /www/includes/class_bbcode_alt.php on line 1618

        vB_DataManager_Forum has a deprecated constructor in /www/includes/class_dm_forum.php on line 37

        vB_DataManager_User has a deprecated constructor in /www/includes/class_dm_user.php on line 31

        vB_Postbit has a deprecated constructor in /www/includes/class_postbit.php on line 176

        vB_DataManager_IP_Data has a deprecated constructor in /www/includes/class_dm_ip_data.php on line 29

        vB_DataManager_Content_Read has a deprecated constructor in /www/includes/class_dm_content_read.php on line 29

Thanks in advance for any advice.

Alex

See this : https://vborg.vbsupport.ru/showthread.php?t=322892

(Btw, two of the fixes in that blog are not actually correct).

Quote:

Originally Posted by Dave (Post 2559779)

On top of my head, I had to make changes to the following files:

includes/class_core.php (to fix constructor error)
includes/class_datastore.php (to fix constructor error)
includes/class_bbcode.php (to fix function name must be a string error)
includes/class_hook.php (to fix constructor error)
vb/exception/parser.php (to fix redefinition of argument error)

Also I had to change the datastore class in config.php back to vB_Datastore_Filecache since there's no PHP 7 version for APC/XCache or Memcached. You don't need it anymore anyway since OPCache has been introduced and it's extremely fast.

Another thing to keep in mind is that PHP 7 deprecates the mysql_* functions. In case you have any plugins or custom scripts installed which makes use of that then it will not work.

You should send these to vB team so we can use PHP7 on forums earilier

I want to upgrade to PHP7 for my hosting but I could not because my vB forum is not compatible with PHP7 so I have to leave it.

Quote:

Originally Posted by Paul M (Post 2573506)

See this : https://vborg.vbsupport.ru/showthread.php?t=322892

(Btw, two of the fixes in that blog are not actually correct).

I'll probably write a follow up blog for more changes/fixes for PHP 7.
Although you state that some of the fixes are not "correct", my forum has been running just fine for about 8 months now on PHP 7.

Quote:

Originally Posted by webmastersun (Post 2573559)

You should send these to vB team so we can use PHP7 on forums earilier

I want to upgrade to PHP7 for my hosting but I could not because my vB forum is not compatible with PHP7 so I have to leave it.

Did you even bother to read the link I posted ?

Quote:

Originally Posted by Dave (Post 2573560)

Actually, I said two, not some ;)

One you would never notice unless you somehow triggered exceptions, even then it would probably just display wrong information.
The other would, I think, break something (custom tags ?) I'm not actually anywhere I can look at code atm.

If they were the only changes you made, you are hiding a ton load of warnings.

The PHP 7 test version has been available for anyone who requests it for almost two months now, posted here, vb.com, and even TAZ - only three people have shown any interest. The Alpha's next month will basically be that code.

I love vB 4.2.5 Beta 1 and together with PHP7 it runs perfectly.

Quote:

Originally Posted by Domenico (Post 2580320)

I love vB 4.2.5 Beta 1 and together with PHP7 it runs perfectly.

Are you running it with PHP7.1 or PHP 7.0.*?
PHP 7.1 should speed it up by a tiny bit more.

I have the beta as well and would love to upgrade but I think I would have to go through older plug ins and I know my Photopost gallery would have issues as well.

I may do it though at some point.

X vBulletin 3.8.12 by vBS Debug Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)bbcode_code_printable (5)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (3)pagenav_pagelink (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages:

Phrase Groups Available:

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01189 seconds Memory Usage 1,751KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)bbcode_code_printable (5)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (3)pagenav_pagelink (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: