vb.org Archive - Miscellaneous Hacks - IE11 browser detection and fixes

Page 3 of 4

Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vBulletin 3.8 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=235)

- - Miscellaneous Hacks - IE11 browser detection and fixes (https://vborg.vbsupport.ru/showthread.php?t=303520)

BirdOPrey5

12-17-2013 11:16 PM

Quote:

Originally Posted by Digital Jedi (Post 2469087)

[minicode](Trident|MSIE)[/minicode] would match specifically one of those two words, but I don' know how that affects the JS.

My concern was the extra parentheses would throw off the rest of the script.

Zachery

12-22-2013 03:16 PM

Did anyone try?

JamesC70

12-28-2013 11:36 PM

Quote:

Originally Posted by EvilLS1 (Post 2468849)

Smileys don't seem to work in IE11/vB3.8 by clicking them in WYSIWYG mode. Works fine in compatibility mode. Any fix for this?

Quote:

Originally Posted by Zachery (Post 2468869)

It appears that YUI will also need to be updated to handle the issues with the editor. Though, I don't know how reasonable that will be. I suspect we can just append similar code to the YUI file for browser matching. But I'm not overly familiar with js.

YUI has been updated: http://www.yuiblog.com/blog/2013/12/...14-1-released/ Has anyone at vB verified that this fixes the issue on 3-series forums? (Alternately: how badly would it screw up our sites if we used this one instead of YUI 2.9.0? :rolleyes: )

Zachery

12-28-2013 11:42 PM

YUI 3, is not YUI 2, its not a drop in replacement. Moving to YUI 3 is about the same as moving to Jquery, or another similar js lib.

So yes, to get IE11 support in vBulletin fully, you'd need to update yui to support something it wasn't originally intended to.

Boothby

01-05-2014 03:10 PM

Quote:

[Trident|MSIE]+

Sorry, but this makes no sense at all, because it would even match M or MM or MMMMMMMM or in an unbelievable worst case |||||. Uuuh. ;)
The | has no meaning between []. The chars/letters are alternatives, so you could also write:

Code:

(T|r|i|d|e|n|t|\||M|S|I|E){1,}

So, after looking into the original source codes of YUI 2 and 3 I would suggest to replace

Code:

else{a=c.match(/MSIE\s([^;]*)/);if(a&&a[1]){g.ie=e(a[1]);}

with

Code:

else{a=c.match(/MSIE ([^;]*)|Trident.*; rv:([0-9.]+)/);if(a&&(a[1]||a[2])){g.ie=e(a[1]||a[2]);}

The browser detection is very similar in both, YUI 2 and 3 and the above code is from YUI3 and then backminified by me. :eek:

untested, hope it works ;)

cellarius

01-05-2014 06:57 PM

What YUI version file do you use, Boothby? I don't have that line in my /clientscript/yui/yahoo-dom-event.js.

Boothby

01-05-2014 07:26 PM

I downloaded the latest version from yahoo, 2.9.0, and it seems identical to the latest stable and beta vBulletin builds. In an older build on my local install I found also Zachery's code which was from 2.7.0.

Here it is:

Find:

Code:

else{A=B.match(/MSIE\s([^;]*)/);if(A&&A[1]){C.ie=parseFloat(A[1]);}

and replace with:

Code:

else{A=B.match(/MSIE ([^;]*)|Trident.*; rv:([0-9.]+)/);if(A&&(A[1]||A[2])){C.ie=parseFloat(A[1]||A[2]);}

And again, not tested with best hopes. :D

Zachery

01-05-2014 08:20 PM

digitalpoint did some testing and he said the YUI 2.9 seemed to work, but again, its not supported by default.

cellarius

01-05-2014 08:45 PM

Thanks guys, appreciated! Shawn's word is good enough for me :-)

Boothby

01-06-2014 04:29 AM

YUI 2.9 is in the current download packages of vB 3.8.7 and 3.8.8.

Code:

/*

Copyright (c) 2011, Yahoo! Inc. All rights reserved.

Code licensed under the BSD License:

http://developer.yahoo.com/yui/license.html

version: 2.9.0

*/

All times are GMT. The time now is 03:44 AM.

Page 3 of 4

Show 40 post(s) from this thread on one page

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01052 seconds Memory Usage 1,739KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (6)bbcode_code_printable (4)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (3)pagenav_pagelink (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: