vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.8 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=235)
-   -   Private Messages Enhancements - Private Message Quote Formatting (https://vborg.vbsupport.ru/showthread.php?t=292996)

kh99 12-21-2012 01:36 AM

Obviously others are interested in the vb3 version so it doesn't matter to me if you wait or decide not to install it at all. But for anyone else who might be worried about it, this makes no database changes and has no custom uninstall code, so uninstalling won't be a problem.

Max Taxable 12-21-2012 01:37 AM

Quote:

Originally Posted by kh99 (Post 2392003)
Obviously others are interested in the vb3 version so it doesn't matter to me if you wait or decide not to install it at all. But for anyone else who might be worried about it, this makes no database changes and has no uninstall code, so uninstalling won't be a problem.

Nice to know.

I thought it was a good idea (it is) that's why I asked for it for v3.

ctrlbrk 12-21-2012 01:47 AM

Yes, I very much want this to work... just need to fix the emails, or trigger them to be sent in HTML mode.

Max Taxable 12-21-2012 02:18 AM

Quote:

Originally Posted by ctrlbrk (Post 2392008)
Yes, I very much want this to work...

Me too.

kh99 12-21-2012 02:34 AM

It turns out that it wasn't a big fix. I'll release a new version tomorrow.

ctrlbrk 12-21-2012 03:11 AM

Quote:

Originally Posted by kh99 (Post 2392014)
It turns out that it wasn't a big fix. I'll release a new version tomorrow.

Excellent, thanks. Crossing fingers for adding the date/time as well, I know it will take some PHP and query but I think is worth it :)

kh99 12-21-2012 10:14 AM

Quote:

Originally Posted by ctrlbrk (Post 2392017)
Excellent, thanks. Crossing fingers for adding the date/time as well, I know it will take some PHP and query but I think is worth it :)

I'll look in to doing that. But one thing about that: it will be something that won't go away when you uninstall the mod. It's going to have to go in as part of the name of the person you're quoting.

ctrlbrk 12-21-2012 10:27 AM

Quote:

Originally Posted by kh99 (Post 2392035)
I'll look in to doing that. But one thing about that: it will be something that won't go away when you uninstall the mod. It's going to have to go in as part of the name of the person you're quoting.

Or just a $variable? I figure you'll need to do a SELECT query to find the info, then the plug-in could just throw it in a $variable? I for instance would prefer to be able to float: right; the date on the other side of the quote box. But either way, it is welcome.

kh99 12-21-2012 11:12 AM

Quote:

Originally Posted by ctrlbrk (Post 2392037)
Or just a $variable? I figure you'll need to do a SELECT query to find the info, then the plug-in could just throw it in a $variable? I for instance would prefer to be able to float: right; the date on the other side of the quote box. But either way, it is welcome.

I'm not sure what you mean by a variable. (Edit: oh, I think I see now, you mean a variable you can use in the template). Maybe you have an idea of how to do it that I haven't thought about. But the quote is just a bbcode with the user's name as an option and the text as the parameter, like: [QUOTE=ctrlbrk]Or just a $variable?...[/quote]. That's all the information there is. It *might* be possible to do a query for previous messages matching the quoted text (assuming it hasn't been deleted), but I'm not going to try to do anything like that - it might end up being more complicated than the entire mod is now.

So that just leaves adding it to the option somehow. Quoting posts uses that method by adding the post id after a semicolon, like [QUOTE=ctrlbrk;2392037]Or just a $variable?...[/quote], then the code looks for that, strips it off and uses it to create the little arrow that takes you to the post. I might be able to do something similar with the date and time, but then if my mod is uninstalled it will still be there (unless I go through all PMs on the system and delete it when I uninstall). That might not be a problem if it's text - my mod can strip it off and make it a variable in the template, and if it's uninstalled it will just appear after the name. Adjusting the timezone might be a bit of an issue but I think I can deal with that.

Anyway, let me know if you have a different idea.

kh99 12-21-2012 11:52 AM

Hmm...I suppose I could just do one query to try to match the quoted text and username, and if it fails (like if the message was deleted) then it just won't show up. I don't like that as mush as including it as part of the option text, but I'm not the one requesting it. Would you rather it be a hit-and-miss type of thing that depends on the quoted message still being in the system (but it would work for existing pms with quotes and would go away completely if uninstalled), or make it part of the option, in which case it would not be there for pre-existing pms and it wouldn't go away when uninstalled, but it would stay around even if the mod is uninstalled? (In either case it will be a variable that you can float right, as long as this mod stays installed).


All times are GMT. The time now is 01:24 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01038 seconds
  • Memory Usage 1,740KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (6)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete