vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Show Thread Enhancements - Digital Point Ad Positioning (https://vborg.vbsupport.ru/showthread.php?t=254332)

Kolbi 11-30-2010 05:24 AM

Well, you have the same issue :)

The ads are only shown after/in the first post.

But this mod should show the ads at the active post you are watching.
For example if you want to view the latest post in a thread the ads are after and in the latest post and not in the first post of the thread.

digitalpoint 11-30-2010 06:10 AM

Yeah, if your setup doesn't use the p= parameter, there's no way for the script to know which post you are looking at. Since the #post12345 isn't seen on the server-side, so...

LbR 11-30-2010 06:38 AM

Good stuff Shawn :)

BadgerDog 12-01-2010 04:03 AM

Installed on 4.04 with thanks ... :)

However, I don't see an ad show up after the post being viewed after we've set up the mod? :confused:

When you set the group that it DOES NOT display for, is this ONLY the Primary Group? In other words if a member belongs to secondary groups as well, will the mod only check the Primary Group to decide whether to display an ad or not?

Thanks ...

Regards,
Badger

Edit: Did some testing and discovered that it reads all user groups, including secondary ones, which causes a "logic" conflict when trying to exclude certain groups for us. It would work for us if if it only read the Primary Group as a means test for DO NOT DISPLAY ads.

digitalpoint 12-01-2010 08:51 AM

It's using the normal is_member_of() function built into vBulletin which does factor in secondary groups... But I'm not sure how that would cause conflicts... if someone is a member of group A, and then a secondary member of group B, and you wanted to hide ads from group B, you wouldn't want to hide ads from that member?

BadgerDog 12-01-2010 09:42 AM

Quote:

Originally Posted by digitalpoint (Post 2127844)
It's using the normal is_member_of() function built into vBulletin which does factor in secondary groups... But I'm not sure how that would cause conflicts... if someone is a member of group A, and then a secondary member of group B, and you wanted to hide ads from group B, you wouldn't want to hide ads from that member?

Thanks for the reply ... :)

I think it's the NOT a member of logic which is exclusive as opposed to an INCLUDE logic that causes our problems.

We only want ads to display for Primary Usergroup ID's 1,2,3,4,6,13:

Currently we use code like this for our ads and it works fine:

Quote:

<vb:if condition="is_member_of($bbuserinfo,1,2,3,4,6,13)" >
<center><script type="text/javascript"><!--
google_ad_client = "pub-99999999999999999"";
/* 728x90, created 1/4/10 */
google_ad_slot = "xxxxxxxxx";
google_ad_width = 728;
google_ad_height = 90;
//-->
</script>
<script type="text/javascript"
src="http://pagead2.googlesyndication.com/pagead/show_ads.js">
</script></center>
</vb:if>
I even tried to leave our own include condition shown above in the ad HTML and leave your NOT include field blank, but it still showed ads for incorrect groups, so I'm not sure what I'm doing wrong. Shouldn't this latter approach effectively negated your field and used what we put in with the ad code as groups, since your field was blank and we would only show the ad if it met our own "is_member_of($bbuserinfo,1,2,3,4,6,13)" condition?

Thanks for your help ... :)

Regards,
Badger

naisho 12-01-2010 11:57 AM

Very good mod! Just installed on vB 4.1.

I agree with you BadgerDog about the logic.

"Show if member of" is easier to understand than "hide (not show) if is not member of", though result is identical, I guess.

You can edit the xml file to do that. Find this line (n?31):

Code:

if ($vbulletin->options['dppa_insidepost'] && !is_member_of($vbulletin->userinfo, explode(',', $vbulletin->options['dppa_insidepost_hidegroups'])) &&
Modify like this:

Code:

if ($vbulletin->options['dppa_insidepost'] && is_member_of($vbulletin->userinfo, explode(',', $vbulletin->options['dppa_insidepost_hidegroups'])) &&
This is for the insidepost. You can do the same for the afterpost. And modify the phrases in the same file ("hide" --> "show"). and re-install the product.

I wish this mod could accept differents ads according to forum ids.

BadgerDog 12-01-2010 01:52 PM

Quote:

Originally Posted by naisho (Post 2127892)
Very good mod! Just installed on vB 4.1.

I agree with you BadgerDog about the logic.

"Show if member of" is easier to understand than "hide (not show) if is not member of", though result is identical, I guess.

You can edit the xml file to do that.

Thank you very much naisho ... appreciate you having a look at it ... :)

Made your edit changes in both places and the mod now works perfectly for us.... :up:

Regards,
Doug

BadgerDog 12-01-2010 02:22 PM

Follow up ...

For those of you running this vb4 [AJAX] Post Thank You Hack mod by Abe ...

https://vborg.vbsupport.ru/showthread.php?t=231666

There's a conflict when this mod puts it's ad as the last post. You can click the "Thanks" button but instead of the "Thanks" box appearing with your name pushing the ad down placed there by digitalpoint's mod and the "Thanks" button disappearing, all that happens is the "Thanks" button disappears as it should, but the screen jumps to the TOP of the thread.

If you scroll back down to where the ad is, you'll see that the "Thanks" button is gone, but there's no "Thanks" box with your name. The "Thanks" action did happen though and if you turn OFF the Insert Ad After Post of this ad and view the same post the "Thanks" box is there with your name but of course, the Insert Ad After Post ad which appeared after it is gone because you've turned OFF that part of this mod.

This problem seems to only happen when the post is the last one in the thread, at least that's what I think right now, since it doesn't happen when it places the ad after the first post, as an example.

Hope this helps others .... :)

Regards,
Doug

Edit: I was wrong ... this conflict exists regardless of what post the Insert Ad After Post element of this mod places the ad. It needs to be turned OFF if you're going to use it with Abe's mod. The place INSIDE ad part works terrific for us, particularly using naisho's edits to reverse the UserGroup ID connotation from being EXCLUDED to ONLY THESE GROUPs.

digitalpoint 12-01-2010 05:22 PM

Quote:

Originally Posted by naisho (Post 2127892)
I wish this mod could accept differents ads according to forum ids.

Well it was never designed to be a full-blown ad delivery system. We *do* happen to have something for that (ability to target specific forums, along with full-blown bidding system for advertisers to bid on ad space), but's it something different... http://advertising.digitalpoint.com/publisher.php

Quote:

Originally Posted by BadgerDog (Post 2127941)
Follow up ...

For those of you running this vb4 [AJAX] Post Thank You Hack mod by Abe ...

https://vborg.vbsupport.ru/showthread.php?t=231666

There's a conflict when this mod puts it's ad as the last post. You can click the "Thanks" button but instead of the "Thanks" box appearing with your name pushing the ad down placed there by digitalpoint's mod and the "Thanks" button disappearing, all that happens is the "Thanks" button disappears as it should, but the screen jumps to the TOP of the thread.

If you scroll back down to where the ad is, you'll see that the "Thanks" button is gone, but there's no "Thanks" box with your name. The "Thanks" action did happen though and if you turn OFF the Insert Ad After Post of this ad and view the same post the "Thanks" box is there with your name but of course, the Insert Ad After Post ad which appeared after it is gone because you've turned OFF that part of this mod.

This problem seems to only happen when the post is the last one in the thread, at least that's what I think right now, since it doesn't happen when it places the ad after the first post, as an example.

Hope this helps others .... :)

Regards,
Doug

Edit: I was wrong ... this conflict exists regardless of what post the Insert Ad After Post element of this mod places the ad. It needs to be turned OFF if you're going to use it with Abe's mod. The place INSIDE ad part works terrific for us, particularly using naisho's edits to reverse the UserGroup ID connotation from being EXCLUDED to ONLY THESE GROUPs.

You could probably just reorder the execution order so the ad positioning one gets triggered before the other.


All times are GMT. The time now is 04:34 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01298 seconds
  • Memory Usage 1,759KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (5)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete