vb.org Archive - Add-On Releases

Page 3 of 3

Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vBulletin 3.7 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=228)

- - Add-On Releases - VBNotes (https://vborg.vbsupport.ru/showthread.php?t=177873)

Sakai Ray

06-01-2008 08:35 PM

Thank you very much

joeycano

06-02-2008 02:42 AM

Did not work for me on 3.7.1. I was not able to see the content after I entered text and pressed "Update Notes"

I just got another blank box appearing.

Also was not able to erase the box as well.

FYI: I'm using: PHP 5.2.3

Boofo

06-02-2008 02:58 AM

I just noticed the line in the first post that says "the last version was put together rather poorly". I hope you weren't referring to Chen's version.

Jafo232

06-02-2008 03:53 PM

Quote:

Originally Posted by Boofo (Post 1538330)

I just noticed the line in the first post that says "the last version was put together rather poorly". I hope you weren't referring to Chen's version.

I was..

The last version as I recall was set up where each user had a row in the vbnotes table. All of the users messages were in ONE row, parsed by something like |||. In otherwords:

Code:

$usernotes = preg_split("/\|\|\|/",$row);

I cannot remember the exact delimiter but that was basically how it went. Sorry, but I think that is a poor design. Each note should have its own row. That is pretty much the point of using SQL. Chen was using the row as if it were a flat file.

It has been a bit since I worked on it, but I recall there were other issues as well.

Boofo

06-02-2008 05:52 PM

His also had a list where you could choose the note and not a separate box for each one, if I recall. If Chen did it that way, then he had to have a good reason. His code is excellent. ;)

Jafo232

06-02-2008 06:26 PM

Quote:

Originally Posted by Boofo (Post 1538992)

His also had a list where you could choose the note and not a separate box for each one, if I recall. If Chen did it that way, then he had to have a good reason. His code is excellent. ;)

Well, hopefully you do not consider this excellent:

Code:

$DB_site->query_first("SELECT lastupdated FROM usernotepad WHERE userid='$bbuserinfo[userid]'")) {

    $note=$DB_site->query_first("SELECT * FROM usernotepad WHERE userid='$bbuserinfo[userid]'");

    $splitnotes=explode("|||",$note[notes]);

There is no reason for that whatsoever.

Not to mention he includes global.php numerous times. I have attached the only file I could find left of it (they have been deleted from chens thread). :p

Of course, this code is about 7 years old, and I know if you looked at mine from that long ago, it would probably not be much better.

Boofo

06-02-2008 06:49 PM

At the time, that was considered top of the line coding. vb has come a long way since then. If ol' Chen was around today I think he would still be able to blow us all away with his knowledge. ;)

Do you have any plans on doing the listing of the notes like he did instead of separate boxes? I might be interested in that.

Jafo232

06-02-2008 07:35 PM

From the hack I saw, it was already in separate boxes. Like I said originally, I basically was just charged to copy it exactly as it was working.

Boofo

06-02-2008 07:52 PM

No, he had it as a listing that would bring up a box for the said note when you clicked on the link. The way you are doing it would make for one long page if you have enough notes.

Supramania

06-02-2008 08:35 PM

Just installed on 3.7.1 - seems to work perfectly. Thanks!

All times are GMT. The time now is 12:54 PM.

Page 3 of 3

Show 40 post(s) from this thread on one page

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01123 seconds Memory Usage 1,738KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (2)bbcode_code_printable (2)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (2)pagenav_pagelink (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: