vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   Modification Graveyard (https://vborg.vbsupport.ru/forumdisplay.php?f=224)
-   -   New Posting Features - vbPostCheck - Warn if someone posted while you were typing (https://vborg.vbsupport.ru/showthread.php?t=144015)

MThornback 04-05-2007 12:39 AM

You are brilliant *installed*

MThornback 04-05-2007 12:45 AM

Quote:

Originally Posted by hambil (Post 1219869)
No - 5 stars not 1 star! I hit the wrong button...

Hopefully someone will wander along and fix it for me.

In the meantime, er, welcome to my lastest hack :D

I did that too...sorry Hambil :(

hambil 04-05-2007 02:09 AM

Damn you Thorn in my Back!!! :D I'll accept a MOTM nomination in repayment :p

Milad 04-05-2007 03:37 AM

I think your hack contains XSS issue, you use $_REQUEST in the HTML without any check, this opens a security hole.

hambil 04-05-2007 03:50 AM

Quote:

Originally Posted by Milad (Post 1220123)
I think your hack contains XSS issue, you use $_REQUEST in the HTML without any check, this opens a security hole.

I change the code to run $_REQUEST['t'] through the cleanup process. Other than that no security issue should exist, since I'm only reloading request and post information, not using it in anyway.

Rat1972 04-05-2007 05:03 AM

Quote:

Originally Posted by hambil (Post 1220085)
Damn you Thorn in my Back!!! :D I'll accept a MOTM nomination in repayment :p

i asked for this mod a week or two ago and now its here. Ofcourse i will nominate it ;) and ofcourse the five stars.
I hope in the future it will also work with quick reply, but that isnt a must. I am glad with this one!

Good work!

Click install

bashy 04-05-2007 05:06 AM

I only added to the phrase nothing that could have added that extra code, i didnt touch any template!?

It warned me about the last post being made, but when i went to review it it was not the last post it was the post before the last post!

Quote:

Originally Posted by hambil (Post 1219946)
I don't understand - sorry. It looks like you edited the template or the phrase, and that's where the odd characters are coming from on the warning message.

As for the last post/not last post, could you explain better, please?


hambil 04-05-2007 07:41 AM

Quote:

Originally Posted by bashy (Post 1220155)
I only added to the phrase nothing that could have added that extra code, i didnt touch any template!?

It warned me about the last post being made, but when i went to review it it was not the last post it was the post before the last post!

It checks to see if any posts have been made since you started your post. There could be more than one.

I might consider complicating the query a bit, and providing some varied phrasing. e.g. "A new reply" and "x new replies".

I'll look into the quick reply at the same time. If I do it, I'll make it off by default and admin settable. I can speak only for myself but if I'm using quick reply I don't want a bunch of checks and stuff slowing me down and asking me questions. That's why I using quick reply ;)

Dismounted 04-05-2007 08:32 AM

Damn! You stole my idea :(, I was in the process of making this. Oh well. But I have a solution to make it work with quick reply :).

hambil 04-05-2007 09:13 AM

It's not an issue of making it work with quickreply. I chose not to. However, I'll probably make it optional in the next release.


All times are GMT. The time now is 01:59 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01120 seconds
  • Memory Usage 1,739KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (5)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete