vb.org Archive - [RELEASE vB2.0] quick 'who posted'

Page 3 of 8

Last »

Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vBulletin 2.x Full Releases (https://vborg.vbsupport.ru/forumdisplay.php?f=4)

- - [RELEASE vB2.0] quick 'who posted' (https://vborg.vbsupport.ru/showthread.php?t=10707)

03-22-2001 03:52 PM

hmm it didn't work nothing no indicator of who subscribed showed up ?

03-22-2001 09:28 PM

oops... you should add $subscribed to your templates... not $subscribe. Sorry.

03-22-2001 10:50 PM

thanks Kier for the change, will do it on next upgrade. cheers.

03-23-2001 01:11 AM

great hack kier.

Just a couple of comments:

1. General comment to all: with regards to the $subscribed thingy, bear in mind that this is a serious invasion of privacy. And, unlike the "who is online", where you allow users to opt out, in adding this $subscrived thingy to the hack you are not allowing anyone any opt-out option.

2. Kier, I LOVE your hacks so please take my following comment as a constructive one: you do not follow strict php coding, which makes it immensely hard to debug a code that consists of your code and others.

Could you perhaps make sure you always use { and } for the ifs and elses? I think in a code made public, strict and global coding guidelines are imperative.

Anyhow, again, thanks for yet another great hack.

Cheers,

Bira

03-23-2001 01:45 AM

Quote:

2. Kier, I LOVE your hacks so please take my following comment as a constructive one: you do not follow strict php coding, which makes it immensely hard to debug a code that consists of your code and others.

Could you perhaps make sure you always use { and } for the ifs and elses? I think in a code made public, strict and global coding guidelines are imperative.

Bira there is no "strict php coding" rulebook that says one must enclose if/then segments withing curly braces. Without curly braces the compiler will only process the first following line for inclusion in the if/then. It is perfectly valid code.

i.e.

Code:

if ($x)

  if ($y)

    if ($z)

      echo "YES";

is the same as and as valid as

Code:

if ($x) {

  if ($y) {

    if ($z) {

      echo "YES";

    }

  }

}

03-23-2001 02:42 AM

This hack is great, but it has a flaw. When you do a search, say for the new posts, or any search for that matter, it does not have the hack in it. I am sure it's a simple bit of code editing but I am just toO damn lazy to look into it...

Lordmusic

03-23-2001 02:44 AM

Quote:

Originally posted by bira
unlike the "who is online", where you allow users to opt out, in adding this $subscrived thingy to the hack you are not allowing anyone any opt-out option.

Okay, if you want to allow users to opt-out, we'll use the invisible setting, so that 'invisible' users don't have their subscriptions shown:

Replace the query with this:

Code:

$posts = $DB_site->query("SELECT

COUNT(postid) AS posts, post.userid, user.username, user.invisible subscribethread.userid AS subuserid

FROM post LEFT JOIN user USING (userid)

LEFT JOIN subscribethread ON

  (subscribethread.threadid=post.threadid AND subscribethread.userid=user.userid)

WHERE post.threadid=\"$threadid\"

GROUP BY post.userid ORDER BY posts DESC");

then change the conditional code to this:

Code:

if ($post[userid]==$post[subuserid] && !$post[invisible]) $subscribed = " <smallfont>[subscribed]</smallfont>";

        else $subscribed = "";

All done. Privacy restored.

Quote:

make sure you always use { and } for the ifs and elses

My new PM hack will be a model of strict coding.

Quote:

Anyhow, again, thanks for yet another great hack.

Welcome.

03-23-2001 02:44 AM

Freddie,

When I have your original code, plus someone else's hack, plus Kier, etc - if the style of coding is not unified, it makes it damn hard to debug if there's a mistake somewhere or a missing curly.

I am not saying this won't work - fact is it does - I am merely asking if possible that hackers restrict themselves to the same "full" (for lack of better word) coding.

03-23-2001 03:47 AM

Quote:

Originally posted by Lordmusic
This hack is great, but it has a flaw. When you do a search, say for the new posts, or any search for that matter, it does not have the hack in it. I am sure it's a simple bit of code editing but I am just toO damn lazy to look into it...

Lordmusic

This would be a simple template edit.

03-23-2001 04:37 AM

A great hack!

A couple of suggestions:

At the bottom of the pop-up box allow the user to click to go the actual thread and to close the window. [you can probably do these in a blink of an eye but I thgout I'd suggest it]

Again, great work!

All times are GMT. The time now is 07:06 PM.

Page 3 of 8

Last »

Show 40 post(s) from this thread on one page

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01241 seconds Memory Usage 1,739KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (4)bbcode_code_printable (5)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: