vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.5 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=113)
-   -   Threaded Forum Views (https://vborg.vbsupport.ru/showthread.php?t=101407)

Maryanninva 02-18-2006 04:43 PM

Hi! I was curious if this has been tested in 3.5.3? I'd like to install it on my forums, but don't want to blow anything up! :)

Thanks!

Maryanninva 02-22-2006 10:28 PM

Quote:

Originally Posted by Maryanninva
Hi! I was curious if this has been tested in 3.5.3? I'd like to install it on my forums, but don't want to blow anything up! :)

Thanks!

Has anyone tried this with 3.5.3? I moved my forums from a fully-threaded site to vB and some of the users are hoping this hack will work (and becoming impatient with me). TIA!

tgmorris 02-22-2006 10:56 PM

Quote:

Originally Posted by Maryanninva
Has anyone tried this with 3.5.3? I moved my forums from a fully-threaded site to vB and some of the users are hoping this hack will work (and becoming impatient with me). TIA!

It runs fine on 3.5.2 so I would think it would be OK on 3.5.3 or 3.5.4. However some of the templates may have changed so it would be wise to make the changes on a test forum first to validate everything. The coding changes should be pretty straightforward.

As always the first thing would be to compare the files with the changes in them between the last known version this was for and the planned version. If those files haven't changed then you should be pretty good to go.

The gotcha regarding the default values getting set was supposed to be fixed by vb in the 3.5.3 release so that at least shouldn't be a worry.

Maryanninva 02-23-2006 04:06 AM

Thanks so much.

It appears that much of code is the same, though some are on different lines than what's in the instructions. If I get it working, I'll post back in case anyone else is wondering.

Surfer 03-13-2006 09:15 AM

Quote:

Originally Posted by Kaitlyn
I have noticed one issue, I haven't quite figured out why it's an issue, but I have a way around it.

If you notice that once it's installed that every post appears to be 'new', this bit will fix the problem. I'll have it included in the next update, as well as moving a bit more of the legacy code to the updated methods.

-K

In includes/functions_threadedmode.php

Find:
Code:

$post['statusicon'] = iif($post['dateline'] > $threadinfo['threadview'], 1, 0);
Replace With:
Code:

//THREADS
$post['statusicon'] = iif($post['dateline'] > $vbulletin->userinfo['lastvisit'], 1, 0);
//THREADS



Doesn't this mean that the new post icon is still showing as new even though you have read the post? With the above modification you will need to login again to make them unread...

Any ideas?

Thanks

Kaitlyn 03-21-2006 04:58 PM

Hopefully I'll get a chance to rework it a bit, and add some stuff tg gave me for an update for 3.5.4 *crosses fingers*

Quote:

Doesn't this mean that the new post icon is still showing as new even though you have read the post? With the above modification you will need to login again to make them unread...
It... does and it dosen't. For some reason, which I have not delved that deeply into, without making the change all posts show up as new, and I mean all of them, and like, forever. The change I added in there doesn't require a logoff, simply a new session so, they'll remain new for that visit and the next time it checks for a last visit, which would be say ya left to do some other things then came back, it will mark those read or not.

It actually works pretty well, at least for me and I've never had any complains, and everything being new all the time was a real downer. When I'll have time I'll have to go through and really find out why $threadinfo['threadview'] dosen't seem to work right with the rest of the hack, but considering how well it works with that change, it's somewhat low on my priority list. Hope that helps!

-K

Surfer 03-30-2006 06:35 AM

Thanks for your reply. I will try and fix this bug.

On another note, I have found another bug. If you have an old thread and bump it by adding a new post only the last post will be visable in the threaded forum view and not the entire thread. It should be the full thread!

Any ideas?

thanks

Surfer 04-11-2006 12:06 PM

hello, just wondering if there has been made any further improvement to this hack? such as deleted threads etc... ?

Thanks

uhnd 05-20-2006 02:03 AM

I have been trying to install this mod onto a fresh copy of 3.5.4. I was editing the FORUMDISPLAY template, and I added:

Code:

<if condition="TFVENABLE=='Disable'">
immediately following the following line:

Code:

$announcebits
However, when I tried to save the template, it generated the following error:

The following error occurred when attempting to evaluate this template:

Code:

Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /data/sites/26657/forum.uhnd.com/www/includes/adminfunctions_template.php(3537) : eval()'d code on line 41

This is likely caused by a malformed conditional statement. It is highly recommended that you fix this error before continuing, but you may continue as-is if you wish.


I'm just wondering if this means anything to anyone? If I add just a new variable, say "$test", then I can save the template. So it doesn't look like it's a problem with my adminfunctions_template.php file. Any suggestions?

uhnd 05-20-2006 02:04 AM

Here's that error message again in a little more legible format... hopefully:

Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /data/sites/26657/forum.uhnd.com/www/includes/adminfunctions_template.php(3537) : eval()'d code on line 41

This is likely caused by a malformed conditional statement. It is highly recommended that you fix this error before continuing, but you may continue as-is if you wish.


All times are GMT. The time now is 02:07 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01117 seconds
  • Memory Usage 1,746KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (5)bbcode_code_printable
  • (4)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete