For your information: I'm currently working on a new version, that will fix the button issue in standard editor mode an will also add an optional button at the bottom next to the autosave restore button.

Some issues remain, and I'll go back through the posts for bugs to look at, but if you have unreported issues, now would be a good time to tell me ;)

Be glad to beta it for you.. I for one like it

I've found several issues with Cel_PhotoPopup version 4.1.002 on vBulletin v4.1.10. Basically class methods/variables are being called without first attaching them to the $this-> instance.

In cel_pp_class_photopost.php, On or about Line 192 (very near end of file):

Was: $img['med'] = $img['orig'];
Fixed: $this->img['med'] = $this->img['orig'];

In cel_pp_class.php, On or about Line 109 (part of function set_choice_by_get()):

Was: $get_album = FALSE;
Fixed: $this->get_album = FALSE;

While I could locate the cause of the above issues and correct them, there is another issue that I have had to make a real hack of a fix for because I can not identify what is causing the page to generate an Error 500 (Server Error) unless at least a single byte is printed by a certain point in photo_popup.php. Around line 204 I had to add the following line of code: echo chr(0); in order to prevent the Server Error 500. With that single null byte printed to the browser HTTP headers are sent and everything works as it should (save for the preceding code fixes), but without nothing is *ever* sent to the browser and the server throws a 500 Server Error and PHP logs the error as "premature end of script headers".

I can not locate anything site specific (like Apache or PHP configurations) that would cause a timeout to occur if headers were not sent in under 1-2 seconds (about the longest possible wait) but it nonetheless behaves a lot like a timeout condition and it is 100% repeatable with absolute certainty -- if at least one byte is not sent to the browser (to trigger PHP sending the headers) by a certain point in the PHP code a 500 Server Error will occur each and every time.

Despite my best efforts, I have not been able to figure out why this hack is necessary to make things work.

If these issues have already been reported and fixed, please accept my apologies. I wanted to report my findings so as to ensure that you were aware of the issues I found so that the fixes could be incorporated into the next official release.

Thank you for your time and efforts in this regard.

Thanks for your reports; I have corrected the two code bugs you reported. Regarding the server error, however, I have never witnessed this myself or had any reports on it. I really don't have an idea either what could cause this or what I could to to try to reproduce it...

Damn, have that @!$?& button under the editor working in IE and FF, but Chrome won't show it. Boy, do I hate Javascript... ;)

New Version: 4.1.004

Highlights:

• This version fixes several bugs, among them the greyed out button in code mode)
• the much requested, better visible text-button is back. It can be turned on and off via a new AdminCP setting, same for the old toolbar icons. See:

• if you are on vB 4.1.10, remove your setting for the seperator - this is obsolete. CKE no longer trims the whitespace Photo Popup inserts by default.

Full list of changes (the leading number refers to posts in this thread):

• #225 [added] suggestion for button under the editor (tested with FF 10, IE 9, Chrome 17)
• #--- [added] AdminCP settings for toolbar and new bottom-button
• #--- [added] code of major plugins moved to file system for better overall performance
• #211 [fixed] Added getBaseUrl() to window.open in plugin.js in order to provide for multi-directory installations (provided in #214)
• #215 [fixed] bug when using MySQLi in photo_popup.php, line 322 (fix provided by snoopytas in #215)
• #224 [fixed] editor button no longer greyed out/inactive in code mode
• #253 [fixed] code bugs
• #229 [can't reproduce] dropdown to choose albums not working (tested in 4.1.10)
• #205 [not a bug] inserting image leads to black font color go white, caused by the placeholder between images (see ##207, 208, 209, also functionality obsolete)
• #246 [not a bug] dark text in dropdowns, bad for black bg (the background and text colors in the dropdowns do follow the "input_"-style variables correctly in 4.1.10)
• #212 [ok] Check compatibility with PhotoPost 8 (tested with vB 4.1.10 and PP 8.0 Gold)
• #--- [obsolete] Add seperator between images feature obsolete, may be removed in future versions

New install VB 4.1.10 & 4.1.004 Using IE9 I am not getting a button image but rather just a grey block as reported in prior posts. The grey is clickable and the modification works. Would just like to see a button :)

Thanx!!!

Huh, that shouldn't be the case, of course ;)
I'll look into it over the weekend.

Had a quick look: I see the icon on IE9, just as in any other browser:

Attachment 136537

Please make sure you have uploaded the icon file correctly. If you use a custom style that uses a custom folder for images, make sure to upload the icon image file to a subfolder named cel in the directory the style uses for buttons. Probably [customstyleimages]/buttons/cel/cel_photo_popup.png.

You right, I'm wrong... Completely forgot about custom style... Still did not get it to show but it is just a matter of figuring out the proper directory structure, the one given did not work.

Also, do you have a mouse over tool tip for the camera image? I can mouse over all the buttons and get a small note but not on yours.