Thank you for this works great!!!

Hi, when this mod is used in a sub forum it makes the inline mod options stop working

Same here, i cant seem to use the option to select all threads...

Has anyone been able to isolate where the inline mod issue is?

Yes! See post above: https://vborg.vbsupport.ru/showpost....&postcount=236

Thanks for this!

Works fine Cheers !

Only problem with this solution is that it generates html that won't validate because you have a div as a direct descendant of a ul tag.

To fix the in-line mod selection problem and have valid xhtml you need to make three changes to your vbulletin-core.js file. No changes are actually required to the plugin itself.

The problem is that the JavaScript that's checking and un-checking the checkboxes from the inline mod menu does not check if there actually is a checkbox before trying to work with the checkbox.

I'll put the changes for those using both the compressed and uncompressed JavaScript.

Uncompressed javascript make the following changes in order otherwise the line numbers will not match up with what I have listed here:

1. On line 2761 change:
   
   Code:

   ---

   if (this.collection[i].checkbox.checked)

   ---

   to
   
   Code:

   ---

   if (this.collection[i].checkbox && this.collection[i].checkbox.checked)

   ---

2. On line 2889, nest the switch statement in an if statement as follows:
   
   Code:

   ---

           switch (action[1])
        {
                case "invert": {

                        this.checkbox.checked = !this.checkbox.checked;
                }
                break;
                case "none": {

                        this.checkbox.checked = false;
                }
                break;

                case "class":
                {
                        this.checkbox.checked = YAHOO.util.Dom.hasClass(this.container, action[2]);
                }
                break;
                case "flag":
                {
                        if (typeof action[2] != undefined && !isNaN(action[2]))
                        {
                                this.checkbox.checked = this.checkbox.value & action[2];
                        }
                        else
                        {
                                this.checkbox.checked = true;
                        }
                }
                break;
                default:
                case "all": {

                        this.checkbox.checked = true;
                }
                break;
        }

   ---

   to
   
   Code:

   ---

           if(this.checkbox)
        {
                switch (action[1])
                {
                        case "invert": {

                                this.checkbox.checked = !this.checkbox.checked;
                        }
                        break;
                        case "none": {

                                this.checkbox.checked = false;
                        }
                        break;

                        case "class":
                        {
                                this.checkbox.checked = YAHOO.util.Dom.hasClass(this.container, action[2]);
                        }
                        break;
                        case "flag":
                        {
                                if (typeof action[2] != undefined && !isNaN(action[2]))
                                {
                                        this.checkbox.checked = this.checkbox.value & action[2];
                                }
                                else
                                {
                                        this.checkbox.checked = true;
                                }
                        }
                        break;
                        default:
                        case "all": {

                                this.checkbox.checked = true;
                        }
                        break;
                }
      }

   ---

3. On line 2941 wrap the content of three lines of code in an if statement as follows:
   
   
   Code:

   ---

           var func = (this.checkbox.checked ? "addClass" : "removeClass");
        YAHOO.util.Dom[func](this.container, "imod_highlight");
        console.log("Set Inlinemod State for %s - %s", this.itemid, func);

   ---

   to
   
   Code:

   ---

           if(this.checkbox)
        {
                var func = (this.checkbox.checked ? "addClass" : "removeClass");
                YAHOO.util.Dom[func](this.container, "imod_highlight");
                console.log("Set Inlinemod State for %s - %s", this.itemid, func);
        }

   ---

If you're using the compressed javascript then you'll need to make the following equivalent adjustments in the order listed for the column numbers to point to the correct location in the file:

1. At column 32267 add:
   
   Code:

   ---

   this.collection[A].checkbox&&

   ---

2. At column 34118 add:
   
   Code:

   ---

   if(this.checkbox){

   ---

3. At column 34531 add a close swiggly bracket:
   
   Code:

   ---

   }

   ---

4. At column 34780 add:
   
   Code:

   ---

   if(this.checkbox){

   ---

5. At column 34964 add a close swiggly bracket:
   
   Code:

   ---

   }

   ---

For the compressed changes, change 1 corresponds to the change 1 from the uncompressed, 2 & 3 correspond to change 2 from the uncompressed and 4 & 5 correspond to change 3 from the uncompressed javascript.

Great mod. Works on 4.1.8