vb.org Archive
Page 25 of 247 « First 152324 25 26273575125 Last »
Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.5 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=113)
-   -   Links and Downloads Manager (https://vborg.vbsupport.ru/showthread.php?t=91107)

AndrewD 10-10-2005 08:50 AM
Quote:
Originally Posted by elsupremo
Unfortunately, it's true - accepting a moderated link does not remove it from the moderation queue.

However - I just checked something, I could be wrong - but if you have anything other than "0" in the Review frequency field of the link properties, then it will stay in the moderation queue. So, if you want the entries gone, put "0" in that field and it will be gone.

David
OK, will investigate - I wish software didn't take on a life of its own!!

AndrewD 10-10-2005 03:15 PM
Quote:
Originally Posted by benj
so andrew how do you get this built in media jukebox thing to work then? enabled it for mp3s added a link to an mp3 doesnt work :S any ideas :P playing atm lovin this so far man......


cheers

benj
This is indeed an interesting question.

The jukebox worked correctly through version 1.61 and that version still works correctly today. However, I find that I cannot get the version 2.0.x to work at all. I'm not sure why, as I don't think I've changed any of the code (obviously I must have). It fires up the windows media player correctly but refuses to play anything.

I wrote this as an add-on for someone who said that it was very important to him, and then decided that he didn't want it after all. I wonder - is this actually a very useful feature? If you have an mp3-aware application on your pc, then this will load and run anyway when you click on an mp3 file. I'm not sure what advantage there is to having it play inside an embedded media player running in the browser.

If anyone can give me good reasons for this feature, I'll continue to try to fix it, otherwise it seems like a feature that could be removed.

AndrewD 10-10-2005 04:15 PM
Quote:
Originally Posted by elsupremo
Unfortunately, it's true - accepting a moderated link does not remove it from the moderation queue.

However - I just checked something, I could be wrong - but if you have anything other than "0" in the Review frequency field of the link properties, then it will stay in the moderation queue. So, if you want the entries gone, put "0" in that field and it will be gone.

David
Bug confirmed. As you say, it occurs when there is a value other than zero in the review frequency field. It will be fixed in 2.0.6, but in the meantime, if this is urgent, the fix in version 2.0.5 is as follows.

Edit local_links.php. Go to line 1881 to 1893, which read as follows:

Code:
        if ($submit == 'submit') {

                if ($statuscheck == $LINK_NO_ACCESS) {
                        $err = $vbphrase['ll_error_protocol'].' '.$linkurl.' <a href='.$url.'><b>'.$vbphrase['ll_return'].'</b></a>';
                        eval(standard_error($err));
                        exit;
                } elseif ($statuscheck == $LINK_NO_REMOTE_DOWNLOADS) {
                        $err = $vbphrase['ll_error_remote'].' '.$linkurl.'. <a href='.$url.'><b>'.$vbphrase['ll_return'].'</b></a>';
                        eval(standard_error($err));
                        exit;
                }

                $statustime = TIMENOW;
Move line 1893
Code:
                $statustime = TIMENOW;
immediately before 1881, ie just before the if test, so that the code reads as follows:
Code:
        $statustime = TIMENOW;
        if ($submit == 'submit') {

                if ($statuscheck == $LINK_NO_ACCESS) {
                        $err = $vbphrase['ll_error_protocol'].' '.$linkurl.' <a href='.$url.'><b>'.$vbphrase['ll_return'].'</b></a>';
                        eval(standard_error($err));
                        exit;
                } elseif ($statuscheck == $LINK_NO_REMOTE_DOWNLOADS) {
                        $err = $vbphrase['ll_error_remote'].' '.$linkurl.'. <a href='.$url.'><b>'.$vbphrase['ll_return'].'</b></a>';
                        eval(standard_error($err));
                        exit;
                }

Boofo 10-10-2005 04:21 PM
My version 2.0.5 already reads like the fix.

AndrewD 10-10-2005 05:14 PM
Quote:
Originally Posted by Boofo
My version 2.0.5 already reads like the fix.
Check again! I've just looked at the code sitting on this site and it reads as I said. It's a subtle change - just moving one line up a dozen lines.

elsupremo 10-10-2005 06:45 PM
Quote:
Originally Posted by AndrewD
This is indeed an interesting question.

The jukebox worked correctly through version 1.61 and that version still works correctly today. However, I find that I cannot get the version 2.0.x to work at all. I'm not sure why, as I don't think I've changed any of the code (obviously I must have). It fires up the windows media player correctly but refuses to play anything.

I wrote this as an add-on for someone who said that it was very important to him, and then decided that he didn't want it after all. I wonder - is this actually a very useful feature? If you have an mp3-aware application on your pc, then this will load and run anyway when you click on an mp3 file. I'm not sure what advantage there is to having it play inside an embedded media player running in the browser.

If anyone can give me good reasons for this feature, I'll continue to try to fix it, otherwise it seems like a feature that could be removed.

When I tried this feature recently, it worked approximately 1/20 times. My point here is that it does work on occasion, although I am not sure what is the variable that allows it to work or not.

I do not see a very important reason for this function to remain. I believe there are better "jukebox" modifications out there made expressly for that purpose.

Boofo 10-10-2005 07:51 PM
Quote:
Originally Posted by AndrewD
Check again! I've just looked at the code sitting on this site and it reads as I said. It's a subtle change - just moving one line up a dozen lines.
I know, sir. I've checked it over and over again and it is already fixed in the version I have. ;)

elsupremo 10-10-2005 08:38 PM
Quote:
Originally Posted by Boofo
I know, sir. I've checked it over and over again and it is already fixed in the version I have. ;)
Lol, this is a funny one. :)

Benj 10-10-2005 10:53 PM
Quote:
Originally Posted by AndrewD
This is indeed an interesting question.

The jukebox worked correctly through version 1.61 and that version still works correctly today. However, I find that I cannot get the version 2.0.x to work at all. I'm not sure why, as I don't think I've changed any of the code (obviously I must have). It fires up the windows media player correctly but refuses to play anything.

I wrote this as an add-on for someone who said that it was very important to him, and then decided that he didn't want it after all. I wonder - is this actually a very useful feature? If you have an mp3-aware application on your pc, then this will load and run anyway when you click on an mp3 file. I'm not sure what advantage there is to having it play inside an embedded media player running in the browser.

If anyone can give me good reasons for this feature, I'll continue to try to fix it, otherwise it seems like a feature that could be removed.

NOOOOOOOO! Keep it i need it coz as you might remember i plan to play mp3s thru this addon. and my artists dont want people to be able to download there mp3's just stream them. i dunno if it would be possible with the media player thing / or will be possible in some other way but i was gonna make a flash player so users can only stream music from my site not download it... this is kinda crutal to my site. unless you have anyother ideas that is :rolleyes: :D


cheers andrew

AndrewD 10-11-2005 03:58 AM
Quote:
Originally Posted by Boofo
I know, sir. I've checked it over and over again and it is already fixed in the version I have. ;)
Now I understand. I broke this between the beta 2.0.5 and the final 2.0.5. You must have got the beta code installed.


All times are GMT. The time now is 03:09 PM.
Page 25 of 247 « First 152324 25 26273575125 Last »
Show 40 post(s) from this thread on one page

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02590 seconds
  • Memory Usage 1,761KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (3)bbcode_code_printable
  • (9)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (4)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete