![]() |
Quote:
Code:
<!--This is my comment--> Code:
<!-- This is my comment --> |
thats all i had to do.. and it solved issues with the scripts
|
I played around with this a bit :)
And after talking to my co-admin (who has quite some knownledge of regular expressions) he told me to exclude <script> and other tag blocks is not possible with one RegEx, it would need additional code. Well, so I started making some code :) This I what I currently have, it gave me a "compression" ratio vom ~10% to ~15% in my tests, while leaving user input, [code] posts and JS fully intact (so far ;)) I added some comments, so you can see what is done where :) PHP Code:
|
That fixed the advanced mode bug, Hellcat, but hosed tons of other stuff on my forums. For one, the edit/quote buttons at the bottom right of posts were almost overlapped, and the breadcrumbs had no spacing at all.
A step in the right direction though, to be sure. Screenshot attached of what I'm experiencing. I'd LOVE to get this sorted out - your code, albeit buggy on my particular theme, quadrupled my compression savings. |
For reference, a screeny of my forums using my existing code, which only strips comments.
|
Hmm.... I think I know what that might cause....
If that's it it would reduce the ratio, but increase compatibility.... [high]* Hellcat starts tweaking :) [/high] [EDIT] OK, try this: In my above posted code, find theese two lines: Code:
$output = str_replace( "\n" , "" , $output ); Code:
$output = str_replace( "\n" , " " , $output ); At least I could confirm this in my last tests.... [high]* Hellcat waits for feedback now :)[/high] |
does this work with vB Drupal?
|
Quote:
There's only one way to find out ;) But it should, yes.... |
Quote:
is it supposed to take all the lines away from the source? |
and the result is: Nope it doesn't work with vb drupal...
works fine for my forums though so installed... /me clicks install |
All times are GMT. The time now is 03:50 PM. |
Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information | |
---|---|
|
|
![]() |
|
Template Usage:
Phrase Groups Available:
|
Included Files:
Hooks Called:
|