vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.5 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=113)
-   -   vRewrite - SEOed URLs for vBulletin (https://vborg.vbsupport.ru/showthread.php?t=104484)

LICryptkeeper 04-06-2006 07:32 PM

Quote:

Originally Posted by Bhuwan
I think i may have this resolved, but not sure.

please let me know when you do, other then being indexed easier I love this hack because all my ads were relevant to the thread they were in when i installed it, and I loved that :p

Bhuwan 04-06-2006 07:41 PM

Quote:

Originally Posted by LICryptkeeper
please let me know when you do, other then being indexed easier I love this hack because all my ads were relevant to the thread they were in when i installed it, and I loved that :p

That's good :)
Will release RC3 tonight

Bhuwan 04-06-2006 09:01 PM

RC3

If you don't post bugs then we assume there aren't any!

xStylezx 04-06-2006 09:29 PM

My page 2 link is still not rewriting correct.I have added other posts to the animation forum and its added a page 3 now,which also isnt rewriting correct

Code:

http://www.signyourmelonz.com/f-animated-gif-7/page2/?order=desc
Code:

http://www.signyourmelonz.com/f-animated-gif-7/page3/?order=desc

Bhuwan 04-06-2006 09:33 PM

Quote:

Originally Posted by xStylezx
My page 2 link is still not rewriting correct.I have added other posts to the animation forum and its added a page 3 now,which also isnt rewriting correct

Code:

http://www.signyourmelonz.com/f-animated-gif-7/page2/?order=desc
Code:

http://www.signyourmelonz.com/f-animated-gif-7/page3/?order=desc

htaccess issue?

xStylezx 04-06-2006 09:34 PM

I uploaded the new one you provided in the RC3 zip just a few ago.Made sure i did that,other than that i dont know

Bhuwan 04-06-2006 09:34 PM

Quote:

Originally Posted by xStylezx
My page 2 link is still not rewriting correct.I have added other posts to the animation forum and its added a page 3 now,which also isnt rewriting correct

Code:

http://www.signyourmelonz.com/f-animated-gif-7/page2/?order=desc
Code:

http://www.signyourmelonz.com/f-animated-gif-7/page3/?order=desc


if you see
and


Code:

http://www.signyourmelonz.com/f-animated-gif-7/page3.html/?order=desc

they both work fine

This shows to me that it is a htaccess issue :)

Bhuwan 04-06-2006 09:36 PM

Quote:

Originally Posted by xStylezx
I uploaded the new one you provided in the RC3 zip just a few ago.Made sure i did that,other than that i dont know

If you decide not to use .html as part of the Rewrites, then you should also remove this from the htaccess file...The htaccess providers defaults which were used for vRewrite 1.0.

Hope this helps out...

xStylezx 04-06-2006 09:37 PM

You have to view the pages with the "?order=desc" off the end of the url and then yes,they function correctly.I dont have time to dig into the .htaccess myself right now.Am i the only one experiencing this problem?Seems like other users would be having the same issues,would everyone have to edit their .htaccess or something.Im just not understanding or something.haha

xStylezx 04-06-2006 09:39 PM

Oh and ive only eliminated .html from the forum names themselves,not the threads,so that shouldnt have anything to do with the page 2 and 3 not rewriting i wouldnt think...

Bhuwan 04-06-2006 09:40 PM

Quote:

Originally Posted by xStylezx
You have to view the pages with the "?order=desc" off the end of the url and then yes,they function correctly.I dont have time to dig into the .htaccess myself right now.Am i the only one experiencing this problem?Seems like other users would be having the same issues,would everyone have to edit their .htaccess or something.Im just not understanding or something.haha

I've created a mini-hack in which it will create the htaccess file FOR YOU based on settings you set. However, it makes no sense to release a fully working copy until 1.5 is stable & final :) -- check it out though if you want.

Bhuwan 04-06-2006 09:41 PM

here's what you need to edit in htaccess

remove
Code:

RewriteRule ^f-(.*)-(.*)/page(.*).html/(.*)$ forumdisplay.php?f=$2&&page=$3%{QUERY_STRING}&is_vrewrite=yes [L]
replace it with

Code:

RewriteRule ^f-(.*)-(.*)/page(.*)/(.*)$ forumdisplay.php?f=$2&&page=$3%{QUERY_STRING}&is_vrewrite=yes [L]

xStylezx 04-06-2006 09:44 PM

Ok,ill check that hack out in a few.Hope it works as im not up to hacking around with this much today.I just looked at the htaccess and right now im not seeing why it would append that extra ?order=desc

Bhuwan 04-06-2006 09:48 PM

Quote:

Originally Posted by xStylezx
Ok,ill check that hack out in a few.Hope it works as im not up to hacking around with this much today.I just looked at the htaccess and right now im not seeing why it would append that extra ?order=desc

The ?order=desc is from vBulletin.

Check out alll vB Sites, they all have that.

xStylezx 04-06-2006 09:57 PM

yeah,i understand that.it just seems like others or at least one person would be having the same issues i am.why is everyone elses page2 and 3 rewriting appropriately and mine not.Even with the default settings,its not rewritting on my board.hmmmmm

Bhuwan 04-06-2006 10:13 PM

Quote:

Originally Posted by xStylezx
yeah,i understand that.it just seems like others or at least one person would be having the same issues i am.why is everyone elses page2 and 3 rewriting appropriately and mine not.Even with the default settings,its not rewritting on my board.hmmmmm

What do you mean not rewrting properly?

jlaine 04-06-2006 10:16 PM

Quote:

Originally Posted by Bhuwan
RC2 will be delayed by tomorrow morning, as I want to fix a bug that Tyler (Immortal) mentioned to me and some various "cosmetic" errors Jlaine reported.
Fruthermore, I am going for ice cream so i wont get started on fixes until later tonight :)!

By the way, everyone should thank Jlaine , as Jlaine reported MANY bugs/fixes to Tyler and myself. Furthermore, Jlaine risked running this hack on their LIVE board (which is very big) which helped us dramatically!

Many people have helped throughout the development of this hack but I personally want to thank Jlaine for their time

No problem at all, glad I could help you guys out through this and get some of the bugs ironed out.

:)

Bhuwan 04-06-2006 10:18 PM

Quote:

Originally Posted by jlaine
No problem at all, glad I could help you guys out through this and get some of the bugs ironed out.

:)

thx!!! :):banana:

xStylezx 04-06-2006 11:22 PM

Not rewriting properly i guess is my way of saying that i cant get to the proper url from a default install.i havent had a chance to play with the htaccess yet,there probably is a small edit that would fix this,but i dont have the time this evening until possibly real late tonight to mess around with it.On top of that i dont know alot about mod rewriting so figuring this out might take me a few weeks.haha i was just hoping to find an easier way as i dont have the time to devote at this very second....

Bhuwan 04-06-2006 11:25 PM

Quote:

Originally Posted by xStylezx
Not rewriting properly i guess is my way of saying that i cant get to the proper url from a default install.i havent had a chance to play with the htaccess yet,there probably is a small edit that would fix this,but i dont have the time this evening until possibly real late tonight to mess around with it.On top of that i dont know alot about mod rewriting so figuring this out might take me a few weeks.haha i was just hoping to find an easier way as i dont have the time to devote at this very second....

Do one thing, post your configuraiton (vBulletin admincp -> vBulletin options -> vrerwite) line for line
i'll set it up on my DEV board and create a htaccess that works
ok?I need every single option, so screen shot may be easier.

LICryptkeeper 04-07-2006 01:48 AM

AGH! Installed it and was all happy. then I could not go to page 2 of any thread (or more) I applied the fix above, then started looking at the htaccess to see if I could patch it myself. last straw was when I clicked on "new posts" and was greeted by a "page cannot be found" the url had a / at the end (new-post.html/) when i deleted it, the page displayed but with extra content on the top. (and the tables were messed up.)

Alex_ 04-07-2006 08:48 AM

Sorry if this was asked before... what do I have to do to enable rewriting in my vbadvanced portal? I want to rewrite links in the news and latest thread modules...


---
Cause of very long thread names the urls grow bigger and bigger... that might be good for SE but not for humans.
I think I will limit the name length to 5-10 chars or so... perhaps you want to make it a feature ;)

Renada 04-07-2006 10:57 AM

Hi,

I have AmyKhar's "Expanded Get New Posts" hack installed and this seems to cause a problem with the vRewrite.

It appears to work for minutes and hours but if you click "4 days" it looks like this. (see attachment)

Any ideas?

Regards
Renada

Bhuwan 04-07-2006 11:12 AM

Quote:

Originally Posted by Renada
Hi,

I have AmyKhar's "Expanded Get New Posts" hack installed and this seems to cause a problem with the vRewrite.

It appears to work for minutes and hours but if you click "4 days" it looks like this. (see attachment)

Any ideas?

Regards
Renada

oops.
Load up your global_complete hook OR load up the complete XML file and
search for

Code:

echo($fname . '<br>');


and delete it



Bhuwan 04-07-2006 11:13 AM

Quote:

Originally Posted by Alex_
Sorry if this was asked before... what do I have to do to enable rewriting in my vbadvanced portal? I want to rewrite links in the news and latest thread modules...


---
Cause of very long thread names the urls grow bigger and bigger... that might be good for SE but not for humans.
I think I will limit the name length to 5-10 chars or so... perhaps you want to make it a feature ;)

Thread name limitation can be very easily applied, espeically since you could use vBulletin's build-in functionality.

Bhuwan 04-07-2006 11:13 AM

Quote:

Originally Posted by LICryptkeeper
AGH! Installed it and was all happy. then I could not go to page 2 of any thread (or more) I applied the fix above, then started looking at the htaccess to see if I could patch it myself. last straw was when I clicked on "new posts" and was greeted by a "page cannot be found" the url had a / at the end (new-post.html/) when i deleted it, the page displayed but with extra content on the top. (and the tables were messed up.)

Can you post your setttings? (/admincp/options.php -> vRewrite) take a screen shot ...

Bhuwan 04-07-2006 12:18 PM

Quote:

Originally Posted by LICryptkeeper
AGH! Installed it and was all happy. then I could not go to page 2 of any thread (or more) I applied the fix above, then started looking at the htaccess to see if I could patch it myself. last straw was when I clicked on "new posts" and was greeted by a "page cannot be found" the url had a / at the end (new-post.html/) when i deleted it, the page displayed but with extra content on the top. (and the tables were messed up.)

Trythe new htaccess generator (0.2) to create the correct htaccess file based on settings you've set.

Renada 04-07-2006 12:23 PM

Quote:

Originally Posted by Bhuwan
oops.
Load up your global_complete hook OR load up the complete XML file and
search for

Code:

echo($fname . '<br>');


and delete it



Hi Bhuwan,

That cured the forums showing up in a list top left but now the only thing that works is "new posts today".

Also I have this hack installed: Super Display Suite but when clicking on a name that uses this hack the script displays in the URL

Code:

http://thinkstop.com/community2/forums/u--var-scolorff6699-var-a_speed120-var-shimmercountshimmercount1-evalvar-shimmerspeed-shimmercount-a_speed-evalvar-shimmercolor-shimmercount-scolor-documentwrite-freddie-35.html
This happens to all names except mine (me being user 1)

Regards,
Renada

Bhuwan 04-07-2006 12:27 PM

Quote:

Originally Posted by Renada
Hi Bhuwan,

That cured the forums showing up in a list top left but now the only thing that works is "new posts today".

Also I have this hack installed: Super Display Suite but when clicking on a name that uses this hack the script displays in the URL

Code:

http://thinkstop.com/community2/forums/u--var-scolorff6699-var-a_speed120-var-shimmercountshimmercount1-evalvar-shimmerspeed-shimmercount-a_speed-evalvar-shimmercolor-shimmercount-scolor-documentwrite-freddie-35.html
This happens to all names except mine (me being user 1)

Regards,
Renada

didn't you already report this as a bug? :-) ...nevertheless, I will ONLY make tvRewrite compatable with other HACKS once i am certain that 1.5 is stable....then we'll addcompatabilit :)

LICryptkeeper 04-07-2006 01:29 PM

I get this when i perform searches (new posts) this happens even when I turn OFF "rewrite searches" in admincp. I'll try the suggestion you gave renada

ALL my settings are default in admincp exept for "on" and "searches off"

also I noteced, inside forums, it's rewritten with a / at the end (t-forumname-01.html/)

Bhuwan 04-07-2006 01:33 PM

Quote:

Originally Posted by LICryptkeeper
I get this when i perform searches (new posts) this happens even when I turn OFF "rewrite searches" in admincp. I'll try the suggestion you gave renada

ALL my settings are default in admincp exept for "on" and "searches off"

also I noteced, inside forums, it's rewritten with a / at the end (t-forumname-01.html/)

forums part you can disable (i.e. remove the "/")

i posted a fix for the additioanl text ons earches (i left an echo statement).

be careful when changing settings as u have toupdate the .htaccess file also.

LICryptkeeper 04-07-2006 01:51 PM

all fixed. hope thers no more errors ;)

Alex_ 04-07-2006 04:28 PM

Quote:

Originally Posted by Bhuwan
Thread name limitation can be very easily applied, espeically since you could use vBulletin's build-in functionality.

No no, I do not mean limiting the allowed thread title length but the length of the name in the url. Cause rewriting only depends on the id in the url I think I will strip an url from blar-blar-blar-blar-12.html down to blar-12.html (first X chars of the title)

Bhuwan 04-07-2006 04:30 PM

Quote:

Originally Posted by Alex_
Nono, I do not mean limiting the allowed thread title length but the length of the name in the url. Cause rewriting only depends on the id in the url I think I will strip an url from blar-blar-blar-blar-12.html down to blar-12.html (first X chars of the title)

Thats what i mean -- it can be done very easily.

jdingman 04-07-2006 05:43 PM

I found a new bug too. When a user creates a username with a space in it, it creates the html file -###.html instead of user name-###.html. Is there a way to sanitize that so it doesn't break and leave out the username?

Bhuwan 04-07-2006 05:49 PM

Quote:

Originally Posted by jdingman
I found a new bug too. When a user creates a username with a space in it, it creates the html file -###.html instead of user name-###.html. Is there a way to sanitize that so it doesn't break and leave out the username?

This is NOT a bug and the code is WORKING as designed...


HOWEVER, if you really wanted to keep the space... you could do this
in the xml file search for (there should be two instances of it):
Code:

$txt = str_replace(' ', '-', $txt);


<b>And replace it with </b>
Code:

//$txt = str_replace(' ', '-', $txt);

But if a user enters a space in the thread name (or forum name for that matter), it won't be replaced with a "-"
SO a thread name with "this is my thread" (t = 82) would be replaced as
"this is my thread-82.html" as opposed to "this-is-my-thread-82.html"


From a SEO stand point, how does it make a difference whether you keep the space or replace it with a "-"?
I am no expert, but I think this is irrelevent.
Furthermore, if I am not mistaken, the browser would replace the space with a %20

jdingman 04-07-2006 06:35 PM

The problem actually happening, is that it shows /member/-###.html instead of showing the username at all. It's not displaying ANYTHING for the username. Is that how it's supposed to work?

Bhuwan 04-07-2006 06:37 PM

Quote:

Originally Posted by jdingman
The problem actually happening, is that it shows /member/-###.html instead of showing the username at all. It's not displaying ANYTHING for the username. Is that how it's supposed to work?

Is that for every user name or just th eusername with a space? is it on forumhome or a thread?

jdingman 04-07-2006 06:52 PM

it's actually just happening with that ONE username, being displayed on the homepage. I'm using the 'all the latest visitors that were here in the last 24 hours'. the other usernames work just fine, if they don't have spaces, but this one breaks.

Also, do you have plans in rewriting the memberlist.php pages or somehow making it easier for search engines to find all the member profiles? I haven't been able to get a working sitemap with all the rewritten pages yet...

Bhuwan 04-07-2006 06:54 PM

Quote:

Originally Posted by jdingman
it's actually just happening with that ONE username, being displayed on the homepage. I'm using the 'all the latest visitors that were here in the last 24 hours'. the other usernames work just fine, if they don't have spaces, but this one breaks.

Also, do you have plans in rewriting the memberlist.php pages or somehow making it easier for search engines to find all the member profiles? I haven't been able to get a working sitemap with all the rewritten pages yet...

This seems more like a noncompatability issue than a bug. I'll take a look at making it compatable once 1.5 is stable :)

I configured vBSEO sitemap to write urls for vrewrite.


All times are GMT. The time now is 09:32 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02776 seconds
  • Memory Usage 1,862KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (16)bbcode_code_printable
  • (23)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (2)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete