vb.org Archive - Show Thread Enhancements

Page 24 of 44

Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- Modification Graveyard (https://vborg.vbsupport.ru/forumdisplay.php?f=224)

- - Show Thread Enhancements - Who has read a Thread (https://vborg.vbsupport.ru/showthread.php?t=230736)

Marv	12-20-2010 01:09 PM

Quote:

Originally Posted by BadgerDog (Post 2136809)

I'm not sure what I'm missing and I apologize if I don't understand what you're saying, but it appears that all the user screens are accessible using Google Web Cache search, regardless of the AdminCP settings or when they were added? :confused:

I double and triplechecked that for me and can?t confirm what you are experiencing. Could it be that you have set a login for the GoogleBot you may be have forgotten about? Happend to me in the past and resulted in an ugly reminder like that ;)

BadgerDog

12-20-2010 01:26 PM

Quote:

Originally Posted by Marv (Post 2136817)

Hmmm... not sure ... :confused:

I do use Google Analytics and to do so, I had to paste code into the footer...

Code:

<script src="http://www.google-analytics.com/urchin.js" type="text/javascript">

</script>

<script type="text/javascript">

_uacct = "xxxxxxxxxxx";

urchinTracker();

</script>

Is that what you're referring to? :)

You can see from the pics I posted that the List of Threads Viewed by xxx do appear in Google CSE searches ...

Thanks for the feedback Marv... :)

Regards,
Doug

Marv	12-20-2010 01:37 PM

To be honest, I can´t recall wether it was Analytics or AdSense. In one of both you could set a login for their bots to crawl sites in the way registered users see it. I guess it was AdSense but I´m not sure. Guess you have to look into your settings there.

BadgerDog

12-20-2010 01:55 PM

Quote:

Originally Posted by Marv (Post 2136826)

To be honest, I can?t recall wether it was Analytics or AdSense. In one of both you could set a login for their bots to crawl sites in the way registered users see it. I guess it was AdSense but I?m not sure. Guess you have to look into your settings there.

Interesting ... :)

I use Adsense as well, but I don't remember giving them that privilege, but I'll check it Marv ... :up:

Although, even if they were just a registered user, that class of usergroup doesn't have permissions to access this mod's screens.

Thanks again ...

Regards,
Doug

Paul M

12-20-2010 02:36 PM

I have looked into this more deeply this afternoon and confirmed there is an issue within the code.

In short - if you have the "Allow Thread Author" option enabled, a bug within the code will allow guests to bypass the permission check on the viewuser page. The workaround [until its fixed] is to disable that option.

BadgerDog

12-20-2010 03:25 PM

Thank you so much Paul .... :)

I will disable the "Allow Thread Author" option now.... :up:

Unfortunately. I notice that the latest version you have v4.1 is noted as not compatible with vBulletin 4.0.7 or Less.

We are still using your v4.0.14 with 4.04pl1 of vBulletin and for a whole range of reasons, won't be able to upgrade vBulletin to be able to use a newer fixed version. If it's possible, a patch through a code statement would be great so we could reactivate that function for the original posters.

Regards,
Doug

ps: I was actually going to spend the holidays going through your excellent mods, as I bet we have nearly every one of them installed, checking to see which ones we can upgrade and which later ones don't support our version any longer.

Paul M

12-20-2010 03:42 PM

Line 686 of the XML ;

Change this ;

PHP Code:


		
			
    $ugroups = unserialize($vbulletin->options['wrtgrps']); 
    if (!((is_member_of($vbulletin->userinfo,$ugroups) OR $ugroups[0] == 0) OR 
    (($threadinfo['postuserid'] == $vbulletin->userinfo['userid']) AND $vbulletin->options['wrtauthor']))) 
    {
        print_no_permission();
     }

To this;

PHP Code:


		
			
    $ugroups = unserialize($vbulletin->options['wrtgrps']); 
    if (!(is_member_of($vbulletin->userinfo,$ugroups) OR $ugroups[0] == 0)) 
    {
        print_no_permission();
     }

Paul M

12-20-2010 03:45 PM

Quote:

Originally Posted by BadgerDog (Post 2136855)

Unfortunately. I notice that the latest version you have v4.1 is noted as not compatible with vBulletin 4.0.7 or Less.

This is purely down the the large number of style changes made in 4.0.8 - they affected about 8 (or more ?) of my mods.

BadgerDog

12-20-2010 04:02 PM

Quote:

Originally Posted by Paul M (Post 2136864)

This is purely down the the large number of style changes made in 4.0.8 - they affected about 8 (or more ?) of my mods.

Understood .. no problem ... I just appreciate being able to continue to use your mods, even on our older version.. :up:

I note that there's two occurrences of the XML code (line 686) you recommend get changed. Unfortunately, we don't have an editor with a line counter on our MacBook Pro, just a simple text editor. So, is the one that gets changed the first or second instance of the exact same code shown in your patch?

Thanks Paul .. :)

Regards,
Doug

Paul M

12-20-2010 08:35 PM

It is the second instance (only).

All times are GMT. The time now is 01:52 PM.

Page 24 of 44

« First

Last »

Show 40 post(s) from this thread on one page

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01589 seconds Memory Usage 1,755KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)bbcode_code_printable (2)bbcode_php_printable (5)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (2)pagenav_pagelinkrel (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: