vb.org Archive - Miscellaneous Hacks - [CMS] Use original thread for comments

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)

- - Miscellaneous Hacks - [CMS] Use original thread for comments (https://vborg.vbsupport.ru/showthread.php?t=230417)

Quote:

Originally Posted by FighterO'Foo (Post 2079910)

Probably the simplest mod I've ever installed. Uploaded the product and it worked straight away, no messing about. Brilliant stuff.

What version of vB are you using?

Quote:

Originally Posted by JonSidneyB (Post 2079911)

What version of vB are you using?

Definitely not the one were using :P (4.05)

Quote:

Originally Posted by daveaite (Post 2079987)

Definitely not the one were using :P (4.05)

Nothing drives me crazy quite so much as when, in the middle of a hundred people pointing out problems someone jumps in with a quick "Thanks!" or "Works perfect!", then says nothing else. I mean, did they bother reading the dozens of posts before theirs detailing all the problems? Who knows? The guy might have installed it on 405 and just doesn't yet have any idea it's not working.

I messaged him. He is using it with 4.0.3

I will give it a try. If this works well on 4.0.3 I will delay 4.0.6 until a fix using this is ready for it.

I have it on my forum now and love it. This is fantastic. I am going to read this and see if I can find away to preserve the comments that existed before I loaded this.

I am on 4.0.3 however

Quote:

Originally Posted by Videx (Post 2079902)

There's a huge problem with that strategy. Namely, that tons of bugs have been fixed in later versions. While this mod is a convenience, it's by no means a necessity.

I sure wish the author would mark it as 'reusable code' if they aren't going to update it themselves. Not that I've seen anyone else clamoring for the opportunity.

You don't think it is a necessity, I do.

If they are going to have a CMS and comments, this is the way it should function. I won't upgrade unless this works with newer versions. Not having this is a bug in my opinion.

Quote:

Originally Posted by Carnage- (Post 2074045)

just looked at http://www.iphonemodding.com/forum/c...h-Make-It-Work (the thread you screenshotted) in my browser (FF3.6.7, winxp) I can view the comments fine.

I think I may be close to finding the source of the other problems with this mod; I went into the source code and compared it side by side with vb 4.0.3 Where once there was this:

Code:

vb_Search_Indexcontroller_Queue::indexQueue('vBForum', 'Post', 'index', $msgid);

There is now this:

Code:

                        if (isset($vbulletin->options['vbcmsforumid']) AND $foruminfo['forumid'] == $vbulletin->options['vbcmsforumid'])

                        {

                                vb_Search_Indexcontroller_Queue::indexQueue('vBCms', 'CmsComment', 'index', $msgid);

                        }

                        else

                        {

                                vb_Search_Indexcontroller_Queue::indexQueue('vBForum', 'Post', 'index', $msgid);

                        }

It seems that there is an intention to separate forum posts and CMS comments even further as they are now different content types. I'm sure that this is the root of the issues with this mod, however I've yet to figure out what its doing to cause them. :(

This bug is affecting me too.
One plugin for this ("clear cache") is setting the vbcmsforumid to the id of the current forum, so that check you quoted thinks that this is the cms forum and that the comment should be indexed as a comment rather than post.
Haven't found a fix yet though. I just disabled the "clear cache" plugin, not sure what that will cause but it's better than having no posts indexed.

I wouldn't waste a lot of time trying to fix it because it's being changed again in 406.

Quote:

Originally Posted by Videx (Post 2080490)

I wouldn't waste a lot of time trying to fix it because it's being changed again in 406.

Yeah... "code, recode, revert code" seems to be vB policy of late... it's a joy. :eek:

I have a problem, when i set a forum to be used for the user comments, normal members are not able to view the forum they get 'Invalid Forum specified'.

Admin can see it fine, have checked forum settings and soon its removed from being the comments forum, users can see the forum.

Any ideas?

X vBulletin 3.8.12 by vBS Debug Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (2)bbcode_code_printable (6)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (2)pagenav_pagelinkrel (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages:

Phrase Groups Available:

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.03743 seconds Memory Usage 1,745KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (2)bbcode_code_printable (6)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (2)pagenav_pagelinkrel (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: