vb.org Archive - Profile Enhancements - e-steki Karma version 2.2

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vBulletin 3.6 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=194)

- - Profile Enhancements - e-steki Karma version 2.2 (https://vborg.vbsupport.ru/showthread.php?t=154264)

Quote:

Originally Posted by NolF (Post 1333568)

Installed, and gave me no errors.
I have a whole bunch of hacks installed and no conflics. Abou 60k users and hips of posts xD so it works ^^

3 suggestiosn I can think at the moment

First: The images (thumbs up down and neutral) should be in the misc folder of the theme instead of the root folder of images :) ($stylevar[imgdir_misc]/)

Second: Put a link to the stats on the "quick link" menu :)

Third: An option to hide who gave the karma

Lovely hack, and honestly great work :) hoppefully we'll see the unvote hack for 3.6 :D
Keep up with the good work and good luck with the MOTM

Thanks NolF, especially for the "good luck with the MOTM" part :) (although I'm sadly loosing :()

I agree with your first and second suggestion, however I don't have the time atm to update or support this modification (as I said, its only supported for a few days after each release). The third suggestion is not needed, as they are already hidden for the members.

ok i fixed this myself. I have to change a little for the sql query in the "e-steki Karma profile field part 2" to get rid of this error for some reason

Code:

$isthere = mysql_num_rows($db->query_read("SELECT karma FROM " . TABLE_PREFIX . "user WHERE userid = ".$vbulletin->userinfo['userid']." AND karma=1"));

Code:

$isthere = $db->num_rows($db->query_read("SELECT karma FROM " . TABLE_PREFIX . "user WHERE userid = ".$vbulletin->userinfo['userid']." AND karma=1"));

Well I've found couple of interesting things. One is a serious bug, which never came to my mind, but has to be fixed :O because is a big one aye

[bug 1]

Code:

When u give karma to someone, you use this link

./karma.php?do=processvote&u=$$$$&rating=4

But if you use firefox (works on ie too u just have to bother yourself coping the link word for word), and copy the link, you cna change that number to any number, for example 100, and it will give 100 karma points to that user. if you put -1000 it will take 1000 points from that user :O



I wonder how one of my users figured it out, but very cleaver indeed. The creep didn't even report it, but there you go

[bug? 2]
I'm pretty sure it is how you intended it to, but, is a bit ehhh to classify inactive users as not having opted to participate in the system. I mean, in the stats page the part which says "users have chosen to not participate in the Karma system. Shame on them!"
In my personal opinion, only active users, who have opted not to participate should be counted here. :D

[Suggestion 1]
Okey this suggestion, is better than any of the previous 3 ^^
When you give karma, you are redirected to the members profile, but my users (at least) find it quite annoying. I guess vBulletin has made them used to been redirected to the same page they were at.

[Suggestion 2]
At the moment, in order to calculate karma averages, you are using the old fashion add all scores and divide by the number. However, it is not the same to have 100 votes and an average of 4 than having 5 votes and an average of 5.
I recon a formula such as the one used on imdb.com is more aquarate than the current formula

Quote:

Originally Posted by imdb

weighted rating (WR) = (v ? (v+m)) ? R + (m ? (v+m)) ? C

where:
R = average for the movie (mean) = (Rating)
v = number of votes for the movie = (votes)
m = minimum votes required to be listed in the Top 250 (currently 1300)
C = the mean vote across the whole report (currently 6.7)

Variables, I guess should be determined via ACP, or calculated to correspond with the votes flux

[Comment]
I run a Spanish forum, so I had to translate the phrases, I just wanted to say, it was quite complicated at times to translate them, because it wasn't intuitive from the names, and the original English sentence what the purpose of the phrase was.
Also in many cases, you just put a word/sentence, which will be followed by a variable (ie number username etc) and dont use the {1} that makes it quite complicated to translate in many languagues
I could do a list if you are interested :)

Thx for listening ^^

Really useful feedback NolF. Thanks a lot.
I hope my users don't figure out bug #1 till I have time to fix it :(
Its so scary to think of what can happen if they do, they really take the karma seriously. :(
I don't think bug #2 can easily be fixed though. Perhaps a workaround would be to substract inactive users from that number, whether they have opted out voluntarily or not.
I'll try to find some time to fix bug #1 soon, it doesn't seem too time consuming to fix.

About the phrases, {1},{2} etc is used in vB phrases as well, its supposed to be the "correct" way. Placing a variable next to the phrase is problematic if a language requires it to be before the phrase or in the middle of it.

edit: Perhaps you should put bug #1 in code tags, till its fixed, so that it can't be read by guests or unlicensed users. You never know who's reading.

Bug #1 bothered me quite a lot, so here's a workaround.
Tell me if it works.

yep that works, when u give 100 for example, it is set back to 5, and if you use 4.5 for example it counts as 4 :)

great job :) faster than I expected great job

Quote:

Originally Posted by Michelle

About the phrases, {1},{2} etc is used in vB phrases as well, its supposed to be the "correct" way. Placing a variable next to the phrase is problematic if a language requires it to be before the phrase or in the middle of it.

That is what I was trying to say ^^. Some of your phrases don't use the {1} etc
for example
karma_rated ---- {1} has rated
in my opinion should be {1} has rated {2}

karma_you_have_voted ---- You have rated this user a
it should be -> You have rated this user a {1}
etc there are some more

Oh, lol :o
Yeah, a list of those would help, so that I change them in the next update. :)

Here you go, a list with the sentences I recon need the {1}s

karma_percent_of_votes == % of total votes => {1} % of total votes [Note: I think this phrase is not beign used]

karma_rated == {1} has rated => {1} has rated {2}

karma_ratedby == {1} was rated by => {1} was rated by {2}

karma_users_have_rated == users have rated => {1} users have rated {2} users

karma_users_not_participate == users have chosen to not participate in the Karma system. Shame on them! => {1} users have chosen to not participate in the Karma system. Shame on them!

karma_users_that_gave_the_most_x_votes == users that gave the most {1} votes => {2} users that gave the most {1} votes [Note: the {2} is the number 10 by default]

karma_you_have_voted == You have rated this user a => You have rated this user a {1}

userrating_lastrated == Last rated on => Last rated on {1}

=======
Note: I've only included the ones users can see, ACP functions can go in english no problem

Thx for the fix once again ^^

I'm wanting to install this hack but am unsure about if its working without problems? Can someone advise on its status? does it work?

cheers

This is an excellent hack, well done, just a question tho can I change the word Karma to something else?

thanks, Mike.

X vBulletin 3.8.12 by vBS Debug Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (3)bbcode_code_printable (3)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (1)pagenav_pagelinkrel (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages:

Phrase Groups Available:

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01261 seconds Memory Usage 1,753KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (3)bbcode_code_printable (3)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (1)pagenav_pagelinkrel (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: