vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.6 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=194)
-   -   Major Additions - Links and Downloads Manager (https://vborg.vbsupport.ru/showthread.php?t=119041)

AndrewD 09-22-2007 01:31 PM

Quote:

Originally Posted by Phalynx (Post 1343087)
I get a blank page if I want to inform users of updated downloads. It takes some time, the mails are also send. Using 2.2.8 RC2

I can't reproduce this problem - it seems to work ok for me. Any further information you can give me?

IrPr 09-22-2007 07:36 PM

Hi Andrew,
want to report a little bug and its fix
Timezone offsets aren't integeral at all, they're decimal and casting their type into integeral will broke some submition dates during add/edit Entries
if your forum/user timezone is +/-x:30, all of submitions will differ +/- 30 minutes to original submition time

Here is bugfix:
File: includes/local_links_misc.php, function: get_datetimebit, about line: 1456

Find:
PHP Code:

$tzoffset intval($vbulletin->userinfo['tzoffset'])-$vbulletin->userinfo['dstonoff']; 

Replace with:
PHP Code:

$tzoffset $vbulletin->userinfo['tzoffset']-$vbulletin->userinfo['dstonoff']; 

also i would suggest add default check to Update to current date and time option during Add entries, but edit

Thanks;

Phalynx 09-22-2007 09:02 PM

Quote:

Originally Posted by AndrewD (Post 1344578)
I can't reproduce this problem - it seems to work ok for me. Any further information you can give me?

Only that this happens with downloads that were downloaded a few thousend times (some hundred from registered) - maybe a performance problem?

IrPr 09-22-2007 09:32 PM

Quote:

Originally Posted by Phalynx (Post 1344814)
Only that this happens with downloads that were downloaded a few thousend times (some hundred from registered) - maybe a performance problem?

its seems to be execution timeout or malloc() exhaustion
whats your error_reporting value ? did u change that?

Phalynx 09-22-2007 09:34 PM

That's the value:
error_reporting = E_ALL & ~E_NOTICE & ~E_STRICT

IrPr 09-22-2007 09:46 PM

Quote:

Originally Posted by Phalynx (Post 1344832)
That's the value:
error_reporting = E_ALL & ~E_NOTICE & ~E_STRICT

Hmmm is that your master values?
refer to your PHP error logs and look for FATAL ERRORS

BTW, if it works and suddenly stops seems memory allocation or maybe timeout to me
I would suggest you to increase your memory_limit and max_execution_time valuse in php.ini

GTRyan 09-22-2007 09:53 PM

I have a folder on my server /videos and in it has months of the year as subfolders with videos for races from my local race track. Would this addon be good for adding all those to a page or threads as a download link with counters? Anybody knows of an addon that can either?

Phalynx 09-22-2007 10:38 PM

Quote:

Originally Posted by IrPr (Post 1344838)
Hmmm is that your master values?
refer to your PHP error logs and look for FATAL ERRORS

BTW, if it works and suddenly stops seems memory allocation or maybe timeout to me
I would suggest you to increase your memory_limit and max_execution_time valuse in php.ini

memory_limit is set to 128M - more than enough. I will check for fatal errors.

Edit:
No errors belonging to the site I run LDM.

AndrewD 09-23-2007 05:41 AM

Quote:

Originally Posted by IrPr (Post 1344763)
Hi Andrew,
want to report a little bug and its fix
Timezone offsets aren't integeral at all, they're decimal and casting their type into integeral will broke some submition dates during add/edit Entries
if your forum/user timezone is +/-x:30, all of submitions will differ +/- 30 minutes to original submition time

Here is bugfix:
File: includes/local_links_misc.php, function: get_datetimebit, about line: 1456

Find:
PHP Code:

$tzoffset intval($vbulletin->userinfo['tzoffset'])-$vbulletin->userinfo['dstonoff']; 

Replace with:
PHP Code:

$tzoffset $vbulletin->userinfo['tzoffset']-$vbulletin->userinfo['dstonoff']; 

also i would suggest add default check to Update to current date and time option during Add entries, but edit

Thanks;

Thanks - will implement the timezone fix.

For the time being, I will not change the behaviour of the 'update to now' checkbox, but leave it as a suggestion. There's a major site which routinely sets new entries to appear at sometime in the future. Having this box checked by default would be confusing to them. It will need a bit of Javascript to ensure that this box gets unchecked if the user modifies the date/time.

AndrewD 09-23-2007 05:46 AM

Quote:

Originally Posted by Phalynx (Post 1344832)
That's the value:
error_reporting = E_ALL & ~E_NOTICE & ~E_STRICT

The blank screen and the large number of downloads are clues. I guess that your server is running out of some form of resource - memory or more likely cpu.

By default, vbulletin is not very user friendly with system errors, because of its default 'gzipping' of messages to the user. Have you tried turning off this option? vb/admin/options/cookies and http header options/ set gzip html output to 'no' and save. Then repeat the test and see if you get a message instead of a blank screen.

I'll take a look at the code to see if I can improve efficiency.

Edited: I'm pretty certain that your problem will be that the script is running out of its allowed cpu time. This is because separate email messages are being sent to each person who has accessed the entry. Grouping these messages (i.e. having multiple email addresses as 'bcc' recipients) may be a solution, but this isn't a trivial change to the code and the php documentation is not very clear on what is allowed and what is not allowed.


All times are GMT. The time now is 02:27 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.03988 seconds
  • Memory Usage 1,756KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (4)bbcode_php_printable
  • (7)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (5)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete