vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 2.x Full Releases (https://vborg.vbsupport.ru/forumdisplay.php?f=4)
-   -   Usenet gateway (https://vborg.vbsupport.ru/showthread.php?t=7100)

fastforward 04-07-2001 06:54 AM

Quote:

Originally posted by Gilby
I found a bug happens when a post is made on the forums and sent to the newsgroup. Then, when the post is fetched, the postid and threadid that is sent in the headers of the message are read in, but gets associated with the post that has the message number one more than the forum post. This results in the post in the forum getting the wrong message-id asigned to it, and then the post right after the forum post can't be inserted because the message-id already exists.
I saw that before. I thought I'd fixed it... but obviously not.
Quote:

If the "Re-import Local Posts" is set to yes, then the forum post gets duplicated in the forums
I don't see how that can be possible. It can't insert an article if the msgid already exists. It's obviously a direct result of the bug above. (Or is that your point?)
Quote:

I tried to look at the newnews.pl script but I was unable to see where there was anything wrong (though I don't follow that programming style all that well :rolleyes: ).
What are you trying to say? What's wrong with the programming style? eh?! ;)
Quote:

I also noticed that when the newnews.pl file was run, and there were 2 new posts on the server, it would get 3 posts. This would be the case any time there were new posts where it would get one more than what was new, and if there were no new posts, it would fetch no posts. I thought this might have some relevance.
This is probably just a problem with the 'for loop'. It derives it's count from the last message number in the forum, the batch limit in the control panel and the last number reported by the newsserver.
Quote:

I think I saw that when using the 'post' in the NNTP module, it returns the message-id, so that may be a different route to use for getting the message-id.
This is the way I expected it to work. That doesn't seem to be the case though. I couldn't get it to return anything. It may be a newsserver issue but even CPAN makes no mention of a return value. If you can confirm it returns the msgid, let me know. it would make things a lot easier and more reliable.

By the way; I've got another version of the script ready. This one has a few efficiency changes but the big change is that it now continues to load replies in the correct order until there are no more left. This avoids having to make multiple runs when collecting history and should also prevent the stray articles that may not get loaded. Here's the zip if you want to play with it. I've got it running on my server. I'll package it up properly after I've looked at these other bugs and beta 5 comes out.

The one big problem with the script at the moment is the orphan reply checking. It does a full table scan for each newsgroup every run. That means for my 70 newsgroups I'm doing 70 full tablescans! My poor little Freedom 300 can barely keep up. As the post table fills up, it gets worse (I've got 23,000 posts at the moment). I need to find another way to do it or maybe make it an option for individual newsgroups. Although you get a few orhans in every newsgroup, it's really only a big problem with the mailing archives. Any ideas?

mkilty 04-07-2001 01:06 PM

Hi fastforward,

Can I replace the old ./newnews.pl with this new one and if so are there any changes I need to make besides just replacing the file?

Thanks,

Michael

v0n 04-07-2001 02:35 PM

Does spam filter work during posting? I'm a little affraid that opening posting features could attract spammers and get my news server blacklisted?

Gilby 04-07-2001 04:48 PM

Quote:

Originally posted by fastforward
I don't see how that can be possible. It can't insert an article if the msgid already exists. It's obviously a direct result of the bug above. (Or is that your point?)

That's the point... one of the results of this bug.
Quote:


What are you trying to say? What's wrong with the programming style? eh?! ;)

I wouldn't say there is anything wrong.... just not a style that I can follow very well (with those variable variables and such). I am not all that good at Perl.

Quote:


This is the way I expected it to work. That doesn't seem to be the case though. I couldn't get it to return anything. It may be a newsserver issue but even CPAN makes no mention of a return value. If you can confirm it returns the msgid, let me know. it would make things a lot easier and more reliable.

I saw it on a page from a google search. I don't know which module it was (I've seen both News::NNTPClient and Net::NNTP which apear to have the same functions). On CPAN, neither of these modules mention anything about returning the message-id. :(

Quote:

Although you get a few orhans in every newsgroup, it's really only a big problem with the mailing archives. Any ideas?
I did a lot of manual insertion to minimize how many articles were in the usenet_article table, then when I gave up for the itme being on inserting those posts, I renamed the table and created a blank one. Though that's just a temporary fix. Another idea is when not importing old archives, to limit the subjects it can match to those threads that have posts from the last 30 days in them. Maybe even make another table with just the subjects and refs of the threads from the last 30 days.

fastforward 04-07-2001 05:09 PM

Quote:

Originally posted by v0n
Does spam filter work during posting? I'm a little affraid that opening posting features could attract spammers and get my news server blacklisted?
No it doesn't. I was thinking of adding it though. It's only a minor change so I'll add it in the next release with beta 5.

fastforward 04-07-2001 05:11 PM

Quote:

Originally posted by mkilty
Can I replace the old ./newnews.pl with this new one and if so are there any changes I need to make besides just replacing the file?
You should be able to do that. provided you deleted the indexes and added the extra table from the latest full release? If not then it won't work. Let me know if you need help.

tamarian 04-07-2001 09:58 PM

Quote:

Originally posted by fastforward
This fix entails two more code changes, both in 'postings.php'.

Fastforward, your 2.5 vb code change instructions don't have any of these postings.php changes. Are they still needed?

fastforward 04-07-2001 10:06 PM

Quote:

Originally posted by tamarian
Fastforward, your 2.5 vb code change instructions don't have any of these postings.php changes. Are they still needed?
No... not needed because the unique constraint has been removed from the msgid columns in the post and thread tables.

Make sure you deleted the unique indexes and re-created normal indexes on those columns.

fastforward 04-10-2001 04:19 AM

This release is for vB 2.0 beta 5

Upgrading:
  • The only vB code changes that differ to the previous version are in showthread.php. The way the Registered: and Location: bits are handled (via custom fields) make it messy to try to hide via code. If you removed the words from your templates in a previous version, you'll have to put it back again as this release doesn't attempt to hide it. If you really need them hiding, the best bet is to create a seperate style set for usenet forums. I'll look at adding options to handle it via the control panel in a later release.
  • No DDL changes have been made.
  • There is one DML change that deletes an unnecessary option. (The 'reply iterations' option that is now handled automatically).
This is all listed in UPGRADE.txt

INSTALL.txt details a fresh installation on a virgin vB 2.0 beta 5.

Download

All links in this thread have been updated to point to the new version. The latest version will always be in the first post of this thread.

I hope to get another release of newnews.pl out over the weekend that will add some of the outstanding features listed at the top of this thread. This should simply be a drop in replacement.

robertusss 04-10-2001 04:45 AM

Quote:

Originally posted by Gilby
It depends on what your webhosting provider offers. If they are dial up users, then you will probably be able to use their news server at no charge. You may be able to get through from your ISP as well by using your username and password to access that news server. If you don't have one of those, then you'll have to find one of the services that you'd need to pay to use... though, I think there are a few free ones out there.
does anybody know some of the free ones?


All times are GMT. The time now is 01:51 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01542 seconds
  • Memory Usage 1,762KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (14)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (2)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete