vb.org Archive - Major Additions - Email Integration (New threads/replies by email)

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vBulletin 3.6 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=194)

- - Major Additions - Email Integration (New threads/replies by email) (https://vborg.vbsupport.ru/showthread.php?t=151222)

That was full of bugs. I forgot to specify the forum in the query. Oops. Here's the updated code

Code:

            // hide email addresses

            $mailmessage = preg_replace("/[a-zA-Z0-9\-_]+@[a-zA-Z0-9\-_]+.[a-z]{2,4}/", 'xxx@xxx.xxx', $mailmessage);



            // find thread with matching title 'Post'

            // make reply if match

            $baseTitle = preg_replace("/re: /", "", $title);

            $baseTitle = preg_replace("/Re: /", "", $baseTitle);

            $baseTitle = preg_replace("/RE: /", "", $baseTitle);

            $forumid = $foruminfo['forumid'];

            $queryResult = $vbulletin->db->query_first("

                SELECT threadid

                FROM " . TABLE_PREFIX . "thread

                WHERE forumid = $forumid AND (title = '$title' OR title = '$baseTitle') ORDER BY threadid DESC LIMIT 1

            ");

            if ($queryResult['threadid']) {

                $threadid = $queryResult['threadid'];

                $type = "reply";

                $cronlog .= "Found reply for thread $threadid";

            }

            // ##### Time To Post The Reply #####

            if ($type == "reply")

            {

                // Building post info

Quote:

Originally Posted by Tralala (Post 1303084)

:confused:

Why wouldn't they just send the pic to the mailboxes already used by this mod?

ie: general@myvbforum.com

Since the sending email address is cross-checked against the member's list, it's more or less just as secure. They can take pic, email it from the phone, and it gets posted. Am I missing something? What more does your request accomplish?

(In other words, this mod isn't just for replies, it's also for new threads too.)

Quote:

Originally Posted by Cyricx (Post 1303113)

This is possible with the current code.

If a user is in a usergroup that is set in this setting in the forum manager -

Please enter the usergroup IDs that can post and reply by email.

They can send an email to the email address for the site and it will post. They do NOT have to be subscribed to the forum in order to start a new thread from email :)

Thanks for the replies. I missed the feature where new threads can be creaed, not just replies posted. However, the user would have to have their mobile phone email address as their main email address for the site, correct?. I could see where people would want to be able to send texts and pictures from their phone and create new threads, however receive subscription/PM notifications to their email address.

Please correct me if I still am not understanding the functionality correctly.

My mobile phone (a Treo 700p) uses the same "email address" as my computer. So if I emailed a picture/attachment, it'd work.

But if you are talking about sending an MMS (multimedia SMS text message) as an email, yes, it'd be addressed from something like yourphonenumber@yourcellservice.com

US Based Carriers:

Alltel = xxxxxxxxxx@message.alltel.com
AT&T = xxxxxxxxxx@mms.att.net
Boost Mobile = xxxxxxxxxx@myboostmobile.com
Cingular (AT&T) = xxxxxxxxxx@mms.mycingular.com
Einstein PCS = xxxxxxxxxx@einsteinmms.com
Sprint = xxxxxxxxxx@messaging.sprintpcs.com
T-Mobile = xxxxxxxxxx@tmomail.net
US Cellular = xxxxxxxxxx@mms.uscc.net
Verizon Wireless = xxxxxxxxxx@vzwpix.com
Virgin Mobile = xxxxxxxxxx@vmobl.com

...and those wouldn't work, since it'd be unlikely that the person is using those as their "registered" email address.

Perhaps Cyricx can come up with additional allowance to allow for the processing of such SMS or MMS messages.

Quote:

Originally Posted by rbgrn (Post 1303232)

Cyricx - I've got everything working with a few modifications, here's my general experience feedback and breakdown:
1a) I modified the code to figure out which thread an email should go into using the subject

I'd advise against doing it this way.. There is a good chance you will have more then one thread with the same name across all your forums... the thread id is a much more certain route. Not to mention some email programs to different formating with RE: and FW:. This is the reason my current code works off the thread id :)

Quote:

2) There is no cron logging working for this
2a) I tried adding some in the cron job php and changed the phrase to have {1} in it so that it'd show up, but for whatever reason (I'm new to vb) it does not still
2b) I recommend adding some informational and debugging logging as it's frustrating when things aren't working and you can't figure out why
2c) My recommended categories - Email Received, Email Sent, Error Email Sent, Other Errors

Yeah.. I'm still learning the cron logging system and trying to learn how to log those. I know zero about the cron logs yet, so that's definately on my list :)

Quote:

3) Configuration
3a) It'd be ideal to have configuration as a separate menu item rather than hang off the forum itself. Multiple select of forums would be excellent on a single configuration
3b) For my set up, I'd like to have an override user that ALL emails get posted as
3c) Also I'd like to pull email from one box and depending on who it's from, get delegated into different forums (for me that translates to multiple mailing list support off 1 account). Another solution would be supporting a box other than INBOX
3d) I'd like an option to globally shut off all outbound email, as I don't use that.
3e) I don't want any other behavior changed within my board

So you allow incoming email? but not outbound? so the whole subscription thing, you don't need? Hmm... so your only using it to start new threads in forums?

Quote:

4) Security
4a) Email inherently is insecure to use for this as I can forge my From address and post as someone I'm not. There's not a lot you can do about that, unfortunately. Just a concern.

Completely agree. I'm brainstorming ideas to help secure it more without making it any more complex for the end user.

Quote:

5) Code
5a) Your code is one monolithic block. It'll be easier for you to add features if you refactor it a bit, breaking it into logical blocks using methods or classes if it gets even bigger.
5b) Consider adding some debugging ability. It'd be nice for us hackers. :)

The cron files HATE functions... I used to have the mail error code in a function and I had to create a list of all the variables I wanted to go through the function as it doesn't seem to accept global functions when embedded in the file.

Quote:

Of course it's easy for someone to sit back and criticize another's work, which is not what I'm trying to do. I really appreciate your time and think this is very valuable. I have different uses for it than what you intended initially and I'd consider polishing this off doing all of my above things and forking it off into a different project maybe called vBulletin Mail Pull or something of that nature. I may consider that if I get some more time to work on this in the future. For now, I'll create multiple mail boxes and users to go into the different forums for different mailing lists.

Thanks again for all your work.

I totally appreciate the ideas and input.

I think I saw in your block how to add to the cron log, so that may make it into an upcoming version.

All - My apologies for the delay in the next version, there was a few bugs found that I need to work on and unfortunately this weekend some RL fit hit the shan so things have been very hectic. Slight delay in the next version unfortunately :(

Quote:

Originally Posted by Tralala (Post 1303862)

Hmmm,

yeah I'd have to think about this, could prolly do it with a user option where they listed alternate email addresses by line or separated by a comma with no spaces so that it forms an array that could be checked against.

Something to consider for 3.0 :)

Ok last time: here's my code with bugfixes.

Code:

            // hide email addresses

            $mailmessage = preg_replace("/[a-zA-Z0-9\-_]+@[a-zA-Z0-9\-_]+.[a-z]{2,4}/", 'xxx@xxx.xxx', $mailmessage);



            // find thread with matching title 'Post'

            // make reply if match

            $baseTitle = preg_replace("/re: /", "", $title);

            $baseTitle = preg_replace("/Re: /", "", $baseTitle);

            $baseTitle = preg_replace("/RE: /", "", $baseTitle);

            $forumid = $foruminfo['forumid'];

            $queryResult = $vbulletin->db->query_first("

                SELECT threadid

                FROM " . TABLE_PREFIX . "thread

                WHERE forumid = $forumid AND (title = '" . $vbulletin->db->escape_string($title) . "' OR title = '" . $vbulletin->db->escape_string($baseTitle) . "') ORDER BY threadid DESC LIMIT 1

            ");

            if ($queryResult['threadid']) {

                $threadid = $queryResult['threadid'];

                $type = "reply";

                $cronlog .= "Found reply for thread $threadid";

            }

            // ##### Time To Post The Reply #####

            if ($type == "reply")

            {

                // Building post info

Cyricx - All I'm using it for is to read email from a mailing list and piece together the threads. No replies are allowed on the forum. It's just informational.

I also don't want people to be able to email in replies right now. I can't use threadid because the threads aren't being replied to from the forum. I have to do a gmail-style subject match to make it all work. I understand the limitations but it's all I can do.

functions work just fine in cron jobs, you just need to watch your scope.

Okay, so what happens if you have two threads titled

"Hey read me!"

in the same forum?

One of those could be a year old :)

Your query would add the posts to the oldest thread, rather then the newest and correct thread :)

The hiding email address preg, is a great idea! my newest version being debugged right now pulls out the To: emailaddress line completely out but your idea is a much better one :)

That's where I'm getting confused then :)

How are the threads being replied to? I mean... how are they getting the emails that they are replying too?

if your not allowing replies, why are you applying emails as replies to a thread? :)

Just a few more cleanups to do with Pocomail then I'll release the 2.x version :)

X vBulletin 3.8.12 by vBS Debug Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (2)bbcode_code_printable (9)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (3)pagenav_pagelinkrel (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages:

Phrase Groups Available:

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01887 seconds Memory Usage 1,795KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (2)bbcode_code_printable (9)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (3)pagenav_pagelinkrel (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: