vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.6 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=194)
-   -   Major Additions - Links and Downloads Manager (https://vborg.vbsupport.ru/showthread.php?t=119041)

itsblack 08-05-2007 01:41 PM

Quote:

Originally Posted by AndrewD (Post 1310129)
It works for me, but there was a bug that I fixed between the beta and the RC code. Can you check that you've correctly uploaded the local_links_actions.php file? Line 2213 should read
Code:

        $links_defaults['autocreate_sync_comments'] and
In the old, incorrect, code, line 2205 read
Code:

        $links_defaults['autocreate_sync_comments_with_thread'] and

Yes, I've uploaded the newset version. I guess maybe it has someting to do with the language? Because I found that you use word "Dicussion" to check the threadid, but unfortunately I've translated it into chinese. What surprised me is, a) after the codes in local_links_actions.php, when there is already $row['linkthread' (I checked the database, some items have this), it should work without check the phrase, but it doesn't; b) Sometime before it works for me, although I use the chinese version all the time.

I have also tried to delete "Dicussion" in the code (local_links_actions.php, line 2232), but it doesn't work.

AndrewD 08-05-2007 02:17 PM

Quote:

Originally Posted by itsblack (Post 1310374)
Yes, I've uploaded the newset version. I guess maybe it has someting to do with the language? Because I found that you use word "Dicussion" to check the threadid, but unfortunately I've translated it into chinese. What surprised me is, a) after the codes in local_links_actions.php, when there is already $row['linkthread' (I checked the database, some items have this), it should work without check the phrase, but it doesn't; b) Sometime before it works for me, although I use the chinese version all the time.

I have also tried to delete "Dicussion" in the code (local_links_actions.php, line 2232), but it doesn't work.

OK, I'll rethink the logic

AndrewD 08-05-2007 05:35 PM

Quote:

Originally Posted by itsblack (Post 1310374)
Yes, I've uploaded the newset version. I guess maybe it has someting to do with the language? Because I found that you use word "Dicussion" to check the threadid, but unfortunately I've translated it into chinese. What surprised me is, a) after the codes in local_links_actions.php, when there is already $row['linkthread' (I checked the database, some items have this), it should work without check the phrase, but it doesn't; b) Sometime before it works for me, although I use the chinese version all the time.

I have also tried to delete "Dicussion" in the code (local_links_actions.php, line 2232), but it doesn't work.

I recall how all this developed now.

In the earlier versions of the 'extra', there was no special database field for the associated thread, so the code had to check for the relevant text (threadid=..) in the body of the link description. In 2.2.7, I realised that this was definitely a kludge, so added a an extra column in the database.

I imagine that you'll find that comments work with those entries where the linkthread column is set, and don't work where it is blank. But (on the assumption that you haven't got a load of threadid bb codes in your LDM descriptions, it should be ok to modify the regular expression, as follows. Instead of

Code:

        elseif ($forumid>0 and preg_match("/\[thread=(\d+)\]Discussion/", $row['linkdesc'], $match)) {
try

Code:

        elseif ($forumid>0 and preg_match("/\[thread=(\d+)\]/u", $row['linkdesc'], $match)) {
(there's an extra 'u' after the second slash)

Can you let me know if this solves it, and if my theory is correct about the linkthread field?

Slave 08-05-2007 05:52 PM

Quote:

Well, how do you do...
I'm doing all right :)

Quote:

This is weird. There is no search table to build - it's all done within sql (unlike vb). How did you import the old entries - via LDM or as a database import?
I exported via, and imported using the 2nd option if I remember


Quote:

Couple of things to try - a) clear the browser cache, and b) go to vbulletin/admincp/options and set the gzip output option to 'no'.
I've done the cache part, and I'm sure the forum is already set at no for gzip, but I will double check ..

Quote:

Concerning the forum plugins, I don't think they've changed, but I'll take a look to see what can be done.
Wonderful, thanks :)

Slave 08-05-2007 05:56 PM

btw .. both the spider links and the tag cloud plugins work superbly .. thank you! :)

Not sure about the spider icon though :p .. I'll see if I can find one that works on a black background. Would it be possible to make it so that in the linkbit if there isn't an image it would have "spider this link" type text like how the other icons work?

AndrewD 08-05-2007 05:58 PM

Quote:

Originally Posted by Slave (Post 1310545)
I exported via, and imported using the 2nd option if I remember

Could you email me the database dump - ad_rodin at noos.fr


Quote:

Originally Posted by Slave (Post 1310545)
I've done the cache part, and I'm sure the forum is already set at no for gzip, but I will double check ..

Keep me informed.

I've sorted out the forum permissions. It had always been that way, but it was a straightforward change to thhe code. Will be in the final release.

itsblack 08-05-2007 07:05 PM

Quote:

Originally Posted by AndrewD (Post 1310527)
I recall how all this developed now.

In the earlier versions of the 'extra', there was no special database field for the associated thread, so the code had to check for the relevant text (threadid=..) in the body of the link description. In 2.2.7, I realised that this was definitely a kludge, so added a an extra column in the database.

I imagine that you'll find that comments work with those entries where the linkthread column is set, and don't work where it is blank. But (on the assumption that you haven't got a load of threadid bb codes in your LDM descriptions, it should be ok to modify the regular expression, as follows. Instead of

Code:

        elseif ($forumid>0 and preg_match("/\[thread=(\d+)\]Discussion/", $row['linkdesc'], $match)) {
try

Code:

        elseif ($forumid>0 and preg_match("/\[thread=(\d+)\]/u", $row['linkdesc'], $match)) {
(there's an extra 'u' after the second slash)

Can you let me know if this solves it, and if my theory is correct about the linkthread field?

I've tried what you said, it took no effect.
Actually after upgraded to the later versions, there are already some entries which the linkthread column are set, but even with these entries the comment doesn't work.
It's weird.

AndrewD 08-06-2007 04:01 AM

Quote:

Originally Posted by Slave (Post 1310547)
btw .. both the spider links and the tag cloud plugins work superbly .. thank you! :)

Not sure about the spider icon though :p .. I'll see if I can find one that works on a black background. Would it be possible to make it so that in the linkbit if there isn't an image it would have "spider this link" type text like how the other icons work?

Indeed, I'll make that change.

I imported and tested each of the xml files you sent into a clean database. In both cases, search work correctly, using both the like and the fulltext methods. I wonder if you had a problem with character encodings or indices in your database. Can't think how to test that, except maybe phpmyadmin/sql/REPAIR TABLE local_linkslink QUICK or vb/admincp/maintenance/repair tables

Slave 08-06-2007 05:38 AM

K .. I'll give that a go and let you know :)

Slave 08-06-2007 06:22 AM

Quote:

Originally Posted by AndrewD (Post 1310550)
Keep me informed.

gzip is off as I thought ..

Quote:

Originally Posted by Slave (Post 1310891)
K .. I'll give that a go and let you know :)

hmm .. seems to have started working I think .. :)


All times are GMT. The time now is 01:21 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.05052 seconds
  • Memory Usage 1,766KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (6)bbcode_code_printable
  • (13)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (5)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete