vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   Modification Graveyard (https://vborg.vbsupport.ru/forumdisplay.php?f=224)
-   -   vBPunch v1.2 - A Quick Warning System (https://vborg.vbsupport.ru/showthread.php?t=97117)

The Realist 10-20-2005 03:53 PM

updated yes but where is the actual hack, cos its not in the 1st post?

Alan @ CIT 10-20-2005 03:54 PM

2 minutes, I'll upload it

Alan @ CIT 10-20-2005 04:01 PM

Sorry folks, last minute bug has reared it's ugly head - just fixing now - 5 more minutes...

Alan @ CIT 10-20-2005 04:33 PM

ok bug (hopefully) fixed :)

v1.1 is now available for download

Hawkbizkit 10-20-2005 04:55 PM

sweet new version is great.... :)

OsMoSiS.it 10-23-2005 11:28 AM

Personally, I don't like the punch starts even if Cancel is clicked on prompt window... if I click erroneously the user gets punched because I can't undo my action... that's not good for me, not intuitive ("cancel" usually means "cancel action"). I've changed "do_punch" to suit my needs: if (message != null) then punch else don't do anyting :)

I'll add also an alert box to confirm that punch was sent (no errors) because some browsers (eg. firefox by default) don't allow status bar text changing via javascript :)


Keep testing it... btw good idea :)

OsMoSiS.it 10-23-2005 12:00 PM

Security checks should be hardened... I was able to send a punch even if I'm not logged in. Try to write the url with the querystring and the user receive a PM from a "non registered" user...

http://[forum_root]/vbpunch.php?punch=[YourUserId]&postid=1&warning=message

A workaround that seems to work (but I don't think is the right way):

In vbpunch.php replace:
PHP Code:

if ((!$vbulletin->options['vbpunch_enabled']) or (!$vbulletin->bf_ugp['vbpunch']['can_punch'])) 

with:
PHP Code:

if ((!$vbulletin->options['vbpunch_enabled']) or (!($permissions['vbpunch'] & $vbulletin->bf_ugp['vbpunch']['can_punch']))) 


Alan @ CIT 10-23-2005 12:54 PM

Osmosis: Thanks for pointing that out, I forgot to add "$permissions['vbpunch']" in vbpunch.php - an oversight on my part :) I'll fix it in the next release.

rb290 10-25-2005 07:48 AM

hey I uninstalled everything cause I dont think it worked for me so now when I went to edit a usergroup it said this:

"Database error in vBulletin 3.5.0:

Invalid SQL:
UPDATE usergroup SET

### UPDATE QUERY GENERATED BY fetch_query_sql() ###
`title` = 'Administrators',
`description` = '',
`usertitle` = 'Administrator',
`opentag` = '<strong><font color=\"#3A69DE\">',
`closetag` = '</font></strong><strong><font color=\"#FF0000\">_BOSS</font></strong>',
`passwordexpires` = '180',
`passwordhistory` = '360',
`forumpermissions` = '470810623',
`genericpermissions` = '255852479',
`attachlimit` = '0',
`pmquota` = '50',
`pmpermissions` = '3',
`pmsendmax` = '5',
`calendarpermissions` = '63',
`wolpermissions` = '31',
`adminpermissions` = '3',
`genericoptions` = '31',
`profilepicmaxwidth` = '100',
`profilepicmaxheight` = '100',
`profilepicmaxsize` = '65535',
`avatarmaxwidth` = '100',
`avatarmaxheight` = '100',
`avatarmaxsize` = '10000',
`vbpunch` = '0'
WHERE usergroupid=6;

MySQL Error : Unknown column 'vbpunch' in 'field list'

rb290 10-25-2005 07:49 AM

its bringing up an error when I save and it says unknown column 'vbpunch in 'field list', how do I remove that ?

rb290 10-25-2005 10:14 PM

some help please ^

Suiko Jin 10-26-2005 01:46 AM

Awesome sounding hack. I might install if my board gets bigger.

Guest190829 10-26-2005 01:47 AM

Just checked, and I have 1.0 installed. Timeeee to upgrade!

Alan @ CIT 10-26-2005 11:02 AM

rb290: Did you remember to delete the bitfield_vbpunch.xml file from the /includes/xml/ directory?

Danny: 'bout time :D

TyleR 10-30-2005 03:50 AM

Quote:

Originally Posted by Alan @ CIT
rb290: Did you remember to delete the bitfield_vbpunch.xml file from the /includes/xml/ directory?

im getting the same error and yes i already deleted that file.

Alan @ CIT 10-31-2005 09:20 AM

For anyone getting the error when editing usergroups after uninstalling, please rebuild the bitfields by following the instructions here: https://vborg.vbsupport.ru/showthread.php?t=92592

For future un-installers, please remove the files uploaded (in particular bitfield_vbpunch.xml), before un-installing the product from the AdminCP.

SuperFly 11-05-2005 05:45 AM

nevermind read above post :)

subnet_rx 11-05-2005 02:44 PM

the upgrade instructions say to remove our postbit changes before installing. Is that really necessary to upgrade from 1.1 to 1.2?

Alien 11-05-2005 11:40 PM

The previous version worked great, this new 1.2 version gives me problems. Using vBulletin 3.5.1

I re-uploaded all new files. Re-imported the product XML, set to overwrite old one.

Still says version 1.1 in the product page. I even re-build bitfields, and replaced the html in the templates again. Every single thread becomes completely unreadable with an error that states:

Parse error: parse error in /pathtomyforums/showthread.php(96) : eval()'d code on line 28

Unable to add cookies, header already sent.
File: /pathtomyforums/showthread.php(96) : eval()'d code
Line: 28

rb290 11-06-2005 02:21 AM

i get this error when I go into a thread:

"Parse error: parse error, unexpected $ in /home/thug/public_html/showthread.php(96) : eval()'d code on line 220

Warning: Cannot modify header information - headers already sent by (output started at /home/thug/public_html/showthread.php(96) : eval()'d code:220) in /includes/functions.php on line 2342

Warning: Cannot modify header information - headers already sent by (output started at /home/thug/public_html/showthread.php(96) : eval()'d code:220) in /includes/functions.php on line 2349"

phonexpo 11-06-2005 03:21 AM

I have this error "showthread.php(96) : eval()'d code on line 28" any ideas ?

Alan @ CIT 11-06-2005 09:12 AM

Hey all,

For those experiencing the error "Parse error: parse error in /pathtomyforums/showthread.php(96) : eval()'d code on line 28" please install the attached, updated, product XML, ensuring that you set "Allow Overrite" to yes.

This should fix the problem.

Thanks,
Alan.

phonexpo 11-06-2005 12:45 PM

Quote:

Originally Posted by Alan @ CIT
Hey all,

For those experiencing the error "Parse error: parse error in /pathtomyforums/showthread.php(96) : eval()'d code on line 28" please install the attached, updated, product XML, ensuring that you set "Allow Overrite" to yes.

This should fix the problem.

Thanks,
Alan.

Hi Alan,

Yes that fixed it. Thank you very much. :-)

Boofo 11-06-2005 12:51 PM

Is there a way to add more than one message to this so you can just tick which message you want sent? Like more than one default message.

Alan @ CIT 11-06-2005 02:18 PM

Boofo,

Not easily in it's current state. I'll look into adding that feature into the next version.

Alien 11-06-2005 05:58 PM

Yeah that would be a cool addition.

Btw, bug fixed with that last file! Thanks so much!

Juzmi 11-06-2005 11:21 PM

Ah works now :)

Thanks :)

Alan @ CIT 11-07-2005 06:37 AM

Juzmi: Good to hear :)

Juzmi 11-17-2005 02:50 AM

Okay when i send a user a punch.. it does not show a new PM message.... but if you go into your PM box it shows it.. any reason why it would do this>

Alan @ CIT 12-03-2005 08:22 PM

Juzmi: Sorry, didn't see your message - I'll look into this.

Everyone: Anyone got any feature requests for the next version? I plan on starting work on it next week.

puertoblack2003 12-04-2005 02:30 PM

Quote:

Originally Posted by Juzmi
Okay when i send a user a punch.. it does not show a new PM message.... but if you go into your PM box it shows it.. any reason why it would do this>

yea same here ran a test on my test user , went into pm and found all of the punches...lol i'll wait for the fix.... :ermm:

coolgus 12-11-2005 04:28 PM

Quote:

Originally Posted by Alan @ CIT
Juzmi: Sorry, didn't see your message - I'll look into this.

Everyone: Anyone got any feature requests for the next version? I plan on starting work on it next week.

I believe that this mod only misses the options to choose in how many warnings the user will be banned permanently or for a short time. Sure I can use the other mod but I like simplicity and of course AJAX :-)

eXaulz 12-11-2005 08:26 PM

Very nice modification, indeed. I modified this modification a bit, and this is what I got:

A 'Punch X' in the user menu

If you want to do this, find the following in the postbit / postbit_legacy template:

Quote:

<if condition="$post['userid'] AND $show['member']">
<tr><td class="vbmenu_option"><a href="profile.php?$session[sessionurl]do=addlist&amp;userlist=buddy&amp;u=$post[userid]"><phrase 1="$post[username]">$vbphrase[add_x_to_buddy_list]</phrase></a></td></tr>
</if>
Add after:

Quote:

<if condition="$can_punch">
<tr><td class="vbmenu_option"><a href="#" onClick="do_punch('$post[userid]', '$post[postid]'); return false;"><phrase 1="$post[username]">$vbphrase[punch_x_user]</phrase></td></tr>
</if>
Add the phrase:

punch_x_user
Punch {1}

Done! :)

By the way, to the developer:

Bug? My PM count doesn't get updated when the PM is sent (nor do I receive the new pm notice).

Alan @ CIT 12-12-2005 07:20 AM

Hi,

Quote:

Originally Posted by coolgus
I believe that this mod only misses the options to choose in how many warnings the user will be banned permanently or for a short time. Sure I can use the other mod but I like simplicity and of course AJAX :-)

Writing a full fledged Warning system based of vBPunch has always been on my todo list, and still is. Unfortunatly, there are many many things above it on my todo list :D

Quote:

Originally Posted by eXaulz
Bug? My PM count doesn't get updated when the PM is sent (nor do I receive the new pm notice).

Thanks, I've added it to the vBPunch todo list :)

AWI 12-12-2005 07:27 AM

Quote:

By the way, to the developer:

Bug? My PM count doesn't get updated when the PM is sent (nor do I receive the new pm notice).
Same here, installed it on 3.5.2...great hack man

puertoblack2003 12-13-2005 03:58 PM

Quote:

Originally Posted by Juzmi
Okay when i send a user a punch.. it does not show a new PM message.... but if you go into your PM box it shows it.. any reason why it would do this>


any updates with the problem when sending pm's

thanks

Alan @ CIT 12-14-2005 01:43 PM

Sorry, but I've been unable to reproduce this.

I've done various tests on my forum (3.5.2) and it all works fine. When I punch a user, they recieve the PM popup if they have it enabled, and recieve an e-mail about the new PM if they have that enabled.

Thanks,
Alan.

MissKalunji 12-16-2005 11:00 PM

n e one has a couple screen shot or a demo ? i'de love to know how it looks

puertoblack2003 12-16-2005 11:43 PM

Quote:

Originally Posted by Alan @ CIT
Sorry, but I've been unable to reproduce this.

I've done various tests on my forum (3.5.2) and it all works fine. When I punch a user, they recieve the PM popup if they have it enabled, and recieve an e-mail about the new PM if they have that enabled.

Thanks,
Alan.

will, i checked that out and it's activated so i did a test run it won't show either the pop-up or it won't show that that the user received a pm upon using the vbpunch..

any idea's :ermm:

GSM_electronic 12-17-2005 12:17 AM

My board's running on vb 3.5.2 also, is it possible that I can't see 'punch' icons at all?

They're shown in the 'preview' of template, but not at the forum...


All times are GMT. The time now is 04:21 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01380 seconds
  • Memory Usage 1,829KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_php_printable
  • (11)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete