vb.org Archive
Page 2 of 4 1 2 34
Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.0 Full Releases (https://vborg.vbsupport.ru/forumdisplay.php?f=33)
-   -   DHC Banner Ads - Upgrade [1.4] (https://vborg.vbsupport.ru/showthread.php?t=79738)

artonex 04-28-2005 10:47 PM
This looks promising, i will be keeping awatch of this thread :)

artonex 04-29-2005 06:22 AM
Future releases are set to include:

Multiple banners per page
Checking of secondary usergroups
Specifying which forums certain banners will be shown in
Limit by time/days
Paypal integration for automatic setup (with admin moderation of banners)
Setup of packages, ie: 1000 views for $5 preset etc... (Custom packages)

Next release due: 13th April

When is this coming mate do u have any ideas ?

artonex 05-02-2005 03:09 PM
Xenatino have you given up on this great hack ?

Storage Guy 05-04-2005 06:52 PM
am I retarded? trying to install this as my first mod... help needed!

Database error in vBulletin 3.0.7:

Invalid SQL: SELECT num_locations FROM dhc_ads_settings
mysql error: Table 'xxxxxxxx.dhc_ads_settings' doesn't exist

mysql error number: 1146

Did I leave something out???

cinq 05-06-2005 05:16 AM
Quote:
Originally Posted by MarcoH64
- There are some places in the coding vulnerable to SQL injections. Please validate all values before using them in a query.
Don't think this has been fully addressed. Also submission of new banners does not capture info correctly. Submission of an 'Others' type banner doesn't accept HTML code either (perhaps should be mentioned :) )

Found these problems whilst installing the hack for TheWebJunkie. Nice and intuitive banner hack, but it needs some improvements :)

Kaelon 05-18-2005 02:12 AM
Quote:
Originally Posted by cinq
Don't think this has been fully addressed. Also submission of new banners does not capture info correctly. Submission of an 'Others' type banner doesn't accept HTML code either (perhaps should be mentioned :) )

Found these problems whilst installing the hack for TheWebJunkie. Nice and intuitive banner hack, but it needs some improvements :)
Confirmed. There are serious security issues with this hack; I was able to insert a string of text into the database, in a separate cell using standard SQL.

MissKalunji 05-22-2005 09:41 AM
Hey does anyone know if this will work with vb 3.5.0? thx

Xenatino 05-22-2005 08:16 PM
Sorry, I'm back again. I will be starting work on this hack again shortly and releasing it within the next few weeks.

Please list any improvements you would like to see in the next release and any bugs/security holes (With the filename and rough location if possible) so that all of these may be corrected.

I apologise for the delay in getting back to you all.

Quote:
Originally Posted by MissKalunji
Hey does anyone know if this will work with vb 3.5.0? thx
This script has only been formally tested with vB 3.0.7. Upon release of vB 3.5.0, I will try and make this version blend seemlessly. If not, I will release an updated version for the new vB version.

MissKalunji 05-22-2005 09:16 PM
Quote:
Originally Posted by Xenatino
Sorry, I'm back again. I will be starting work on this hack again shortly and releasing it within the next few weeks.

Please list any improvements you would like to see in the next release and any bugs/security holes (With the filename and rough location if possible) so that all of these may be corrected.

I apologise for the delay in getting back to you all.



This script has only been formally tested with vB 3.0.7. Upon release of vB 3.5.0, I will try and make this version blend seemlessly. If not, I will release an updated version for the new vB version.
cool thx for the quick reply :ermm:

Blue Moose Aaron 05-23-2005 02:34 AM
I get errors when trying to insert data

Code:
Warning: Cannot modify header information - headers already sent by (output started at /home/thekryp/public_html/includes/adminfunctions.php:223) in /admincp/dhcbannerads.php on line 304
I'm using vBadvanced on my website and it will not display the ad on that page. Any idea why?

Also, is it possible to display Google Ads?

cinq 05-23-2005 02:49 AM
Quote:
Originally Posted by Blue Moose Aaron
Also, is it possible to display Google Ads?
Not at the moment.

redhotstang00 05-25-2005 04:16 AM
When i'm in the Admin CP, I can view the Add New Banner Ad and Edit Settings for DHC Banner Ads.

But i can't see it on the left side this is the pic you have https://vborg.vbsupport.ru/attachmen...chmentid=25581

but i can't see any off this

Xenatino 05-25-2005 08:41 AM
That is a screenshot of the original version, and not of the upgrade.

You should see 3 links under the heading of DHC Banner System (Manage Banner Ads, Add New Banner Ad and DHC Banner Settings)

etinteractive 05-25-2005 05:16 PM
Has the SQL injection hole been fixed??

Trana 05-25-2005 09:11 PM
I am getting the same error message as storageguy:

Database error in vBulletin 3.0.7:

Invalid SQL: SELECT num_locations FROM dhc_ads_settings
mysql error: Table 'forum.dhc_ads_settings' doesn't exist

mysql error number: 1146

I get this error message after I log in to the install script. The error is on every page of my site. Please help!

Thank you.

PixelFx 05-25-2005 10:38 PM
Clicked install but waiting for PayPal integrated version, also ucash/ushop intergration would be cool aka buy with points or something as sugguestion.

etinteractive 05-27-2005 12:40 PM
The one thing I had a problem with is the VBphrases in the admin cpanel wouldnt appear for me. They exist and all looks right, but the didnt output.

So i just hardcoded them.

any thoughts?

etinteractive 05-27-2005 01:00 PM
also, when I click a banner, its going to www.xxx.com/clickthru.php and NOT /forum/clickthru.php.

So if i move clickthru.php to root then i get error msgs that /.global.php cannot be found.

etinteractive 05-27-2005 01:15 PM
Quote:
Originally Posted by etinteractive
also, when I click a banner, its going to www.xxx.com/clickthru.php and NOT /forum/clickthru.php.

So if i move clickthru.php to root then i get error msgs that /.global.php cannot be found.
I realized this is due to using Vbadvanced portal. the banner ad doesnt work on the portal page, but it does on the forum pages.

any thoughts on how to change the output accordingly?

MissKalunji 05-27-2005 02:27 PM
Quote:
Originally Posted by etinteractive
The one thing I had a problem with is the VBphrases in the admin cpanel wouldnt appear for me. They exist and all looks right, but the didnt output.

So i just hardcoded them.

any thoughts?

i had the same problem....i just took off the vb phrases and 'wrote it normally'

Blue Moose Aaron 05-28-2005 01:13 AM
My banner will display for a time and then I revisit my site and nothing is showing. So for some reason it is disableing itself..

Xenatino 05-30-2005 01:04 AM
Quote:
also, when I click a banner, its going to www.xxx.com/clickthru.php and NOT /forum/clickthru.php.

So if i move clickthru.php to root then i get error msgs that /.global.php cannot be found.
Download the file attached to this reply and replace the current /includes/functions_bannerads.php file.

It has a few bug fixes and should fix this clickthru.php error.

Protoman 05-30-2005 04:37 PM
Quote:
Originally Posted by Blue Moose Aaron
My banner will display for a time and then I revisit my site and nothing is showing. So for some reason it is disableing itself..
open clickthru.php and find:
PHP Code:
if ($Select['limit_type'] == "clicks" && ($Select[clicks]+1) >= $Select[limit_to]) 
replace with:
PHP Code:
if ($Select['limit_type'] == "clicks" && ($Select[clicks]+1) >= $Select[limit_num]) 
how it's currently setup it validates that you are limiting by clicks.. then looks for a nonexistant variable in the database.. returned 0.. and tada, 1 click, ad turns off.

dennisuello 06-07-2005 03:12 PM
i installed it and followed all the instrucation, now i get:

Database error in vBulletin 3.0.7:

Invalid SQL: SELECT displayads FROM usergroup WHERE usergroupid='6'
mysql error: Table 'reno4x4_vbulletin.usergroup' doesn't exist

mysql error number: 1146

The Realist 06-07-2005 03:19 PM
As the error states "Table 'reno4x4_vbulletin.usergroup' doesn't exist"

Create it

Quote:
Originally Posted by dennisuello
i installed it and followed all the instrucation, now i get:

Database error in vBulletin 3.0.7:

Invalid SQL: SELECT displayads FROM usergroup WHERE usergroupid='6'
mysql error: Table 'reno4x4_vbulletin.usergroup' doesn't exist

mysql error number: 1146

dennisuello 06-07-2005 03:21 PM
my forum worked just fine before this, now i get this error. doesn't this table exist already?

all my tables start with vb3, like vb3_usergroup.

how do i uninstall this hack?

The Realist 06-07-2005 03:30 PM
If you want to uninstall it you have 2 options.

1) Reinstall the backup of your forum you should do before installing hacks.
2) Follow the instructions in reverse and put the edits etc back as they were.



Quote:
Originally Posted by dennisuello
my forum worked just fine before this, now i get this error. doesn't this table exist already?

all my tables start with vb3, like vb3_usergroup.

how do i uninstall this hack?

dennisuello 06-07-2005 03:32 PM
Quote:
Originally Posted by The Realist
2) Follow the instructions in reverse and put the edits etc back as they were.

what about reversing changes made by "install_bannerads.php"

Big J 06-13-2005 04:01 PM
Hi,

I get the following error when I try to add a banner: Warning: Cannot modify header information - headers already sent by (output started at /home/extreme-/public_html/forums/includes/adminfunctions.php:223) in /admincp/dhcbannerads.php on line 337

im running vb3.0.7

please help.

MissKalunji 06-13-2005 04:05 PM
Quote:
Originally Posted by Big J
Hi,

I get the following error when I try to add a banner: Warning: Cannot modify header information - headers already sent by (output started at /home/extreme-/public_html/forums/includes/adminfunctions.php:223) in /admincp/dhcbannerads.php on line 337

im running vb3.0.7

please help.
it still saves up your settings......i have the same error 2....

Big J 06-13-2005 04:15 PM
Quote:
Originally Posted by MissKalunji
it still saves up your settings......i have the same error 2....

It's not saving my settings. I also cant see the DHC Banner System option links in the nav, the phrases are not displaying. All I have are empty, clickable boxes.

MissKalunji 06-13-2005 04:16 PM
Quote:
Originally Posted by Big J
It's not saving my settings. I also cant see the DHC Banner System option links in the nav, the phrases are not displaying. All I have are empty, clickable boxes.
no no trust me it does.....and as for the phrases i had to twik the index in adminc instead of making it look for the phrases (for some reason it doesnt) i put up the word myself here's what i did and it works fine :

//Banner
construct_nav_option("Banner View", 'dhcbannerads.php?do=view', '<br />');
construct_nav_option("Banner Add", 'dhcbannerads.php?do=add', '<br />');
construct_nav_option("Banner Settings", 'dhcbannerads.php?do=settings', '<br />');
construct_nav_group("DHC Banner System", '<hr />');
//Banner

Aeolian_X 06-13-2005 10:27 PM
Quote:
Warning: Cannot modify header information - headers already sent by (output started at /xxx/xxx/xxx/xxxx/xxxx/xxxx/forum/includes/adminfunctions.php:223) in /admincp/dhcbannerads.php on line 313
Getting this same error, but the settings do seem to save. Though I still am not seeing any banners on the forum pages.

Big J 06-13-2005 10:30 PM
Thank you Miss!

MissKalunji 06-13-2005 10:57 PM
Quote:
Originally Posted by Big J
Thank you Miss!
np :nervous:

MissKalunji 06-13-2005 10:57 PM
Quote:
Originally Posted by Aeolian_X
Getting this same error, but the settings do seem to save. Though I still am not seeing any banners on the forum pages.
make sure that when u put up the banner code into your forum sometimes in the header template....that you put up example : number 1 make sure that when u add the banners from teh admincp make sure you put 1 in location...

Aeolian_X 06-14-2005 02:37 AM
Quote:
Originally Posted by MissKalunji
make sure that when u put up the banner code into your forum sometimes in the header template....that you put up example : number 1 make sure that when u add the banners from teh admincp make sure you put 1 in location...
Ah Ha!!! That's Beautiful! lol! Thank You Very Much MissKalunji. :)

Densit5 06-14-2005 03:46 AM
Checked why my click throughs were not working - totally missing the URI and found this code:-

Back up your file before you edit it please!


functions_bannerads.php
Code:
Find
Around line 39

global $DB_site, $banner_ad;

Replace

global $DB_site, $banner_ad,$vboptions;

Find
Line 77 - 79
 
case "image":
        $banner = "<a href=\"clickthru.php?uid=$ad[uid]\" target=\"_blank\"><img src=\"$ad[banner_image]\" height=\"$ad[height]\" width=\"$ad[width]\" border=\"0\"></a>";
break;

Added the full url code to the clickthru links - This should also work for people that have VB advanced installed, since i have it too :lick:
Replace

case "image":
        $banner = "<a href=\"$vboptions[bburl]clickthru.php?uid=$ad[uid]\" target=\"_blank\"><img src=\"$ad[banner_image]\" height=\"$ad[height]\" width=\"$ad[width]\" border=\"0\"></a>";
break;

Find
Line 95 - 102

case "other":
        $banner = $ad['other_code'];
        $url_code = "clickthru.php?uid=" . $ad['uid'];
        $banner = str_replace("{url}", $url_code, $banner);
        $banner = str_replace("{image}", $ad['banner_image'], $banner);
        $banner = str_replace("{height}", $ad['height'], $banner);
        $banner = str_replace("{width}", $ad['width'], $banner);
break;

Replace

case "other":
        $banner = $ad['other_code'];
        $url_code = "$vboptions[bburl]clickthru.php?uid=" . $ad['uid'];
        $banner = str_replace("{url}", $url_code, $banner);
        $banner = str_replace("{image}", $ad['banner_image'], $banner);
        $banner = str_replace("{height}", $ad['height'], $banner);
        $banner = str_replace("{width}", $ad['width'], $banner);
break;
This hack is nice but will not work on "other" for google addsense javascripts until you change the case "other" code.

Aeolian_X 06-14-2005 08:23 PM
I've noticed that my banners do not stay active. Not sure what's causing it, but I have had to recheck the Active box three times now.

I'd still like a fix for this too.

Quote:
Warning: Cannot modify header information - headers already sent by (output started at /xxx/xxx/xxx/xxx/xxx/xxx/forum/includes/adminfunctions.php:223) in /admincp/dhcbannerads.php on line 304

MissKalunji 06-14-2005 08:28 PM
Quote:
Originally Posted by Aeolian_X
Ah Ha!!! That's Beautiful! lol! Thank You Very Much MissKalunji. :)
n e time glad i could help :)


All times are GMT. The time now is 04:50 PM.
Page 2 of 4 1 2 34
Show 40 post(s) from this thread on one page

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01468 seconds
  • Memory Usage 1,849KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (2)bbcode_php_printable
  • (21)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete