vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.0 Full Releases (https://vborg.vbsupport.ru/forumdisplay.php?f=33)
-   -   AdColumns v1.0 (https://vborg.vbsupport.ru/showthread.php?t=62348)

magnus 03-13-2004 02:21 AM

Quote:

Originally Posted by drumsy
Unfortunately that did not work and I do not know what other recourse to take.

If you could give me the source of the page in question, I could check out the HTML. I'm sure it's a simple <table> problem.

I'm betting you're using the default vB Style? (Layout, not colors..)

adusei 03-13-2004 07:20 AM

Hi,
first of all - thx to Magnus: I really appreciate the work you've done! Great hack!

Small problem:
Everything is working proper but - if I enable the RIGHT sidebar, it is only to be seen on all forumdisplay-pages, not on the index-page.
Of course it would be better not only to see the left sidebar (if enabled) on the first page of the board but the right (if enabled) too.

Any help out there?

Best regards and TIA -

adusei

magnus 03-13-2004 01:07 PM

Quote:

Originally Posted by adusei
Hi,
first of all - thx to Magnus: I really appreciate the work you've done! Great hack!

Small problem:
Everything is working proper but - if I enable the RIGHT sidebar, it is only to be seen on all forumdisplay-pages, not on the index-page.
Of course it would be better not only to see the left sidebar (if enabled) on the first page of the board but the right (if enabled) too.

Any help out there?

Best regards and TIA -

adusei

adusei, I'm confused. The AdColumns show up on every page that includes $header and $footer. It's impossible for them not to. Could you show screenshots or possibly give me a link to see for myself?

magnus 03-13-2004 01:55 PM

Drumsy,

Ok, I found the culprit. It's a slight glitch with the vB default style.

This line is what is causing the problem:
HTML Code:

<div style="padding:0px 25px 0px 25px">
You need to remove, or replace that line with:
HTML Code:

<!-- <div style="padding:0px 25px 0px 25px"> -->
Now, I just need to figure out what template that is located in. Check the following templates:

spacer_open
postbit
postbit_legacy

It should be in one of those. ;)

drumsy 03-14-2004 02:20 AM

Ok, so far I've found it in spacer_open only as:

Code:

<div style="padding:0px $stylevar[spacersize]px 0px $stylevar[spacersize]px">

drumsy 03-14-2004 02:22 AM

This does change the layout, even before I enable the AdColumn. Namely, where I used to have some space between the right and left edges of my forums and the edge of the screen, it sits pretty much right on top of it now.

drumsy 03-14-2004 02:24 AM

Ok, I've enabled it, it works fine everywhere, but does it have to be right up on the edge of the screen? Check out www.honda-acura.net/forums as an example.

adusei 03-14-2004 08:47 AM

Quote:

Originally Posted by magnus
adusei, I'm confused. The AdColumns show up on every page that includes $header and $footer. It's impossible for them not to. Could you show screenshots or possibly give me a link to see for myself?

I'm sorry to say - but it is like I mentioned before: RIGHT sidebar is not to be seen (to be more precisely: it is to be seen BELOW the "What's up here"-column and on top of the time).
I tested it with Mozilla 1.6 and Opera 7 and IE6 - always the same problem.

A friend tested it with IE5 - and there it s working proper. Since I need the RIGHT sidebar I please need some help. What can be my mistake ?

TIA and best regards,

adusei

P.S.: I installed everything again - same problem LEFT sidebaris ok, RIGHT doesn't appear proper...

magnus 03-14-2004 12:53 PM

adeusi,

In a previous post you said it's working fine on FORUMHOME, but not on your INDEX page, correct? When I checked your site earlier, you have pretty heavily modified INDEX page. I'm sure you've got an open html tag somewhere that's screwing with it. Try running the site url through a HTML validator, it will help you track down the culprit.

If it's working on fORUMHOME fine, logic tells us it's got to be something specific to the INDEX page.

magnus 03-14-2004 12:58 PM

Quote:

Originally Posted by drumsy
Ok, I've enabled it, it works fine everywhere, but does it have to be right up on the edge of the screen? Check out www.honda-acura.net/forums as an example.

What do you mean by 'right up on the edge of the screen'? I visited the link, and it looks great on my side?

adusei 03-14-2004 07:06 PM

@magnus

Yup - thx for the hint - it's been the forumhome template! Now everthing is working proper!
Thanks for the fine hack again!

Best regards,

adusei

joeychgo 03-15-2004 04:03 AM

Its strange, everything else is fine, but my calander is too wide... Im set to 1050 width and when I enable left column ads (via hack) the calander doesnt adjust.


www.lincolnvscadillac.com

magnus 03-15-2004 09:59 AM

Quote:

Originally Posted by joeychgo
Its strange, everything else is fine, but my calander is too wide... Im set to 1050 width and when I enable left column ads (via hack) the calander doesnt adjust.


www.lincolnvscadillac.com

Odd, but I don't even see a calendar on your FORUMHOME? It has to be a missing HTML tag in the calendar code. If you could enable it, so I could get a look I could probably find the missing tag.

joeychgo 03-15-2004 10:50 AM

Quote:

Originally Posted by magnus
Odd, but I don't even see a calendar on your FORUMHOME? It has to be a missing HTML tag in the calendar code. If you could enable it, so I could get a look I could probably find the missing tag.

Calendar is there-- I have the ads turned off though... here is a screenshot. Its taken on my 19" lcd monitor and you can see I have the scrollbar on the bottom

magnus 03-15-2004 12:09 PM

Oh, that problem has been addressed. See this thread. The changes you need to make are in the "spacer_open" template.

It's a glitch in the default vB style.

joeychgo 03-17-2004 02:54 AM

nope --- that thread doesnt help -- here is my spaceropen template -- what that thread calls for isnt there or in postbit or postbit_legacy

<!-- open content container -->
<if condition="$show['old_explorer']">
<table cellpadding="0" cellspacing="0" border="0" width="$stylevar[outertablewidth]" align="center"><tr><td class="page" style="padding:0px $stylevar[spacersize]px 0px $stylevar[spacersize]px">
<else />
<div align="center">
<div class="page" style="width:$stylevar[outerdivwidth]; text-align:$stylevar[left]">
<div style="padding:0px $stylevar[spacersize]px 0px $stylevar[spacersize]px">
</if>

magnus 03-17-2004 10:04 AM

Joey, do me a favor. Enable AdColumns, go to your Calendar. Click "View Source", and save the source to a file and give it to me. I can track down what's wrong much easier that way. :)

joeychgo 03-17-2004 01:47 PM

here you go.............its attached

Quote:

Originally Posted by magnus
Joey, do me a favor. Enable AdColumns, go to your Calendar. Click "View Source", and save the source to a file and give it to me. I can track down what's wrong much easier that way. :)


magnus 03-17-2004 02:04 PM

Quote:

Originally Posted by joeychgo
here you go.............its attached

Well, I found the problem:

HTML Code:

<!-- open content container -->

        <div align="center">
                <div class="page" style="width:1000px; text-align:left">
                        <div style="padding:0px 25px 0px 25px">

You need to remove, or comment out:

HTML Code:

<div style="padding:0px 25px 0px 25px">
I'm not sure which template this is located in, since you said it's not in spacer_open. Use the template search feature and see what it pulls up. :)

joeychgo 03-17-2004 02:10 PM

I did a template search, no dice----

this is spacer_open

<!-- open content container -->
<if condition="$show['old_explorer']">
<table cellpadding="0" cellspacing="0" border="0" width="$stylevar[outertablewidth]" align="center"><tr><td class="page" style="padding:0px $stylevar[spacersize]px 0px $stylevar[spacersize]px">
<else />
<div align="center">
<div class="page" style="width:$stylevar[outerdivwidth]; text-align:$stylevar[left]">
<div style="padding:0px $stylevar[spacersize]px 0px $stylevar[spacersize]px">
</if>

magnus 03-17-2004 02:11 PM

In spacer_open, comment out:

HTML Code:

<div style="padding:0px $stylevar[spacersize]px 0px $stylevar[spacersize]px">

joeychgo 03-17-2004 07:01 PM

what do you mean --- "comment out" ?

Quote:

Originally Posted by magnus
In spacer_open, comment out:

HTML Code:

<div style="padding:0px $stylevar[spacersize]px 0px $stylevar[spacersize]px">


magnus 03-17-2004 07:09 PM

Quote:

Originally Posted by joeychgo
what do you mean --- "comment out" ?

Either delete it, or place "<!--" and "-->" around it, for example:

HTML Code:

<!-- <div style="padding:0px $stylevar[spacersize]px 0px $stylevar[spacersize]px"> -->

joeychgo 03-17-2004 07:25 PM

ok, I commented it out and, well that keeps it from running off the page --

But the forum automatically adjusts size to fit within the size allotted - the members list and calander do not. They stretch so as to be larger then the header. Not running off the page, but not quite right either. any thoughts?

gc1 03-17-2004 11:22 PM

Installed, works perfect on the forums and the vb advanced homepage

magnus 03-18-2004 01:24 AM

Quote:

Originally Posted by joeychgo
ok, I commented it out and, well that keeps it from running off the page --

But the forum automatically adjusts size to fit within the size allotted - the members list and calander do not. They stretch so as to be larger then the header. Not running off the page, but not quite right either. any thoughts?

Could you show me a screenshot, as well as provide the source one more? This is very odd.

joeychgo 03-18-2004 01:32 AM

HEre are some screenshots -- the first 2 are with both left and right turned on and you can see in the first one with forums its fine - but the second one, calander isnt.-- the third on is with only left on showing the same problem

what code do you want?

magnus 03-18-2004 11:25 AM

Quote:

Originally Posted by joeychgo
HEre are some screenshots -- the first 2 are with both left and right turned on and you can see in the first one with forums its fine - but the second one, calander isnt.-- the third on is with only left on showing the same problem


what code do you want?

I'll need two sources. First, your /index.php with both sides enabled. Then your /calendar.php with both sides enabled.

joeychgo 03-18-2004 11:58 AM

here you go. I included member list.php because the calander and memberlist are the ones screwed up. -

magnus 03-18-2004 04:22 PM

Quote:

Originally Posted by joeychgo
here you go. I included member list.php because the calander and memberlist are the ones screwed up. -

Hrm.. I didn't mean I needed your .PHP files. I need the source. I need you to access each of those files/pages in your browser, then View Source and save them to separate files so I can open them on my end and twiddle with the source.

Make sure you have both sidebars enabled when you save the source, as I'll need that code in their, too.

As for the index, I need your forum index. Not vBadvanced index. ;)

joeychgo 03-18-2004 05:26 PM

ACtually -- I figured out my problem

I had width set to 1000 sx instead of just 100%

One question while im here --- can the logo be set to 100% somehow?

joeychgo 03-20-2004 07:24 AM

After upgrading to gold - i tried to reinstall -- I got this after running the install script.....

Database error in vBulletin 3.0.0:

Invalid SQL:
INSERT INTO settinggroup (grouptitle, displayorder, volatile) VALUES ('adcolumn', '600', 1)

mysql error: Duplicate entry 'adcolumn' for key 1

mysql error number: 1062

Date: Saturday 20th of March 2004 01:26:22 AM

magnus 03-20-2004 01:43 PM

Quote:

Originally Posted by joeychgo
After upgrading to gold - i tried to reinstall -- I got this after running the install script.....



Database error in vBulletin 3.0.0:

Invalid SQL:
INSERT INTO settinggroup (grouptitle, displayorder, volatile) VALUES ('adcolumn', '600', 1)

mysql error: Duplicate entry 'adcolumn' for key 1

mysql error number: 1062

Date: Saturday 20th of March 2004 01:26:22 AM

You have no reason to re-run the installer. Upgrading to Gold didn't erase anything from the SQL DB. You need to perform the template and file edit mods again though.

DaveLogic 03-23-2004 07:01 AM

Quote:

Originally Posted by magnus
You have no reason to re-run the installer. Upgrading to Gold didn't erase anything from the SQL DB. You need to perform the template and file edit mods again though.


Since upgrade to Gold all has stopped working..In AdminCP there is still Advertisment Colomn option under VB options but when you click on it it no longer brings up any options..i.e Left / Right check boxes. If I click on OK it just says "Nothing to do"

joeychgo 03-23-2004 07:02 AM

thats the same problem i have

magnus 03-23-2004 11:25 AM

It seems like vB3 Gold may have removed some things from the dB. Looks like I'm going to have to make a quick uninstaller, so you can re-run the installer and put all the settings back.

/sigh.. why Jelsoft, why?

magnus 03-23-2004 11:33 AM

Ok, run these following queries:
[SQL]DELETE FROM `phrase` WHERE `varname` = 'settinggroup_adcolumn' LIMIT 1;
DELETE FROM `phrase` WHERE `varname` = 'setting_adenable_title' LIMIT 1;
DELETE FROM `phrase` WHERE `varname` = 'setting_adenable_desc' LIMIT 1;
DELETE FROM `phrase` WHERE `varname` = 'setting_adleft_title' LIMIT 1;
DELETE FROM `phrase` WHERE `varname` = 'setting_adleft_desc' LIMIT 1;
DELETE FROM `phrase` WHERE `varname` = 'setting_adright_desc' LIMIT 1;
DELETE FROM `phrase` WHERE `varname` = 'setting_adtitleleft_title' LIMIT 1;
DELETE FROM `phrase` WHERE `varname` = 'setting_adtitleleft_desc' LIMIT 1;
DELETE FROM `phrase` WHERE `varname` = 'setting_adtitleright_title' LIMIT 1;
DELETE FROM `phrase` WHERE `varname` = 'setting_adtitleright_desc' LIMIT 1;

DELETE FROM `settinggroup` WHERE `grouptitle` = 'adcolumn' LIMIT 1;

DELETE FROM `setting` WHERE `varname` = 'adenable' LIMIT 1;
DELETE FROM `setting` WHERE `varname` = 'adleft' LIMIT 1;
DELETE FROM `setting` WHERE `varname` = 'adright' LIMIT 1;
DELETE FROM `setting` WHERE `varname` = 'adtitleleft' LIMIT 1;
DELETE FROM `setting` WHERE `varname` = 'adtitleright' LIMIT 1;[/SQL]

Then, go ahead and re-run the installer. It should work fine after that. Be sure to verify the file and template edits! ;)

heynurse 03-26-2004 07:51 AM

I've also got the alignment issues in the show thread where the thread contents are not as wide as they should be (see screenie)

I've made the changes you suggested throughout this thread:

Quote:


Let's try something, go to your AdminCP then Styles and Templates -> StyleVars. Look for the "Message Area Width (pixels)" and set it to "auto"

I've tried:
Quote:

In SHOWTHREAD template, find:

<!-- / toolbar -->

<!-- end content table -->
$spacer_close
<!-- / end content table -->

and delete the $spacer_close text
I've tried commenting out
Quote:

<!-- <div style="padding:0px 25px 0px 25px"> --> from spacer_open template.
Has anyone figured this problem out? Any help would be appreciated, I have also included the source of a page with the problem. Please let me know if you need anything else. Thanks

magnus 03-26-2004 02:49 PM

heynurse,

Here is your problem:
HTML Code:

                <div class="page" style="width:95%; text-align:left">
That needs to be "width:100%". You can change it in your Stylevars in the AdminCP.

jeoworks 03-28-2004 06:25 PM

Will this work with the final version of vBulletin? The version after RC4?

Forgive me with terminology ;)

vBulletin 3.0.0

Thanks.


All times are GMT. The time now is 09:45 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01530 seconds
  • Memory Usage 1,850KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code_printable
  • (8)bbcode_html_printable
  • (18)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete