![]() |
I was the first one to run this script after the post. No problems on testboard or online board.. which kinda surprised me. Can't wait to see the admin functions.
filburt - stop being so fussy :p |
woooo hoooo
Any conflicting tables or columns must be removed or renamed before the upgrade to vBulletin 3 proceeds Table Conflicts No Table Conflicts Column Conflicts No Column conflicts |
Quote:
[/high] ummm :cry: |
BTW, just looked index.php for 3.0.0 public beta (first public beta, but beta 3 internally). There still are a significant number of lines that well exceed the 80-char limit, but I'm assuming that they'll be cleaned up in the RCs and finals.
|
The script does NOT catch all problems a hacked board will have when upgrading.
1. If you removed the filedata column from the attachments table when you installed the attachments as files hack, put it back. 2. You will need to remove all the extra settings for hacks such as the arcade, quiz, bookmarks, etc. from your database. Those were the only two problems I encountered during the upgrade and both were easily fixed. Now I am looking at a butt-ugly default beta installation on my board :D Can't wait to see the new style when Gold comes out. |
Yeah.. i'm gonna upgrade to vb3 and start making vb3 hacks! i wanna make the most vb3 hacks and the most hacks that have been converted. Lesane.. can i do store v3? lol.
|
Quote:
We don't have an 80 char limit rule in place. |
Wouldn't a limit like that screw up a lot of queries?
|
Quote:
|
LOL @ Crinos. I couldn't have said it better myself. ;)
|
Quote:
|
Cheers Scott man ;)
I gotta have a quick go with this. Thanks ;) Quote:
|
Freddie and his team may have developed vB, but I have also developed quite a few massive projects, including one fully based in PHP for NASA. Please do not be so quick to judge. He simply took it personally, which I did not intend.
An 80-character line limit is there for three primary reasons: 1. To prevent ridiculously long lines, such as those queries in vB2 (which are gone in vB3, thankfully) 2. To allow editing of the code at low resolutions or in a complex IDE such as Zend Studio with all the panels open. 3. To allow printing of the code such that two columns can be on each page. All of the above make it much nicer to follow the 80-character standard for code reviews. Also IDEs have that gray line in the editor for a reason. :) BTW, I do agree that 80 chars is a bit small (it actually makes the code more messy quite often) and 100 or 120 would be better, but a limit is necessary. Surely you can understand that and see my point. (also please don't bump such an old thread, so closed) |
All times are GMT. The time now is 04:17 AM. |
Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information | |
---|---|
|
|
![]() |
|
Template Usage:
Phrase Groups Available:
|
Included Files:
Hooks Called:
|