vb.org Archive - Recycle Bin & Moderator Log

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vBulletin 2.x Beta Releases (https://vborg.vbsupport.ru/forumdisplay.php?f=5)

- - Recycle Bin & Moderator Log (https://vborg.vbsupport.ru/showthread.php?t=47469)

Are there any plans, for further updates to improve this hack, or is this final?

thanks,
Metro.

Apart from bug fixes, in the install, some work in the report script and a few bugs here and there its more or less good to go.
I've been very busy recently with getting ready to leave my Job, as well as my primary BB.

Left the job on monday this week, been spending some QT with the wife, and I should get some coding time early next week - Oh god I hope i can get some codeing time next week

Dan

I get the error during the installation

You have an error in your SQL syntax near '$DB_site->query("INSERT INTO forum VALUES (NULL, 1, 'RCBforum', '', 1, 1, 0, 0, ' at line 1

I get this when installing with the default values or when I try to do it manually. However, I get zero instruction on the screen (in manual mode) for setting up the database and noting in the readme file either.

That is a bug - I should be able to get to withing the next 24 hours - wife and QT permitting.

Dan

Ok, the installer is fixed regarding the forum creation errors.

I'll do my best to get to other stuff soon.

Dan

Quote:

Warning: Failed opening '/home/libragrr/public_html/forums/showthread.php' for inclusion (include_path='.:/usr/local/lib/php') in Unknown on line 0

When I tried to go to a thread

and my index page is Kapoof! http://www.libragrrl.com/forums/index.php

Quote:

Today at 06:02 AM Sue said this in Post #46
When I tried to go to a thread

and my index page is Kapoof! http://www.libragrrl.com/forums/index.php

Sue, the board is up and runmning again. I fixed everything.

Check your Emails. ;)

Zzed, I'm most interested what was the fault...

Dan

Quote:

Today at 04:04 PM Sasq said this in Post #49
Zzed, I'm most interested what was the fault...

Dan

There were 2 problems.

index.php had been reduced to a 0 byte file, which I restored from the backup copies created by emacs.

The file permissions on forumdisplay.php had changed to -rw-rw--w-. Since Apache is not the same user and usergroup as Sue's ID on the server it had no read permission to read that file and hence the error message would pop. ;) I cured that puppy with a chmod 644 forumdisplay.php. :D

Ok, my next question .... (probably for Sue) when you installed it, did you use the ftp update or the direct file update?

I'm not quite sure why it would have changed the permissions... I'll have to check, but the more info I can get on the install the better chance I have of makeing sure it never happens again.

Zzed if this hack is still installed, the only lines for index.php are related to keeping the postcount/threadcount from the bin hidden on the main page... two lines. I'm not at my main box atm so if you need them I'll have to drag them up later..

Dan

I am not sure how index.php got clubbered, or how the permissions on forumdisplay.php changed sonce Sue was the one who did the install.

I was just fortunate enough to have shell access and had installed some of my hacks for her and ended up with backup copies.

I may have to reinstall your hack for her again.

My guess is that the FTP program she used may have been the culprit here. I prefer to edit files on site. ;)

P.S. I told Sue earlier that I was going to kill her. :laugh::banana: I was kidding of course. :)

hehe np, when you find out if you can let me know...

Thanks

Dan

This is a great hack! I'll be running it offline for a little while (until it's released as stable) and i'll report any bugs :)

How's progress on this ? :)

Installation Bugs ###############################

Quote:

------------------------------------------------
loginstall.php :: admin/functions.php :: Modification No.2

there are two modifications called Modification No.2. Doesn't bother me, but just thought i'd say.

------------------------------------------------
loginstall.php :: admin/functions.php :: Modification No.13

the modification details say

PHP Code:


		
			
// ###################### Start delete post #######################

function deletepost($postid,$countposts=1,$threadid=0, $stoplog=0) {

  global $DB_site, $bbuserinfo;



  // decrement user post count

  if ($postinfo=getpostinfo($postid)) {

    if ($countposts) {

      $DB_site->query("UPDATE user SET posts=posts-1 WHERE userid='$postinfo[userid]'");

    }



//log mod

However, you check later whether or not post counts should be updated so:

PHP Code:


		
			
// decrement user post count

  if ($postinfo=getpostinfo($postid)) {

    if ($countposts) {

      $DB_site->query("UPDATE user SET posts=posts-1 WHERE userid='$postinfo[userid]'");

    }

should be but highlighted in red (as it needs to be removed otherwise post counts are updated incorrectly)
There's also a problem related to this, see the editpost section ;)

Quote:

------------------------------------------------
loginstall.php :: editpost.php :: Modification No.2 to 4

Modification No.2

PHP Code:


		
			
//delete just this post

$foruminfo=getforuminfo($threadinfo[forumid]);

deletepost($postid,$foruminfo[countposts],$threadinfo[threadid]);



$logperms=deletepost($postid,$foruminfo[countposts],$threadinfo[threadid]);

$threadreturn=$threadinfo[threadid];



updatethreadcount($threadinfo[threadid]);

updateforumcount($threadinfo[forumid]);

Modification No.3

PHP Code:


		
			
updatethreadcount($threadinfo[threadid]);

updateforumcount($threadinfo[forumid]);



updatethreadcount($logperms[delpost]);//modlog

updateforumcount($logperms[recforumid]); //modlog



eval("standardredirect(\"".gettemplate("redirect_deletepost")."\",

\"showthread.php?s=$session[sessionhash]&threadid=$threadinfo[threadid]\");");

Modification No.4

PHP Code:


		
			
$threadinfo[threadid]$threadreturn

Just a couple of things i'd like to query here:

Modification No.2:
"$logperms=deletepost($postid,$foruminfo[countposts],$threadinfo[threadid]);
$threadreturn=$threadinfo[threadid];"

Those two added lines don't actually seem nessesary.
Firstly, you've already called the deletepost function on the line above so when i deleted the line
"$logperms=deletepost($postid,$foruminfo[countposts],$threadinfo[threadid]);" everything still worked fine.

Also, the variable $threadinfo[threadid] doesn't actually change at any point (as far as i can see) the line to copy it to a new variable isn't needed.

Point two means that Modification No.4 wouldn't be needed.
I think modification 2 and 4 can really be skipped :)

No issues would Modification No.3 ;)

Quote:

------------------------------------------------
loginstall.php :: showthread.php :: Modification No.3

PHP Code:


		
			
$viewattachedimages=0;

    }



    $postbits = getpostbit($post);



//modlog

// with rest of modlog code following here

this line (the one just above //modlog):

PHP Code:


		
			
$postbits = getpostbit($post);

should be highlighted in red (it needs to be removed). Otherwise the postbit template appears twice per post

------------------------------------------------
loginstall.php :: showthread.php :: Modification No.7

PHP Code:


		
			
//$postbits .= getpostbit($post);

  

  //modlog

// with rest of modlog code following here

this line (the one just above //modlog):

PHP Code:


		
			
$postbits .= getpostbit($post);

PHP Code:


		
			
eval("dooutput(\"".gettemplate("showthread")."\");");



//modlog

// with rest of modlog code following here

this line (the one just above //modlog):

PHP Code:


		
			
//eval("dooutput(\"".gettemplate("showthread")."\");");

should be highlighted in red (it needs to be removed). If not, the script never gets to the //modlog code that follows (which also outputs the template anyway!)

Quote:

------------------------------------------------
logbit :: template :: -

Uploaded in the zip, minor changes.
Judging by the other templates, i don't think it's actually used!

------------------------------------------------
postbit_reedit :: template :: -

Uploaded in the zip, minor changes.

------------------------------------------------
postbit_recycle :: template :: -

Uploaded in the zip, minor changes.

################################################## ############

Notes:
Tested on vb2.2.9 | Don't know if it works on vb2.3.0, can't get it
Tried both automatic and manual installation options.

Find it works best if everything is done automatically, except for template changes.

Quote:

General Bugs ###############################

Problems when users have weird usernames. Here's my example one (the quotes are part of it):
"';:*->Test<-*:;'"

I think you need to use addslashes() when entering info into the logs table, i'll test this later.
=============

/* -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Listed this problem already, check my earlier notes on editpost.php and admin/functions.php

If a user deletes their own post, their post count becomes 0. If they delete their own thread, the post count is updated correctly.

I think (really, not sure here) that this line in admin/functions.php
- just after function deletepost($postid,$countposts=1,$threadid=0, $stoplog=0) {:

Find:

PHP Code:


		
			
  // decrement user post count

  if ($postinfo=getpostinfo($postid)) {

    if ($countposts) {

      $DB_site->query("UPDATE user SET posts=posts-1 WHERE userid='$postinfo[userid]'");

    }

This needs to be changed to just:

PHP Code:


		
			
  // decrement user post count

  if ($postinfo=getpostinfo($postid)) {

    /*if ($countposts) {

      $DB_site->query("UPDATE user SET posts=posts-1 WHERE userid='$postinfo[userid]'");

    }*/

This is because you check later whether or not post counts should be updated (incase posts are being deleted from the log forum, etc).

The second modification (this time in edit.php):

Find:

PHP Code:


		
			
} else {

      //delete just this post

      $foruminfo=getforuminfo($threadinfo[forumid]);

      deletepost($postid,$foruminfo[countposts],$threadinfo[threadid]);



      $logperms=deletepost($postid,$foruminfo[countposts],$threadinfo[threadid]);

      $threadreturn=$threadinfo[threadid];

Should become:

PHP Code:


		
			
} else {

      //delete just this post

      $foruminfo=getforuminfo($threadinfo[forumid]);

      deletepost($postid,$foruminfo[countposts],$threadinfo[threadid]);



      //$logperms=deletepost($postid,$foruminfo[countposts],$threadinfo[threadid]);

      $threadreturn=$threadinfo[threadid];

otherwise, again, the post count seems to be done twice. It seems to work fine when that line is removed. Everything is still logged correctly.
=============
Listed this problem already
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= */

But that's it. This hack is absolutely brilliant!
Much thanks :)

[ mY edit note:
Corrected one or two things i wrote originally.
Listed a bit more details ;)

If you're unsure what i'm on about with anything you can email me at
info@radgam.fsworld.co.uk ]

I succesfully installed this hack on 2.2.9, with no errors during the install. I went to the forum index page and recieved this error:

Fatal error: Call to undefined function: getlogset() in /....../httpdocs/forums/index.php on line 50

Any suggestions would be much appreciated, thank you for creating this hack (even though it isn't working for me yet :D )

I got the same error as Karbon. Ive installed it on 2.3.0. Didnt get any errors, but I noticed the admin commands dont appear either so it seems it havnt changed some files as it should.

It seems to be a problem with the automated installer. It works best if you do the file mods by hand :)

ah, I guessed it was something like that. I usally dont like to run those automatic programs cause you never know what they do. But I guess I gotta sit down someday and break it down, so I find out where to do the changes. (Or is there released a howto txt file ? I havnt seen one at least)

Anyway thanks for the reply.

There sure is :)
If you select to do the code modifications by hand the last step will have a link for each file that needs modified with a list of all the changes but there are a few bugs which you should check on previous page.

I'm hoping to attach the updates/fixes to the file changes later but i've been a bit caught up with stuff the past few days :/

ah ok, Ill try that. Just one more question, does it run any of the queries if I chose "by hand" ? Kinda dont want the script to do anything again.

No, although if you let it do everything except file modifications it turns out pretty good :)

Love this hack. Works absolutely fine except for the installation. It all installed except for the editpost.php and admin/functions which I had to edit myself manually. Everything is perfect. I installed it on a vb 2.30 board btw with vbportal 2.30 aswell to. The other thing is that the system doesn't show up in the admin cp. I just manually added it in but just letting you know.

Great hack ;)
Hope those vb guys are watching this one cos its very very useful.

this gonna come outta beta?

i need to change my editpost.php manualy. I dont understand this:
Modification No.4
The Highlighted text indicates the modification that has been done.
The Highlighted text indicates script that has been removed.

$threadinfo[threadid]$threadreturn

the $threadinfo[threadid] is red.

I would love to use this, but No offence to you, do to the rapid changes in vbulletin, the file editing portion of the installer is really crappy. You need to make MUCH better manual install instructions, b/c i get a parse error in every file i do. :(

A real grate hack. it this hack gone come out off beta ???

I don`t whant to start jusing vb3, to many bugs yet.

I know it's been asked, but there's a real need for this on a board, and don't want to install unless it's out of beta and all is well.

Has this passed the beta stage?

Phrase Groups Available:

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.02354 seconds Memory Usage 1,851KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (15)bbcode_php_printable (8)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (1)pagenav_pagelink (1)post_thanks_navbar_search (1)printthread (29)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: