vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 2.x Full Releases (https://vborg.vbsupport.ru/forumdisplay.php?f=4)
-   -   Quick PM Reply Box (https://vborg.vbsupport.ru/showthread.php?t=38178)

Jawelin 06-12-2002 03:56 PM

Very very nice hack.

Something I always lack in the PM page was the 'delete original
on reply' flag.
Is it possible to add a checkbox to automatically delete the incoming message when submitting the quick-reply ?

Thank you very much
Bye

Erwin 06-13-2002 12:51 AM

I'll work on it - that shouldn't be too hard to do.

Erwin 06-13-2002 02:08 AM

Mmm... a simple template edit won't do that. The 2 action variables are different. One is dosend, the other is dodelete - this will take further hacking of private.php to combine the 2 variables.

Jawelin 06-13-2002 08:30 AM

Quote:

Originally posted by Erwin
Mmm... a simple template edit won't do that. The 2 action variables are different. One is dosend, the other is dodelete - this will take further hacking of private.php to combine the 2 variables.
Yes, of course.
I asked to you as the original author of the hack... :D

I definetively think the following code :
PHP Code:

  $privatemessageid=verifyid("privatemessage",$privatemessageid);
  
$DB_site->query("DELETE FROM privatemessage 
                  WHERE privatemessageid=
$privatemessageid 
                  AND userid=
$bbuserinfo[userid]"); 

should be added somewhere in the "dosend" section of private.php, managed in an if-clause by a check-box variable in privmsg template...

I think this php mod should make it better called 'hack' ... instead of a template modification, with the addition of more than a row to the script...

:knockedout:

Thanks again.

Jawelin 06-13-2002 09:15 AM

Just an addon.
What will be the behavior of this quick reply about the message tracking and the outbox ?
I mean, are they managed as defaults or not ?

What about adding, beside 'delete' option, even the checkboxes for :
- Signature
- Save a copy
- Message tracking
(defaulted, as in QuickReplyBox hack, upon the user's preferences) ???

Thanks

freakyshiat 06-14-2002 12:27 AM

Quote:

Originally posted by TheCaver

And a weird double border on the right hand side, which I haven't looked at just yet.....
JC

i am gettin that too, do u know what it is?

Jawelin 06-14-2002 06:21 AM

Quote:

Originally posted by Fazle

i am gettin that too, do u know what it is?

Wrong colspan number; set it to '6' instead '5' ...
Bye

Erwin 06-15-2002 02:28 AM

Okay, Jawelin, I'll do it just for you... hang on while I add those things you suggested...

Erwin 06-15-2002 03:36 AM

Okay, the hack is updated.

Version 2 additions:
--------------------------

Added options using checkboxes to:

1) Delete original: Delete original PM from PM box when you send reply
2) Automatically parse URLs.
3) Show Signature.
4) Save a copy: Also save a copy in the 'Sent Items' folder.
5) Request Read Receipt: Choose message tracking.

Also fixed up the colspan issue, colors etc.

Refer to the 1st post for the updated text file, and the 2nd post for the updated screenshot.

Boofo 06-15-2002 04:41 AM

I ran into a problem. I had two instances of the specialcharacters line in private.php. If I put the code after one of them, I got an error if I chose to delete the message after sending. It said I didn't specify a message. If I put it under the other one, I didn't get the error, but the message was not deleted. Also, in your oicture (2nd post), There is a preview button under the box. I don't have that on mine. Would there be any way to add that? :)

Quote:

Originally posted by Erwin
Okay, the hack is updated.


Version 2 additions:
--------------------------

Added options using checkboxes to:

1) Delete original: Delete original PM from PM box when you send reply
2) Automatically parse URLs.
3) Show Signature.
4) Save a copy: Also save a copy in the 'Sent Items' folder.
5) Request Read Receipt: Choose message tracking.

Also fixed up the colspan issue, colors etc.

Refer to the 1st post for the updated text file, and the 2nd post for the updated screenshot.


Erwin 06-15-2002 05:19 AM

Mmm...

Let me look into it now...

Erwin 06-15-2002 05:19 AM

It works fine on my forums... but my private.php is very modified...

Boofo 06-15-2002 05:21 AM

I can pm you my file if you need to look at it.

Quote:

Originally posted by Erwin
It works fine on my forums... but my private.php is very modified...

Boofo 06-15-2002 05:27 AM

There was a similar problem with the Quick reply Box that would give you a forum specification error (errorid). Could that also be what is going on here? :)

Erwin 06-15-2002 05:30 AM

Okay, I've updated the text file.

Clear your browser cache (delete all files in your browser's temporary folder), and download the new text file.

The difference:

Find this code in private.php

PHP Code:

if ($HTTP_POST_VARS['action']=="dosend") { 

Underneath, add this:

PHP Code:

if ($deleteorig=="yes") {
  
$privatemessageid=verifyid("privatemessage",$privatemessageid);
  
$DB_site->query("DELETE FROM privatemessage WHERE privatemessageid=$privatemessageid AND userid=$bbuserinfo[userid]");
  } 

You need to make sure you copy the WHOLE new template across as well. Not just the new checkboxes. This is because I have added this new line in the template HTML code:

Code:

<input type="hidden" name="privatemessageid" value="$privatemessageid">
You need this for the delete function to work.

This needs to be in between the form tags. Just use the WHOLE of the new template and replace the whole of your old one.

It should work now. :)

Boofo 06-15-2002 05:44 AM

That didn't chnage anything here. I still get the same error message when trying to delete a message when sending the reply. :)

Erwin 06-15-2002 06:13 AM

Did you copy the whole template across and replace the old template changes? Did you make sure you have the privatemessageid variable as hidden included?

Make sure you have this:

Code:

<input type="hidden" name="privatemessageid" value="$privatemessageid">
in your privatemsg template in the quick pm reply box form - use the template that I provided.

It does work - trust me. :) You just need to give the delete function the private message id.

Boofo 06-15-2002 06:27 AM

You caught me. No, I didn't copy the whole template. The reason is because the template didn't match vBulletins setup all the way and I had to play with it quite a while last time to get it to look right. If you want the code for my fixed box, let me know and I'll PM it to you. What happened was, in the first version of the quick pm reply box, that line you wanted me to add this time said <input type="hidden" name="previewmessageid" value="$privatemessageid"> instead of what it is now. Once I took that old line out and put the new one ine, then it worked fine. As you can see they look very close when you're going through the code. :) It works great here. Thanks!

BTW you had a preview button in your picture in the second post. Any way we can add that to this? :) Thanks again and sorry for the misunderstanding. (we don't need the old preview message id code in there right?)

Quote:

Originally posted by Erwin
Did you copy the whole template across and replace the old template changes? Did you make sure you have the privatemessageid variable as hidden included?

Make sure you have this:

Code:

<input type="hidden" name="privatemessageid" value="$privatemessageid">
in your privatemsg template in the quick pm reply box form - use the template that I provided.

It does work - trust me. :) You just need to give the delete function the private message id.


Erwin 06-15-2002 12:26 PM

The previewmessageid is for the preview message - different kettle of fish.

The Preview PM hack is located here - just do a search for it. It works well with my hack too.

Glad to know the hack is working! :)

Jawelin 06-15-2002 02:11 PM

Quote:

Originally posted by Erwin
Okay, Jawelin, I'll do it just for you... hang on while I add those things you suggested...
Thank you very much for this dedication... :D
I'll apply it to my files... Thanks again.

Boofo 06-15-2002 06:00 PM

That preview part I took out was in the same part where you had me add that second code. Wasn't that from the first release of your hack here? I already have the preview private message hack installed but I couldn't find one for the preview Quick PM reply.

Quote:

Originally posted by Erwin
The previewmessageid is for the preview message - different kettle of fish.

The Preview PM hack is located here - just do a search for it. It works well with my hack too.

Glad to know the hack is working! :)


Erwin 06-15-2002 10:29 PM

Oh.... if you already have the Preview PM hack installed, then all you have to do to make that work with my hack is this:

In your privmsg template:

Find this:

Code:

<form action="private.php" method="post" enctype="multipart/form-data" name="vbform" onSubmit="return validate(this)">
Add this underneath:

Code:

<input type="hidden" name="prevmessageid" value="$privatemessageid">
Then find this:

Code:

<input type="submit" class="bginput" name="submit" value="Send Message" accesskey="s" tabindex="4">
Add this underneath:

Code:

<input type="submit" class="bginput" name="preview" value="Preview Message" accesskey="p" tabindex="4">
The preview function should work immediately. From what I can remember anyway.

Erwin 06-15-2002 10:30 PM

Remember, the above variables are to be between the form tags for my hack, not in the original privmsg template.

Boofo 06-15-2002 11:24 PM

Ok, that worked, I think. When it goes to preview the message, it throws it to the regular preview message, right? So you are no longer in the Quick PM reply message?

Quote:

Originally posted by Erwin
Remember, the above variables are to be between the form tags for my hack, not in the original privmsg template.

X-Fan 06-16-2002 03:52 AM

Great hack! Works perfectly, and it's a real time-saver. Thanks Erwin!

Erwin 06-16-2002 08:38 PM

Quote:

Originally posted by Boofo
Ok, that worked, I think. When it goes to preview the message, it throws it to the regular preview message, right? So you are no longer in the Quick PM reply message?


Yes. :)

Boofo 06-16-2002 08:49 PM

Great, thanks! BTW: Do you know why the me vbcode hack (by Firefly) doesn't work in the quote of a private message? If you quote that from someone in a private message, it still says [disable]/me[/disable] and puts in my name in the reply. Any ideas on this one? :)

Quote:

Originally posted by Erwin


Yes. :)


Erwin 06-16-2002 10:17 PM

To be honest, it should work, as long as you installed the private.php part of the /me hack.

Boofo 06-16-2002 11:08 PM

I just double checked everything and it is all there like it is supposed to be. I don't know why it is not working now in the private messages. :)

Quote:

Originally posted by Erwin
To be honest, it should work, as long as you installed the private.php part of the /me hack.

kmistry 06-18-2002 08:47 PM

hey, i just downloaded 2.2.6 and i thought i might as well get the new pm reply while im at it. just wondering that thick border at the bottom, how do i get rid of it!

thx.

Erwin 06-18-2002 11:32 PM

Just experiment around with the table HTML code for the Quick PM Reply Box - I don't have a bottom border using the same code for my forums. Every forum has a different layout - modify the hack to make it suit yours. :)

Bro_Joey_Gowdy 06-20-2002 08:28 PM

Nice hack Erwin

:)

Erwin 06-20-2002 08:41 PM

Hi Joey, long time no see...

Boofo 06-20-2002 09:12 PM

Erwin,

Chen helped me start to get the /me vbcode hack working with regular private messages. I noticed that when I reply to a message with the quick pm reply box, it shows it as /me still. Is there a way to make it so it shows the person's name instead of /me in the quick pm box?

Heineken77 07-27-2002 04:15 PM

Hey :)

I was wondering, is it possible to remove extra quotes in the quick reply PM box as it was done in this hack for replying to PMs manually?

Also, remove the extra Re: Re: Re: ? :(

That would be sweet!
Sincerely,
Heineken

Boofo 07-27-2002 05:53 PM

Erwin,

Are you still supporting this?

Erwin 07-27-2002 08:59 PM

Boofo: I am still supporting it. :)

Heineken:

To remove the extra quotes, just install that hack. It works - I've tried it.

To remove the extra RE: RE: - that's easy - just go to your "privmsg" template (after you have installed the hack) and find:

Code:

value="RE: $message[title]"
And replace with:

Code:

value="$message[title]"
There you go!

Erwin 07-27-2002 09:04 PM

Quote:

Originally posted by Boofo
Erwin,

Chen helped me start to get the /me vbcode hack working with regular private messages. I noticed that when I reply to a message with the quick pm reply box, it shows it as /me still. Is there a way to make it so it shows the person's name instead of /me in the quick pm box?

To be honest, Boofo, the /me code works for me using the Quick PM reply box with no problems - both in the Reply and in the Quoted area. That's why I didn't answer you - it works. If it doesn't, it's not this hack, it must be the way /me was installed on your site.

Boofo 07-27-2002 09:15 PM

I'm sorry, I guess i didn't explain it right. :)

It worksd fine for me except when it is quoted from someone else. Then it still shows the [disable]/me[/disable] code instead of that person's name in the quote.

Quote:

Originally posted by Erwin


To be honest, Boofo, the /me code works for me using the Quick PM reply box with no problems - both in the Reply and in the Quoted area. That's why I didn't answer you - it works. If it doesn't, it's not this hack, it must be the way /me was installed on your site.


Boofo 07-28-2002 12:08 AM

I must be doing something wrong then, because I have that hack installed and I still get more than the last quote if there is more than one (but only in the Quick Reply PM Box, the regular reply box works as it should).

The RE: RE: fix is working fine now. Thanks, Erwin. :)

Now, all we have to do is figure out the quote problem, for now, anyway. :) Is anyone else having the quote problem in the Quick PM Reply Box after the hack install?

Quote:

Originally posted by Erwin
Heineken:

To remove the extra quotes, just install that hack. It works - I've tried it.

To remove the extra RE: RE: - that's easy - just go to your "privmsg" template (after you have installed the hack) and find:

Code:

value="RE: $message[title]"
And replace with:

Code:

value="$message[title]"
There you go!



All times are GMT. The time now is 06:53 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01458 seconds
  • Memory Usage 1,845KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (11)bbcode_code_printable
  • (3)bbcode_php_printable
  • (15)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete