No, i've attached the html as a txt file so you can see for yourself.

thankz all of u~~ :D

now it works~~~

Hmmm. no onload attribute. Not that is odd...because that attribute should be there regardless of my hack if you have a new PM. Were your popups working fine before?

oh yes, the pop-up was running fine before.

there is a small update to this, late last night it actually worked, completly out of a blue one of my members sent me a message, and low and behold I got it.

It was just strange that when I was testing it myself it did not work :?:

Hmmmm. Perhaps the problem is your method of testing, then: I test it by having one window, like the Who's Online page, or the main forum page, open, and alongside it, a window to send myself a message with. The thing is that you have to close the window, or hit the back button, before it takes you back to your PM list after sending it...remember. the private.php doesn't pop those messages up. :)

in that case I think you have solved the problem.

thank you very much for helping out, and for developing the hack, it's really cool :)

If you have any problems, please let me know. And no, thank YOU for installing the hack. :) I'm just glad some people have found it to be useful.

I installed the hack and I now get this message at the top of everypage of my board.

Warning: extract() expects first argument to be an array in /usr/local/psa/home/vhosts/forums.411hype.com/httpdocs/global.php on line 274

???

sorry, got it fixed. ignore last message.

great hack

I sill have a problem when receiving multiple pm. It is reading from single template (with blank name and subject) and is opening an error page about cannot find message. I checked the routine in global.php, it seems fine, exactly as posted.

Excellent hack, TWTCommish. Thank you!

Lionel: can you PM me some of the full files and such? I'd be more than glad to go through them and try to figure things out. :)

TWTCommish, the following error occors when I am logged in. It just appears at the top of the page. when I log-out it goes away.

error: Warning: extract() expects first argument to be an array in /usr/local/psa/home/vhosts/forums.411hype.com/httpdocs/global.php on line 274

What's the problem?

That's a very odd error. I think it implies that, for some reason, it's finding a PM without a matching username that it came from. You can email or PM me some specific code if you'd like me to try and debug it for you.

i'm still having problems, the box doens't popup when i get a new pm, and yes i do have it enabled in the user cp

please help

thanks,

Dimava

A few things to check:

Make sure that, when you send the PM to yourself, you CLOSE the window before it finishes redirectin...otherwise it won't work...that's just the way the vB Popup is. Furthermore, make sure you set it up right...get rid of any unread messages and make sure it's all "clean" beforehand. It's a pain to test, but it's the only way.

o ok, thanks works great

i have double checked and trouble checked. the templated are right. the edit to global php is right but i am getting this error i attached. and nothing pops up

Can you look at your HTML at line 88 and see what block of JS, specifically, is giving you problems? If I could take a look at the HTML output, I might be able to help.

this is what is around 88

<!-- BEGIN TEMPLATE: head_newpm -->
<script language="JavaScript">
<!--
function confirm_newpm() {
input_box = confirm("<!-- BEGIN TEMPLATE: pm_popup -->
You have a new private message from Keta entitled \"hjkk.\"\nClick OK to view it, or cancel to hide this prompt.
<!-- END TEMPLATE: pm_popup -->");
if (input_box == true) { // Output when OK is clicked
second_box = confirm("Open in new window?\n\n(Press cancel to open your Inbox in the current window.)");
if (second_box == true) {
window.open('<!-- BEGIN TEMPLATE: pm_popup_url -->
private.php?s=&action=show&privatemessageid=888
<!-- END TEMPLATE: pm_popup_url -->','pmnew','width=600,height=500,menubar=yes,scrol lbars=yes,toolbar=yes,location =yes,directories=yes,resizable=yes,top=50,left=50' );
} else {
window.location = "<!-- BEGIN TEMPLATE: pm_popup_url -->
private.php?s=&action=show&privatemessageid=888
<!-- END TEMPLATE: pm_popup_url -->";
}
} else {
// Output when Cancel is clicked
}
}
-->
</script>

<!-- END TEMPLATE: head_newpm -->
<!-- END TEMPLATE: headinclude -->
</head>
<body onload="Javascript:confirm_newpm()" background="images/apple/foot_bg.gif" text="#000000" leftmargin="0" topmargin="0" marginwidth="0" marginheight="0">
<!-- BEGIN TEMPLATE: header -->

I think the problem is the fact that you've chosen to add the template beginning/ending comments. Try turning them off...that might fix the problem.

and how do you turn that off?

edit: nvm i got it. it works! thanks !

Under your vBulletin Options screen, click on Templates -- there's only one option, I believe, under that section. Set it to "no" instead of "yes," and you're there. :)

Just installed, took me a while to get rid of the errors but it's working now :D Cheers!

Note: I'm new to these hacks so for any other newbs : make sure when you copy text, especially javascript that each piece of code is on the correct line, otherwise you'll get all sorts of errors. Also, make sure to delete any extra lines(CRs) at the end of the .php files :)

i dont realy have time to look through the whole thread to see if this has already been said but i'm having a problem...

everytime i add that code to the PHP file this error comes up...

Parse error: parse error in /home/virtual/site71/fst/var/www/html/forums/global.php on line 275

Fatal error: Call to undefined function: getpermissions() in /home/virtual/site71/fst/var/www/html/forums/index.php on line 10

Can you post lines 270-280 here, then? That's a really odd error.

its okay, i sorted it out... i think i made to many lines between the codes, to try and seperate the hack from the rest of it so i dont get confused =\

ice!~neko <--- is a newbie to vBB and hacking

Okay then. :) I hope you like it.

Great hack.. it was an improvement over what I was doing already because it has the multiple pm option. One problem though, the query as posted runs very slow on my site (166k PMs stored). I've never understood the duplicate fields in the PM table, but changing around the WHERE clause helps alot:

That uses the indexed p.userid field instead of the unindexed p.touserid. It seems to work the same and is no longer a PITA query. Thanks for the hack.

Thanks for pointing that out; I'll make the change shortly and update the instructions/file/etc. I appreciate it...and I'm honored that you'd find use for this. I'm a big admirer of your hacking, and the way you've put together your forums.

I don't know if anyone's done this yet, but I need to keep tabs on all the hacks I install. The only directions in the directions file itself were the new templates, so I made this set of instructions that were included in the first post. If anyone else wants them to keep tabs on the whole thing, here's the entire set of instructions.

i have the welcome panel hack. no i added your hack and the PM box is gone. i revert to my original files and the pm is still gone. can't see a thing. please help.

i'm having trouble looking for the original head_newpm template. can someone check if this is the original one?

<script language="JavaScript">
<!--
function confirm_newpm() {
input_box=confirm("You have a new private message. Click OK to view it, or cancel to hide this prompt.");
if (input_box==true) { // Output when OK is clicked
second_box=confirm("Open in new window?\n\n(Press cancel to open your $inboxname in the current window.)");
if (second_box==true) {
window.open('private.php?s=$session[sessionhash]','pmnew','width=600,height=500,menubar=yes,scroll bars=yes,toolbar=yes,location= yes,directories=yes,resizable=yes,top=50,left=50') ;
} else {
window.location="private.php?s=$session[sessionhash]";
}
} else {
// Output when Cancel is clicked
}
}
// -->
</script>

thanks!

I don't think we're allowed to post entire templates.

I tried installing this hack and all I could get where script errors. (Line 79). I realluy wanted it, but it doesn't look like it wants to work with my setup. If anybody has any updates that might make it work for me, I'm willing to try them. :)

Check your vBulletin Options to make sure you do NOT have each template beginning and ending with an HTML comment. If you do, the hack won't work.

I already checked that when you mentioned it in the other post. :) I reverted back to the standard popup and everything works like it should now. I'd like to get this one going if you can think of anything. :)

Hmmm. What error do you get? I'm wondering if the title of the PM or the username of the person who sent it might be interfering...

The title was Test and the name of the sender was Brandon. Normal stuff. :) It was the same kind of error that other user got at around line 88, only mine was 79. An object expected error, or something like that.

hmm. I am having a little problem.. the PM box won't Pop up....

when i view the source.. the js is there. and says the info, but it won't pop up.