vb.org Archive
Page 2 of 2 1 2
Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Moderators Functions - Show User History On Infraction Form And Postbits (https://vborg.vbsupport.ru/showthread.php?t=318633)

BrettC Frontier 07-12-2015 04:42 AM
Hi Mark,

A few bugs/issues/requests to report of on this addon.


- The text in the ACP, products, your product name shows as "MarkFL: Show Usernotes And Infraction History On I". Seems to have hit a limit or something. :)

- Would be nice to change the check boxes on the usergroup selection into a select box. Selected group names would be active, unselected would be inactive.

- The yellow background and text do not play nice with one another on the blue vbulletin admin theme. White text on yellow.

- Within user notes, if a title field is empty, it may be worth while putting N/A into the field as a placeholder.

- Within Warnings/Infractions:
  • The reason field always has a / somewhere. It would appear the slash in the code is a delimiter between a custom infraction reason and a preset reason. May be worthwhile using a "if ? :" Ternary operator php clause in that segment.
  • Infraction list does not show expiry time.
  • Infraction list does not show infraction type: warning/infraction text, only a numerical point value. May be worthwhile using the infraction icon images.
  • Infraction list does not link to the post/item that was infracted.

Observed on both sections:
- Dark themes absolutely decimate the text coloring of the rows to background coloring. The rows appear to not use vbulletin's CSS variables of blockrow, blockhead as seen elsewhere in VB.

- Having user notes and infractions all in the same blob of text is rather confusing. Moving user notes to the left side, and moving infractions to the right made the segments much more readable.

- The text bubble assigned to administrative notes on infractions should default to N/A or "No Administrative Note Assigned" if no text was put there.

- The postbit hooking appears to completely fail if there's been any edits to the segments near post counts/userinfo bits.

- Issued By / Author username is not linkable.

- "User Notes: ###" could have an additional link to the right for "Manage User Notes".

- "Warnings/Infractions" could have a link to the users profile page. For example: /member.php?u=#####&tab=infractions&pp=40#infractio ns-content


Sorry for the wall of text. Just a few knacks to advise of. :D

MarkFL 07-12-2015 06:05 AM
Hello Brett,

I truly appreciate your interest in improving this add-on, and I will see what I can do to address the issues you have outlined. :D

MarkFL 07-16-2015 09:10 PM
Update: version 2.0
  • Shortened product title so it won't be truncated in AdminCP ► Plugins & Products ► Manage Products.
  • Fixed text color on usergroup checkbox elements in product settings to be dark.
  • If usernote title is empty, displays "N/A" within user history block on infraction form.
  • Fixed infraction reason to either use chosen or custom reason, whichever applies.
  • Infractions show date/time of expiry.
  • Infractions show link to post that caused warning/infraction to be issued, using thread title.
  • Infractions are shown in descending order, sorted by time issued.
  • Background color of user history block fixed to white.
  • If no "Administrative Note" is given for an infraction, then "N/A" is displayed.
  • Execution order of postbit plugin increased to help ensure it gets run.
  • Usernames of usernote authors and infraction issuers link to user profiles.

BrettC Frontier 07-28-2015 07:14 PM
Found a slight issue with the latest version. Issuing a profile infraction rather a post infraction will cause the infraction.php page to throw up a SQL error. It's expecting a post ID.

MarkFL 07-28-2015 09:31 PM
Quote:
Originally Posted by BrettC Frontier (Post 2551607)
Found a slight issue with the latest version. Issuing a profile infraction rather a post infraction will cause the infraction.php page to throw up a SQL error. It's expecting a post ID.
Great catch! I appreciate you letting me know. I have fixed the issue. If an infraction does not have an associated postid, then "N/A" will be displayed in the post field. I have also changed the usergroup selection as you previously requested.

Update: version 2.1
  • Fixed bug regarding infraction not being associated with a post and causing and SQL
    error.
  • Changed usergroup selection from checkboxes to select elements.

Stratis 08-01-2015 11:25 AM
1 Attachment(s)
Mark very nice, I install this to my test forum, it works ok.
But that's say that some forums as mine don't use infractions, or some other don't use usernotes
How about in future if there is an option to select...

User History usernotes In Postbits Enabled?
User History infractions In Postbits Enabled?
Thanks, with some changes to my need.
Attachment 153053

imported_vauge 08-09-2015 10:51 AM
This looks awesome! How many additional queries per thread does this add?

MarkFL 08-09-2015 11:29 AM
Quote:
Originally Posted by imported_vauge (Post 2552495)
This looks awesome! How many additional queries per thread does this add?
There are 2 queries per selected user if the user history is set to display in postibts.

MarkFL 08-19-2015 02:18 AM
By request, I have made the following update:

Update: version 2.2
  • Added the display of active infraction points on infraction form.
  • Added the ability to customize the color of the active points based on value.

MarkFL 08-20-2015 01:25 AM
Update: version 2.3
  • Added the display of active infraction points on user postbits, where the number is colored as defined.

killah360z 08-20-2015 01:58 AM
Fatal error: Call to a member function fetch_array() on a non-object in /usr/www/sghosting/public/forums/includes/class_postbit.php(345) : eval()'d code on line 296

MarkFL 08-20-2015 02:07 AM
Quote:
Originally Posted by killah360z (Post 2553283)
Fatal error: Call to a member function fetch_array() on a non-object in /usr/www/sghosting/public/forums/includes/class_postbit.php(345) : eval()'d code on line 296
Strange...I'm not getting that error on either of my dev sites.

Try the following:

1.) Open the plugin titled "Usernote Information In Postbits"

2.) Locate the line:

PHP Code:
    $markfl_infraction_activepoints = 0; 
3.) Directly below it, add:

PHP Code:
    global $db; 
4.) Let me know if that works. :)

BrettC Frontier 08-20-2015 04:39 AM
I'm a bit confused why it's not showing up on postbits for me (namely postbit_legacy).

I can see it is hooked to postbit_display_complete, and it additionally has a hook set for postbit_userinfo_right_after_posts. However nothing appears to be showing, even after configuration settings were applied and enabled.

The only other plugin running is https://vborg.vbsupport.ru/showthread.php?t=227946 which has the same hook, with an exec order of 5 rather the setting that yours has of 20.

killah360z 08-20-2015 04:57 AM
when giving an infraction

Code:
Database error in vBulletin 4.2.3:

Invalid SQL:

                        SELECT thread.*
                        FROM thread AS thread
                        WHERE threadid =;

MySQL Error  : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 3
Error Number  : 1064
Request Date  : Wednesday, August 19th 2015 @ 11:56:36 PM
Error Date    : Wednesday, August 19th 2015 @ 11:56:36 PM
Script        : http://silentgamerz.com/forums/infraction.php?do=report&p=456
Referrer      : http://silentgamerz.com/forums/threads/185-asd-tripped-AE-detector
IP Address    : 124.195.207.82
Username      : KillaHinstinct
Classname    : vB_Database
MySQL Version : 5.6.22
happens on v2.2 & 2.3

--------------------------------------------

nvm looks like it magically got fixed on its own ;d

--------------------------------------------

its back again

MarkFL 08-20-2015 05:09 AM
Quote:
Originally Posted by BrettC Frontier (Post 2553288)
I'm a bit confused why it's not showing up on postbits for me (namely postbit_legacy).

I can see it is hooked to postbit_display_complete, and it additionally has a hook set for postbit_userinfo_right_after_posts. However nothing appears to be showing, even after configuration settings were applied and enabled.

The only other plugin running is https://vborg.vbsupport.ru/showthread.php?t=227946 which has the same hook, with an exec order of 5 rather the setting that yours has of 20.
I gave it a higher execution order so it would display the data below other postbit data that might be hooked there. I have a dozen or so add-ons hooked there, and no issues whatsoever on either of my 2 test sites. :confused:

killah360z 08-20-2015 05:19 AM
Quote:
Originally Posted by MarkFL (Post 2553292)
I gave it a higher execution order so it would display the data below other postbit data that might be hooked there. I have a dozen or so add-ons hooked there, and no issues whatsoever on either of my 2 test sites. :confused:
uh wait i was wrong it is back again weird ( happens randomly )

MarkFL 08-20-2015 05:33 AM
Quote:
Originally Posted by killah360z (Post 2553293)
uh wait i was wrong it is back again weird ( happens randomly )
I just gave 4 infractions in a row on my dev site...everything works perfectly. 2 were profile infractions and 2 were on posts.

Exactly how are you giving the infractions?

killah360z 08-20-2015 05:50 AM
Quote:
Originally Posted by MarkFL (Post 2553294)
I just gave 4 infractions in a row on my dev site...everything works perfectly. 2 were profile infractions and 2 were on posts.

Exactly how are you giving the infractions?
by clicking the icon~

https://vborg.vbsupport.ru/external/2015/08/18.png

MarkFL 08-20-2015 05:54 AM
And when do you get the error? I get no errors on my end, so I need to have detailed information about what is happening on your end if I am to be able to figure out what changes I have to make to accommodate your site/settings.

killah360z 08-20-2015 06:34 AM
as i said the database error comes when i press the button like i'd be lead to
/infraction.php?do=report&p=456
also it is really weird how i am getting this error from just 1 user ( its my test account ) any posts made by the account gives off the db error every other post is fine o_O

MarkFL 08-20-2015 06:45 AM
Try this:

1.) Go to the plugin titled "Renders Usernotes/Infraction History Data On Infraction Form"

2.) Locate the line that reads:

PHP Code:
        if ($postid) 
3.) Change it to read:

PHP Code:
        if (intval($postid) > 0) 
4.) Let me know if this works.

killah360z 08-20-2015 07:48 AM
didn't work

MarkFL 08-20-2015 02:01 PM
Quote:
Originally Posted by killah360z (Post 2553300)
didn't work
Try repairing your tables.

killah360z 08-20-2015 03:37 PM
Quote:
Originally Posted by MarkFL (Post 2553319)
Try repairing your tables.
that didn't work either

Alan_SP 12-11-2015 06:57 AM
For some reason your mod interferes with mod QAS: https://vborg.vbsupport.ru/showthread.php?t=237286

If your mod is active, changing active user works quirky. At the moment I find QAS more important. But, if you're willing to test why your mod breaks QAS, it would be great.

And, testing your mod, I didn't succeeded to see postbit info, but it's not that important.

MarkFL 03-18-2016 01:38 PM
Update - Version 2.4:
  • Corrected typo preventing templates from being cached.

Innsomnimaniac 03-19-2016 09:20 AM
Where are the options located? I can't seem to find them.

MarkFL 03-19-2016 01:14 PM
Quote:
Originally Posted by MaxwellMorphine (Post 2567633)
Where are the options located? I can't seem to find them.
Follow:

AdminCP -> Settings -> Options -> MarkFL: Show User History v2.4

Leebo89122 05-06-2017 09:32 PM
Quote:
Originally Posted by killah360z (Post 2553291)
when giving an infraction

Code:
Database error in vBulletin 4.2.3:

Invalid SQL:

                        SELECT thread.*
                        FROM thread AS thread
                        WHERE threadid =;

MySQL Error  : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 3
Error Number  : 1064
Request Date  : Wednesday, August 19th 2015 @ 11:56:36 PM
Error Date    : Wednesday, August 19th 2015 @ 11:56:36 PM
Script        : http://silentgamerz.com/forums/infraction.php?do=report&p=456
Referrer      : http://silentgamerz.com/forums/threads/185-asd-tripped-AE-detector
IP Address    : 124.195.207.82
Username      : KillaHinstinct
Classname    : vB_Database
MySQL Version : 5.6.22
happens on v2.2 & 2.3

--------------------------------------------

nvm looks like it magically got fixed on its own ;d

--------------------------------------------

its back again


I too keep getting this error when it's installed. Any idea why this is occurring?

MarkFL 05-06-2017 09:55 PM
Quote:
Originally Posted by Leebo89122 (Post 2586257)
I too keep getting this error when it's installed. Any idea why this is occurring?
No idea...I have this running on two sites, and have never seen that error. :)

migratoria 08-19-2017 02:48 PM
ONLY FOR INFO

Yet Another Award System generate a conflicts during the uninstallation phase with:

MarkFL: Show User History 2.4

MarkFL 08-19-2017 04:56 PM
Quote:
Originally Posted by migratoria (Post 2589457)
ONLY FOR INFO

Yet Another Award System generate a conflicts during the uninstallation phase with:

MarkFL: Show User History 2.4
Can you be more specific? :)

migratoria 08-19-2017 05:30 PM
If both are installed on vbulletin 4.2.5 "Yet Another Award System" generate a conflicts during her uninstallation

MY LOG:
mod_fcgid: stderr: PHP Fatal error: Call to a member function fetch_array() on null in /forum/includes/class_postbit.php(345) : eval()'d code on line 261

This error Generates a crash when displaying a topic


All times are GMT. The time now is 04:45 AM.
Page 2 of 2 1 2
Show 40 post(s) from this thread on one page

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01305 seconds
  • Memory Usage 1,830KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (4)bbcode_php_printable
  • (13)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (33)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete