vb.org Archive - Major Additions - [OzzModz] Closed Thread Reason

Page 2 of 2

Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- Modification Graveyard (https://vborg.vbsupport.ru/forumdisplay.php?f=224)

- - Major Additions - [OzzModz] Closed Thread Reason (https://vborg.vbsupport.ru/showthread.php?t=313594)

ozzy47

08-16-2014 03:00 PM

No, the image is not in the background. :)

ozzy47

08-16-2014 03:51 PM

Looks like I might just have it licked, v2.0.0 is working on Alan's site just fine. Will wait to see if he comes back on.

ozzy47

08-16-2014 04:03 PM

But I do see a couple of issues I need to fix. :(

CAG CheechDogg

08-16-2014 04:42 PM

ok good stuff ...

ozzy47

08-16-2014 07:34 PM

v2.0.0 Released August 16th 2014
- Completely rewrote the mod.
- Fixed a issue with the mod not working on some sites.
- Added the missing phrases, now the mod is fully phrased.
- Increased security.
- Added a option to show a closed thread image in the block.
- Added a option to set the image name, so you can easy change it to one of your choosing.
- Added a option to select which forums the mod will work in, if the thread is closed.
- Added a option that if you allow guests to see the thread closed reason block, to show them a message asking them to register to see the reason for the thread being closed.

ozzy47

08-16-2014 07:43 PM

@Alan_SP, your site is running the latest version, but you may want to grab the new files anyway. :)

Alan_SP

08-16-2014 08:15 PM

I just tested how it works on my site. It works great now. :up:

Only thing I noticed is that there's no easy way to select all forums, I needed to select them all manually. If there could be option to easily select all forums? For example, in the beginning to have option for none, all and then list of all individual forums? Or maybe option if we want to select individual forums or not? For example, I want to use it everywhere.

Especially as some of guests could be curios why thread is closed and they might register just to see this reason, as now we can choose not to show them reason, but "please register" text instead. :D

And yes, I'll download installation files just in case, thank you. :up:

ozzy47

08-16-2014 08:19 PM

Click the first forum in the list, scroll down to the last forum, then hold shift, and right click on the last forum.

You can change the message the guest see's by editing the phrase, ozzmodz_t_closed_reason_guest

Alan_SP

08-16-2014 08:44 PM

Yes, I did that for selecting all forums, just thought that it might be easier for some people... And you don't need to right click, left click works just fine. Acutally, I don't know what would be if the right click is used?

And yes, I translated everything important, including guest message. Hopefully over the time there would be some curios users who would register just to see why thread has been closed. :D

ozzy47

08-16-2014 08:54 PM

Yeah there is no easy way to gt all forums in the vBoptions that I know of.

Would be nice to get some people to register to see the reason. :)

Alan_SP

08-16-2014 09:05 PM

Well, your mod can at least help somewhat to get those curios enough to register. :D

And just to mention, there's some minor spelling errors, nothing that impacts the way the mod works (or I didn't noticed that for the moment).

For example:
_______

So by setting this to "Yes" you will stop dmins and moderators from being able to reply to closed threads.

Note: Of course this will only work if the selected usergroups are a admin or moderator group.

Set this to "Yes" to chow a thread closed image in the closed reason block.
________

As you can see, nothing big, but just to mention...

ozzy47

08-16-2014 09:08 PM

Crap, I will get those fixed up in a future update, that's what I get for coding when I am tired. :)

Alan_SP

08-16-2014 09:34 PM

And I just tested with really long thread closing reason, and there's a bit of overlapping text with image. Take a look: http://slobodni.net/t116947/ (log in as ozzy47 to see how it looks)

I noticed that you reduced image to 125x125 in CSS, as I'm using a bit larger image (I removed this image restriction in CSS), then I first noticed this. But, it still appears even with 125x125. Maybe to use tables to separate image from text, just in case if someone needs to use really long reason? Or some other way that restricts text right of the image?

ozzy47

08-16-2014 09:55 PM

To fix the text overlapping the image, in the ozzmodz_t_closed_reason.css find the following:

Code:

#ct_image {

    position:absolute;

    padding-left:2px;

    width:125px;

    height:125px;

    float:left;

}

And remove the line:

Code:

position:absolute;

I think I had that in there when I first added the image.

ozzy47

08-16-2014 10:00 PM

I have updated the zip to include the above fix, and the spelling corrections. :)

So if anyone downloaded v2.0.0 before this post, please re-download, only the XML has changed.

CAG CheechDogg

08-17-2014 04:04 AM

Nice..good stuff Ozzy and Alan ! I come back from a nice long nap and I see this...im SO EXCITED ! LOL ............

CAG CheechDogg

08-17-2014 05:04 AM

So far so good ! everything is good to go !

I did make a few changes like changed the name of the folder where the image is in, I aligned the text and image to the left instead of center and the size of the image as well in the css.

But everything is looking smOOOOth! Thank you Ozzy! Once again great work my Man!!!

woodmj

08-17-2014 07:26 AM

Strange. Uploading the new files to my site crashed it with a DB error. I needed to remove the files to get to my ACP and then uinstall the mod to get the whole site working again. I'm on 4.2.2 Patch 1, mySQL 5.5.38.

ozzy47

08-17-2014 07:43 AM

What was the error?

woodmj

08-17-2014 08:27 AM

Unfortunately I didn't write it down and when I tried a fresh install there was no error but the mod just remained inactive even though it was set to active in Options in the ACP.

ozzy47

08-17-2014 08:29 AM

Did you set up all the options for it to show on closed threads?

Alan_SP

08-17-2014 10:35 AM

I installed latest version, image and text are now fine.

Spelling wise, isn't this:

Of course this will only work if the selected usergroups are in a admin or moderator group.

should be:

Of course this will only work if the selected usergroups are in an admin or moderator group.

Because admin is pronounced with an a sound?

And maybe feature request (although I know I can manually edit CSS) so we could easily impact how closing reason looks like. Bigger text, or bolder, or maybe even different color?

ozzy47

08-17-2014 10:38 AM

You can use bbcode in the reason.

Alan_SP

08-17-2014 11:35 AM

Great, I was wandering, is it HTML or BBcode we can use there. :up:

ozzy47

08-17-2014 11:41 AM

Yeah I thought bbcode would be the easiest. :)

thetechgenius

08-22-2014 02:28 AM

Is there any way to make the Box smaller? I think it looks to big when there is only a single line of text for the reason.

ozzy47

08-22-2014 08:18 AM

Quote:

Originally Posted by thetechgenius (Post 2512294)

Is there any way to make the Box smaller? I think it looks to big when there is only a single line of text for the reason.

Sure, first mark the mod as installed, then open the file, ozzmodz_t_closed_reason.css, under the group, CSS Templates and find this bit of code:

Code:

.ct_block{

    padding: 10px 0px 10px 0px;

}

And change it to this:

Code:

.ct_block{

    padding: 10px 0px 10px 0px;

    width:700px;

}

Adjust the 700 as needed. :)

mitch84

08-22-2014 03:04 PM

installed & nominated, great idea! thx

ozzy47

08-22-2014 03:08 PM

Quote:

Originally Posted by mitch84 (Post 2512357)

installed & nominated, great idea! thx

Glad you like it, and thanks for marking as installed, and nominating it. :)

thetechgenius

08-24-2014 10:01 PM

Quote:

Originally Posted by ozzy47 (Post 2512314)

Sure, first mark the mod as installed, then open the file, ozzmodz_t_closed_reason.css, under the group, CSS Templates and find this bit of code:

Code:

.ct_block{

    padding: 10px 0px 10px 0px;

}

And change it to this:

Code:

.ct_block{

    padding: 10px 0px 10px 0px;

    width:700px;

}

Adjust the 700 as needed. :)

Installed, and thank you! ;)

ozzy47

08-24-2014 10:03 PM

Not a problem, glad to help. Also thanks for marking as installed. :)

Alan_SP

09-13-2014 10:05 PM

Just noticed one thing: If there's no closing reason given, user's who are able to see closing reason see it (and if they're guests, they see special guest message).

But, description of this option is this:

Quote:

Select which usergroups can see the closed message, if the thread is closed, and there was a reason added.

Because of it I was thinking they would see reason for closing thread only if it is given, not message that no reason is given at the moment.

And that made me thinking about a new feature request, that we have option to see thread reason only if it exist. Other option is that we see it in any case, even if thread is closed without given reason.

Or just change description, to set which usergroups would see closing reason, whether it exist or not.

ozzy47

09-13-2014 10:12 PM

Well you are supposed to be able to see if if no reason was given, so you could always add one at a future date.

Now if you mean users that can see it, but can not give a reason, I will have to see about adding that.

Alan_SP

09-13-2014 10:28 PM

Yes, I'm talking about users, not about staff members that are able to give reason. I was testing mod for welcoming new users just to check if registration goes well and I noticed that reason is visible even if it wasn't given.

ozzy47

09-13-2014 10:30 PM

I can see about adding such a option at some point. I did not add it originally as that is not the way I invisioned the mod. :)

Alan_SP

09-14-2014 09:26 AM

I thought that reason isn't visible because how option was described, so it was a bit of surprise to see every closed thread shows reason to users. Which made me thinking, maybe someone would want only to show it if reason is actually given.

ozzy47

09-14-2014 09:49 AM

True, but I would think users would like to see that their was no reason given. Either way, I'll look into adding it. :)

All times are GMT. The time now is 07:39 PM.

Page 2 of 2

Show 40 post(s) from this thread on one page

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01847 seconds Memory Usage 1,808KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (6)bbcode_code_printable (4)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (1)pagenav_pagelink (1)post_thanks_navbar_search (1)printthread (37)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: