Yes I saw that unsubscribe auth link while going through the phrases for email body text. I also saw a couple of links that led to the usercp being used as unsubscribe links.

Either way, what you've done works awesome as far as my host is concerned, and I've already gone though all of the email body text phrases adding the link to your mod and removing any others I found.

I suppose I could have done it the other way around, but I didn't look at what the unsubscribe links did and felt my way was just ... easier :D

No problem at all with the release not being tonight :) I'll do some more sleuthing when it cools off here in regards to the smilie page issue and get back to you.

--------------- Added [DATE]1342060732[/DATE] at [TIME]1342060732[/TIME] ---------------

Ok the message that pops up is - could not find phrase unsubscrib_done and then sends me to the index page :D

You are correct, turning off "receive admin emails" does not stop thread subscriptions (and I'm going to assume group and others as well), and I think I figured that out yesterday which is why I added the condition to set thread subscriptions to "do no subscribe". I figured doing that and adding the unsubscribe link would be enough to cover my butt ... and the host agrees. In fact they wonder why I bothered adding all of that other stuff ... but screw them they suck :D

You should post this as a plugin once all bugs are worked out

I believe he (Kevin) intends to do just that :)

--------------- Added [DATE]1342065400[/DATE] at [TIME]1342065400[/TIME] ---------------

I figured out why this was happening. During my sleep deprived state last night comparing the new version and the old version I accidentally copied over a snipet of code from the old version and imported the contaminated version to my live site :D Once I removed the code everyone works properly now :)

OK, I'm glad you got the error message worked out. Sounds like you've pretty much got yourself straightened out. As fo rthe thread subscription unsubscribe links, I had a look and it's actually pretty much the same thing we're doing. The auth code is a hash of the user id and subscription id, and it's used to unsubscribe without needing to log in, the same as we're using the email address. I think in general it might still be useful to expand the page on our mod to let the user choose what they want to unsubscribe from, and have an "I don't want any more email" box.

When you said your host "wonders why you bothered adding all of that other stuff", what do you mean exactly - that you added another unsubscribe link to the subscription emails?

In any case, do you need anything else? If you're all set with your host I'll just take my time (...and probably never get it released :) ).

That would be a crying shame as that should be built in to vb!

Yeah, I was just joking because that's happened to me with a few other mods - that I have them virtually complete then never actually get around to releasing them. I'll make sure I get this one done.

I want to run a couple of tests today with regards to the thread subscriptions. Mainly I want to know if setting the default to 'do not subscribe' will prevent existing subscriptions from sending emails. If it does not, then I'd test to see if setting the default to 'control panel' stops sending emails for existing subscriptions. That way we don't have to delete existing subscriptions :) I'll actually be doing that after this post :D

If either one of those works, then you do not need to incorporate anything different as I have already done so in the modified version of the old mod.

In regards to the host, I told them exactly what I tweaked the old mod to do (ie turn off pms, turn off vcard, deselect the 3 email settings, and change the thread description. Personally I'd rather do all of that vs just the 'receive admin emails'.

--------------- Added [DATE]1342113466[/DATE] at [TIME]1342113466[/TIME] ---------------

Ok simply changing the default subscription mode does not prevent emails from being sent on existing subscriptions :( If you would be so kind as to include the ability to unsubscribe from existing subscriptions that would be awesome.

Personally I don't have the blog system on, but I'm sure others do, and I can wait until you get it all sorted out since my host turned on my emails :)

Let me know what you find out - but like I said, I'm pretty sure neither the "admin email" nor the "default subscription" settings affect existing subscription emails. But what you can do is set all existing subscriptions to "no notification" (or whatever it's called) using a few queries, that way if someone changes their mind they won't have lost their list of subscriptions.

I guess you read my first reply but missed the second before logging off :) Changing the option does not affect existing subscriptions. I absolutely love the idea of setting the existing subscriptions to "do not subscribe" instead of unsubscribing them. That is awesome!

So are you done yet? ;p ;p

--------------- Added [DATE]1342115148[/DATE] at [TIME]1342115148[/TIME] ---------------

I have finished placing the unsubscribe link in all of the email body text phrases. I haven't tested EVERY possible scenario but I feel confident enough that adding a couple of lines in each phrase will cover any outgoing email with the exception of the admin sending mass emails. I'll look into that a little later today.

For those interested this is what I added to all of my "email body text" phrases.

There are some phrases that already contain $vboptions[bbtitle] so make sure you delete them or you will have duplicate bbtitles in one email ;)

Yeah, I did see your reply after I posted. I'll work out how to reset the subscriptions.

I'm not done - I have to confess I haven't made any progress on it today, and I have to go out for a while this afternoon. Maybe tonight.

Edit: ...and if you have any other changes you want me to look at and possibly include, go ahead and post them.

With the reset of the subscriptions I can't think of anything else that would be needed.

Don't know what you think of this but maybe a way to re-subscribe or request a mail back with the subscribe options in it. I only say this because you know how people are, if they've turned it off as sure as eggs are eggs they'll want to turn it back on at some point!, if we could make that process automated then they won't bother admins or staff and create more work for their pay! (what, you don't pay your staff? :D )

So you want a "re-subscribe" option? How would that work if they delete the unsubscribe email? Perhaps have this plugin send the user a pm explaining what options were changed in case they would like to change them back in the future. If I could pay my staff I surely would :D

Me too!, i suppose the pm is fine as long as notifications we're turning off are ones that we can turn back on easily, if for instance you blocked birthday emails that would be done with a database query...etc so not something we can easily turn back on this is why i suggested a way of requesting a "Subscribe Options" email, if we're just blanket turning off admin mails then thats easy enough to direct them on how to turn those back on.

Like i've said before, just thinking or brain farting out loud :)

Actually the blocking of birthday emails is done by deselecting the "receive emails from admin" option. But yes the pm would contain a list of options that were changed and how to change them back to however you want them :)

--------------- Added [DATE]1342196403[/DATE] at [TIME]1342196403[/TIME] ---------------

It just dawned on me, I don't know for sure which settings you have already included into this mod.

What I think it should include (to be the most comprehensive unsubscribe mod to date) is: turn off email from admins, turn off email from other members, turn off friend requests, turn off emails for new pms, turn off vcard download, set subscriptions to "through control panel only", reset existing subscriptions to "through control panel only", move the user to a different user group, send the user a pm explaining what changes where made and where to change them back if they want.

That bit takes care receive email from members, receive email on friendship request, new subscriptions to "through control panel only", turns off vcard, and turns of emailonpm.

So at 4 am this morning I woke up with an idea on how to incorporate into this mod Simon's idea for a resubscribe link.

In the pm that is sent out stating that such and such settings have been changed to ensure you no longer receive emails from our site, a link is included to "resubscribe" the user. The link would take you to a page (not the user cp) with only the settings that were changed and explain in a little more detail what the settings do and the option to change / reselect them. Then the users clicks a radio button saying "yes I want to receive emails from websitehere that correspond with the settings I have selected". Once the radio button is checked the input box for their email address becomes available and they enter their email and click the resubscribe box.

That way a user has to "double opt in" and has no ground to claim any of the emails as spam :)

Under the resubscribe box is a note that states "In order to receive emails from websitehere you need a valid email address. To update/change your email address click here before submitting." That link would open a new window to the change email / password in the users cp (since they're already logged on to read the pms).

I think if you could incorporate that, this mod will become very popular, and perhaps if the devs really do have some smarts they'll incorporate it into the core at some point :)

John, exactly my thoughts, only i was thinking of it in a one shot mail, the one they get to unsubscribe also has the options to resubscribe (negates the need for extra coding in templates..etc) but your idea can work just as well and like you say, a seperate page gives you the space to explain a little more (Kevin, don't forget to make this compatible with at least vb3.7.x onward, it's gotta be the most "Must have" mod idea to have ever come about), and hopefully they'll take this on in vb5 :)

The only small issue I see with the resubscribe stuff is that it's actually possible (as far as I know) for a member to be subscribed to hundreds of threads and forums and have a different type of notification for each, so if we set them all to "no email" then we won't remember what they were (unless of cource we save all that somewhere - I suppose we could make a huge string).

And that is the issue, if you turn off forum subscriptions (the user may have only wanted to turn off the odd one or two) then it's a pain for the user to resubscribe to each, so either you do need to save all the unsubscribes in a string in the db or explain to the user that it turns all of them aff and that they'd have to visit each forum to turn on the ones they want (i've built a mod for this vb3 for easy selection all in one place, which if you want the code i'll gladly donate it), see that attached for how my mod works :)

Just set them to "through control panel only" that way they keep their subscriptions but don't get the emails. They can then choose to receive emails upon thread subscription, sure they'll have to go through it thread by thread ... but it's the price they'll have to pay for unsubscribing then resubscribing.

My thoughts are, if they want to unsubscribe from all emails then it's on them to reselect the ones they want if they change their mind later on.

I think having options in the ACP to choose what the unsubscribe button does would be the best bet. Then you would have to tell them (admins) to change the phrase(s) to reflect what settings are changed when a user clicks the button.

The reason I suggest a pm vs email for the resubscribe is (at least in my case(s) ), the user will most likely delete the email and therefore have no idea what was changed. There is a better chance at them saving a pm then the email ;)

Hi Kevin :)

Have you been able to work on this mod lately? Curious to know where you are at with it :)

I haven't made much progress but I haven't forgotten about it - I'll get to it soon. :)

Have you solved all your email problems?

As far as the host knows I have ;) I'm actually just waiting for this mod as (assuming it does everything we've discussed) it's a complete solution for unsubscribing :)

I remember it being brought up on the first page, were you going to incorporate and option to move the unsubscribers to a different user group? I think that should be an option so we can see how many people are unsubscribing ;)

Hey John - I kind of figured you had given up on this since I saw that you had posted in one of the other mods. Anyway, I asked Simon Lloyd if he wanted to take over working on this (so it might actually get done), but I think he's been too busy.

Send me what you have and I'll fiddle around with it :D I only posted in that other mod to help that guy. This mod here (this thread) is the one I'm after ;)

--------------- Added [DATE]1343974087[/DATE] at [TIME]1343974087[/TIME] ---------------

Ok all I have left to do is code the move to a different user group and code the options for the ACP. I worked out how to change existing subscriptions to "through control panel only" :)

I'll wait and see what you've got before I continue as I'm quite tired tonight.

Hi John, Kevin's right, i haven't had time at the moment, i've been looking at the product that Kevin uploaded here and he's pretty6 much got it down except the re-subscribe or keeping a record of what the user unsubscribed from, or allowing a page where all the things they unsubscribed from are present to resubscribe, i cant say when i'll have time at the moment as i have many things going on on along with 7 day working at the moment.

That's alright I've been working on it myself :) However I'm a bit stumped. Trying to add the option (I add them one at a time to make trouble shooting my screw ups easier :D ) to change new thread subscriptions to "through control panel only" and when I import the XML I get the following error;

XML Error: XML_ERR_NAME_REQUIRED at Line 153

Line 153
Every solution I have seen says it's the & not being parsed (which I have none), so that's where I'm stumped, it looks fine to me.

The setting looks like (followed Kevin's format obviously)

The last one posted here is pretty much all I have.



What does the line before that look like?

Line 152

Hmm...that doesn't help. Look at the surrounding line for missing quote or unusual characters.

It was a missing ! in the following line :p

I'm about to head to bed after staring at this damn mod for 2 hours trying to find my error.

It imports just fine and the settings work, but when I go to /mics.php?do=unsubscribe all I get is the smiley page. No errors.

So I'm going to attach it here and maybe someone can find the error for me :D

It's not complete yet, still have to do the user group stuff, the resubscribe stuff, and find a way to store the existing thread subscriptions. The plan for the subscriptions is to create another table to copy the users subscriptions to and the query to take the data from the backup table and repopulate the original.

EDIT: It was a simple typo in the template name :D So with no errors I can now work on the user group stuff :)

Ok I'm a bit stuck and a little confused (and not about the same thing :D ).

I basically followed Kevin's "select" and "update" queries to add the other options to be changed. However I'm a little confused why the "select" query selects username and userid when the "update" query doesn't use those variables.

Select query
Update query
Now to the part I'm stuck on.... thread subscriptions. When I use my "select" query it triggers this if statment:
This is the select query
I have other issues with thread subscriptions, but I figure I should find out what's wrong with my select query first :D

Is it because the subscribethread table doesn't have an email column?

I don't remember why the query included username and userid, I suppose I thought I needed them (or might need them) for one of the other features we talked about. But it also doesn't hurt anything to have them there.

You're right, the subscription table doesn't include email, so there's no reason to check for that field being blank. Also I don't think you're checking correctly for multiple values of emailupdate. I think you want something like:


I think have "OR 2 OR 3" on the end of the query like that will cause it to return every row.

Oh, that brings up another issue - since you want to return every record of a user's subscriptions, you can't use query_first(), you need to use query_read() and then use a loop to get each record.

Thanks for the tips on thread subscription :) I thought it was the '$id' that was returning every row, I'll use IN and see what happens :D

Ok I have confused myself once again :D The subscribethread table has one column (subscribethreadid) that is auto increment, according to this website https://www.vbulletin.com/docs/html/...ards_sql_query I'm not supposed to include that field in an insert query.

I have tried the following queries which result in different errors.


error

I don't understand how to use VALUES in this case (because the values can't be hard coded IE 5 for userid etc etc), everything I've tried results in syntax errors. So what would I put after VALUES?

So I went with the SELECT * to insert everything from subscribethreads.

error

None but it doesn't populate unsub_subscribethread, is it because of the auto increment column in subscribethread?

According to this website http://www.w3schools.com/sql/sql_select_into.asp I should be using SELECT INTO to copy subscribethread to unsub_subscribethread (vs INSERT INTO) at least that's how I understand it so I tried;

error

Now I can only guess that this is caused by me creating the table unsub_subscreibethread in the "<installcode>" at the start of the plugin (code is below for reference). If I understand what SELECT INTO is supposed to do, it's creating the table "unsub_subscribethread" on the fly? So this wouldn't work because it would try to create the table each time the script is run?

I haven't tried these, but I think there's two things you can do: when a column is auto increment, you don't want to supply a value but you can put NULL as a placeholder. You can put NULL where you'd put a column name in a select, and that value will always be null. So I think this would work:


The other way would be to list each column and leave out the id column, like:


BTW, for future reference you can see some of this in the mysql manual, for instance here's the page for the INSERT statement: http://dev.mysql.com/doc/refman/5.0/en/insert.html

Well so far nothing has worked as far as populating unsub_subscribethread. However plugging each query into phpmyadmin (removing the table prefix and defining a user) works.

So it's either not pulling the userid properly, or my loop is screwed up (which certainly wouldn't surprise me). I'll have to do some more reading and hopefully find an good loop example instead of the crap that's in the tutorials.

A week ago or so I screwed up and deleted my "good" file for the mod and instead saved the "working" copy. Well when I navigate to the page on my local test site for testing I get the following error;

What on earth is it looking for? I have not found any open brackets anywhere :(

While I am on this subject ... why are there two ' after the ] ? For that matter why is there a ` before it?

misc.php code from line 80 to 89