Hello , this is looks very good mod , can i ask , is the attachments storage in the selected path in server or database as others or only in database ?

How can this be on the mod of the month list? Surely it should be on most anticipated working mod of the month list???

is it safe to install it on vb 4.2.0 suite ?

I installed on 4.2 but get db errors and it does not work, I would wait.

My error on addiing xml:

Database error in vBulletin 4.2.0:

Invalid SQL:

UPDATE pm AS pm
SET attach = (SELECT COUNT(*) FROM attachment WHERE contentid = pm.pmid AND attachment.contenttypeid = );

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 2
Error Number : 1064
Request Date : Saturday, July 14th 2012 @ 02:47:58 AM
Error Date : Saturday, July 14th 2012 @ 02:48:00 AM
Script : http://www.thewoollybacks.co.uk/test...=productimport
Referrer : http://www.thewoollybacks.co.uk/test...?do=productadd

Same here.

Database error on installation for me as well. Running 4.2 PL1.

Yep. Got exactly the same error and the installation would not complete.

Are both beta 1 AND beta 2 only for 4.2? Is anyone running either of these on 4.1.X?

Tagged for final version. Much anticipated.

Hopefully this will also allow attachments in the calendar editor as well. Seems like it's the same editor box. Or it may need a separate mod.

Thanks

>Duplicate entry 'PMAttachments' for key 'class'

Same...

No Joy on install, great product if it worked something that has been lacking in VB for a long time. Wish it was working .

So, it doesn't work ?

yep, does not work, actual error:

the problem is, that:

vB_Types::instance()->getContentTypeId('PMAttachments_PrivateMessage' )

returns an empty value.

for everyone with that duplicate errors, thats because database fields get added to existing tables before the script breaks.

need to remove a few:
from table "pm" remove "attach" and "attachmap"
from usergroup remove "advpmpermissions"
from packages remove the entry "PMAttachments"
from contenttype remove the entry "PrivateMessage"

the productinstaller of vbulletin is unable the remove database entries when theyre duplicate, even if you choose overwrite as an option, plus the script actually breaks before putting the entry into the products manager...

ps: bitte koenntest du die titel fuer die plugins ins englische umbenennen, fuer unsere uebersee freunde;-)

ps: even after fixing the obvious errors (VBForum_PrivateMessage instead of PMAttachment_PrivateMessage...), opening the newattachment.php link causes an error

looking at the link i see a major difference between a working and non working url for calling newattachment.php:

doesnt work:
does work:
just a first glimpse...

Thanks Andreas!

I have completed a similar hack for my company (in the core files, not a plugin). Your code examples helped me tremendously. Very, very grateful! :) Let me know if I can reciprocate.

Aside from the headaches of cleaning up our database tables from a previous failed Product XML Upload failure due to "Database Error" so as to return all the table entries and fields to a virgin state, I also ran into the following faults in the original XML file:

1. Very Minor - Descriptions alternate between German and English in both the XML file and portions of the instructions files -- all the Plugin titles are in German for instance. I don't want to harp (or even really complain for that matter) on this one because language is inherently relative to the observer, but I figured I should probably mention it for consistency's sake.
2. On Lines 160 and 261 of the XML file, the SQL Query does not properly reference tables that have a vBulletin TABLE_PREFIX attached to them... The initial FROM statement is correct, but the "as attachment" portion of the Query is missing, so the query fails a bit further in when the table.fieldid "attachment.contenttypeid" is called. This will only fail for sites that have defined a TABLE_PREFIX value, but should be corrected.
3. The more troublesome one (for me) was on Line 160 (again) where "attachment.contenttypeid" is set:
   
   
   PHP Code:

   ---

   attachment.contenttypeid = " . vB_Types::instance()->getContentTypeId('PMAttachments_PrivateMessage') . ") 


   ---

   It appears that the call to getContentTypeId is coming too early in the process, as the value returned is an empty string rather than the intended value. However, this same code works later on come line 261, so clearly it is an order-of-execution issue. This suggests that this query should be moved until after the "pmattachments" row has been added to the "packages" table so that the call does not fail.
   
   I temporarily worked around this issue by hard coding the next Auto Increment value to be assigned to the next record ID for the "packages" table so that I could at least get the Product installed ("13" in my case, after some earlier failed attempts and cleanups).

I apologize for having to submit these changes rather than a corrected XML Product File. I am comfortable enough to make minor tweaks to the XML files, but I am not comfortable enough with my knowledge of the XML file's layout to make wholesale changes so that I can change the order of execution of the "contenttype" table's record insertion. Especially not comfortable enough to submit something that others will run on their servers!



Despite my concerns, I do greatly appreciate your sharing this plugin with us as our users genuinely want the functionality without having to wait for vBulletin to get around to releasing such. I hope my suggested amendments will help both yourself and other users trying to install the product. The instructions user nevbear666 provided for backing out the database changes were most valuable to eventually getting the product installed (after making my above changes), they certainly saved me some time.

works good :D

on which vb version ?

I too got an SQL error. Amazing some people put their unfinished and error-prone product to public use and then not willing to help. Bad product.

damn it, this worked perfectly on my test server and now not working on my main site. Does anybody know the database entries I can remove by hand to remove this mod?

Not working on VB 4.2

Mod doesn't work!!!

Yay! now my database is inconsistent...

Ding ding ding! I agree! Already lots of complains from my members about this lack of seemingly obviously functionality that is missing.

Have someone tips how to remove this product? Gives database error when try to remove.

regards

bosss

Just noticed this post, but in the mod information:

Perhaps check this next time? :)

Not relevant IMO. The mod is listed as a mod for 4.2 yet it does NOT work in 4.2 for ANYONE. It should be pulled as it works for no one at all using vb 4.2. How can a mod be listed for 4.2 and NOT work for it? Whether its supported or not it should at least work for someone.

Quote from OP promising a beta 3 version, this was in June 2012 so many months ago. I'm guessing this has been abandoned now.

I have a database error as well:

Great, now I receive a database error any time I try to make any changes to the usergroups even if it has nothing to do with pm attachments.

Does anybody know what needs to be removed from the database to get rid of this mod?

SIGH.....When I try to uninstall I get this now...

For those of you who have experienced problems sending or getting PM'S after installing this buggy hack the best thing I can suggest is to disable the hack in your products. I cannot uninstall the product to save my life I get the above error. I looked at the database tables and the fields that need to be taken out are not there so I can only assume that it was taken out in one of the uninstalls that I tried.

For people having problems uninstalling this mod:

1) If you can't get to the admincp, edit includes/config.php and insert this line, at the top just under the <?php line:

2) Go to Manage Products and uninstall this product. If it won't uninstall because you get an error, edit your includes/config.php, find the $config['Misc']['debug'] line and change it to true (or if you can't find it, insert the line below):
Now go to the Manage Products and select "Edit" next to this product, and press "go". Find the section labeled "Existing Install/Uninstall Code" and check the delete box next to each code box, on the right. Then press save and try uninstalling the product again.

3) If you want to clean up the database, the columns added by this mod are 'attach' and 'attachmap' in the pm table, and 'advpmpermissions' in the usergroup table. There is also a row added in the package table with productid='pmattachments' and a row in the contenttype table with class='PrivateMessage'. I don't believe any of this will actually cause problems if you don't remove it (and in fact some of it may have been removed by the uninstall before the error), so if you don't know how, don't worry about it. Edit: But don't try to install this mod again unless you do clean things up.

4) Remove the DISABLE_HOOKS line if you added it in step 1, and change $config['Misc']['debug'] = false;

in vb421 it installed correctly but when i go to send new message and click attachment. the attachment dialog box didn't open correctly.

really want an upgrade version

To uninstall


First Install pmattachments_1-0-0_Beta_1.zip and Replace the Beta 2 version.

After that Disable plugin hook system

and then remove it from ACP..

Done...

Worked for me :D

May I take over this project in order to maintain/update it as needed?

Sweet there are so many people that would love that!

Please do the needful to fix the error.

After getting 'Andreas' explicit permission to take over his code -- there is plenty of work before it can be useable.

I implemented private messaging on the site I oversee. Andreas's code pointed me to the right direction to begin my project, especially since I was new to Vbulletin source and methods back then.
Unfortunately, my team modifies vbulletin source directly and the hooks were not present in the vbulletin source then to make a workable mod.

In Andreas's code, the basis for the project is there, but there are many areas of the project that are incomplete as noted by the BETA status.
If someone decides to write a similar mod from the ground floor up and donate it to the community, then you are welcome to contact me for some pointers and pitfalls that I ran into. Have fun! :)

-- General shout-out to Andres: We miss you around here bud! :)

Well I am willing to Beta for you and help where I can, this is a much needed mod that vB should have addressed a long time before this release. I hope this comes to fruition, instead of chasing copious releases and always leaving something out.

But enough of the negative, thanks for stepping up on this mod.

I would like to get the official permission to take over this project, rather than reinventing the wheel. So let's wait a little to give Andreas a chance to reply :)

Worked for me

The new mod by DragonByte offers attachments in PM's, but that option is in the pro version, https://vborg.vbsupport.ru/showthread.php?t=298444