vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   Modification Graveyard (https://vborg.vbsupport.ru/forumdisplay.php?f=224)
-   -   Show Thread Enhancements - [AJAX] Post Thank You Hack (updated) - Removed (https://vborg.vbsupport.ru/showthread.php?t=261866)

Boofo 04-14-2011 12:38 PM

Quote:

Originally Posted by djbaxter (Post 2184428)
Well, seriously, I don't see why there would be an objection. Abe1 hasn't been here in a year and he's therefore provided no support for the mod and shown no interest in further development. And this is a "freeware" community, after all. If he wanted to continue to support it or develop it, I assume he would have done so and if he isn't interested why on earth would he object to someone else taking on the job?

It's still the author's copyrighted code no matter how you look at it.

Phaedrus 04-14-2011 12:48 PM

Quote:

Originally Posted by Vaira (Post 2184263)
Suggestion for further updates/ info:

I have got that info from the original thread and they are useful for me:

1.
in template post_thanks_postbit_info
looking for {vb:stylevar right} and replace with {vb:stylevar left}, all occurrences.
This resolves my alignment issue.

2.
post_thanks_box entire new code (fixes inline mod issue):
<li class="postbit<vb:if condition="$vboptions['legacypostbit']">legacy</vb:if>" id="post_thanks_box_{vb:raw post.postid}"<vb:if condition="!$post_thanks_box == 1"> style="display:none"</vb:if>>
{vb:raw post_thanks_box}
</li>

3. Give reputation points for each thanks received.
This will create a link at the users setting page, users are now able to find the post for which they have got thanks. Set the entries to 20 at acp (User reputation options). Controls how many ratings to display in the user's control panel.

This is a temporary solution until the search option will be reintegrated.
Thanks to the original authors for the ideas which are very useful and I am using atm.

1. I changed that template, but not exactly that way. I was integrating with the Groans hack and this caused issues I had to write it so that they wouldn't overlap and step on each other in the postbit. It also clashed with the blogs if you have those turned on.

2. If there is ever some way to get permission I'll look into this.

3. That is already an option of the mod.

Phaedrus 04-14-2011 12:51 PM

I may attack this from a different direction and simply rewrite the mod using a different approach giving the same usability, but without the problem of copyrighted code. However in order to maintain the database entries I would need to use those same tables. Is that copacetic or is that enough to make it clash with vbulletin.org rules?

Phaedrus 04-14-2011 12:59 PM

I guess I could try to figure out how to make it translate Abe1's tables into new tables... Anybody a Mysql expert around here?

djbaxter 04-14-2011 01:11 PM

Quote:

Originally Posted by Phaedrus (Post 2184560)
I may attack this from a different direction and simply rewrite the mod using a different approach giving the same usability, but without the problem of copyrighted code. However in order to maintain the database entries I would need to use those same tables. Is that copacetic or is that enough to make it clash with vbulletin.org rules?

Quote:

Originally Posted by Phaedrus (Post 2184563)
I guess I could try to figure out how to make it translate Abe1's tables into new tables... Anybody a Mysql expert around here?

I don't think it's necessary to change the table names.

Phaedrus 04-14-2011 01:30 PM

Quote:

Originally Posted by djbaxter (Post 2184570)
I don't think it's necessary to change the table names.

I sent a PM to Paul to find out, if it isn't I should be able to do this in a reasonable amount of time. If it is, I should still be able to, but I'll need to figure out how to do the table changes and that may add time, depending on how difficult it is to find out the right commands to do it. All of it is doable.

djbaxter 04-14-2011 01:44 PM

By the way, I assume you've tried to reach Abe1 by PM?

Phaedrus 04-14-2011 02:10 PM

I did, but he hasn't even been to the board for a year. No answer.

Alan_SP 04-14-2011 02:23 PM

Just want to give support to Phaedrus. I understand where the problem is, but I think that Abe1 should made his code reusable. He even stopped to offer installation for $50 of his mod, he retired from his forum and he maybe even don't use his email address anymore.

This is regretful, as his two mods (Post Thanks and Groan) where very popular in community.

djbaxter 04-14-2011 02:26 PM

Quote:

Originally Posted by Phaedrus (Post 2184584)
I did, but he hasn't even been to the board for a year. No answer.

Quote:

Originally Posted by Alan_SP (Post 2184589)
Just want to give support to Phaedrus. I understand where the problem is, but I think that Abe1 should made his code reusable. He even stopped to offer installation for $50 of his mod, he retired from his forum and he maybe even don't use his email address anymore.

This is regretful, as his two mods (Post Thanks and Groan) where very popular in community.

All the more reason to assume this is abandoned code.

sadiq6210 04-14-2011 02:45 PM

Quote:

•Search for a users thanked posts
•Search for all thanked posts
Did you active these features?
Abe stopped thes two features till fix it, we wish you can solve this

Thanks

sadiq6210 04-14-2011 02:52 PM

Suggestion :)

Notification when the user recieve new thanks

Paul M 04-14-2011 03:13 PM

Quote:

Originally Posted by Phaedrus (Post 2183801)
I used the Groans hack which was marked as "re-usable code" and worked it backwards from that

Unfortunately, it would appear that was released without permission (but never bought to our attention) - as a result they had no right to mark it as re-usable. It has also been removed.

Phaedrus 04-14-2011 03:29 PM

Quote:

Originally Posted by Paul M (Post 2184607)
Unfortunately, it would appear that was released without permission (but never bought to our attention) - as a result they had no right to mark it as re-usable. It has also been removed.

That's cool. I'll take a different approach and write something that will do this, my question about the tables, thanks for the answer.

I'll have to rewrite code, but I should be able to get this done and repost a new version that will have the same function without using Abe1's code. Since I can use the same tables as a starting point it should be upgradable from Abe1's mods even though it will be new code...

Vaira 04-14-2011 04:15 PM

Quote:

Originally Posted by Phaedrus (Post 2184612)
That's cool. I'll take a different approach and write something that will do this, my question about the tables, thanks for the answer.

I'll have to rewrite code, but I should be able to get this done and repost a new version that will have the same function without using Abe1's code. Since I can use the same tables as a starting point it should be upgradable from Abe1's mods even though it will be new code...

It should be no problem to use abe1's tables (database), since the importer of Dragon Byte accesses them as well. (I mean in the aspect of copyrights).

And to point 3:
Yes I know it is an option already, I just suggested to use it to find the thanks via reputation links.;)

Phaedrus 04-14-2011 04:38 PM

Quote:

Originally Posted by Vaira (Post 2184637)
It should be no problem to use abe1's tables (database), since the importer of Dragon Byte accesses them as well. (I mean in the aspect of copyrights).

And to point 3:
Yes I know it is an option already, I just suggested to use it to find the thanks via reputation links.;)

Ah... LOL. I did the same thing. However I also disabled reputation display in the postbit and profile so that the points didn't become an issue...

Filgga 04-15-2011 12:36 PM

SAD; this means I have to disable this mod on my board?

Alan_SP 04-15-2011 03:16 PM

No, just that you wouldn't get new versions of this mod. But, when Phaedrus makes his version, you can install this new version and have all your thanks imported.

There is only one problem. If you uninstall this version, you loose thanks of your users, as they get removed from database. Even if you Phaedrus makes new code using same tables, uninstalling would mean removing that tables. So we should always keep Abe1's product installed.

Or can new product replace Abe1's? So we wouldn't see Abe1's as disabled?

Hippy 04-15-2011 07:53 PM

if you need be disable it ..
like you said if you uninstall all thanks are gone and cant be recovered

Phaedrus 04-15-2011 11:28 PM

Quote:

Originally Posted by Filgga (Post 2184908)
SAD; this means I have to disable this mod on my board?

No, and I'll answer questions until I come up with an updated version that doesn't violate copyright rules of vbulletin.org.


All times are GMT. The time now is 01:37 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01223 seconds
  • Memory Usage 1,775KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (13)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (20)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete