vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.8 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=235)
-   -   Miscellaneous Hacks - Who Quoted Me (https://vborg.vbsupport.ru/showthread.php?t=258001)

FreshFroot 01-30-2011 08:00 AM

well what the "p" does it it brings you DIRECTLY to the post, where as the "t" brings you directly to the post BUT allows you to see the whole thread.

I'm not sure what problem you are having exactly. can you PM me ur url so I can take a look.

Wonksta 01-30-2011 08:09 AM

Quote:

Originally Posted by FreshFroot (Post 2156364)
well what the "p" does it it brings you DIRECTLY to the post, where as the "t" brings you directly to the post BUT allows you to see the whole thread.

I'm not sure what problem you are having exactly. can you PM me ur url so I can take a look.

Thanks mate PM sent. Mines doing the opposite as per PM.

Thanks again

FreshFroot 01-30-2011 08:25 AM

If anyone else wants to use the method Wonksta did just do the following

PHP Code:

Go into your templates and edit the display_who_quoted_me templated

Find

<a href="showthread.php?t=$threadinfo[threadid]#post$whoquote[postid]">$threadinfo[title]</a>

REPLACE

<a href="showthread.php?p=$whoquote[postid]#post$whoquote[postid]">$threadinfo[title]</a

Cheers.

Wonksta 01-30-2011 09:02 AM

I was just thinking... I have reported posts auto create a thread on behalf of the reporter that gets posted in invisible and private Mod Room now the post contains a quote of the persons posts.

Will this Mod notify the user that they have been quoted in the Mod Room listing the title etc?

Alfa1 01-30-2011 02:34 PM

Quote:

Originally Posted by Wonksta (Post 2156369)
I was just thinking... I have reported posts auto create a thread on behalf of the reporter that gets posted in invisible and private Mod Room now the post contains a quote of the persons posts.

Will this Mod notify the user that they have been quoted in the Mod Room listing the title etc?

Very good point! I think most boards have post reports working as such.

Alfa1 01-30-2011 03:10 PM

I have installed the new version and it works!

bug: setting usergroups to 0 does not work. That turns it off.
sort of a bug: quoting yourself gives an alert.

The overview in usercp would look nicer if:
- the font would be smaller. (smallfont)
- display it like this:
Quote:

Member_X quoted your post in the thread_title on [date;time]
Please make that all one line.

It would be nice if there were 2 different phrases for the notification:
1 member quoted you.
x members quoted you.

The latter being plural.

Below the 'Who Quoted Me' block, there should be some empty space. I have Paul M's modification installed to show a 'latest reputation given' block there and both blocks touch each other. There should be some distance. Adding a <br/> at the end of the usercp_who_quoted_me template resolves that.

I think that the link should really lead to the post where the quote is. The way to handle the target location that you have posted earlier in the thread should be in the xml.

Thank you!

Alfa1 01-30-2011 04:09 PM

I have reworked the usercp listing to the following:
display_who_quoted_me
Code:

<tr>
    <td class="alt1Active" width="80%">
        <a class="smallfont" href="member.php?$session[sessionurl]u=$whoquote[userid]">$whoquote[username]</a> <a class="smallfont"> quoted your post in the thread: </a> <a class="smallfont" href="showthread.php?p=$whoquote[postid]#post$whoquote[postid]"><b>$threadinfo[title]</b></a>
    </td>
    <td class="alt1Active">
    <div class="userinfo">
        <div class="smallfont">$whoquote[dateline] <span class="time">$whoquote[timeline]</span></div>
        </td>
</tr>

Looks better now IMHO.

Wonksta 01-30-2011 10:42 PM

Quote:

Originally Posted by Alfa1 (Post 2156513)
I have reworked the usercp listing to the following:
display_who_quoted_me
Code:

<tr>
    <td class="alt1Active" width="80%">
        <a class="smallfont" href="member.php?$session[sessionurl]u=$whoquote[userid]">$whoquote[username]</a> <a class="smallfont"> quoted your post in the thread: </a> <a class="smallfont" href="showthread.php?p=$whoquote[postid]#post$whoquote[postid]"><b>$threadinfo[title]</b></a>
    </td>
    <td class="alt1Active">
    <div class="userinfo">
        <div class="smallfont">$whoquote[dateline] <span class="time">$whoquote[timeline]</span></div>
        </td>
</tr>

Looks better now IMHO.

Screenshot?

Wonksta 01-31-2011 12:59 AM

Doesn't seem to notify me if someone quotes my post that contains links, it's a bit of a hit and miss when a URL is pasted. Can anyone check?

FreshFroot 01-31-2011 03:06 AM

I'll work on some of the suggestions later on.

As for the url thing.. it could be due to checks for if a post was replied too or not. I'm just guessing right now.

when you mean url does www.name.com work fine or is it a problem when you add http://

Wonksta 01-31-2011 07:16 AM

Quote:

Originally Posted by FreshFroot (Post 2156770)
I'll work on some of the suggestions later on.

As for the url thing.. it could be due to checks for if a post was replied too or not. I'm just guessing right now.

when you mean url does www.name.com work fine or is it a problem when you add http://

Hmmmmm!

Tried it with both http and www and got both notifications how, odd. I'll keep an eye on it though.

Mod is great, users love it btw.

Alfa1 01-31-2011 10:17 AM

1 Attachment(s)
Im not sure what the culprit is, but not all quotes cause a notification. We are testing in order to find out. Maybe it differs per subforum?

I am worried that reported posts will cause members to find out, who reported their post. That could spark some riots. So its definitely needed to exclude report forums and infraction forums from causing notifications. Or does this mod already do that?

Here's a screenshot of the usercp after the modifications I applied:

https://vborg.vbsupport.ru/external/2011/01/3.jpg

Wonksta 01-31-2011 11:15 AM

OK Just reported one of my own posts and it created a reported post in the Reports sub forum but the good news is it did not notify me that I reported my post. I tried twice. Take note you can notify yourself when you quote yourself anyway so hence I think it wont notify people but maybe FreshFoot could confirm by looking at the code for us?

Alfa that looks great!

EDIT: Alfa the template tweak is mint, thanks for sharing!

Alfa1 01-31-2011 12:32 PM

I would appreciate it if someone could check the code below to see if proper syntax has been used:

Quote:

Originally Posted by Alfa1 (Post 2156513)
I have reworked the usercp listing to the following:
display_who_quoted_me
Code:

<tr>
    <td class="alt1Active" width="80%">
        <a class="smallfont" href="member.php?$session[sessionurl]u=$whoquote[userid]">$whoquote[username]</a> <a class="smallfont"> quoted your post in the thread: </a> <a class="smallfont" href="showthread.php?p=$whoquote[postid]#post$whoquote[postid]"><b>$threadinfo[title]</b></a>
    </td>
    <td class="alt1Active">
    <div class="userinfo">
        <div class="smallfont">$whoquote[dateline] <span class="time">$whoquote[timeline]</span></div>
        </td>
</tr>

https://vborg.vbsupport.ru/attachmen...1&d=1296476200


FreshFroot 02-01-2011 12:57 AM

I will check the reporting issue and will add in Alfa1's layout, as it looks pretty good.

As for all quote's not being notified. I will try to run a few tests with subforums to see if that could be a problem.

Will keep ya updated.

Thanks.

Wonksta 02-02-2011 12:25 AM

FreshFroot here is a post which did not notify me:

This is what it contained:
-----------
Quote:

Originally Posted by Me (Post 195701)

Quote notification not working @Admin ??

------

Two things present in this post A URL DBTECH's Advanced User Tagging Mod which parsed @Admin.

Thoughts?

FreshFroot 02-02-2011 04:17 AM

Quote:

Originally Posted by Wonksta (Post 2157611)
FreshFroot here is a post which did not notify me:

This is what it contained:
-----------


Quote notification not working @Admin ??

------

Two things present in this post A URL DBTECH's Advanced User Tagging Mod which parsed @Admin.

Thoughts?

Sorry I don't get what you mean? Are you saying urls don't get a notification or when using @name (DBTech's mod) causes no notification?

Wonksta 02-02-2011 05:27 AM

After testing it sometimes it randomly doesn't notify of quotes.

Just to confirm if a member from a usergroup who isn't given permission to use the mod quotes a member from a usergroup which is given permission to use the mod, will it cause a notification?

FreshFroot 02-02-2011 05:29 AM

Quote:

Originally Posted by Wonksta (Post 2157682)
After testing it sometimes it randomly doesn't notify of quotes.

Just to confirm if a member from a usergroup who isn't given permission to use the mod quotes a member from a usergroup which is given permission to use the mod, will it cause a notification?

I'll re-check the usergroups. I know there was a bug with adding a 0.

But if the usergroup has no permission to use it, then it will not create a notification at all.

Wonksta 02-02-2011 05:42 AM

Quote:

Originally Posted by FreshFroot (Post 2157683)
I'll re-check the usergroups. I know there was a bug with adding a 0.

But if the usergroup has no permission to use it, then it will not create a notification at all.

Ahhhhhhhhhhhhh bummer is there anyway to make it so that if you don't have permission to use it and you get quoted you simply don't get notified but when you quote someone who has permission and you don't have permission to use it, it notifies the person with the permission.

If that makes sense? That would be amazing.

Da-Vinci 02-02-2011 03:30 PM

Must be clasing with something I get.

PHP Code:

Fatal errorCall to a member function query_read_slave() on a non-object in /home/clandigi/public_html/includes/class_bootstrap.php(1120) : eval()'d code on line 10 

as soon as I install this mod.

Konstantinos 02-03-2011 11:36 AM

Code:

Invalid SQL:
SELECT hasseen FROM vbquotedatanew
                WHERE quoted = '1' AND hasseen = 0;

MySQL Error  : Unknown column 'hasseen' in 'field list'


FreshFroot 02-04-2011 01:24 AM

Quote:

Originally Posted by Wonksta (Post 2157687)
Ahhhhhhhhhhhhh bummer is there anyway to make it so that if you don't have permission to use it and you get quoted you simply don't get notified but when you quote someone who has permission and you don't have permission to use it, it notifies the person with the permission.

If that makes sense? That would be amazing.

hmmmm ya that could work, I will look into that this weekend.

Quote:

Originally Posted by Da-Vinci (Post 2157824)
Must be clasing with something I get.

PHP Code:

Fatal errorCall to a member function query_read_slave() on a non-object in /home/clandigi/public_html/includes/class_bootstrap.php(1120) : eval()'d code on line 10 

as soon as I install this mod.

hmmmm could be due to other mods too. I'm using quite a lot and so far haven't had clashes.

Quote:

Originally Posted by Konstantinos (Post 2158186)
Code:

Invalid SQL:
SELECT hasseen FROM vbquotedatanew
                WHERE quoted = '1' AND hasseen = 0;

MySQL Error  : Unknown column 'hasseen' in 'field list'


Seems like you did not install the mod properly. Try installing again.

FreshFroot 02-04-2011 03:17 AM

Quote:

Originally Posted by Wonksta (Post 2157611)
FreshFroot here is a post which did not notify me:

This is what it contained:
-----------


Quote notification not working @Admin ??

------

Two things present in this post A URL DBTECH's Advanced User Tagging Mod which parsed @Admin.

Thoughts?

Looks like there IS a problem when using this mod and the DBTech user tag mod. It then will not allow quotes to show or work at all.

Wonksta 02-04-2011 04:55 AM

Ahhh bummer mate! So it's not a permission thing as per your previous post but DBTech only?

Konstantinos 02-04-2011 06:29 AM

can u make it that the who quoted me to be on a new page ? like misc.php and linked from the user.cp or a popup window ?? there are so many items showing in usercp like subscription reps etc

Wonksta 02-04-2011 06:48 AM

Fresh I am willing to chip in some $$ if you can fix the compatibility issue with Dbtech mate!

Alfa1 02-04-2011 11:18 PM

I dont have the DBtech user tagging addon and somehow the quote notifications work in some instances, while not in other instances. Its a complete mystery to me.

Could this be subforum related?

Wonksta 02-05-2011 04:16 AM

Yeah I was looking at that some of the Quotes do not include a DBTECH Parsed link in them and don't show :(

FreshFroot 02-05-2011 07:35 AM

Quote:

Originally Posted by Konstantinos (Post 2158580)
can u make it that the who quoted me to be on a new page ? like misc.php and linked from the user.cp or a popup window ?? there are so many items showing in usercp like subscription reps etc

You can do that already.. Look at the vB4 version of this mod and it has a separate file that you can use.

Quote:

Originally Posted by Wonksta (Post 2158561)
Ahhh bummer mate! So it's not a permission thing as per your previous post but DBTech only?

Nope not a permission issue. It's an issue with the DBTECH mod I think breaking this mod.

Quote:

Originally Posted by Wonksta (Post 2158584)
Fresh I am willing to chip in some $$ if you can fix the compatibility issue with Dbtech mate!

I'll look into it... but I'll have to find out what the DBTECH mod is doing itself.

Quote:

Originally Posted by Alfa1 (Post 2158892)
I dont have the DBtech user tagging addon and somehow the quote notifications work in some instances, while not in other instances. Its a complete mystery to me.

Could this be subforum related?

Could be.. although I don't think I've had a subforum problem yet....

Wonksta 02-05-2011 07:39 AM

Holy fark you're the man! If ya ever come to Australia let me know I owe you a beer Fresh!

Konstantinos 02-05-2011 04:48 PM

Quote:

Originally Posted by FreshFroot (Post 2158975)
You can do that already.. Look at the vB4 version of this mod and it has a separate file that you can use.



..

but it doesnt work 0n 3.8 does it ?

Konstantinos 02-05-2011 09:59 PM

as others said it doesnt work on all quotes. weird. i also am using this https://vborg.vbsupport.ru/showthread.php?t=112498

maybe u can fix the bugs, add a new page with pagenation and include pm email options per user too

FreshFroot 02-05-2011 11:41 PM

Quote:

Originally Posted by Wonksta (Post 2158976)
Holy fark you're the man! If ya ever come to Australia let me know I owe you a beer Fresh!

hmm I'm not a huge beer fan sadly.. I like hard liquor :p

Quote:

Originally Posted by Konstantinos (Post 2159102)
but it doesnt work 0n 3.8 does it ?

I haven't tested it.. so I can't say for sure. I assume it needs small tweaks.

Quote:

Originally Posted by Konstantinos (Post 2159177)
as others said it doesnt work on all quotes. weird. i also am using this https://vborg.vbsupport.ru/showthread.php?t=112498

maybe u can fix the bugs, add a new page with pagenation and include pm email options per user too

I would have to look later. That mod might be coded differently, so I'd have to look at it.

Alfa1 02-06-2011 11:01 AM

Is there any way to get the quote notifications to disappear when the post is visited, instead of the usercp?

Quote:

Originally Posted by Konstantinos (Post 2158580)
can u make it that the who quoted me to be on a new page ? like misc.php and linked from the user.cp or a popup window ?? there are so many items showing in usercp like subscription reps etc

I much agree with this. My users are complaining about this. I display in usercp: personal notepad, invitations, PMs, Friend requests, thread subscriptions, who quoted me, reputation given, reputation received. With 8 blocks thats quite a jungle of notifications to wade through.

I think the optimal solution would be to create an AJAX tabbed content block in usercp.php so that its easy to browse notifications.

Wonksta 02-06-2011 12:02 PM

Although I agree with the whole Misc.php I think we should be thankful of Fresh for his work so far and that we should prioritise the issue of some quotes not working properly (not notifying the user)

Once the core purpose of the Mod is solid then we should focus on extra goodies! :P

FreshFroot 02-08-2011 04:35 AM

Well I might get everyone to move to another similar mod. Apparently it WORKS, but it sends you a PM for each quote. So with that we could modify it to create a method in the usercp.

As for the blocks, we might be able to do that as well. I'm thinking if we make a usercp clone, but just for quotes. That way it LOOKS like the usercp and you can use the block, but it won't display everything at once besides the quotes.

Wonksta 02-08-2011 06:14 AM

I'm interested whats different about that code to this one we are using now regarding it being more accurate in notifying people?

Alfa1 02-08-2011 12:19 PM

I would not want my members to get a PM for every quote. If that can be replaced with a usercp type method then Im surely up for it.

Wonksta 02-08-2011 02:05 PM

Quote:

Originally Posted by Alfa1 (Post 2160165)
I would not want my members to get a PM for every quote. If that can be replaced with a usercp type method then Im surely up for it.

x2

But I think that's what Fresh meant too


All times are GMT. The time now is 01:02 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02514 seconds
  • Memory Usage 1,863KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (5)bbcode_code_printable
  • (3)bbcode_php_printable
  • (24)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete