vb.org Archive - Miscellaneous Hacks

Page 2 of 3

Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)

- - Miscellaneous Hacks - Who Quoted Me (https://vborg.vbsupport.ru/showthread.php?t=255285)

rajubd

12-18-2010 03:57 PM

it will add extra query in every thread view?

Hornstar

12-18-2010 08:30 PM

Finally got to test this on a Test VB4.1 board, and I had two people just quote me, but I got no notification and nothing showed up in my usercp.

I checked the settings and I have it enabled with notifications. I am a super admin if that helps you work out the problem.
Thanks.

robbieswan

12-19-2010 04:03 AM

Quote:

Originally Posted by Hornstar (Post 2136080)

Same here

rajubd

12-19-2010 05:28 AM

it add query in every thread view?

FreshFroot

12-19-2010 08:15 AM

Quote:

Originally Posted by Wonksta (Post 2135274)

Awww bummer any luck of a 3.8.6 version this was exactly what I needed :(

Same here.

If not.. then I'll have to port it myself for 3.8 I suppose...

Though this one should not be hard to convert to vB3.8. Just some minor changes.

Hornstar

12-19-2010 07:02 PM

Also other people only get a notification once. So if you quote them in one thread they get a notification, but then if you quote them later on in that same thread, they won't get a notification.

FreshFroot

12-22-2010 01:40 AM

Looks good, but needs some minor fixes and usage for 3.8.

need2fart

12-22-2010 04:51 AM

Awaiting 3.8.6. version:)

Reason why previous quotes are not showing is because quotes are stored in the post table. It's a bbcode it's not stored anywhere else in the DB. So it's just a bbcode quote of the user. When you install this it manages quotes a step further.

FreshFroot

12-23-2010 02:10 AM

Quote:

Originally Posted by need2fart (Post 2137500)

Well then you could store that BB code somewhere or the use of it. So that way you know there was a use of quotes somewhere.

I wonder if the creator is going to put up an update. Seems like he's on daily, but no replies so far.

renlok

12-24-2010 09:14 AM

Yeah ive been sort of watching the thread but not had any time free after christmas i should be able to do the update and release a 3.8 version

FreshFroot

12-24-2010 10:44 AM

Quote:

Originally Posted by renlok (Post 2138542)

Yeah ive been sort of watching the thread but not had any time free after christmas i should be able to do the update and release a 3.8 version

Sounds great!!

Thanks for updating us.

And best of holidays :)

8thos

12-26-2010 12:58 AM

Installed. Hope it works.

toneee

01-04-2011 07:56 AM

Best mod!

FreshFroot

01-05-2011 12:45 AM

Any new updates yet?

renlok

01-13-2011 10:04 AM

sorry I didn't get to this earlier, I'm really busy at the moment but will be free to have a look at it again on the 24th

Alfa1

01-18-2011 10:57 PM

Thanks for letting us know. I'm checking this thread very regularly, as I much need the 3.8 version and quote notifications in navbar notification drop down.

Donation guaranteed.

FreshFroot

01-19-2011 04:24 AM

Quote:

Originally Posted by Alfa1 (Post 2151201)

Thanks for letting us know. I'm checking this thread very regularly, as I much need the 3.8 version and quote notifications in navbar notification drop down.

Donation guaranteed.

same here.. I think a lot of users are waiting for a 3.8 version.

Bulletnewcomer

01-23-2011 12:23 PM

Wishlist: User can take on/off this mod.

FreshFroot

01-25-2011 12:07 AM

Well an update should hopefully be coming this week.

OldSchoolDSL

01-28-2011 02:54 PM

Updated to v1.2.0

All is working well

4.1.1

FreshFroot

01-29-2011 04:02 AM

That's odd? It says the mod was updated?

Anyone find any new features or bug fixes? Looks like no 3.8 version either?

renlok

01-29-2011 08:22 AM

Yeah I added this

Quote:

27-01-2011: v1.2.0 Added a button in maintenance -> update counters which finds all quotes and adds them to the who quoted me list (So users know who quoted them in all posts not just those made after installing this)

Also Im looking into making a version for vb3 although I've never coded anything for 3 so may take a while

renlok

01-29-2011 10:17 AM

heres the vb3 version https://vborg.vbsupport.ru/showthread.php?t=258001

TTF	02-10-2011 01:16 AM

Installed (nice one!) and seems to be working for most users however I have one person who can't see any quotes.

Also where I clicked on "update who quoted me" a few times stupidly, it's created duplicated of the quotes. What's the best way of removing these duplicates? Thanks

inpico

02-11-2011 01:15 PM

seems that it doesn't work properly when in quoted Text are Linebreaks ?!

will give in 'Find_Quotes' a try ( instead /i use /is in preg_match... )

PHP Code:


		
			
if (preg_match('/\[quote=(.*?)\](.+?)\[\/quote\]/is', $post['message'])) 
{
    preg_match_all('/\[quote=(.*?)\](.+?)\[\/quote\]/is', $post['message'], $quotematch);

scott_237

04-06-2011 10:06 PM

Is there any easy way to add this to a custom HTML/PHP block in the sidebar?

bwheelock

04-08-2011 04:46 AM

I thought I saw this issue mention in this thread before, but can you increase the security to check permissions on the section the quote comes form? It doesn't happen often, but every now and then someone will paste a quote into a different section than the one the quote came from, potentially notifying a user they were quoted in an area off-limits to them.

IE: I quoted a regular user in a public thread and pasted the quote in the staff section, and the regular user was notified and it showed the title of the staff thread. Not too huge a deal, but depending on the content and context it could cause problems for people.

Edit: Two additional comments:

1.) Seems like I have intermittent load time issues since installing this on our forum the other night. Might be unrelated, as we just pushed out a major forum upgrade on Monday, but I thought I would mention it because I didn't notice it until I added this mod.
2.) I'm anticipating requests from users who don't care to be notified about this sort of thing wanting to disable it, so the ability to disable at least notifications from the user CP would be really cool.

Phaedrus

04-12-2011 04:13 AM

Tagged, awaiting updates for permissions issues...

scott_237

04-28-2011 02:00 PM

I've installed this on 4.0.6, it seems to be working for all my other users but for some reason it doesn't work on my account - the administrator account.

Any reason why this should be?

henriof9

09-02-2011 07:46 AM

We have installed vb 4.1.3 but why is it that not all quote appear ?

The Version for vB 3.x.x has worked wonderfully under vb:3.x.x.

Swedie

12-01-2011 06:13 PM

Yeah, same problem here. It doesn't update... WTF: Must fix!

Swedie

12-01-2011 07:11 PM

The problem lies in the preg_match function. It's incorrect and fails finding quotes when there are line breaks (what I guess) in the post that is being quoted.

I wish I knew regex code well enough, but I don't, so I can only fix this by making an ugly piece of hack without regex that finds the quotes and puts then in an array. I might post it here, but beware it's fugly code.

Swedie

12-01-2011 07:58 PM

I figured it out pretty decently what caused it. It was the first preg_match but also for me I needed /is for case incensitive version.

Replace all the code in the plugin for this mod: Find Quotes

Code:

if(preg_match("/\[quote=(.*)\](.*)\[\/quote\]/is", $post['message'])) 

{

   preg_match_all("/\[quote=(.*?)\](.*?)\[\/quote\]/is", $post['message'], $quotematch);

        $quotecount = count($quotematch[0]);

        $tempcount = 0;

        $quotearray = array();



        while ($tempcount < $quotecount) 

        {

                $username = explode(';', $quotematch[1][$tempcount]);

                $quoteduserid = $vbulletin->db->query_first(

                        "SELECT userid FROM " . TABLE_PREFIX . "user

                        WHERE username = '" . $vbulletin->db->escape_string(htmlspecialchars_uni($username[0])) . "'"

                );



                if (!in_array($quoteduserid['userid'], $quotearray)) 

                {

                        if ($quoteduserid['userid'] > 0)

                        {

                                $vbulletin->db->query_write("

                                        INSERT INTO " . TABLE_PREFIX . "quotedatanew (quoted,quoter,postid,dateline)

                                        VALUES ('" . $quoteduserid['userid'] . "','" . $vbulletin->userinfo['userid'] . "','" . $post['postid'] . "','" . time() . "')"

                                );

                                $quotearray[] = $quoteduserid['userid'];

                        }

                }

                $tempcount++;

        }

}

This means this mod works up to version 4.x.x.

henriof9

12-13-2011 04:45 PM

[QUOTE=Swedie;2273791]I figured it out pretty decently what caused it. It was the first preg_match but also for me I needed /is for case incensitive version.

Replace all the code in the plugin for this mod: Find Quotes

Code:

if(preg_match("/\[quote=(.*)\](.*)\[\/quote\]/is", $post['message'])) 

{

   preg_match_all("/\

        Quote:


        

        

                

        

        

                        


                        

                                

                                        Originally Posted by (.*?)\

                                        

                                


                                (.*?)\[\/quote\]/is", $post['message'], $quotematch);

        $quotecount = count($quotematch[0]);

        $tempcount = 0;

        $quotearray = array();



        while ($tempcount < $quotecount) 

        {

                $username = explode(';', $quotematch[1][$tempcount]);

                $quoteduserid = $vbulletin->db->query_first(

                        "SELECT userid FROM " . TABLE_PREFIX . "user

                        WHERE username = '" . $vbulletin->db->escape_string(htmlspecialchars_uni($username[0])) . "'"

                );



                if (!in_array($quoteduserid['userid'], $quotearray)) 

                {

                        if ($quoteduserid['userid'] > 0)

                        {

                                $vbulletin->db->query_write("

                                        INSERT INTO " . TABLE_PREFIX . "quotedatanew (quoted,quoter,postid,dateline)

                                        VALUES ('" . $quoteduserid['userid'] . "','" . $vbulletin->userinfo['userid'] . "','" . $post['postid'] . "','" . time() . "')"

                                );

                                $quotearray[] = $quoteduserid['userid'];

                        }

                }

                $tempcount++;

        }

}

Quote:

Originally Posted by (.*?)\

This means this mod works up to version 4.x.x.

Thanks, I have taken the hint from @inpicos post #65 and it works perfectly now. :)

Breakpoint

12-20-2011 11:29 PM

Let me know when updates, would love to try with out fixing code :D

thenamesgould

01-28-2012 12:42 AM

I like it, thanks! The only thing is the quotes in the off-limits areas, but we can be careful not to do any for now. Cheers. :D

vauge

08-17-2012 01:47 PM

Is there a way to easily turn this off per user?

scott_237

09-11-2012 01:20 PM

I think this works MOST of the time, but I'm admin on my forums and I only get notified for a small percentage of the quotes, no all of them. Why is this?

EliasAlucard

10-02-2012 07:42 PM

Quote:

Originally Posted by scott_237 (Post 2364615)

I think this works MOST of the time, but I'm admin on my forums and I only get notified for a small percentage of the quotes, no all of them. Why is this?

Yeah, I noticed now that it hasn't been working the past 3-4 days. I'm using vB 4.2.0 and it seems like this plugin could need an update.

farazfaraz

11-02-2012 10:52 PM

dont show

why?

All times are GMT. The time now is 07:54 PM.

Page 2 of 3

Show 40 post(s) from this thread on one page

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01278 seconds Memory Usage 1,829KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (2)bbcode_code_printable (1)bbcode_php_printable (9)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (2)pagenav_pagelink (1)post_thanks_navbar_search (1)printthread (40)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: