![]() |
Quote:
|
Quote:
|
Okay I went ahead and changed my thread/forum read marking type from cookie to database and installed the NOMEMCACHED product on my forum and it's working fine.
Only one issue. There aren't notifications for email subscriptions. I mean, members only get notifications of threads subscriptions made with the option "without email notification". |
I've updated the phrase. Also, I'm pretty sure it'll work for all kinds of notifications, as they're all stored in the same database table.
|
Tried to install nonmemcached version:
Fatal error: Class 'Memcache' not found in /home/user/public_html/forum/global.php(400) : eval()'d code on line 255 |
@grey_goose: double check that you have downloaded the NOMEMCACHE.xml version.
@MoMan: unfortunately it appears that it isn't working for all kind of subscriptions. As I already said, this isn't displaying notifications for subscriptions made with email notification but with no email notification it's working fine. I'm talking about the NOMEMCACHE.xml version. Thank you, Jonathan |
Quote:
|
It does work for all types of threads- have a look at what the query does. It doesn't discriminate by subscription type.
|
I'm not a programmer so I don't understand queries but I'll be more than happy if you can perform a quick review of the code of the NOMEMCACHED version to see if there is something wrong.
Thanks. |
Something strange is happening.
I have some thread subscriptions and I'm getting the notifications without any problem (except for the one mentioned here) but after marking all forums read the notification is still present! Please take a look at these screenshots for further reference: http://img585.imageshack.us/img585/7015/crazy1.png http://img89.imageshack.us/img89/9316/crazy2.png I remember it was working fine (without this issue) but now this strange behavior is driving me crazy :( Any idea? |
I've updated the original post with the latest version of the memcache version of this modification, which uses memcache for both count tracking and thread read times. In the future, I may release the further-improved version which uses memcache only for count tracking.
The non-memcache version of this mod is provided as-is and is not supported. It uses the same queries as the other version, however, so it really should work. I had a look at the code, and saw no problems. There must be something wrong with your forum's read marking- it must not be properly updating the threadread table. |
Well, there are two bugs in this product:
Bug #1 There aren't notifications for email based subscriptions. I mean, members only get notifications of threads subscriptions made with the option "without email notification". If someone has a thread subscribed with instant/daily/weekly email notification then they will not receive notifications in the top right corner but email notifications will be dispatched to the member's inbox as usual. Bug #2 (strange) After marking all forums read the subscribed threads notification is still present (it's always 1). I remember it was working fine but now it isn't. That's why I'm marking this bug as strange. I'm talking about the NOMEMCACHED version running in a vB 3.8.5 forum. The programmer already said that that version is provided as-is so we can't expect any further updates :( |
I don't believe this is an issue with the plugin itself. I've tested both of these things successfully on two separate forums. All I can think of is that other settings/plugins are conflicting with it. I also use is on my own site, on which the users aren't reporting any problems (at least after I introduced the "clear notifications" feature ;))
To debug bug #2, go into the threadread table and see if all records for your username have the same timestamp. If not, then the discrepancy is what the system is picking up as a new thread. Try the memcached version- it's a lot better! |
Quote:
First of all thank you for the useful info. I went ahead and performed the following SQL query: Code:
SELECT * Is 'readtime' the timestamp that you're talking about? If so, is there anything wrong with my threadread table? :( |
Now you should run a similar query on the subscription table to see which threads you're subscribed to. Then we can take a look and compare.
|
I ran this:
Code:
SELECT * It looks like the subscribethread table doesn't have a timestamp column so how to compare against the threadread table? If I read the thread then the notification disappear (as designed). Issue here is that after marking all threads as read (mark forums as read) the notifications for subscribed threads don't disappear. |
I even performed the following SQL queries:
Code:
DELETE FROM subscribethread; |
Quote:
I see two solutions: 1. Checking the last time the forum was marked read before running the subscribed thread query 2. Updating threadread where userid = $vbulletin->userinfo['userid'] with TIMENOW when $_REQUEST['do'] == 'markread' by adding code to the plugin |
Since forumcache doesn't store the forum read time, I went with #2 and implemented that. Note that now the notifications will clear when you mark all forums read, but not when you mark an individual forum.
|
Thanks for the workaround. I'll try it soon.
Uhm... the memcache enabled version doesn't have this issue, right? |
No, because the last read time is stored in memcache, and updated when you mark forums read :)
|
I do have another question regarding your memcache enabled version. You said:
Quote:
|
Right, it can take up to 5 minutes for a notification to pop up after a reply has been made to a subscribed thread. However, once you open the thread, the notification is cleared immediately.
|
There is another annoying bug in the NOMEMCACHED version.
Sometimes the product is adding notifications properly but sometimes when a subscribed thread gets updated (someone replies to it) the product isn't adding notifications. So in other words, sometimes it work and sometimes it doesn't. It appears to be a random behavior. I don't know if the memcache-enabled version of your product is better or doesn't have this bug and I'd like to use the memcache-enabled one instead of the NOMEMCACHED version but as I already told you I'm running xCache not Memcache so let allow me to insist with this: Quote:
Quote:
I was talking about this. |
Just updating the bugs in the NOMEMCACHED version for anyone interested:
Quote:
|
I can confirm Bug #2 in the one day of using the Non-memcached version.
I tried the memcached version but do not have a memcacher server available to me. uninstalled |
Bug #2 has been already fixed by the programmer.
Quote:
Issue here are bugs #1 and #3. |
I'd like to remind you that the non-memcached version isn't supported, and that I use the memcached version of this on my own site with no problems. If there were bugs, my members would have complained.
Perhaps there's some sort of setting conflict with your particular installations (this goes back to the cookie-based vs database thread marking), I'm not sure. |
I've updated both versions of this mod:
If a soft-deleted thread was still unread, a notification would be shown even though the thread wouldn't be visible to the user. I've now added an AND visible = 1 statement to the query to avoid such conflicts. I recommend you upgrade to 1.0.3 if you're using the non-memcached version of the mod. |
Hi MoMan,
Now all the bugs listed here are resolved. Thanks for updating your hack :) Regards, Jonathan |
I've updated the non-memcached version: it now only uses 1 query, rather than 3, and the overall quality of the code has been improved.
I currently don't have the time to update the memcached version, although this shouldn't matter as much due to the caching. |
Non-memcached version of this working fine in vb4.1.4
|
Great to hear! I can re-release this in the vb4 section, then.
|
I've updated this thread with the latest version of this mod. I've also removed the memcached version, as it seemed it was caused more confusion than it did good. If admins of large forums are looking for a more efficient version of this hack, please contact me via PM.
|
I tried the memcached version when it was still free. Now I regret not keeping the xml back then :P
|
Is there a way to disable this notification via usercp?
Thanks |
Ok here the modification in order to enable/disable the notification via usercp :
Create a customfield and remember the ID then modify the .xml Line 27: PHP Code:
|
Hi
After installing when click "Today's Posts" an error Code:
Warning: Cannot use a scalar value as an array in [path]/search.php on line 2501 Help me |
Quote:
|
I have a problem with this mod.
i have added this mod (sound plays when page loads if notification exists) to my forums, using this sound. So when someone replies to a subbed thread, notification sound plays. The problem is, when YOU post a reply in a thread that you are subscribed to, you get a notification, until it becomes marked as read. with both of these mods the way they are, when you post in a subbed thread, you hear the notification sound. I was wondering if there is a way to alter this mod so that your own posts in a thread you are subbed to never cause a notification. |
All times are GMT. The time now is 01:02 PM. |
Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information | |
---|---|
|
|
![]() |
|
Template Usage:
Phrase Groups Available:
|
Included Files:
Hooks Called:
|