vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Administrative and Maintenance Tools - Private Messages & Email Log (https://vborg.vbsupport.ru/showthread.php?t=245243)

Vitaly 01-07-2011 02:53 PM

TimesOut, Britmovies,

Checks, that you have uploaded source files to server, and set ptoper permission. That file exists in archive.

Paul. 01-15-2011 12:32 PM

Since it has been updated after I installed it, is it necessary to download and replace all the files again? Is that how you do it? Download it again as if you never had it and let it replace what is there already?

Vitaly 01-19-2011 03:49 AM

Yes, all files have been changed. You have to reupload all (override old ones, if any).

mplode 02-22-2011 09:12 AM

Invalid SQL:
Code:

SELECT DISTINCT  COUNT(cr.logid) AS count
              FROM((SELECT
                      pm.logid AS logid
                  FROM
                      rcd_log_pm AS pm
                  WHERE
                fromusername = 'Qui's World' ) UNION (SELECT
                      pm.logid AS logid
                  FROM
                      rcd_log_pm AS pm
                  WHERE
                tousername = 'Qui's World' )) AS cr;

Got a bit of an SQL injection going there. Might want to fix that.

edit: two actually. You need to sanitize $user_name

Additionally, there's XSS on the search fields. You need to sanitize those for HTML usage as well. And everywhere where it lists usernames.

Vitaly 02-22-2011 01:22 PM

Try the latest version frim github

https://github.com/shkuropat/vb-pm_log

Updated nick escapeing.

mplode 02-22-2011 11:50 PM

Thanks for the quick response! I have some remarks, however.

Why are you applying htmlspecialchars_uni() to the usernames before using them in the query? That should be unnecessary and in fact will probably cause problems with users who have <>& or similar signs in their usernames. $db->escape_string() should be enough there.

Code:

    print_input_row($vbphrase['username'], 'username', $user_name, false);
    print_input_row($vbphrase['keywords'], 'keywords', $search_keywords, false);

in these lines, you have not yet sanitized the HTML on the other hand;
Code:

    print_input_row($vbphrase['username'], 'username', htmlspecialchars_uni($user_name), false);
    print_input_row($vbphrase['keywords'], 'keywords', htmlspecialchars_uni($search_keywords), false);

And I think you need to sanitize the username in the search results etc. as well. In case someone has a username like "<script>alert(1)</script>" or "<!--" or something.

Vitaly 02-23-2011 03:42 AM

You could check on real data fist. Nicks in db are html-escaped.

mplode 03-05-2011 06:45 PM

Ah. Yeah, I wasn't too sure about that one.

RedHacker 03-10-2011 08:06 AM

Fatal error: Call to undefined function rcd_pm_log_CacheTemplates() in /home/xxxxxxx/public_html/includes/class_bootstrap.php(1312) : eval()'d code on line 363

I cant use anything with update

Vitaly 03-21-2011 03:44 PM

Updated version to fix bug with SQL, reported by mplode.

Markco 03-21-2011 04:10 PM

not working in Vb 4.12 error message "Nothing found"

Vitaly 03-21-2011 04:25 PM

"not working" and "nothing found" is a big difference.

Markco 03-24-2011 05:26 AM

not working under Vb 4.12 product Private Messages & Email Log display error message "Nothing found" while there are private messages

Vitaly 03-24-2011 06:22 AM

- You had this product installed and it stopped working?
- Or just installed?
- Or after mod upgrade?
- Which search conditions?

Please, provide more details. I use this mod @ 4.1.2

Markco 03-24-2011 04:43 PM

I installed for the first time your hack I have switch diverse parameter I clicked PM Log below the panel private messages a message appears Nothing found.
I search with a nick name for the same message appears Nothing found.

Vitaly 03-24-2011 04:48 PM

This mod logs messages AFTER installation. Make a new test message for yourself and try to search it.

Markco 03-24-2011 05:57 PM

After installation i make a PM and show a PM in PM log,
thank you.
Now, how to see before installation?

Alan_SP 03-25-2011 11:25 PM

No way for that with this add-on. :)

You should use different add-on, maybe the one from Valter: https://vborg.vbsupport.ru/showthread.php?t=233350

With this add-on you log in users account and after that you can see their PM box. Of course, you can use it to diagnose what's troubling them as well.

nta_viking 03-31-2011 06:34 PM

i installed this and it works fine, but my other administrators can not see the pm log link. I have enabled this for them in the admin permissions but it does not appear.

i will also add that if my admins go directly to the link it works, so its just not showing up for them in the users menu.

jnrdavo 06-03-2011 03:39 AM

Quote:

Originally Posted by nta_viking (Post 2179510)
i installed this and it works fine, but my other administrators can not see the pm log link. I have enabled this for them in the admin permissions but it does not appear.

i will also add that if my admins go directly to the link it works, so its just not showing up for them in the users menu.

I have exactly the same problem. Loaded the latest version on a clean BB yesterday. I can see logs (I am userid 1), but the other admins can't see it...

Any clues?

Have modified the admin permissions so they can view pm's, but still no luck.

Luca_ITA 08-05-2011 07:40 PM

On my forum mod works good. I'm using v4.1.5pl1.
tnx man!

MalluParadise 10-23-2011 10:53 PM

how about working in 4.1.7 ?

Sarab 10-26-2011 11:38 PM

Hello,

I was wondering who can see the pm? only the admin or even the mods?

Best Regards,
Sarab

Luca_ITA 12-23-2011 08:18 PM

1 Attachment(s)
works on 4.1.9
+
italian translate

Alibass 06-28-2012 09:32 PM

This mod does not work with 4.2.0 PL2. When you click on member name to read PM it redirects to the members profile. :(

CharlieDelta 06-28-2012 10:53 PM

That is what is supposed to do. Click on the subject to read the PM.

Works fine on 4.2.

Alibass 06-29-2012 03:56 PM

Quote:

Originally Posted by Alibass (Post 2343707)
This mod does not work with 4.2.0 PL2. When you click on member name to read PM it redirects to the members profile. :(

Quote:

Originally Posted by CharlieDelta (Post 2343718)
That is what is supposed to do. Click on the subject to read the PM.

Works fine on 4.2.

My bad, I haven't used the mod in so long I'd forgot [old age] to click on subject to view PM. :o

CharlieDelta 06-29-2012 04:32 PM

Quote:

Originally Posted by Alibass (Post 2343892)
My bad, I haven't used the mod in so long I'd forgot [old age] to click on subject to view PM. :o

:eek::D
No worries. We all have bad days.

baileyjojoms 01-09-2013 12:34 PM

No Moderators cannot view the PM's only Admins

Unfolded90 02-26-2013 03:57 PM

Always *Nothing Found* on 4.2

fortforum 07-01-2013 08:46 PM

We dont need a mod that can read peoples pm´s. It´s unethical. There used to be a mod called read_pms and it was not to the liking of this community. Now everybody seems to like thisone. What have changed?

killslick1 11-18-2014 01:12 PM

Same issue


All times are GMT. The time now is 04:59 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01189 seconds
  • Memory Usage 1,781KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (3)bbcode_code_printable
  • (4)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (32)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete