vb.org Archive
Page 2 of 4 1 2 34
Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.8 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=235)
-   -   Miscellaneous Hacks - Two-Step External Links for Link Weight Retention (https://vborg.vbsupport.ru/showthread.php?t=217708)

Saviour 07-03-2009 03:31 PM
It's also opening internal links in a new window and I have http://glitchpc.com added to the Whitelist.

Saviour 07-03-2009 03:46 PM
Uninstalled...went back to using NuHit's mod...at least I know that's working as it should.

Thanks, anyway...for the help.

saadessa 07-03-2009 04:06 PM
thank you i will wait to see more tests
thank you

aspen0 07-03-2009 04:36 PM
Quote:
Originally Posted by Saviour (Post 1842126)
It's also opening internal links in a new window and I have http://glitchpc.com added to the Whitelist.
So, you got it working?

The whitelist is wildcard based, just like VB's email or ip banning. If you add http://glitchpc.com and the link is to http://www.glitchpc.com it will not match.

I suggest adding to your whitelist as just "glitchpc.com"

aspen0 07-03-2009 04:45 PM
Quote:
Originally Posted by Saviour (Post 1842132)
Uninstalled...went back to using NuHit's mod...at least I know that's working as it should.


Thanks, anyway...for the help.
If you mean this mod:

https://vborg.vbsupport.ru/showthread.php?t=145402

It hurts you, technically.

Saviour 07-03-2009 07:12 PM
Quote:
Originally Posted by aspen0 (Post 1842165)
So, you got it working?

The whitelist is wildcard based, just like VB's email or ip banning. If you add http://glitchpc.com and the link is to http://www.glitchpc.com it will not match.

I suggest adding to your whitelist as just "glitchpc.com"
When I first installed this mod...I uninstalled NuHit's mod first.

I followed the directions to install your mod. I used glitchpc.com and http://glitchpc.com in the whitelist and neither worked. By the way...my site is configured as http://glitchpc.com...without the "www". Even rebuilt the post cache. Still could not get your mod to work.

Also read your blog and the latest info from Google regarding "nofollow". I do not use no follow...so I can't see where using NuHit's mod is technically hurting my site.

The only difference, I can see, between these two mods is that NuHit's is working for me...and yours is not.

So...sorry to say...I have to use something that works...

Good luck with your mod...

Smitty 07-03-2009 07:47 PM
Quote:
Originally Posted by Saviour (Post 1842272)
Also read your blog and the latest info from Google regarding "nofollow". I do not use no follow...so I can't see where using NuHit's mod is technically hurting my site.
Doesn't the NuHit mod put in "rel=nofollow" tags? If you are you *are* using the "rel=nofollow".

As I understand it "rel=nofollow" is not looked at any more so one might as well not use them. If I'm not understanding this, please let me know.

I've never worry about outbound links because the moderators and I monitor them closely, but this mod sounds interesting. I'm always interested in vB forum SEO.

Saviour 07-03-2009 07:57 PM
1 Attachment(s)
Smitty...

NuHit's mod settings will allow you to turn "rel=nofollow" links on/off.

Smitty 07-03-2009 08:35 PM
Thanks for the info. I hadn't really looked at that NuHit mod. Probably because I bought the Mediawiki integration mod (which is still working on vB 3.8.3, but with an old version of Mediawiki) and the NuHit guy disappeared. I should have looked at that mod closer.

On the other hand, in my forums we monitor all external links very closely so we're not too worried about external links to 'bad neighborhoods'.

aspen0 07-03-2009 09:05 PM
Quote:
Originally Posted by Saviour (Post 1842313)
Smitty...

NuHit's mod settings will allow you to turn "rel=nofollow" links on/off.
On or off, you'll lose linkweight either way. That was the change, used to be using nofollow would save linkweight, now it doesn't. It used to mean you kept the weight, and the linkee didn't get any. Now it means you lose the weight, but the linkee still doesn't get any.

I've a question for you though, if you couldn't get it installed, how is it you noticed the whitelist not working? If links were being redirected, it was obviously installed. This is where you confuse me.

TWTCommish 07-03-2009 09:10 PM
I didn't really follow how that would be possible, either. Either the mod didn't do anything, or it redirected all links and the whitelist didn't work. It can't be both.

Regardless, I'd be glad to take a look at the user's site, but he seems to have given up on it pretty quickly. If you change your mind, Saviour, I'm fairly certain we could find the problem.

Alfa1 07-03-2009 09:34 PM
Quote:
Originally Posted by aspen0 (Post 1842011)
You mean show different content to search engines than you show to other guests Alfa1 for the purposes of SEO? That'd technically be cloaking Alfa1 and is against guidelines and while it is a minor offense and probably wouldn't result in a penalty or ban, it is not really that worth it.
All vbulletin boards do this, because member groups have different permissions than others. Most boards restrict guests from posting or from various functionality. That's the nature of the permissions system.
Cloaking would be treating guests differently than SE bots.

Quote:
Originally Posted by aspen0 (Post 1842011)
I have no idea why someone would become logged out, the external link does nothing with cookies. Perhaps it is a browser issue? No one else has reported that, perhaps that user's cookies got corrupted or overwritten randomly, just as they clicked the link.
I am not sure either. I always have a fair amount of members online, so bugs tend to surface quickly.

After installing your hack, my members report the following issues:
- If a member has not listed a website in profile, then this dead link is displayed on profiles: http://www.mysite.com/forum/externalredirect.php?url=
I have about 40.000 of those dead links now.
- signature pictures that are on another site, no longer display.
- the link to a members home page from postbit dropdown does not work.

Please advise.

TWTCommish 07-03-2009 10:35 PM
The cloaking bit wasn't addressed to me, but restricting posting is a bit different than restricting content, since content is the issue here.

Anyway, I'm afraid I need some more information to debug these issues; a link to your site, for example, would help a great deal. Regarding these:

signature pictures that are on another site, no longer display.

Does this mean the images don't display, the images are broken, or the link is not directed?

the link to a members home page from postbit dropdown does not work.

How does it not work? Is it not redirected as it should be, redirected when it shouldn't, or does it something else? I can't see any of these things, obviously, so I need much more information in order to help debug these problems.

TWTCommish 07-03-2009 10:41 PM
Quote:
Originally Posted by Alfa1 (Post 1842385)
- If a member has not listed a website in profile, then this dead link is displayed on profiles: http://www.mysite.com/forum/externalredirect.php?url=
I'm PMIng you a small patch now. Looks like this is caused because vBulletin is parsing this field even when it's blank, or something similar. Odd, but easily fixed. Check your PMs in a minute. :)

aspen0 07-03-2009 11:15 PM
Quote:
Does this mean the images don't display, the images are broken, or the link is not directed?
I think I know what is happening here, the image URL is being rewritten as a redirect as well, causing the image to fail and be broken. That would be my guess anyways.

TWTCommish 07-03-2009 11:17 PM
That was my guess, as well, but the only part of the script that adds the URL rewrite is the function which handles bbCode links, which shouldn't effect the image tag's URL.

aspen0 07-04-2009 12:13 AM
Yes, it'd be best to see the exact examples, or a snippet of view source from the page.

Alfa1 07-04-2009 12:45 AM
Quote:
Originally Posted by TWTCommish (Post 1842416)
signature pictures that are on another site, no longer display.

Does this mean the images don't display, the images are broken, or the link is not directed?
Images displayed with the [SIGPIC] bbcode are not displayed. Here is the source:
PHP Code:
        <!-- sig -->
            <div>
                __________________<br />
                <div align="center">[nopparse][SIGPIC][/SIGPIC][/nopparse]</div>

            </div>
        <!-- / sig --> 
^ignore the noparse code please.

Quote:
Originally Posted by aspen0 (Post 1842421)
I think I know what is happening here, the image URL is being rewritten as a redirect as well, causing the image to fail and be broken. That would be my guess anyways.
Quote:
Originally Posted by TWTCommish (Post 1842422)
That was my guess, as well, but the only part of the script that adds the URL rewrite is the function which handles bbCode links, which shouldn't effect the image tag's URL.
Please check if affects the [SIGPIC] bbcode.

Quote:
Originally Posted by TWTCommish (Post 1842416)
the link to a members home page from postbit dropdown does not work.

How does it not work? Is it not redirected as it should be, redirected when it shouldn't, or does it something else?
Nothing happens when clicking the link. This is caused by this being added to the link:
PHP Code:
 rel= 
Now that i see it, I am not sure if this is related to this hack.

Quote:
Originally Posted by TWTCommish (Post 1842417)
I'm PMIng you a small patch now. Looks like this is caused because vBulletin is parsing this field even when it's blank, or something similar. Odd, but easily fixed. Check your PMs in a minute. :)
Thank you. That works well.

TWTCommish 07-04-2009 12:52 AM
Glad that worked for you. :) We'll incorporate that change into the official release.

I've tried adding signature pictures to my test board without incident so far. I'll try a few more things and let you know if that helps me duplicate the problem.

I think you're correct about the homepage link and the rel= issue being related to another mod, as this particular hack doesn't add any rel attitributes, except in the EXTERNAL_LINK template.

Saviour 07-04-2009 02:51 AM
Quote:
Originally Posted by TWTCommish (Post 1842370)
I didn't really follow how that would be possible, either. Either the mod didn't do anything, or it redirected all links and the whitelist didn't work. It can't be both.

Regardless, I'd be glad to take a look at the user's site, but he seems to have given up on it pretty quickly. If you change your mind, Saviour, I'm fairly certain we could find the problem.
Okay guys...

I'll try to describe the problem again...hopefully, this time, I won't lose you.

When your mod is installed...and a user clicks an external link, it's supposed to redirect them with a message that they are leaving the current site...correct? Your mod does not do this for me.

Your mod also opens internal links (from my site) in a new window or tab. I'm using Firefox 3.5. I included glitchpc.com in the whitelist. I had set "rel=nofollow" to off. All other settings were set to "yes".

Those are the issues I'm having with your mod. For the life of me, though, I don't see the difference between your mod and NuHit's mod. How is your mod any different than NuHit's...other than the fact there's supposed to be a redirect message that does not seem to be working for me...along with the fact that internal links are opened in a new window...which shouldn't be happening.

When I installed your mod...I made sure NuHit's mod was uninstalled, first. I tried several times to get your mod to work, but was unsuccessful. It's not that I had given up...I just decided to return to the previous mod I was using that worked fine. The only reason I wanted to try your mod was due to the fact a message was supposed to be displayed notifying the person who clicks an external link that they are being redirected to another site.

Again...I gave this mod every opportunity and it failed on every attempt to get the redirect message to display or to prevent internal links from opening in a new window...even after rebuilding the post cache. If it matters...I'm running vb 3.8.3, vba CMPS 3.2.0 and vba Links Directory 3.2.0. I use quite a few mods...so...I'm not sure if any of them are conflicting with your mod...but that could be a possibility. However...like I said...NuHit's mod is working flawlessly.

Also...aspen0 stated this:

Quote:
If you mean this mod:

https://vborg.vbsupport.ru/showthread.php?t=145402

It hurts you, technically.
How? NuHit's mod gives you the ability to turn "rel=nofollow" on/off. It opens external links in a new window and you can choose whether to open internal links in the same (or a new) window. It also uses a whitelist. So tell me...how can using their mod technically have me at a disadvantage? Other than the fact if I'm using their mod, I'm not using yours.

Well...that's it...in a nutshell. I look forward to your replies.

TWTCommish 07-04-2009 05:10 AM
Nothing in this hack causes links to open in a new window, save for the one on the EXTERNAL_LINK template, which I believe has already been updated, and is easily modified. But it doesn't cause any of the links in signatures, posts, visitor comments, or anything else, to open in a new window/tab. That is vB's default behavior when parsing links in posts, etc.

Regarding differences between this hack and the other: I'm not familiar with the other one, so I couldn't tell you, but I notice you're asking for differences other than the redirect page. The redirect page may be the only major difference, but as aspen0 has explained, it's the entire point. I won't repeat his descriptions of how link weight is distributed, as they're still there for anyone to see and he explains it better than I can, but it bears mentioning.

I'd be glad to help you debug this hack if you'd like to contact me privately and give me some level of access. Suffice to say this has been tested on several different versions and the code itself is pretty straightforward, so I should be able to determine rather quickly if perhaps something went wrong during installation, or if some other mod is in conflict.

I am still somewhat curious about your reference to the whitelist, though. The whitelist exists to stop links from being run through the redirection page. Are you saying you added your URL to the whitelist even though this wasn't happening?

Saviour 07-04-2009 07:53 AM
TWTCommish...

I appreciate the offer...and hope my posting hasn't had an ill affect on others who may want to download it. However, I've just decided to stay with what I have.

If I do change my mind...I'll be back to ask for assistance. Thanks, again, for your offer to help.

All my best...

aspen0 07-04-2009 12:02 PM
Quote:
Originally Posted by Saviour (Post 1842474)
Okay guys...

I'll try to describe the problem again...hopefully, this time, I won't lose you.

When your mod is installed...and a user clicks an external link, it's supposed to redirect them with a message that they are leaving the current site...correct? Your mod does not do this for me.

Your mod also opens internal links (from my site) in a new window or tab. I'm using Firefox 3.5. I included glitchpc.com in the whitelist. I had set "rel=nofollow" to off. All other settings were set to "yes".

Those are the issues I'm having with your mod. For the life of me, though, I don't see the difference between your mod and NuHit's mod. How is your mod any different than NuHit's...other than the fact there's supposed to be a redirect message that does not seem to be working for me...along with the fact that internal links are opened in a new window...which shouldn't be happening.

When I installed your mod...I made sure NuHit's mod was uninstalled, first. I tried several times to get your mod to work, but was unsuccessful. It's not that I had given up...I just decided to return to the previous mod I was using that worked fine. The only reason I wanted to try your mod was due to the fact a message was supposed to be displayed notifying the person who clicks an external link that they are being redirected to another site.

Again...I gave this mod every opportunity and it failed on every attempt to get the redirect message to display or to prevent internal links from opening in a new window...even after rebuilding the post cache. If it matters...I'm running vb 3.8.3, vba CMPS 3.2.0 and vba Links Directory 3.2.0. I use quite a few mods...so...I'm not sure if any of them are conflicting with your mod...but that could be a possibility. However...like I said...NuHit's mod is working flawlessly.

Also...aspen0 stated this:



How? NuHit's mod gives you the ability to turn "rel=nofollow" on/off. It opens external links in a new window and you can choose whether to open internal links in the same (or a new) window. It also uses a whitelist. So tell me...how can using their mod technically have me at a disadvantage? Other than the fact if I'm using their mod, I'm not using yours.

Well...that's it...in a nutshell. I look forward to your replies.
Our mod has nothing to do with links being opened in a new window, as the other Chris said. VB by default opens user posted links, anything generated by bbcode, in a new window. In fact, in the post I'm quoting you quote me where I post a link to another vb.org page, go click on that link. Notice the new window. VB default behavior.

It sounds to me like Nuhit's mod is malfunctioning for you actually. If Nuhit's mod is supposed to allow you to stop internal links from opening in a new window, it is malfunctioning.

Now, how is it hurting you? Hurting is perhaps the wrong word to use. It isn't helping you. It isn't helping you a lick with Google. It is doing nothing for your Google rankings. That was my point, if that is not why you use it, if you use it to stop VB's default behavior of opening links in new windows, then I misunderstood. I thought you were using it with the idea to help your search engine rankings.

As for why our mod doesn't work, I'm guess it was either installed incorrectly, or there is a conflict with one of your other mods, like nuhit's not being uninstalled fully or something.

I don't know how many forums the other chris runs, I've got about 10, and at least 9 other people have installed it so far too, so that is a lot of variation, in which it works, your forum might just be an oddity.

aspen0 07-04-2009 06:36 PM
updated with bug fixes and a toggle to allow you to set to only show it to unregistered users. No file changes are needed, just reinstall the new xml file.

smirkley 07-04-2009 07:46 PM
Quote:
Originally Posted by aspen0 (Post 1842642)
..., I've got about 10, and at least 9 other people have installed it so far too, so that is a lot of variation, in which it works, ....
I know it is probably too soon to tell yet, but when you can, is it possible to provide some statistics based on your experience, of the net improvements that this mod has provided, based on actual data?

aspen0 07-04-2009 10:11 PM
Unfortunately that is very hard to do. Google purposefully obfusicates the link weight reporting they provide to webmasters, we never know the actual score, and as well they only always show data thats usually 4 months out of date.

dont.net 07-04-2009 10:51 PM
installed :D

Thanks

NLP-er 07-05-2009 01:41 AM
Installed and after link clicking on my forum I got:
Code:
1||1246761650||88.199.62.36||url=http://www.wp.pl||http://www.forum.simple-nlp.pl/informacje/887-kolejny-test.html||Opera/9.61 (Windows NT 5.1; U; pl) Presto/2.1.1Access Denied, you have been logged.

NLP-er 07-05-2009 02:02 AM
Also going to externalredirect.php without url param generates normal page with message about invalid url.

So this error exists only when url is set - I have white page whit that communicate and nothing else.

aspen0 07-05-2009 02:19 AM
I'm sorry NLP'er, I'm not understanding your issue.

NLP-er 07-05-2009 10:51 AM
Quote:
Originally Posted by aspen0 (Post 1843005)
I'm sorry NLP'er, I'm not understanding your issue.
so look on this link:
http://www.forum.simple-nlp.pl/exter...tp://www.wp.pl

There is an error about aess denied. But thi is not access to externalredirect.php, because when you go here:
http://www.forum.simple-nlp.pl/externalredirect.php

It generates. So somesthing is wrong with externalredirect.php code. Whad to do to have it working?

Sayid 07-05-2009 12:05 PM
Hi,

First I want to thank you, I like seo mods btw .

I,m afraid now before installing about this ,

Quote:
I think I know what is happening here, the image URL is being rewritten as a redirect as well, causing the image to fail and be broken. That would be my guess anyways.
Is it a bug ? I mean when install this mod , forums signatures that have external images will not displayed ??

aspen0 07-05-2009 12:21 PM
Quote:
Originally Posted by Sayid (Post 1843159)
Hi,

First I want to thank you, I like seo mods btw .

I,m afraid now before installing about this ,



Is it a bug ? I mean when install this mod , forums signatures that have external images will not displayed ??
it was fixed in the last update I believe.

aspen0 07-05-2009 12:22 PM
Quote:
Originally Posted by NLP-er (Post 1843130)
so look on this link:
http://www.forum.simple-nlp.pl/exter...tp://www.wp.pl

There is an error about aess denied. But thi is not access to externalredirect.php, because when you go here:
http://www.forum.simple-nlp.pl/externalredirect.php

It generates. So somesthing is wrong with externalredirect.php code. Whad to do to have it working?
I have no idea, there is nothing in the mod that would print out a page like that. It has to be a conflict with something you have on your server. A setting that handles query strings for PHP pages, a security setting that disallows URLs from being in query strings, something like that.

NLP-er 07-05-2009 12:45 PM
Quote:
Originally Posted by aspen0 (Post 1843162)
I have no idea, there is nothing in the mod that would print out a page like that. It has to be a conflict with something you have on your server. A setting that handles query strings for PHP pages, a security setting that disallows URLs from being in query strings, something like that.
:/ Ok - till solution mod dissabled. I send query to my hosting company - see do they will find out somesthing. Thanks anyway :)

Sayid 07-05-2009 01:05 PM
It works :)

But as I said about signatures,

it shows the url of the image like this

PHP Code:
http://i9.photobucket.com/albums/a58...o1ni0220-1.jpg 
when I click on it, it redirects me as expected .. And if there is an image without extension like attachments of other forums, it give another message in redirect page which is "Invalid url"

PHP Code:
http://localhost/123vb/externalredirect.php?url=http://i48.servimg.com/u/f48/11/38/19/72/110.jpg 
Note: I installed it in localhost forum.

btw, I think vbanonymizer does redirect . Is there a difference ??

Sayid 07-05-2009 01:31 PM
another small bug

URL that contains '&' gives the same invalid message in redirect page

example:

Code:
http://localhost/123vb/externalredirect.php?url=http://www.external.com/vb/external.php?type=rss2&forumids=56

NLP-er 07-05-2009 01:47 PM
Quote:
Originally Posted by Sayid (Post 1843177)
btw, I think vbanonymizer does redirect . Is there a difference ??
I just installed it - difference is that you don't have to make strange file edition which will disappear after next vb update like in this mod. Unfortunately i have same behavior like in this mod... So right now I'm sure that my problem is not with mod but something else...

TWTCommish 07-05-2009 03:41 PM
Quote:
Originally Posted by Sayid (Post 1843159)
Is it a bug ? I mean when install this mod , forums signatures that have external images will not displayed ??
I used a signature picture on my test forum and it worked fine, so I've been unable to duplicate the problem in question. I'm not sure if it's limited to this one user, who seems to have many modifications installed.

It also, in theory, shouldn't change it, if only because it only modifies links passed through vB's link creation function. Can't imagine that vB would be passing image URLs through that by default.

TWTCommish 07-05-2009 03:57 PM
1 Attachment(s)
Quote:
Originally Posted by Sayid (Post 1843191)
another small bug

URL that contains '&' gives the same invalid message in redirect page
I've attached an updated externalredirect.php file that relaxes the URL validating regular expression a bit. :) Thanks for bringing this to our attention!


All times are GMT. The time now is 11:25 AM.
Page 2 of 4 1 2 34
Show 40 post(s) from this thread on one page

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01553 seconds
  • Memory Usage 1,899KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (4)bbcode_php_printable
  • (26)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete